[JBoss JIRA] (TEIID-5861) Salesforce translator should support nested joins
by Renat Eskenin (Jira)
[ https://issues.redhat.com/browse/TEIID-5861?page=com.atlassian.jira.plugi... ]
Renat Eskenin edited comment on TEIID-5861 at 5/31/20 5:15 AM:
---------------------------------------------------------------
I investigated bugs in some my tasks and described its with code of teiid engine (concrete strings in code of engine and how you can repair bug), but implementing of new functions is very difficult.
was (Author: i3draven):
I investigated bugs in some my tasks and described its with code, but implementing of new functions is very difficult.
> Salesforce translator should support nested joins
> -------------------------------------------------
>
> Key: TEIID-5861
> URL: https://issues.redhat.com/browse/TEIID-5861
> Project: Teiid
> Issue Type: Enhancement
> Components: Salesforce Connector
> Reporter: Renat Eskenin
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: Backlog
>
> Original Estimate: 2 days
> Remaining Estimate: 2 days
>
> For this SQL we have wrong generated SOQL
> {code}
> select
> price.Id,
> price.IsActive__c,
> price.name,
> price.PriceBook__c,
> book.DefaultCurrency__c,
> price.Price__c,
> price.ProductCode__c,
> price.ProductName__c,
> price.Product__c,
> product.Id,
> product.Name,
> product.Description
> from
> MSRP__c as price
> left outer join /*+ MAKEDEP */ Product2 as product on
> price.Product__c = product.id
> left outer join /*+ MAKEDEP */ Pricebook2 as book on
> price.PriceBook__c = book.id
> where
> price.PriceBook__c =:priceBookId
> and ProductCode__c in(
> :productCodes
> )
> and IsActive__c = true"
> {code}
> {code}
> START DATA SRC COMMAND: startTime=2019-12-02 12:43:54.368 requestID=9MPiB/GOwB5f.0 sourceCommandID=3 executionID=2 txID=null modelName=sf translatorName=salesforce sessionID=9MPiB/GOwB5f principal=anonymous sql=SELECT sf.Pricebook2.DefaultCurrency__c FROM sf.Pricebook2 WHERE sf.Pricebook2.Id = 'xxxxx'
> [2019-12-02 12:43:54,368 MSK] DEBUG [salesforce-failover-facade,,,] org.teiid.COMMAND_LOG.SOURCE [Worker0_QueryProcessorQueue1]: SOURCE SRC COMMAND: endTime=2019-12-02 12:43:54.368 requestID=9MPiB/GOwB5f.0 sourceCommandID=2 executionID=1 txID=null modelName=sf translatorName=salesforce sessionID=9MPiB/GOwB5f principal=anonymous sourceCommand=[SELECT MSRP__c.Id, MSRP__c.IsActive__c, MSRP__c.Name, MSRP__c.PriceBook__c, MSRP__c.Price__c, MSRP__c.ProductCode__c, MSRP__c.ProductName__c, MSRP__c.Product__c, Product__r.Id, Product__r.Name, Product__r.Description FROM MSRP__c WHERE (MSRP__c.PriceBook__c = 'xxxx') AND ((MSRP__c.ProductCode__c IN(xxxxx)) AND (MSRP__c.IsActive__c = true))]
> [2019-12-02 12:43:54,368 MSK] DEBUG [salesforce-failover-facade,,,] org.teiid.CONNECTOR [Worker1_QueryProcessorQueue2]: salesforce.9MPiB/GOwB5f.9MPiB/GOwB5f.0.3: Incoming Query: SELECT Pricebook2.DefaultCurrency__c FROM Pricebook2 WHERE Pricebook2.Id = 'xxxx'
> [2019-12-02 12:43:54,368 MSK] DEBUG [salesforce-failover-facade,,,] org.teiid.COMMAND_LOG.SOURCE [Worker1_QueryProcessorQueue2]: SOURCE SRC COMMAND: endTime=2019-12-02 12:43:54.368 requestID=9MPiB/GOwB5f.0 sourceCommandID=3 executionID=2 txID=null modelName=sf translatorName=salesforce sessionID=9MPiB/GOwB5f principal=anonymous sourceCommand=[Using retrieve: Pricebook2.DefaultCurrency__c Pricebook2 [xxxx]]
> {code}
> But need to generate one. Because we have two relations in MSRP__c
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5962) Teiid locks many threads when Salesforce is disconnected
by Renat Eskenin (Jira)
Renat Eskenin created TEIID-5962:
------------------------------------
Summary: Teiid locks many threads when Salesforce is disconnected
Key: TEIID-5962
URL: https://issues.redhat.com/browse/TEIID-5962
Project: Teiid
Issue Type: Bug
Components: Salesforce Connector
Affects Versions: 12.3.1
Reporter: Renat Eskenin
Assignee: Steven Hawkins
Attachments: Снимок экрана от 2020-05-31 11-09-10.png
We had two incidents in our experimental service with teiid spring boot app. When Salesforce is down to 20min and service with teiid trying to call SQL from Salesforce we have many threads in tomcat server (in spring boot app). Then when 200 threads is activated service do not reply to requests because is "max threads" in tomcat of service.
Why teiid do not send response as "Salesforce is down - error" or connection timeout?
Micro schema:
HTTP Requests to REST api -> Teiid spring boot app -> {broken 20min}Salesforce
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5861) Salesforce translator should support nested joins
by Renat Eskenin (Jira)
[ https://issues.redhat.com/browse/TEIID-5861?page=com.atlassian.jira.plugi... ]
Renat Eskenin commented on TEIID-5861:
--------------------------------------
I investigated bugs in some my tasks and described its with code, but implementing of new functions is very difficult.
> Salesforce translator should support nested joins
> -------------------------------------------------
>
> Key: TEIID-5861
> URL: https://issues.redhat.com/browse/TEIID-5861
> Project: Teiid
> Issue Type: Enhancement
> Components: Salesforce Connector
> Reporter: Renat Eskenin
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: Backlog
>
> Original Estimate: 2 days
> Remaining Estimate: 2 days
>
> For this SQL we have wrong generated SOQL
> {code}
> select
> price.Id,
> price.IsActive__c,
> price.name,
> price.PriceBook__c,
> book.DefaultCurrency__c,
> price.Price__c,
> price.ProductCode__c,
> price.ProductName__c,
> price.Product__c,
> product.Id,
> product.Name,
> product.Description
> from
> MSRP__c as price
> left outer join /*+ MAKEDEP */ Product2 as product on
> price.Product__c = product.id
> left outer join /*+ MAKEDEP */ Pricebook2 as book on
> price.PriceBook__c = book.id
> where
> price.PriceBook__c =:priceBookId
> and ProductCode__c in(
> :productCodes
> )
> and IsActive__c = true"
> {code}
> {code}
> START DATA SRC COMMAND: startTime=2019-12-02 12:43:54.368 requestID=9MPiB/GOwB5f.0 sourceCommandID=3 executionID=2 txID=null modelName=sf translatorName=salesforce sessionID=9MPiB/GOwB5f principal=anonymous sql=SELECT sf.Pricebook2.DefaultCurrency__c FROM sf.Pricebook2 WHERE sf.Pricebook2.Id = 'xxxxx'
> [2019-12-02 12:43:54,368 MSK] DEBUG [salesforce-failover-facade,,,] org.teiid.COMMAND_LOG.SOURCE [Worker0_QueryProcessorQueue1]: SOURCE SRC COMMAND: endTime=2019-12-02 12:43:54.368 requestID=9MPiB/GOwB5f.0 sourceCommandID=2 executionID=1 txID=null modelName=sf translatorName=salesforce sessionID=9MPiB/GOwB5f principal=anonymous sourceCommand=[SELECT MSRP__c.Id, MSRP__c.IsActive__c, MSRP__c.Name, MSRP__c.PriceBook__c, MSRP__c.Price__c, MSRP__c.ProductCode__c, MSRP__c.ProductName__c, MSRP__c.Product__c, Product__r.Id, Product__r.Name, Product__r.Description FROM MSRP__c WHERE (MSRP__c.PriceBook__c = 'xxxx') AND ((MSRP__c.ProductCode__c IN(xxxxx)) AND (MSRP__c.IsActive__c = true))]
> [2019-12-02 12:43:54,368 MSK] DEBUG [salesforce-failover-facade,,,] org.teiid.CONNECTOR [Worker1_QueryProcessorQueue2]: salesforce.9MPiB/GOwB5f.9MPiB/GOwB5f.0.3: Incoming Query: SELECT Pricebook2.DefaultCurrency__c FROM Pricebook2 WHERE Pricebook2.Id = 'xxxx'
> [2019-12-02 12:43:54,368 MSK] DEBUG [salesforce-failover-facade,,,] org.teiid.COMMAND_LOG.SOURCE [Worker1_QueryProcessorQueue2]: SOURCE SRC COMMAND: endTime=2019-12-02 12:43:54.368 requestID=9MPiB/GOwB5f.0 sourceCommandID=3 executionID=2 txID=null modelName=sf translatorName=salesforce sessionID=9MPiB/GOwB5f principal=anonymous sourceCommand=[Using retrieve: Pricebook2.DefaultCurrency__c Pricebook2 [xxxx]]
> {code}
> But need to generate one. Because we have two relations in MSRP__c
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5960) Setting connection url property for MYSQL XA Datasource
by Ramesh Reddy (Jira)
[ https://issues.redhat.com/browse/TEIID-5960?page=com.atlassian.jira.plugi... ]
Ramesh Reddy commented on TEIID-5960:
-------------------------------------
Teiid does not control any properties what is being set, if the MySQL data source supports the URL property on it then you can use it, if not no. AFAIK, I only seen Oracle supports the URL property on their data source. If MySQL also supports that is fine. Check the "setter" methods on the data source class then use them to define it.
> Setting connection url property for MYSQL XA Datasource
> -------------------------------------------------------
>
> Key: TEIID-5960
> URL: https://issues.redhat.com/browse/TEIID-5960
> Project: Teiid
> Issue Type: Bug
> Components: AdminApi, JDBC Connector
> Affects Versions: 11.1.2
> Reporter: Manoj Majumdar
> Assignee: Steven Hawkins
> Priority: Minor
> Labels: Mysql-connector, teiid, xa-datasource-property
>
> I am trying to create a mysql xa datasource, but am unable to mention connection url properties in it. I have used property names such as "URL" and "connection-url", but the property is not visible in datasource.
> Also when I explicitly make a property tag in datasource for the url, it is working, but not when I am creating it through Admin Api,
> I need the connection url for setting mysql connection arguments such as "rewriteBatchedStatements=true"
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5961) create foreign data wrapper statement cleanups
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5961?page=com.atlassian.jira.plugi... ]
Steven Hawkins commented on TEIID-5961:
---------------------------------------
[~rareddy] this is optional. It just makes it clearer for migrated vdbs and new ddl where the fdw options are supposed to go.
> create foreign data wrapper statement cleanups
> ----------------------------------------------
>
> Key: TEIID-5961
> URL: https://issues.redhat.com/browse/TEIID-5961
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 15.0
>
> Original Estimate: 2 hours
> Time Spent: 2 hours
> Remaining Estimate: 0 minutes
>
> ConvertVDB is still adding create foreign data wrapper x; statements. These are not needed and should be suppressed. It's also causing some confusion that a user can enter
> create foreign data wrapper x options (...);
> The options are actually ignored. We should probably throw an exception instead. Either a type or a handler are required (we don't currently support a separate notion of a handler - it's treated the same as type).
> See also TEIID-5850
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5961) create foreign data wrapper statement cleanups
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5961?focusedWorklogId=12451177&pag... ]
Steven Hawkins logged work on TEIID-5961:
-----------------------------------------
Author: Steven Hawkins
Created on: 29/May/20 12:58 PM
Start Date: 29/May/20 12:58 PM
Worklog Time Spent: 2 hours
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 2 hours)
Time Spent: 2 hours
Worklog Id: (was: 12451177)
> create foreign data wrapper statement cleanups
> ----------------------------------------------
>
> Key: TEIID-5961
> URL: https://issues.redhat.com/browse/TEIID-5961
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 15.0
>
> Original Estimate: 2 hours
> Time Spent: 2 hours
> Remaining Estimate: 0 minutes
>
> ConvertVDB is still adding create foreign data wrapper x; statements. These are not needed and should be suppressed. It's also causing some confusion that a user can enter
> create foreign data wrapper x options (...);
> The options are actually ignored. We should probably throw an exception instead. Either a type or a handler are required (we don't currently support a separate notion of a handler - it's treated the same as type).
> See also TEIID-5850
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5961) create foreign data wrapper statement cleanups
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5961?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIID-5961.
-----------------------------------
Resolution: Done
Updated the parser and the convert vdb routine as described.
> create foreign data wrapper statement cleanups
> ----------------------------------------------
>
> Key: TEIID-5961
> URL: https://issues.redhat.com/browse/TEIID-5961
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 15.0
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> ConvertVDB is still adding create foreign data wrapper x; statements. These are not needed and should be suppressed. It's also causing some confusion that a user can enter
> create foreign data wrapper x options (...);
> The options are actually ignored. We should probably throw an exception instead. Either a type or a handler are required (we don't currently support a separate notion of a handler - it's treated the same as type).
> See also TEIID-5850
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5961) create foreign data wrapper statement cleanups
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5961?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIID-5961:
----------------------------------
Description:
ConvertVDB is still adding create foreign data wrapper x; statements. These are not needed and should be suppressed. It's also causing some confusion that a user can enter
create foreign data wrapper x options (...);
The options are actually ignored. We should probably throw an exception instead. Either a type or a handler are required (we don't currently support a separate notion of a handler - it's treated the same as type).
See also TEIID-5850
was:
ConvertVDB is still adding create foreign data wrapper x; statements. These are not needed and should be suppressed. It's also causing some confusion that a user can enter
create foreign data wrapper x options (...);
The options are actually ignored. We should probably throw an exception instead. Either a type or a handler are required (we don't currently support the notion of a handler).
See also TEIID-5850
Summary: create foreign data wrapper statement cleanups (was: create foreign data wrapper statements)
> create foreign data wrapper statement cleanups
> ----------------------------------------------
>
> Key: TEIID-5961
> URL: https://issues.redhat.com/browse/TEIID-5961
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 15.0
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> ConvertVDB is still adding create foreign data wrapper x; statements. These are not needed and should be suppressed. It's also causing some confusion that a user can enter
> create foreign data wrapper x options (...);
> The options are actually ignored. We should probably throw an exception instead. Either a type or a handler are required (we don't currently support a separate notion of a handler - it's treated the same as type).
> See also TEIID-5850
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months