Today's meeting agenda
by Antoine Sabot-Durand
Hi all,
Here are the points I’d like to discuss in our meeting today :
1) Back on Websocket + RequestScoped issue : CDI-370 : Expand @RequestScoped and @SessionScoped to account for WebSocket
Stuart Douglas will be our Guest Star to help us sort out if we can fix this issue on CDI side and if yes, if it’s doable in the MR timeframe
2) If there’s time left let’s discuss the following point :
- CDI-406 Make stereotypes bean defining annotations
Should we define all stereotype as a bean definition annotation or should clarify the fact that it’s not the case in the spec ?
- CDI-404 adding bean-defining annotations for Interceptor while setting bean-discovery-mode=« annotated »
- CDI-389 Revert CDI-85 (an easy one)
- CDI-397 Clarify Section 6.6.3 regarding singletons
An ambiguity, we all agree to clarify. I’d had we should check for all singleton occurrence in the spec (they seems all related to EJB) and perhaps think for a mention about singleton scope
- CDI-395 Public fields in extensions should not be allowed (also easy to decide)
I you’d like to have other issues put in priority please tell me. I took those to have a mix sample…
Antoine
11 years, 3 months
[JBoss JIRA] (CDI-395) Public fields in extensions should not be allowed
by Martin Kouba (JIRA)
[ https://issues.jboss.org/browse/CDI-395?page=com.atlassian.jira.plugin.sy... ]
Martin Kouba commented on CDI-395:
----------------------------------
I think only non-static public fields should be disallowed, see also CDI-244.
> Public fields in extensions should not be allowed
> -------------------------------------------------
>
> Key: CDI-395
> URL: https://issues.jboss.org/browse/CDI-395
> Project: CDI Specification Issues
> Issue Type: Clarification
> Components: Portable Extensions
> Affects Versions: 1.1.PFD
> Reporter: Marko Lukša
> Labels: cdi-1.1-mr
>
> Since the container must provide an @ApplicationScoped bean for every extension and since a proxy must be injected into injection points requesting this bean, it should be clear that extensions should not be allowed to have public fields. The spec doesn't specify this explicitly, but it should - like it does for non-dependent managed beans.
> The container should treat this as a definition error, otherwise people may end up accessing these public fields of extensions and getting weird errors.
> See also WELD-1474
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months
meeting 11/18/2013 notes
by Antoine Sabot-Durand
Hi all,
Sorry for the delay.
You’ll find the 11/18/2013 meeting notes here [1]. The asciidoc source below :
= CDI EG meeting 11/18/2013 notes on CDI 1.1.1 MR
The goal of this 1st meeting was to organize the MR launching, and start discussing its content
The following people assisted this meeting :
* Pete Muir (pm)
* Mark Struberg (ms)
* Jozef Hartinger (jh)
* Joseph Bergmark (jb)
* Arne Limburg (al)
* Antoine Sabot-Durand (asd)
== Proposed Agenda
The following agenda was proposed by *asd*
1. MR proposed roadmap
2. Content of the proposed list
3. Try to have a 1st decision on big tickets (tickets with great impact on implementation or spec)
* CDI-377 : automatic JSR-330 annotation processing problematic
* CDI-370 : Expand @RequestScoped and @SessionScoped to account for WebSocket
* others
== Proposed Roadmap
As we should run the MR in 60 days and that we cannot change its content after its start we proposed the following roadmap
* 16th Dec - list of issues complete
* 6th Jan - Maintenance review starts
* 7th March - Maintenance review ends
* 21st March - Maintenance ballot ends
This roadmap integrates the holidays constraints as well. It'll be confirmed after the meeting *pm* and *asd* will have with the JCP on 11/26
== Content of the proposed list
*asd* stressed on the fact that the long proposed list won't probably fit in the MR but that would be nice to provide them a status.
We decided to deal the most important ticket first.
== list of tickets
=== https://issues.jboss.org/browse/CDI-377[CDI-377 : automatic JSR-330 annotation processing problematic]
All the participant agreed that this ticket could be quite tricky. 2 scenario for solving it
* Having an umbrella scanning mechanism : beyond CDI and off course the MR.*pm* took note of escalate this need to the JCP
* in the meantime could investigate an exclusion in beans.xml. this solution is to be explored and if we have an agreement we could provide a fix in MR scope
=== https://issues.jboss.org/browse/CDI-370[CDI-370 : Expand @RequestScoped and @SessionScoped to account for WebSocket]
A tricky issue as well. No one in the EG has a sufficient knowloedge of websocket sepc to statute ont in so *pm* propose to ask help to *Matthias Wessendorf*
Other tickets related to `@RequestScoped` clarification
* https://issues.jboss.org/browse/CDI-379[CDI-379 Clarify life cycle of RequestScoped]
* https://issues.jboss.org/browse/CDI-381[CDI-381 and other request scope related ticket]
* https://issues.jboss.org/browse/CDI-406[CDI-406 Make stereotypes bean defining annotations]
[1] http://docgist.nawroth.se/?dropbox-2898173%2Fcdi%2520eg%2Fmeetings%2F2013...
Antoine Sabot-Durand /@antoine_sd
———————————————
CDI co-spec lead
CDI eco-system development
Agorava tech lead
11 years, 3 months
[JBoss JIRA] (CDI-408) bean-discovery-mode="annotated" and Producers/Observers in @Dependent beans
by Jens Schumann (JIRA)
Jens Schumann created CDI-408:
---------------------------------
Summary: bean-discovery-mode="annotated" and Producers/Observers in @Dependent beans
Key: CDI-408
URL: https://issues.jboss.org/browse/CDI-408
Project: CDI Specification Issues
Issue Type: Clarification
Components: Beans
Reporter: Jens Schumann
Right now bean-discovery-mode="annotated" skips beans that are not annotated with an bean-defining annotation even if they contain an observer method or producer method/field. I would not recommend having (not annotated) @Dependent beans with @Observes or @Produces - I just had them by accident while playing around with Wildfly.
However there are two impacts:
1. Someone might be confused by ignored @Producer's. Not a major issue here, the CDI runtime will report it. We could optionally document the behavior in the spec, so it's clear to everyone. However I think it's inconsistent, since @Produces may contain a scope (and has a default scope too). Therefore I would vote for @Produces support in bean-discovery-mode="annotated". Of course the enclosing class is not a managed bean that may be injected somewhere.
2. Since Observer methods in "not annotated" beans fail silently this can be a major issue for applications, especially if you migrate from CDI 1.0 (CDI 1.0 source code and CDI 1.0 thinking model). Therefore I believe @Observer methods have to be included in bean-discovery-mode="annotated" even if the enclosing bean does not have a bean-defining annotation. Of course the enclosing class is not a managed bean that may be injected somewhere.
I understand that the proposal above might have negative impacts on class scanning performance in bean-discovery-mode="annotated". However silently failing @Observes can be a major cause of defects that have to be treated because of technical and political reasons. Technical - because it may cause bugs. And political - because in my experience many people are still skeptical that CDI events are a trustworthy achievement[1]. Possibly skipped observer methods won't make live easier.
If you believe the proposal would kill the original intent of bean-discovery-mode="annotated" please document the impact for Producers and Observers in the spec and even in the XSD.
--
[1] I have trained a couple hundred people in using CDI and CDI events. And every time I have to argument against the uncertainty on event delivery: "How do I know which observers are active?", "Who ensures that event's are delivered?"... I personally LOVE events;)
Btw: Which JIRA version is CDI 1.1 Final?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 3 months