February 2014 - cdi-dev - Jboss List Archives

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by John Ament (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] John Ament commented on CDI-377: -------------------------------- As a user, I find this bug tough to swallow. On one side, what I think the Java EE platform is saying is that if you run on an EE container, you're getting EE features. In the case of what was added in EE7, this means you get various stuff automatically added to your app, including a servlet container, a default JMS connection factory, JAX-RS enabled, JSF enabled and CDI enabled. The problem is that CDI enabling means enabling of JSR-330 annotation processing. This means for apps using Spring, Guice that there's already a consumer of the JSR-330 annotations on the path and if they want to be used they need a way to coexist with the CDI processors. The downside to this is that now you need to have certain libraries being EE aware, that when they run on an EE7 container they need to follow certain rules. I'm not sure if this is the original intention of the EE expert group, it may be worthwhile to ask. > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Jozef Hartinger (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Jozef Hartinger commented on CDI-377: ------------------------------------- We definitely cannot revert one of the main new features of CDI 1.1 just because we think that CDI 1.1 is not mainstream yet. Btw, how is your proposal consistent with Java EE 7 spec which says that CDI is enabled by default in EE7? > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

I need implementation team review on PR 201

by Antoine Sabot-Durand

Hi, As defined on the last meeting I need the review of one member of the implementor team (Arne, Jozef, Mark or Martin) on PR 201[1] to close the ticket CDI-410. It should be quick. thanks Antoine [1]https://github.com/cdi-spec/cdi/pull/201

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-377: ------------------------------------------ [~bergmark]The problem is that we break apps that don't use CDI. > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-377: ------------------------------------------ [~jharting] I understand what you're saying but I don't agree. That's what I'd call a general guidelines, but when we decided something wrong (a mistake that we didn't foreseen) we have to do something. And we already broke this rule by reverting things in CDI-389. We have the opportunity to correct an issue before mainstream developer start seriously using CDI 1.1+. Sorry to say that but there are zillions of Spring and Guice libs out there with dev team that don't care about CDI and that will have no reason or interest to add a beans.xml file to their lib. This critical ticket is 9 months old with no satisfying solution. At this step I think nobody can comme in the discussion and simply say "no" without a constructive solution. So what do you suggest to fix this? > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Romain Manni-Bucau (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Romain Manni-Bucau commented on CDI-377: ---------------------------------------- We scan more than before and it is enough to break apps not relying on CDI rules. Explicit declaration should be at least the default to keep compatibility. > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Joe Bergmark (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Joe Bergmark commented on CDI-377: ---------------------------------- I completely agree with Jozef. I don't see how we break apps written using the rules that were explicit in CDI 1.1, especially in what is supposed to be a MR of CDI 1.1. > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Romain Manni-Bucau (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Romain Manni-Bucau commented on CDI-377: ---------------------------------------- @Jozef: so we should really rollback it since that's what was done between 1.0 and 1.1 and it creates a lot of issues in apps. For JavaEE this is a clear BUG + CDi 1.1 is not yet really used so we should do it now IMHO. > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Jozef Hartinger (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Jozef Hartinger commented on CDI-377: ------------------------------------- This is not how Java EE works. You have to retain backwards compatibility. You can define what was previously optional or undefined (e.g. implicit bean archive support in CDI 1.0) but you cannot change defined behavior. > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

[JBoss JIRA] (CDI-377) automatic JSR-330 annotation processing problematic

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-377?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-377: ------------------------------------------ Yes we do. But we broke compatibility with the rest of the world with CDI 1.1. Today people who are taking their app containing JSR 330 application to Wildfly see their app crash with a stuff they don't use in their devs. I don't think it's a great promotion of CDI ;). WDYT [~jharting] ? > automatic JSR-330 annotation processing problematic > --------------------------------------------------- > > Key: CDI-377 > URL: https://issues.jboss.org/browse/CDI-377 > Project: CDI Specification Issues > Issue Type: Bug > Components: Java EE integration > Affects Versions: 1.1.PFD > Environment: glassfish-4 > Reporter: Reuben Pasquini > Labels: CDI_spec_chge, CDI_tck_chge > Fix For: 1.2 Proposed > > > The jsr-330 dependency injection annotations (javax.inject.*) find use in javase environments using IOC packages like guice. > Adding a dependency on a jar that uses guice or whatever in a javase environment > to a war deployed to a jee7 container > results in CDI processing annotated classes intended for > app-managed injection. See this ticket filed with guava for a concrete example: > https://code.google.com/p/guava-libraries/issues/detail?id=1433 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cdi-dev February 2014