January 2017 - cdi-dev - Jboss List Archives

[JBoss JIRA] (CDI-644) Link formatting in the specification text

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-644?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-644: ------------------------------------------ I'm investigating this, but not sure to provide a solution before 2.0 spec doc release. > Link formatting in the specification text > ------------------------------------------ > > Key: CDI-644 > URL: https://issues.jboss.org/browse/CDI-644 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Tomas Remes > Fix For: 2.0 .Final > > > In previous versions (1.x) of specification links to chapters within spec were formatted as follows: > {noformat} > Section 2.4.1, “Built-in scope types” > {noformat} > I would like to preserve this formatting (especialy the prefix "Section x.x.x") also in the new specification version because I think it's more legible. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-670) Clarify InterceptionFactory.ignoreFinalMethods() purpose and functioning

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-670?page=com.atlassian.jira.plugin.sy... ] Work on CDI-670 started by Antoine Sabot-Durand. ------------------------------------------------ > Clarify InterceptionFactory.ignoreFinalMethods() purpose and functioning > ------------------------------------------------------------------------ > > Key: CDI-670 > URL: https://issues.jboss.org/browse/CDI-670 > Project: CDI Specification Issues > Issue Type: Clarification > Reporter: Martin Kouba > Assignee: Antoine Sabot-Durand > Priority: Critical > Fix For: 2.0 .Final > > > It should be clear that {{InterceptionFactory.ignoreFinalMethods()}} only affects the generation of the "proxy" which enables interception. E.g. the following example would FAIL during validation of {{myFoo}} injection point (bootstrap): > {code:java} > @Inject > Foo myFoo; > @Produces > @RequestScoped // -> Requires a client proxy > public Foo produce(InterceptionFactory<Foo> interceptionFactory) { > // Suppose Foo has a final method > return interceptionFactory.ignoreFinalMethods().createInterceptedInstance(new Foo()); > } > {code} > The reason is that the CDI container must treat the producer as a deployment problem (unless {{javax.enterprise.inject.spi.ProcessBeanAttributes.ignoreFinalMethods()}} is used for the producer method). > I understand that it's not very intuitive. On the other hand, these are two different concepts. I.e. the *injection point validation happens during bootstrap* while the {{InterceptionFactory}} *is used at runtime*. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-668) Most Example with @Priority provide non fully qualified contant name

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-668?page=com.atlassian.jira.plugin.sy... ] Work on CDI-668 started by Antoine Sabot-Durand. ------------------------------------------------ > Most Example with @Priority provide non fully qualified contant name > -------------------------------------------------------------------- > > Key: CDI-668 > URL: https://issues.jboss.org/browse/CDI-668 > Project: CDI Specification Issues > Issue Type: Clarification > Affects Versions: 2.0.Beta1 > Reporter: Antoine Sabot-Durand > Assignee: Antoine Sabot-Durand > Fix For: 2.0 .Final > > > Example in spec show {{@Priority}} are assuming static import of {{javax.interceptor.Interceptor.Priority.APPLICATION}} > We should change them to show full qualified path or add static import to examples for readability sake. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-677) Specify the default scope for beans created from BeanConfigurator

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-677?page=com.atlassian.jira.plugin.sy... ] Work on CDI-677 started by Antoine Sabot-Durand. ------------------------------------------------ > Specify the default scope for beans created from BeanConfigurator > ----------------------------------------------------------------- > > Key: CDI-677 > URL: https://issues.jboss.org/browse/CDI-677 > Project: CDI Specification Issues > Issue Type: Clarification > Reporter: Martin Kouba > Assignee: Antoine Sabot-Durand > Fix For: 2.0 .Final > > > Right now, this is undefined. However, it might me useful to specify that the scope is defaulted if not set by {{BeanConfigurator.scope(Class<? extends Annotation>)}}. The default scope could be either {{@Dependent}} or determined by the rules from "2.4.4. Default scope" (i.e. including default scopes from stereotypes). -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-671) SPI element related to Instance are missing info about their qualifier

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-671?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-671: ------------------------------------------ EG agreed to standardize Weld Behaviour described by [~mkouba] > SPI element related to Instance are missing info about their qualifier > ---------------------------------------------------------------------- > > Key: CDI-671 > URL: https://issues.jboss.org/browse/CDI-671 > Project: CDI Specification Issues > Issue Type: Clarification > Components: Javadoc and API > Affects Versions: 2.0.Beta1 > Reporter: Antoine Sabot-Durand > Assignee: Antoine Sabot-Durand > Fix For: 2.0 .Final > > > Following elements are related to {{Instance}} interface: > * {{CDI}} class implements {{Instance}} > * {{SeContainer}} extends {{Instance}} > * {{BeanManager.createInstance()}} returns and {{Instance}} object > If these {{Instance}} usage are all {{Instance<Object>}} there's no information regarding their qualifier. > We should state in Javadoc and spec that these Instance behaves like an injected instance with {{@Inject @Any Instance<Object>}} to allow access to all beans instance in the container. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-671) SPI element related to Instance are missing info about their qualifier

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-671?page=com.atlassian.jira.plugin.sy... ] Work on CDI-671 started by Antoine Sabot-Durand. ------------------------------------------------ > SPI element related to Instance are missing info about their qualifier > ---------------------------------------------------------------------- > > Key: CDI-671 > URL: https://issues.jboss.org/browse/CDI-671 > Project: CDI Specification Issues > Issue Type: Clarification > Components: Javadoc and API > Affects Versions: 2.0.Beta1 > Reporter: Antoine Sabot-Durand > Assignee: Antoine Sabot-Durand > Fix For: 2.0 .Final > > > Following elements are related to {{Instance}} interface: > * {{CDI}} class implements {{Instance}} > * {{SeContainer}} extends {{Instance}} > * {{BeanManager.createInstance()}} returns and {{Instance}} object > If these {{Instance}} usage are all {{Instance<Object>}} there's no information regarding their qualifier. > We should state in Javadoc and spec that these Instance behaves like an injected instance with {{@Inject @Any Instance<Object>}} to allow access to all beans instance in the container. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-673) Revisit manipulation with InjectionPoint(s) in ProducerConfigurator

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-673?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-673: ------------------------------------------ I agree. If a user needs to resolve an injection from here, providing fix for CDI-679 or using {{BeanManger#createInstance()}} seems a better approach. > Revisit manipulation with InjectionPoint(s) in ProducerConfigurator > ------------------------------------------------------------------- > > Key: CDI-673 > URL: https://issues.jboss.org/browse/CDI-673 > Project: CDI Specification Issues > Issue Type: Bug > Affects Versions: 2.0.Beta1 > Reporter: Matej Novotny > Assignee: Antoine Sabot-Durand > Fix For: 2.0 .Final > > > Currently, {{ProducerConfigurator}} allows to add or replace injection points. > Firstly, {{addInjectionPoints}} - if you think about this, it does not really make sense. You already have producer method defined, it has some body and uses its parameter within that method body. So if you add any IP, the method would not make use of it anyway. > Secondly, replacing IP with {{injectionPoints}} - now this seems useful, but in fact it won't work. As it stands, replacing them in Weld only affects validation phase, not the injection itself. This means that if you have following producer: > {code} > @Produces public Foo produceIt (@Default Bar) { //do stuff} > {code} > and meant to replace the parameter with, say, {{@MyCustom Bar}}, you would in the end still end up with {{@Default Bar}}. > The problem here is that [spec|http://docs.jboss.org/cdi/spec/2.0.EDR2/cdi-spec.html#injectiontarget] states the following: > bq. Implementations of Producer and InjectionTarget must ensure that the set of injection points returned by getInjectionPoints() are injected by produce() or inject(). > However, spec says nothing about what should happen when you change implementation's set on IPs later. > Note: I think we bumped into similar issue with {{BeanConfigurator}} (or some other configurator as well). I will try to dig up that discussion. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-673) Revisit manipulation with InjectionPoint(s) in ProducerConfigurator

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-673?page=com.atlassian.jira.plugin.sy... ] Work on CDI-673 started by Antoine Sabot-Durand. ------------------------------------------------ > Revisit manipulation with InjectionPoint(s) in ProducerConfigurator > ------------------------------------------------------------------- > > Key: CDI-673 > URL: https://issues.jboss.org/browse/CDI-673 > Project: CDI Specification Issues > Issue Type: Bug > Affects Versions: 2.0.Beta1 > Reporter: Matej Novotny > Assignee: Antoine Sabot-Durand > Fix For: 2.0 .Final > > > Currently, {{ProducerConfigurator}} allows to add or replace injection points. > Firstly, {{addInjectionPoints}} - if you think about this, it does not really make sense. You already have producer method defined, it has some body and uses its parameter within that method body. So if you add any IP, the method would not make use of it anyway. > Secondly, replacing IP with {{injectionPoints}} - now this seems useful, but in fact it won't work. As it stands, replacing them in Weld only affects validation phase, not the injection itself. This means that if you have following producer: > {code} > @Produces public Foo produceIt (@Default Bar) { //do stuff} > {code} > and meant to replace the parameter with, say, {{@MyCustom Bar}}, you would in the end still end up with {{@Default Bar}}. > The problem here is that [spec|http://docs.jboss.org/cdi/spec/2.0.EDR2/cdi-spec.html#injectiontarget] states the following: > bq. Implementations of Producer and InjectionTarget must ensure that the set of injection points returned by getInjectionPoints() are injected by produce() or inject(). > However, spec says nothing about what should happen when you change implementation's set on IPs later. > Note: I think we bumped into similar issue with {{BeanConfigurator}} (or some other configurator as well). I will try to dig up that discussion. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-679) ProducerConfigurator should provide the possibility to simulate parameter injection

by Martin Kouba (JIRA)

[ https://issues.jboss.org/browse/CDI-679?page=com.atlassian.jira.plugin.sy... ] Martin Kouba commented on CDI-679: ---------------------------------- I would say this is a low priority issue (Minor/Optional). Also for {{BeanConfigurator}} it makes more sense to simulate a producer method. > ProducerConfigurator should provide the possibility to simulate parameter injection > ------------------------------------------------------------------------------------ > > Key: CDI-679 > URL: https://issues.jboss.org/browse/CDI-679 > Project: CDI Specification Issues > Issue Type: Feature Request > Reporter: Antoine Sabot-Durand > > As BeanConfigurator, ProducerConfigurator should provide {{<U extends T> BeanConfigurator<U> produceWith(Function<Instance<Object>, U> callback);}} to simulate parameter injection in producer method. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

[JBoss JIRA] (CDI-679) ProducerConfigurator should provide the possibility to simulate parameter injection

by Antoine Sabot-Durand (JIRA)

Antoine Sabot-Durand created CDI-679: ---------------------------------------- Summary: ProducerConfigurator should provide the possibility to simulate parameter injection Key: CDI-679 URL: https://issues.jboss.org/browse/CDI-679 Project: CDI Specification Issues Issue Type: Feature Request Reporter: Antoine Sabot-Durand As BeanConfigurator, ProducerConfigurator should provide {{<U extends T> BeanConfigurator<U> produceWith(Function<Instance<Object>, U> callback);}} to simulate parameter injection in producer method. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cdi-dev January 2017