June 2017 - cdi-dev - Jboss List Archives

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand edited comment on CDI-705 at 6/7/17 8:20 AM: ------------------------------------------------------------------ Obviously, we introduced a mistake in CDI 2.0 by mentioning that transactional observers bound to {{BEFORE_COMPLETION}} phase should be called even if the transaction is rolled back or marked as rolled back. I plan to contact the EG to propose that we ignore this feature and align on JTA behaviour (related [test|https://github.com/cdi-spec/cdi-tck/blob/master/impl/src/main/java/o...] in TCK should also be ignored and this ticket will have to be corrected in a coming CDI 2.0 MR IMO. was (Author: antoinesabot-durand): Obviously, we introduced a mistake in CDI 2.0 by mentioning that transactional observers bound to {{BEFORE_COMPLETION}} phase should be called even if the transaction is rolled back or marked as rolled back. I plan to contact the EG to propose that we ignore this feature and align on JTA behaviour (related [test|https://github.com/antoinesd/cdi-tck/blob/2092263827d68253e2a74c6150...] in TCK should also be ignored and this ticket will have to be corrected in a coming CDI 2.0 MR IMO. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Antoine Sabot-Durand (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Antoine Sabot-Durand commented on CDI-705: ------------------------------------------ Obviously, we introduced a mistake in CDI 2.0 by mentioning that transactional observers bound to {{BEFORE_COMPLETION}} phase should be called even if the transaction is rolled back or marked as rolled back. I plan to contact the EG to propose that we ignore this feature and align on JTA behaviour (related [test|https://github.com/antoinesd/cdi-tck/blob/2092263827d68253e2a74c6150...] in TCK should also be ignored and this ticket will have to be corrected in a coming CDI 2.0 MR IMO. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Martin Kouba (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Martin Kouba commented on CDI-705: ---------------------------------- [~ochaloup] Thanks for your explanation. That makes sense. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Ondra Chaloupka edited comment on CDI-705 at 6/6/17 9:22 AM: ------------------------------------------------------------- Tom already mentioned it so these are just my two cents: as I understand it, the main difference is in the fact that {{beforeCompletion}} is expected to be called with the active transaction context (by spec it's required). That provides the way for e.g. JPA (as Tom mentioned) to call flushes etc. That's are operations which are needed for data changes being made visible for the consumer - that's when the transaction *is going* to be committed. When the transaction *is not going* to be committed (was rolled back or marked to roll back) then first there is no need for such operations (and they could be considered as superfluous). Plus at that time the transaction context could not be available (as txn could be rolled back) and operations working on beforeCompletion context is expecting to use it. The {{afterCompletion}} is expected to be called without active transaction context - that's true for commit and rollback. For both cases, the transaction already finished and there isn't any notion of it. From that point, both cases are the same. was (Author: ochaloup): Tom already mentioned it so these are just my two cents: as I understand it, the main difference is in the fact that {{beforeCompletion}} is expected to be called with the active transaction context (by spec it's required). That provides the way for e.g. JPA (as Tom mentioned) to call flushes etc. That's are operations which are needed for data changes being made visible for the consumer - that's when the transaction *is going* to be committed. When the transaction *is not going* to be committed (was rolled back or marked to roll back) then first there is no need for such operations (and they could be considered as superfluous). Plus at that time the transaction context could not be available (as txn could be rolled back) and operations working on beforeCompletion context is expecting to use it. The {{afterCompletion}} is expected to be called without active transaction context - that's true for commit and rollback. For both cases, the transaction already finished and there could not be any notion of it. Those cases are the same in that way. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Ondra Chaloupka edited comment on CDI-705 at 6/6/17 9:21 AM: ------------------------------------------------------------- Tom already mentioned it so these are just my two cents: as I understand it, the main difference is in the fact that {{beforeCompletion}} is expected to be called with the active transaction context (by spec it's required). That provides the way for e.g. JPA (as Tom mentioned) to call flushes etc. That's are operations which are needed for data changes being made visible for the consumer - that's when the transaction *is going* to be committed. When the transaction *is not going* to be committed (was rolled back or marked to roll back) then first there is no need for such operations (and they could be considered as superfluous). Plus at that time the transaction context could not be available (as txn could be rolled back) and operations working on beforeCompletion context is expecting to use it. The {{afterCompletion}} is expected to be called without active transaction context - that's true for commit and rollback. For both cases, the transaction already finished and there could not be any notion of it. Those cases are the same in that way. was (Author: ochaloup): Tom already mentioned it so these are just my two cents: as I understand it, the main difference is in the fact that {{beforeCompletion}} is expected to be called with the active transaction context (by spec it's required). That provides the way for e.g. JPA (as Tom mentioned) to call flushes etc. That's are operations which are needed for data changes being made visible for the consumer - that's when the transaction *is going* to be committed. When the transaction *is not going* to be committed (was rolled back or marked to roll back) then first there is no need for such operations (and they could be considered as superfluous) and at that time the transaction context could not be available. The {{afterCompletion}} is expected to be called without active transaction context - that's true for commit and rollback. For both cases, the transaction already finished and there could not be any notion of it. Those cases are the same in that way. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Ondra Chaloupka edited comment on CDI-705 at 6/6/17 9:20 AM: ------------------------------------------------------------- Tom already mentioned it so these are just my two cents: as I understand it, the main difference is in the fact that {{beforeCompletion}} is expected to be called with the active transaction context (by spec it's required). That provides the way for e.g. JPA (as Tom mentioned) to call flushes etc. That's are operations which are needed for data changes being made visible for the consumer - that's when the transaction *is going* to be committed. When the transaction *is not going* to be committed (was rolled back or marked to roll back) then first there is no need for such operations (and they could be considered as superfluous) and at that time the transaction context could not be available. The {{afterCompletion}} is expected to be called without active transaction context - that's true for commit and rollback. For both cases, the transaction already finished and there could not be any notion of it. Those cases are the same in that way. was (Author: ochaloup): Tom already mentioned it so these are just my two cents: as I understand it, the main difference is in the fact that {{beforeCompletion}} is expected to be called with the active transaction context (by spec it's required). That provides the way for e.g. JPA (as Tom mentioned) to call flushes etc. That's are operations which are needed for data changes being made visible for the consumer - that's when the transaction is going to be committed. When the transaction is not going to be committed (was rolled back or marked to roll back) then first there is no need for such operations (and they could be considered as superfluous) and at that time the transaction context could not be available. The {{afterCompletion}} is expected to be called without active transaction context - that's true for commit and rollback. For both cases, the transaction already finished and there could not be any notion of it. Those cases are the same in that way. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Ondra Chaloupka commented on CDI-705: ------------------------------------- Tom already mentioned it so these are just my two cents: as I understand it, the main difference is in the fact that {{beforeCompletion}} is expected to be called with the active transaction context (by spec it's required). That provides the way for e.g. JPA (as Tom mentioned) to call flushes etc. That's are operations which are needed for data changes being made visible for the consumer - that's when the transaction is going to be committed. When the transaction is not going to be committed (was rolled back or marked to roll back) then first there is no need for such operations (and they could be considered as superfluous) and at that time the transaction context could not be available. The {{afterCompletion}} is expected to be called without active transaction context - that's true for commit and rollback. For both cases, the transaction already finished and there could not be any notion of it. Those cases are the same in that way. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Martin Kouba (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Martin Kouba commented on CDI-705: ---------------------------------- [~tomjenkinson] Well, I don't want to do anything ;-) I'm just curious. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Tom Jenkinson commented on CDI-705: ----------------------------------- AC is already defined as called an undefined transaction context so I wonder what it is that you want to do in AC when abort is called? But again, perhaps best to discuss on the forum. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

[JBoss JIRA] (CDI-705) BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback

by Martin Kouba (JIRA)

[ https://issues.jboss.org/browse/CDI-705?page=com.atlassian.jira.plugin.sy... ] Martin Kouba commented on CDI-705: ---------------------------------- Well, {{Synchronization.afterCompletion()}} should be called even if a tx is rolled back. But it probably makes sense to skip BC. > BEFORE_COMPLETION Transactional observer is notified for transaction which is marked for rollback > ------------------------------------------------------------------------------------------------- > > Key: CDI-705 > URL: https://issues.jboss.org/browse/CDI-705 > Project: CDI Specification Issues > Issue Type: Bug > Components: Events > Affects Versions: 2.0 .Final > Reporter: Tomas Remes > > In {{10.4.5. Transactional observer methods}} CDI spec states: > {quote} > If the transaction is in progress, but javax.transaction.Synchronization callback cannot be > registered due to the transaction being already marked for rollback or in state where > javax.transaction.Synchronization callbacks cannot be registered, the before completion, after completion and after failure observer methods are notified at the same time as other observers, but after_success observer methods get skipped. > {quote} > This doesn't conform to JTA spec, which says in {{3.3.2 Transaction Synchronization}}: > {quote} > The Synchronization.beforeCompletion method is called prior to the > start of the two-phase transaction commit process. This call is executed with > the transaction context of the transaction that is being committed. > {quote} > So the before_completion transactional observer shouldn't be notified for transaction marked for rollback. > The method {{Synchronization.beforeCompletion}} is actually not called at WildFly and GlassFish app servers for transaction which is marked for rollback. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cdi-dev June 2017