Re: [cdi-dev] Full rewrite for CDI 558 / PR 270

Hi all, Following discussion during last meeting, I rewrote most of my PR for builders. We now have 2 clean and distinct ways of using them 1) in DSL style (with a Configurator interface without build() method) public void processAT(@Observes ProcessAnnotatedType<?> pat) { pat.setAnnotatedType().read(pat.getAnnotatedType()).addToType(new AnnotationLiteral<MyInterceptor>() {};); } 2) In classical reusable builder mode (builders extends configurator and only add build() method) public void processAT(@Observes ProcessAnnotatedType<?> pat) { AnnotatedTypeBuilder atb = Builders.annotatedTypeBuilder(); atb.read(pat.getAnnotatedType()).addToType(new AnnotationLiteral<MyInterceptor>() {};); pat.setAnnotatedType(atb.build()); } As Configurators don't have build() method there's no risk that users mix them with standard builders. For clarity sake, builders are no more available in lifecycle event but in Builders class for consistency. I'm quite happy with the result, but I'm sure you'll have comment ;). So thanks for your feedback https://github.com/cdi-spec/cdi/pull/270 Antoine _______________________________________________ cdi-dev mailing list cdi-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/cdi-dev Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 ( http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.