Thanks Antoine and John! done!
Many thanks,
Emily
===========================
Emily Jiang
WebSphere Application Server, CDI Development Lead
MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
Phone: +44 (0)1962 816278 Internal: 246278
Email: emijiang(a)uk.ibm.com
Lotus Notes: Emily Jiang/UK/IBM@IBMGB
From: Antoine Sabot-Durand <antoine(a)sabot-durand.net>
To: John Ament <john.ament(a)spartasystems.com>, Emily
Jiang/UK/IBM@IBMGB
Cc: cdi-dev <cdi-dev(a)lists.jboss.org>
Date: 20/10/2016 17:04
Subject: Re: [cdi-dev] Open PR validation
Sent by: cdi-dev-bounces(a)lists.jboss.org
Emily,
As John said, create your fork of the repo and then follow this guide:
https://help.github.com/articles/creating-a-pull-request-from-a-fork/
Antoine
On Thu, Oct 20, 2016 at 5:53 PM John Ament <john.ament(a)spartasystems.com>
wrote:
You need to fork the repository and push to your fork.
From: cdi-dev-bounces(a)lists.jboss.org <cdi-dev-bounces(a)lists.jboss.org> on
behalf of Emily Jiang <EMIJIANG(a)uk.ibm.com>
Sent: Thursday, October 20, 2016 11:47 AM
To: Antoine Sabot-Durand
Cc: cdi-dev
Subject: Re: [cdi-dev] Open PR validation
I'm trying to push my changes on cdi-616, but got the following error
message:
C:\cdi-2.0\cdi>git push -u origin emily-cdi
remote: Permission to cdi-spec/cdi.git denied to Emily-Jiang.
fatal: unable to access 'https://github.com/cdi-spec/cdi.git/': The
requested URL returned error: 403
Any thoughts on what went wrong?
Many thanks,
Emily
===========================
Emily Jiang
WebSphere Application Server, CDI Development Lead
MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
Phone: +44 (0)1962 816278 Internal: 246278
Email: emijiang(a)uk.ibm.com
Lotus Notes: Emily Jiang/UK/IBM@IBMGB
From: Antoine Sabot-Durand <antoine(a)sabot-durand.net>
To: cdi-dev <cdi-dev(a)lists.jboss.org>
Date: 20/10/2016 09:16
Subject: [cdi-dev] Open PR validation
Sent by: cdi-dev-bounces(a)lists.jboss.org
Hi all,
As the feature freeze date approach we have a lot of PR pending. Some are
big ones and ask a lot of discussion, some are rather obvious.
For these PR, I started to merge them if they were 1 week old and have at
least one person ok with its content. I'd prefer to have more than one
review of these, but we have a schedule to meet.
Try to check these small PR to be sure that we don't miss something, but
after one week with only positive feedback there will be merged.
Antoine_______________________________________________
cdi-dev mailing list
cdi-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/cdi-dev
Note that for all code provided on this list, the provider licenses the
code under the Apache License, Version 2 (
http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas
provided on this list, the provider waives all patent and other
intellectual property rights inherent in such information.
cdi-dev Info Page - JBoss Developer
lists.jboss.org
List to discuss the development of CDI (the specification) To see the
collection of prior postings to the list, visit the cdi-dev Archives.
Apache License, Version 2.0
www.apache.org
Apache License Version 2.0, January 2004
http://www.apache.org/licenses/
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION. 1.
Definitions.
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
NOTICE: This e-mail message and any attachments may contain confidential,
proprietary, and/or privileged information which should be treated
accordingly. If you are not the intended recipient, please notify the
sender immediately by return e-mail, delete this message, and destroy all
physical and electronic copies. Thank you.
_______________________________________________
cdi-dev mailing list
cdi-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/cdi-dev
Note that for all code provided on this list, the provider licenses the
code under the Apache License, Version 2 (
http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas
provided on this list, the provider waives all patent and other
intellectual property rights inherent in such information.
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU