12:06 a.m.
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Reporter: Brian Leathem
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:02 a.m.
New subject: [JBoss JIRA] Commented: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Lincoln Baxter III commented on CDI-127:
----------------------------------------
+1
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Reporter: Brian Leathem
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 a.m.
New subject: [JBoss JIRA] Updated: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-127:
--------------------------
Fix Version/s: 1.1 (Proposed)
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Reporter: Brian Leathem
Fix For: 1.1 (Proposed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:14 a.m.
New subject: [JBoss JIRA] Updated: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-127:
--------------------------
Component/s: Beans
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Fix For: 1.1 (Proposed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:10 a.m.
New subject: [JBoss JIRA] Commented: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-127:
-------------------------------
h1. Notes
Enums are somewhat different to normal classes, as Java guarantees that any instances are
singletons. Therefore we cannot treat them as classes. Furthermore, do we want to support
them as beans, allowing them to be injected?
Differences are:
* No callback on instantiation, when do we inject?
* Shared between deployments as singletons, how do we handle dependent scoped injections?
* We do not control instantiation, cannot perform constructor injection
h1. Proposal
We should support enums as non-contextual objects, performing field injection only. Enums
should be assumed to be injected only after the application is fully initialized for
portability.
If an enum is on a shared classloader, any injections should correctly resolve to the
deployment of the calling context. In other words, if a shared library or installed
library has an enum A:
{code}
enum A {
FOO, BAR;
@Inject B b;
String getName() {
return b.name;
}
}
{code}
where B is a class defined in the shared library
{code}
@ApplicationScoped
class B {
String name;
}
{code}
Then assuming that the name has been set to Pete in deployment 1, and Marius in deployment
2, when the enum A is used in deployment 1, the method getName() should return Pete, and
in deployment 2 it should return Marius.
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Fix For: 1.1 (Proposed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:12 a.m.
New subject: [JBoss JIRA] Updated: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-127:
--------------------------
Assignee: Pete Muir
Fix Version/s: 1.1 (Confirmed)
(was: 1.1 (Proposed))
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1 (Confirmed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir edited comment on CDI-127 at 6/21/11 9:16 AM:
--------------------------------------------------------
h1. Notes
Enums are somewhat different to normal classes, as Java guarantees that any instances are
singletons. Therefore we cannot treat them as classes. Furthermore, do we want to support
them as beans, allowing them to be injected?
Differences are:
* No callback on instantiation, when do we inject?
* Shared between deployments as singletons, how do we handle dependent scoped injections?
* We do not control instantiation, cannot perform constructor injection
h1. Proposal
We should support enums as non-contextual objects, performing field and method injection
only. Enums should be assumed to be injected only after the application is fully
initialized for portability.
If an enum is on a shared classloader, any injections should correctly resolve to the
deployment of the calling context. In other words, if a shared library or installed
library has an enum A:
{code}
enum A {
FOO, BAR;
@Inject B b;
String getName() {
return b.name;
}
}
{code}
where B is a class defined in the shared library
{code}
@ApplicationScoped
class B {
String name;
}
{code}
Then assuming that the name has been set to Pete in deployment 1, and Marius in deployment
2, when the enum A is used in deployment 1, the method getName() should return Pete, and
in deployment 2 it should return Marius.
was (Author: petemuir):
h1. Notes
Enums are somewhat different to normal classes, as Java guarantees that any instances are
singletons. Therefore we cannot treat them as classes. Furthermore, do we want to support
them as beans, allowing them to be injected?
Differences are:
* No callback on instantiation, when do we inject?
* Shared between deployments as singletons, how do we handle dependent scoped injections?
* We do not control instantiation, cannot perform constructor injection
h1. Proposal
We should support enums as non-contextual objects, performing field injection only. Enums
should be assumed to be injected only after the application is fully initialized for
portability.
If an enum is on a shared classloader, any injections should correctly resolve to the
deployment of the calling context. In other words, if a shared library or installed
library has an enum A:
{code}
enum A {
FOO, BAR;
@Inject B b;
String getName() {
return b.name;
}
}
{code}
where B is a class defined in the shared library
{code}
@ApplicationScoped
class B {
String name;
}
{code}
Then assuming that the name has been set to Pete in deployment 1, and Marius in deployment
2, when the enum A is used in deployment 1, the method getName() should return Pete, and
in deployment 2 it should return Marius.
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1 (Confirmed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:05 p.m.
New subject: [JBoss JIRA] Commented: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-127:
-------------------------------
https://github.com/jboss/cdi/pull/37
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1 (Confirmed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 a.m.
New subject: [JBoss JIRA] Resolved: (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir resolved CDI-127.
---------------------------
Resolution: Done
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1 (Confirmed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:20 a.m.
New subject: [JBoss JIRA] (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Jozef Hartinger reopened CDI-127:
---------------------------------
Reopening since several important aspects are not addressed in the specification.
h3. Validation
The specification does not require validation of enum injection points. The section 5.2.1
should be modified to include enums.
h3. ProcessAnnotatedType
{quote}The container must fire an event for each Java class or interface it discovers in a
bean archive{quote} - enums should be added. Since enums can now receive injection, it may
be interesting for extensions to examine/modify their annotated types.
h3. Bugs
{quote}The container is also required to perform dependency injection whenever it
instantiates any of the following non-
contextual objects: enums
{quote}
{quote}When the container creates a new instance of a managed bean, session bean, enum, or
of any other Java EE component
class supporting injection, the container must:{quote}
Expressions "Instantiating enum" or "creating a new instance of enum"
are not technically correct, because the container never creates a new instance.
----
Furthemore, I suggest the following changes to be considered by the expert group:
h3. New beans:
{quote} The container discovers @New qualified beans by inspecting injection points of
other enabled beans.{quote}
I suggest aligning the discovery process of @New qualified beans to cover Java enums.
h3. ProcessInjectionTarget
Internally, Weld uses an implementation of the InjectionTarget interface for injecting and
disposing enum instances. It may be useful to require enum injection to be treated this
way and allow extensions to alter the injection mechanism by overriding the
InjectionTarget implementation. This can be achieved by requiring that the container fires
a ProcessInjectionTarget event for each enum type it may inject.
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1.EDR1
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:58 a.m.
New subject: [JBoss JIRA] (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-127:
--------------------------
Fix Version/s: 1.1 (Proposed)
(was: 1.1.EDR)
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1 (Proposed)
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:47 a.m.
New subject: [JBoss JIRA] (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-127:
--------------------------
Fix Version/s: 1.1.PRD
(was: 1.1 (Proposed))
Please review https://github.com/jboss/cdi/pull/124
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1.PRD
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:17 a.m.
New subject: [JBoss JIRA] (CDI-127) Add support for annotation scanning of Java enums
[
https://issues.jboss.org/browse/CDI-127?page=com.atlassian.jira.plugin.sy...
]
Pete Muir resolved CDI-127.
---------------------------
Resolution: Done
Add support for annotation scanning of Java enums
-------------------------------------------------
Key: CDI-127
URL: https://issues.jboss.org/browse/CDI-127
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Beans
Reporter: Brian Leathem
Assignee: Pete Muir
Fix For: 1.1.PRD
It would be useful if Java enums were included in the CDI annotation scan.
A use case for this is found in the Seam Faces project, where we would like to use
annotations on enums for configuration purposes. The annotation would look like:
@ViewConfig
public enum Pages {
...
}
It is my understanding that the current CDI specification (1.0) does not require scanning
of the enum and will not pick up the @ViewConfig annotation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4446
days inactive
4974
days old
12 comments
4 participants
participants (4)
-
Brian Leathem (JIRA) -
Jozef Hartinger (Reopened) (JIRA)
-
Lincoln Baxter III (JIRA)
-
Pete Muir (JIRA)