[JBoss JIRA] (CDI-218) Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes a bean archive
9:51 a.m.
Dan Allen created CDI-218:
-----------------------------
Summary: Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive to
activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:06 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Craig Ringer commented on CDI-218:
----------------------------------
This would be a big usability improvement, though I'm strongly against warning if both
are present. If both are present it should be a fatal deployment error, anything else will
create more confusion down the track.
Maybe implementations should be permitted to vary the behaviour with a configuration
option or system property, in case someone for some reason needs to deploy a broken
archive they can't modify. It seems unlikely but not impossible. IMO it's
important to fail to deploy by default.
CDI already has too much subtle magic, adding more won't help make it usable. Warnings
usually get drowned in the logging spew from app servers, so they'll often be missed.
Most importantly, honouring one over the other may lead to things like security
interceptors not being enabled. That's bad enough that I think a deployment error is
warranted. The implementation could check to see whether one of the beans.xml files was
just an empty marker with no child elements and ignore that one, but IMO anything else is
unsafe.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:38 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-218:
-----------------------------------
Imo there is no need to change anything.
12.1 Bean archives
A directory in the JVM classpath is a bean archive if it has
a file named beans.xml in the META-INF directory.
WEB-INF/classes is a JVM classpath element as per the Servlet Spec 10.5 'Directory
Structure'. Thus no change is needed.
-1 for a warning btw.
The whole BDA stuff needs clarification anyway, but there is absolutely no question that
WEB-INF/classes/META-INF/beans.xml must get picked up by a CDI container.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:35 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-218:
-------------------------------
If we are satisfied this is covered, then I will assign to Martin to add a TCK test.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:35 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir updated CDI-218:
--------------------------
Issue Type: Clarification (was: Feature Request)
Fix Version/s: 1.1.EDR2
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Martin Kouba
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:35 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir reassigned CDI-218:
-----------------------------
Assignee: Martin Kouba
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Feature Request
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Martin Kouba
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:45 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-218:
-----------------------------------
As for the current status with BDA: what we might need to clarify is the relation between
WEB-INF/classes/META-INF/beans.xml and WEB-INF/beans.xml as they 'target' the same
BDA.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Martin Kouba
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-218:
-------------------------------
Good point.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir reassigned CDI-218:
-----------------------------
Assignee: (was: Martin Kouba)
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:14 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-218:
-------------------------------
I would propose we merge the two beans.xml, removing duplicates.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:28 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-218:
-----------------------------------
Not really possible I fear. removing WEB-INF/beans.xml would break backward compat. And
removing WEB-INF/classses/META-INF/beans.xml would as well.
This will automatically be resolved if we finally fix CDI-18...
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-218:
-------------------------------
No, I mean we read both beans.xml, and then merge the contents if both exist.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:57 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-218:
-----------------------------------
Oh I c. Humm, might get tricky. But 'merging' is exactly what is also proposed in
CDI-18 - just for all beans.xml and based on 'magic numbers' (or any other
mechanism we still need to figure).
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:57 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Jozef Hartinger commented on CDI-218:
-------------------------------------
This may be tricky to specify in a way that correctly handles corner cases such as two
beans.xml files with the same set of interceptors but in a different order.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:53 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-218:
-------------------------------
The other option is that we allow one or the other, but not both. I think that is also
perfectly reasonable.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:34 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-218:
-------------------------------
Pull request issued, please review https://github.com/jboss/cdi/pull/74
I've made putting a beans.xml in both locations very explicitly non-portable. An
implementation might wish to try merging, or might decide not to support it.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir reassigned CDI-218:
-----------------------------
Assignee: Pete Muir
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.EDR2
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:33 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir commented on CDI-218:
-------------------------------
This one should be reviewed at the next meeting.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:07 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Pete Muir resolved CDI-218.
---------------------------
Resolution: Done
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:50 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-218:
-----------------------------------
As we made very good progress on CDI-18 the last meetings I think we can just leave it as
is. For the 2 beans.xml the standard ordering rules defined in CDI-18 will take place.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:50 a.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
jaikiran pai commented on CDI-218:
----------------------------------
I have been reading Pete's blog about CDI 1.1 Public review draft of the spec and
noticed this JIRA and the changes being proposed. FWIW, in Java EE6, it's only JPA
which has been inconsistent on where the deployment descriptor (persistence.xml) is
expected to be placed. It expects it to be under .war/WEB-INF/classes/META-INF. The EJB
3.1 spec (just like CDI 1.0 spec) expects ejb-jar.xml to be under .war/WEB-INF folder. So
I'm not sure if allowing beans.xml in .war/WEB-INF/classes/META-INF is going to help
much in fixing that inconsistency or if it's going to make it a bit more
inconsistent.
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:15 p.m.
[
https://issues.jboss.org/browse/CDI-218?page=com.atlassian.jira.plugin.sy...
]
Mark Struberg commented on CDI-218:
-----------------------------------
I'd rather say it the other way around: ejb-jar.xml is the _only_ exception ;)
MANIFEST.MF e.g. is the oldest of this kind of files and it is perfectly fine in both
locations. As all other XML or similar files which contain additional info (properties,
etc) are perfectly fine in WEB-INF/classes/...
Honor WEB-INF/classes/META-INF/beans.xml to activate WEB-INF/classes
a bean archive
-----------------------------------------------------------------------------------
Key: CDI-218
URL: https://issues.jboss.org/browse/CDI-218
Project: CDI Specification Issues
Issue Type: Clarification
Components: Packaging and Deployment
Reporter: Dan Allen
Assignee: Pete Muir
Priority: Minor
Fix For: 1.1.PRD
Chapter 12.1 specifies that beans.xml must be in the WEB-INF directory of a web archive
to activate the WEB-INF/classes directory of that war as a bean archive (and thus make
java:comp/BeanManager visible to the web app).
However, many developers find this location both confusing and inconvenient at times. The
instinct of many developers is to put the beans.xml in WEB-INF/classes/META-INF since that
follows the convention that applies to library jars.
Obviously, we cannot break backwards compatibility. Therefore, this issue proposes to
honor either location in the war:
- WEB-INF/beans.xml
- WEB-INF/classes/META-INF/beans.xml
If both files are present, the WEB-INF/beans.xml should take precedence and a warning is
recommended. (Merging them is not likely the behavior that a developer would want).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4420
days inactive
4688
days old
21 comments
6 participants
participants (6)
-
Craig Ringer (JIRA) -
Dan Allen (JIRA)
-
jaikiran pai (JIRA)
-
Jozef Hartinger (JIRA)
-
Mark Struberg (JIRA)
-
Pete Muir (JIRA)