[ https://issues.jboss.org/browse/CDI-149?page=com.atlassian.jira.plugin.sy... ] Mark Struberg commented on CDI-149: ----------------------------------- Figured this myself lately. We should really go for it! There are a few areas which we could improve, mostly equals() and hashCode(). A fact upfront: if an Annotation has no member values, it returns 0 as hashCode()! That sucks, but we need to stay compatible. I'm not sure if we can cache the hashCode of an AnnotationLiteral if it contains member values. But we can for sure cache the 0 if getDeclaredMethods() returned an empty array. for equals() please at least push the getDeclaredMethods() down the call chain as it is madly expensive!. public boolean equals(Object other) { - Method[] methods = this.annotationType.getDeclaredMethods(); if(other == this) { return true; } if(other == null) { return false; } + Method[] methods = this.annotationType.getDeclaredMethods(); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/CDI-149?page=com.atlassian.jira.plugin.sy... ] Marko Lukša updated CDI-149: ---------------------------- Git Pull Request: https://github.com/jboss/cdi/pull/64 Please review the pull request. I've implemented the caching even for annotations with members. I don't think anyone, who understands what an AnnotationLiteral is, would implement a mutable concrete AnnotationLiteral. Maybe the javadoc of AnnotationLiteral should clearly state that member values must be constant. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/CDI-149?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated CDI-149: -------------------------- Fix Version/s: (was: 1.1 (Proposed)) Git Pull Request: https://github.com/jboss/cdi/pull/64 (was: https://github.com/jboss/cdi/pull/64) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira