[hibernate/hibernate-validator] 0a199d: HV-1438 Use Set consistently while manipulating va...
by GitHub
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-validator
Commit: 0a199d59cd8220d08b6a8e2f6794804d82bb37f8
https://github.com/hibernate/hibernate-validator/commit/0a199d59cd8220d08...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
Log Message:
-----------
HV-1438 Use Set consistently while manipulating value extractor
descriptors
Commit: cffcdec53fa0a27737caebbc137956c370188e2e
https://github.com/hibernate/hibernate-validator/commit/cffcdec53fa0a2773...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedExecutableBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedFieldBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedGetterBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedParameterBuilder.java
Log Message:
-----------
HV-1438 Fix XML cascading metadata for arrays
It was fixed for the annotations as part of HV-1384 but it was forgotten
for the XML part. The issue was hidden by how cascading was
implemented but some tests will fail once the follow up changes will be
incorporated.
Commit: e4d1c3138661fa6d2d43f11eebcc53e47f1873ff
https://github.com/hibernate/hibernate-validator/commit/e4d1c3138661fa6d2...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraints.java
Log Message:
-----------
HV-1438 Use the right method to throw the exception
This issue was previously hidden but it was an oversight.
Commit: 662b1605d16358dd98360e22f5df3faadd802f9f
https://github.com/hibernate/hibernate-validator/commit/662b1605d16358dd9...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorDescriptor.java
M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java
Log Message:
-----------
HV-1438 Improve a log message
Commit: 99c1d260697dd9857ff6be66d2d80c59c8d82d25
https://github.com/hibernate/hibernate-validator/commit/99c1d260697dd9857...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
R engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ObjectValueExtractor.java
M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
Log Message:
-----------
HV-1438 Remove the ObjectValueExtractor
It's one more value extractor to test and it's always a valid candidate.
Moreover, it hid some unexpected behaviors.
Commit: 68f1332356096bdb0aff919df6a7f9b62d1d8099
https://github.com/hibernate/hibernate-validator/commit/68f1332356096bdb0...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/util/Contracts.java
M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java
Log Message:
-----------
HV-1438 Narrow down the possible value extractors to the ones compatible
with the declared type when dealing with cascaded validation
Commit: 7fbed6624d6b782b90ffaa5890d944a281f3282c
https://github.com/hibernate/hibernate-validator/commit/7fbed6624d6b782b9...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GroupConversionHelper.java
Log Message:
-----------
HV-1437 Share the default empty instance of GroupConversionHelper
Commit: 24ae78ecf9827f032cc9892cb01d74f6902f99b3
https://github.com/hibernate/hibernate-validator/commit/24ae78ecf9827f032...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
Log Message:
-----------
HV-1437 Make the signatures an immutable set
In the default case of one signature, it improves the memory usage as
the Set is converted to a singleton set.
Commit: d0e3eeb42fca2f4091b8995120c51baa2c214c62
https://github.com/hibernate/hibernate-validator/commit/d0e3eeb42fca2f409...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorFactoryImpl.java
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/BeanMetaDataManager.java
M engine/src/test/java/org/hibernate/validator/test/internal/engine/path/PathImplTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/BeanMetaDataManagerTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/aggregated/ExecutableMetaDataTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/aggregated/ParameterMetaDataTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/aggregated/PropertyMetaDataTest.java
Log Message:
-----------
HV-1437 Share a common ValidationOrderGenerator
There is no point in having 2 separate ones in ValidatorImpl and
BeanMetaDataManager.
Commit: 744e679c0dfad4e0905cdc2a8b6d94cf2462ab83
https://github.com/hibernate/hibernate-validator/commit/744e679c0dfad4e09...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
Log Message:
-----------
HV-1437 Add constant CascadingMetaDatas for non container configuration
Commit: aafb64a389c212deadb94ca0849e27eb23e664aa
https://github.com/hibernate/hibernate-validator/commit/aafb64a389c212dea...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M performance/src/main/java/org/hibernate/validator/performance/cascaded/CascadedValidation.java
M performance/src/main/java/org/hibernate/validator/performance/simple/SimpleValidation.java
Log Message:
-----------
HV-1439 Remove the iterative versions of the benchmarks: they are
useless
Commit: d0d554534b31caa6ef3d29bb94742997d0221851
https://github.com/hibernate/hibernate-validator/commit/d0d554534b31caa6e...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M performance/README.md
M performance/pom.xml
Log Message:
-----------
HV-1439 Adjust how the performance tests are run
Commit: de37a14df62eb939be30b32e839f30c519a661fc
https://github.com/hibernate/hibernate-validator/commit/de37a14df62eb939b...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M performance/README.md
M performance/pom.xml
Log Message:
-----------
HV-1439 Update 5.4 to 5.4.1 in performance tests
Commit: 9d893078436291f1789f0e94d7a6431750c4043e
https://github.com/hibernate/hibernate-validator/commit/9d893078436291f17...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
Log Message:
-----------
HV-1439 Reduce the contention on the beanMetaDataCache concurrent map
I introduced the infrastructure for that quite some time ago but only
used it for properties, whereas it's also beneficial in the method
validation path.
Commit: 485750cce9f797bc0776c109539e930d8113cf34
https://github.com/hibernate/hibernate-validator/commit/485750cce9f797bc0...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/util/Contracts.java
M engine/src/main/java/org/hibernate/validator/internal/util/TypeHelper.java
Log Message:
-----------
HV-1439 Avoid using toString() and string append if we don't have to log anything
Commit: efdd5115803725f2c526a67ecae574a8ddb1f67a
https://github.com/hibernate/hibernate-validator/commit/efdd5115803725f2c...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ReturnValueMetaData.java
Log Message:
-----------
HV-1439 Optimize a bit the initialization of ReturnValueMetaData
Commit: a98ce3d84800f99c9766c410de30d4432f427e74
https://github.com/hibernate/hibernate-validator/commit/a98ce3d84800f99c9...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
Log Message:
-----------
HV-1439 Use computeIfAbsent when retrieving BeanConfiguration
Commit: 1749f69a5589f203e0aa96644b2055bbbb442ce2
https://github.com/hibernate/hibernate-validator/commit/1749f69a5589f203e...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GroupConversionHelper.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ReturnValueMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/cascading/CascadingTypeParameter.java
M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java
Log Message:
-----------
HV-1441 Clean up the initialization of CascadingMetaData
Commit: 08f46dc32506ec51c0b5257d9daca21a6c896bae
https://github.com/hibernate/hibernate-validator/commit/08f46dc32506ec51c...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/AbstractConstraintMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
A engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ContainerCascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
A engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/NonContainerCascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/cascading/CascadingTypeParameter.java
M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java
Log Message:
-----------
HV-1441 Separate CascadingMetaData in 2 classes: one very lightweight
for non containers and the other full featured for containers
Commit: e0f480f53110e7ca062a975cf3eb0decaf365f82
https://github.com/hibernate/hibernate-validator/commit/e0f480f53110e7ca0...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/cfg/context/CascadableConstraintMappingContextImplBase.java
M engine/src/main/java/org/hibernate/validator/internal/cfg/context/ContainerElementConstraintMappingContextImpl.java
M engine/src/main/java/org/hibernate/validator/internal/cfg/context/ExecutableConstraintMappingContextImpl.java
M engine/src/main/java/org/hibernate/validator/internal/cfg/context/ParameterConstraintMappingContextImpl.java
M engine/src/main/java/org/hibernate/validator/internal/cfg/context/PropertyConstraintMappingContextImpl.java
A engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaDataBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ContainerCascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/MetaDataBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/NonContainerCascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/rule/ParallelMethodsMustNotDefineGroupConversionForCascadedReturnValue.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/rule/ReturnValueMayOnlyBeMarkedOnceAsCascadedPerHierarchyLine.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/rule/VoidMethodsMustNotBeReturnValueConstrained.java
R engine/src/main/java/org/hibernate/validator/internal/metadata/cascading/CascadingTypeParameter.java
R engine/src/main/java/org/hibernate/validator/internal/metadata/cascading/package-info.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/facets/Cascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/AbstractConstrainedElement.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedElement.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedExecutable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedField.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedParameter.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/ConstrainedType.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedExecutableBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedFieldBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedGetterBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedParameterBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/xml/ContainerElementTypeConfigurationBuilder.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/provider/AnnotationMetaDataProviderTest.java
Log Message:
-----------
HV-1441 Rename CascadingTypeParameter to CascadingMetaDataBuilder
It does not exactly follow the builder pattern but it's really what it
does.
Commit: 99551f9c5c6a1e20ab07ddbd53726a5f75ae4ff9
https://github.com/hibernate/hibernate-validator/commit/99551f9c5c6a1e20a...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/AbstractConstraintMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaDataBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ContainerCascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/MetaDataBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/NonContainerCascadingMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ReturnValueMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/rule/ParallelMethodsMustNotDefineGroupConversionForCascadedReturnValue.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/rule/ReturnValueMayOnlyBeMarkedOnceAsCascadedPerHierarchyLine.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/rule/VoidMethodsMustNotBeReturnValueConstrained.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/AbstractConstrainedElement.java
Log Message:
-----------
HV-1441 Some naming improvements to improve consistency
Commit: 39e70a9499c89dd24fa453212eced860afe50d50
https://github.com/hibernate/hibernate-validator/commit/39e70a9499c89dd24...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaDataBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ContainerCascadingMetaData.java
Log Message:
-----------
HV-1439 Have a specific method to check that cascading should be
performed on container elements: there is no need to execute part of the
code if only the annotated object is cascaded.
Commit: ca0a8041bfad5f7c1bfc4eeb27c96c0fc19bbc8c
https://github.com/hibernate/hibernate-validator/commit/ca0a8041bfad5f7c1...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorFactoryImpl.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/core/ConstraintHelper.java
Log Message:
-----------
HV-1439 Detect built-in constraints right away and keep a cache of the detected constraints
Commit: 24f21d1a522854d5024c5b7a734a01063f88fbd6
https://github.com/hibernate/hibernate-validator/commit/24f21d1a522854d50...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/MethodValidationConfiguration.java
Log Message:
-----------
HV-1439 Create only once the set of rules as everything is immutable
Commit: 00ba073e9d69a9dc0b4a795c0574bcda46c3fa46
https://github.com/hibernate/hibernate-validator/commit/00ba073e9d69a9dc0...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/BeanMetaDataImpl.java
Log Message:
-----------
HV-1439 Add hashCode() and equals() methods to the builder delegate as it's
used in a HashSet
Commit: 567cbe92502111a16bdef54a6d64a68319b23f46
https://github.com/hibernate/hibernate-validator/commit/567cbe92502111a16...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
Log Message:
-----------
HV-1437 No need to copy the set of rules as it's immutable
Commit: 82167c74d570f188c5abf28f729c1bb8839eef62
https://github.com/hibernate/hibernate-validator/commit/82167c74d570f188c...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
Log Message:
-----------
HV-1439 Avoid calling reflection methods multiple times
Commit: 06d6fd2982b61f3061f15d1e9d0f71fb51799a3c
https://github.com/hibernate/hibernate-validator/commit/06d6fd2982b61f306...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/descriptor/ConstraintDescriptorImpl.java
A engine/src/main/java/org/hibernate/validator/internal/util/privilegedactions/GetAnnotationParameters.java
Log Message:
-----------
HV-1439 Get all the annotation parameters at once
Getting them one by one is excessively costly.
Commit: 25d2e6e3e097494f3ba33fb04a4be0dfb26e6549
https://github.com/hibernate/hibernate-validator/commit/25d2e6e3e097494f3...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/descriptor/ConstraintDescriptorImpl.java
Log Message:
-----------
HV-1439 Avoid calling toImmutable in the getter: the collection is already immutable
Commit: f31db806faa59d2253daab25edc593c142519f0d
https://github.com/hibernate/hibernate-validator/commit/f31db806faa59d225...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/util/annotationfactory/AnnotationProxy.java
Log Message:
-----------
HV-1439 Make the AnnotationProxy equals more efficient
The current method is calling GetDeclaredMethod for each attribute of
the annotation, which is not a good idea, considering this call is
rather slow.
Instead, if the annotation is an AnnotationProxy, we directly work on
the map that is in the InvocationHandler, and if not, we get all the
parameters at once.
Commit: d86d336800bd94b7291e3832d3eb5231e68dc743
https://github.com/hibernate/hibernate-validator/commit/d86d336800bd94b72...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/raw/AbstractConstrainedElement.java
Log Message:
-----------
HV-1443 AbstractConstrainedElement#isConstrained() should also return true if there are group conversions without cascading
Commit: e676956ff796af718ee98016640af41a21d789b4
https://github.com/hibernate/hibernate-validator/commit/e676956ff796af718...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/provider/AnnotationMetaDataProvider.java
Log Message:
-----------
HV-1439 Avoid calling getParameters() if there are no parameters
Commit: 6ea2fc22bfc115d4ea3612b86aaa6f170b842dd6
https://github.com/hibernate/hibernate-validator/commit/6ea2fc22bfc115d4e...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/MetaDataBuilder.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
Log Message:
-----------
HV-1439 HV-1437 Only create the accessible method once and share the
GetterConstraintLocation
Commit: b52f1fbc78a0fce3f38562717cab7eb1ad1a7286
https://github.com/hibernate/hibernate-validator/commit/b52f1fbc78a0fce3f...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/location/FieldConstraintLocation.java
M engine/src/main/java/org/hibernate/validator/internal/util/privilegedactions/GetDeclaredField.java
M engine/src/main/java/org/hibernate/validator/internal/util/privilegedactions/GetDeclaredMethod.java
M engine/src/main/java/org/hibernate/validator/internal/util/privilegedactions/SetAccessibility.java
Log Message:
-----------
HV-1439 Group the reflection and the setAccessible priviledged actions
Commit: 6be092872ef8f23165db340cd24541577a5d8275
https://github.com/hibernate/hibernate-validator/commit/6be092872ef8f2316...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/metadata/core/ConstraintHelper.java
Log Message:
-----------
HV-1439 Add a comment on why we don't use isJdkAnnotation() in isConstraintAnnotation()
Commit: 6caa16d0b1402c75e44bb9cbad3dbf70578e474c
https://github.com/hibernate/hibernate-validator/commit/6caa16d0b1402c75e...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/util/annotationfactory/AnnotationProxy.java
Log Message:
-----------
HV-1439 Disable AnnotationProxy equals optimization if the security manager is enabled
Apparently, the security check for getInvocationHandler() was not
correctly implemented in JDK 8 < 131.
Commit: aa03d82464157fac5ee535e6032d2768204b71f1
https://github.com/hibernate/hibernate-validator/commit/aa03d82464157fac5...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/BeanMetaData.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/BeanMetaDataImpl.java
M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/UnconstrainedEntityMetaDataSingleton.java
M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java
M engine/src/test/java/org/hibernate/validator/test/internal/engine/methodvalidation/WrongMethodOrParameterForMethodValidationTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/engine/path/PathImplTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/CustomerRepositoryExt.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/aggregated/ExecutableMetaDataTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/aggregated/JobRepository.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/aggregated/ParameterMetaDataTest.java
M engine/src/test/java/org/hibernate/validator/test/internal/metadata/aggregated/SpecialJobRepositoryImpl.java
Log Message:
-----------
HV-1447 Remove metadata for unconstrained methods from the aggregated metamodel
We still keep a set of the signatures of the unconstained methods to be
able to throw an exception if the method does not exist.
Commit: 51ca465d2ac88aaf76abc1243a957c71034eb3f1
https://github.com/hibernate/hibernate-validator/commit/51ca465d2ac88aaf7...
Author: Guillaume Smet <guillaume.smet(a)gmail.com>
Date: 2017-08-03 (Thu, 03 Aug 2017)
Changed paths:
M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
Log Message:
-----------
HV-1447 Be more consistent about the naming of validationContext
context is not clear enough as we also have the valueContext.
Compare: https://github.com/hibernate/hibernate-validator/compare/9d6c5b80aac3...5...
6 years, 9 months