[hibernate/hibernate-search] bf6e02: HSEARCH-3893 Return the count of *root* documents ...
by Yoann Rodière
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: bf6e021f999a8297099de0a7846469bf10d12c97
https://github.com/hibernate/hibernate-search/commit/bf6e021f999a8297099d...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-16 (Thu, 16 Apr 2020)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchBucketAggregation.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchNestableAggregation.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchRangeAggregation.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchTermsAggregation.java
Log Message:
-----------
HSEARCH-3893 Return the count of *root* documents instead of leaf documents for Elasticsearch aggregations
Commit: 297cfe9a5bb72f07609e2506245303acc97305b2
https://github.com/hibernate/hibernate-search/commit/297cfe9a5bb72f07609e...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-16 (Thu, 16 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
Log Message:
-----------
HSEARCH-3893 Test aggregations on fields in nested documents when there are multiple nested documents
Commit: feccb0b245bd901194bdf8f0d92769a19ed6ab4f
https://github.com/hibernate/hibernate-search/commit/feccb0b245bd901194bd...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-16 (Thu, 16 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/TextMultiValueFacetCounts.java
Log Message:
-----------
HSEARCH-3894 Fix Lucene text aggregations: count each document only once per term
This solution is probably not great performance-wise, but at least it
will work. It'll have to do until someone has time to find something
better.
Compare: https://github.com/hibernate/hibernate-search/compare/d04f0b604f89...fecc...
4 years
[hibernate/hibernate-search] e81445: HSEARCH-3892 Introduce TestIndexMapping for easier...
by Yoann Rodière
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: e81445e4d2a3bdb154d0ff60c9006bc9f64422a3
https://github.com/hibernate/hibernate-search/commit/e81445e4d2a3bdb154d0...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/rule/SearchSetupHelper.java
M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/AbstractMassIndexingBenchmarks.java
M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/AbstractOnTheFlyIndexingBenchmarks.java
M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/testsupport/index/AbstractBackendHolder.java
M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/testsupport/index/IndexInitializer.java
M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/testsupport/index/MappedIndex.java
A util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/SimpleMappedIndex.java
A util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappedIndex.java
M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMapper.java
M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMapping.java
M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingIndexManager.java
M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingInitiator.java
M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingPartialBuildState.java
R util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubTypeMetadataContributor.java
Log Message:
-----------
HSEARCH-3892 Introduce TestIndexMapping for easier test fixture implementation
Commit: fa17bb3dd1540b7ac79ca1ad2a99a4d65ea1b232
https://github.com/hibernate/hibernate-search/commit/fa17bb3dd1540b7ac79c...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/AggregationBaseIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/RangeAggregationSpecificsIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationUnsupportedTypesIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/TermsAggregationSpecificsIT.java
Log Message:
-----------
HSEARCH-3892 Convert aggregation tests to using SimpleMappedIndex
Commit: cab3ea39673e3529fe1faae3d7dccd4cdd84a3f4
https://github.com/hibernate/hibernate-search/commit/cab3ea39673e3529fe1f...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/RangeAggregationSpecificsIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationUnsupportedTypesIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/TermsAggregationSpecificsIT.java
Log Message:
-----------
HSEARCH-3892 Convert aggregation tests to using SimpleFieldModel
Commit: e9ae8695cbee48aeda97eeeba553d9912bbe8df5
https://github.com/hibernate/hibernate-search/commit/e9ae8695cbee48aeda97...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/types/FieldTypeDescriptor.java
M integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/testsupport/types/PropertyTypeDescriptor.java
Log Message:
-----------
HSEARCH-3892 Use a shorter toString() for FieldTypeDescriptor/PropertyTypeDescriptor
Because parameters of parameterized tests are unreadable otherwise.
Commit: 5193aa553d6c550814145f6d3230eabe1b8fb295
https://github.com/hibernate/hibernate-search/commit/5193aa553d6c55081414...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/RangeAggregationSpecificsIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationUnsupportedTypesIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/TermsAggregationSpecificsIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/operations/RangeAggregationDescriptor.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/operations/TermsAggregationDescriptor.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/operations/expectations/SupportedSingleFieldAggregationExpectations.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/SimpleFieldModelsByType.java
Log Message:
-----------
HSEARCH-3892 Align test fixtures for aggregation tests on FieldSearchSortBaseIT
We're going to test multiple index field structures, like in
FieldSearchSortBaseIT, and making these tests more similar to
FieldSearchSortBaseIT will make it easier to do so.
Commit: 44f20850d345509ffc93aecc89fd524dad459058
https://github.com/hibernate/hibernate-search/commit/44f20850d345509ffc93...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
R util/internal/test/src/main/java/org/hibernate/search/util/impl/test/singleinstance/AfterAll.java
R util/internal/test/src/main/java/org/hibernate/search/util/impl/test/singleinstance/BeforeAll.java
R util/internal/test/src/main/java/org/hibernate/search/util/impl/test/singleinstance/InstanceRule.java
R util/internal/test/src/main/java/org/hibernate/search/util/impl/test/singleinstance/SingleInstanceRunnerWithParameters.java
Log Message:
-----------
HSEARCH-3892 Remove the "single instance" runner
We don't use it anymore, and there are several caveats that we cannot
solve in JUnit 4 (such as test failures not being displayed correctly in
the IDE). Let's restore it if we really must, later.
Commit: 03f7621e0dd3783ce6d361fa35f8cff89d75283c
https://github.com/hibernate/hibernate-search/commit/03f7621e0dd3783ce6d3...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
A integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationTypeCheckingAndConversionIT.java
Log Message:
-----------
HSEARCH-3892 Move type-checking and type-conversion tests for single-field aggregations to a dedicated class
Commit: 7ad87153cd0d2324f039621b79291aaf50269127
https://github.com/hibernate/hibernate-search/commit/7ad87153cd0d2324f039...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/resources/impl/BackendThreads.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/resources/impl/BackendThreads.java
Log Message:
-----------
HSEARCH-3892 Avoid NPE when stopping threads that are not started yet.
Not related to this PR, but I encountered this problem while debugging
and a bootstrap failure occured.
Commit: 4c1be89146950fa6c74a6fe9d55193b195ca7ef7
https://github.com/hibernate/hibernate-search/commit/4c1be89146950fa6c74a...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
Log Message:
-----------
HSEARCH-3892 More exhaustive tests for aggregations on multiple field structures (nested, nested twice...)
Commit: 6ff7f03693ff195e78885b88b58f43fe05818f4e
https://github.com/hibernate/hibernate-search/commit/6ff7f03693ff195e7888...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/elasticsearch/src/test/java/org/hibernate/search/integrationtest/backend/elasticsearch/work/ElasticsearchZeroDowntimeReindexingIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryBaseIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/query/SearchQueryFetchIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/sharding/AbstractShardingIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/AbstractIndexWorkspaceSimpleOperationIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexIndexerIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/work/IndexWorkspaceIT.java
M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/AbstractMassIndexingBenchmarks.java
M integrationtest/performance/backend/base/src/main/java/org/hibernate/search/integrationtest/performance/backend/base/testsupport/index/IndexInitializer.java
M util/internal/integrationtest/mapper/stub/src/main/java/org/hibernate/search/util/impl/integrationtest/mapper/stub/StubMappingIndexManager.java
Log Message:
-----------
HSEARCH-3892 Remove an unused parameter in StubMappingIndexManager#createIndexer()
This was an oversight in HSEARCH-3822
Commit: bed7a84e0d5784d1e56538adad239255a4852ee2
https://github.com/hibernate/hibernate-search/commit/bed7a84e0d5784d1e565...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
Log Message:
-----------
HSEARCH-3892 Speed up data initialization in SingleFieldAggregationBaseIT
With all the combinations, indexing serially is becoming too slow.
Commit: 182fb9722e29f54b72afdd3c4245b882b96bd36c
https://github.com/hibernate/hibernate-search/commit/182fb9722e29f54b72af...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M build-config/src/main/java/org/hibernate/checkstyle/filters/ExcludeTestPackages.java
Log Message:
-----------
HSEARCH-3892 Relax some checkstyle rules for integration tests
Commit: 973e525b4c638dcc6cb9f8c05f1e9cfd2b20ea5a
https://github.com/hibernate/hibernate-search/commit/973e525b4c638dcc6cb9...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/rule/SearchSetupHelper.java
Log Message:
-----------
HSEARCH-3892 Add some logging to tests for easier debugging of test setup failures
Commit: 7333baed5ca632c939972a74fb88f749f2e6abe0
https://github.com/hibernate/hibernate-search/commit/7333baed5ca632c93997...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/join/impl/NestedDocsProvider.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/query/impl/Queries.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/LuceneNestedPredicateBuilder.java
Log Message:
-----------
HSEARCH-3892 Fix a bug where child documents could be assigned to the wrong parent in Lucene queries
Commit: 03188714cc3f03dac07a7c6647145f9f71eeb993
https://github.com/hibernate/hibernate-search/commit/03188714cc3f03dac07a...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchBucketAggregation.java
A backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchNestableAggregation.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchRangeAggregation.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchSearchAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/ElasticsearchTermsAggregation.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchBooleanFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchGeoPointFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchStandardFieldAggregationBuilderFactory.java
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/types/aggregation/impl/ElasticsearchTextFieldAggregationBuilderFactory.java
Log Message:
-----------
HSEARCH-3892 Aggregations on fields in nested objects for Elasticsearch
Commit: e253a606c08c8b9001b4cd1c394e26ae021f0c34
https://github.com/hibernate/hibernate-search/commit/e253a606c08c8b9001b4...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/impl/LuceneIndexEntryFactory.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/impl/LuceneRootDocumentBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/model/dsl/impl/LuceneIndexSchemaRootNodeBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/model/impl/LuceneIndexModel.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/document/model/impl/LuceneIndexSchemaNodeCollector.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/IndexManagerBackendContext.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/index/impl/LuceneIndexManagerBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/logging/impl/Log.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/TextMultiValueFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneFacetsBasedTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneTextTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/codec/impl/LuceneStringFieldCodec.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/AbstractLuceneNumericIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneGeoPointIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneNativeIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/dsl/impl/LuceneStringIndexFieldTypeOptionsStep.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/impl/LuceneIndexFieldType.java
Log Message:
-----------
HSEARCH-3892 Move away from FacetConfig/SortedSetDocValuesFacetCounts for text doc values used in aggregations
1. SortedSetDocValuesFacetCounts does not support nested documents
2. SortedSetDocValuesFacetCounts depends heavily on how FacetConfig
organizes doc values, with some dependencies on internal code.
3. FacetConfig is able to do much more than what we need, and is very
complicated. So we don't want to copy that.
Thus I copied SortedSetDocValuesFacetCounts to our project as
TextMultiValueFacetCounts, and removed the FacetConfig parts.
I'll adapt the code to support nested documents it in the next few commits.
Commit: fdd7f228ad316cb76a087e99911fb982409193f3
https://github.com/hibernate/hibernate-search/commit/fdd7f228ad316cb76a08...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/TextMultiValueFacetCounts.java
Log Message:
-----------
HSEARCH-3892 Avoid the use of ConjunctionDISI in TextMultiValueFacetCounts
First because ConjunctionDISI is internal to Lucene and shouldn't be
used elsewhere, and second because it won't work when we switch to our
own TextValues which do not extend DocIdSetIterator (nextDoc(),
advance(), etc.).
The performance cost shouldn't be too high as long as documents without
a value are relatively rare, and in any case we already pay the same cost
for numeric aggregations.
Commit: 65c66d90a82e212436370c4d2aca6f19d08d71b7
https://github.com/hibernate/hibernate-search/commit/65c66d90a82e21243637...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/JoiningTextMultiValuesSource.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/TextMultiValues.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/TextMultiValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/TextMultiValueFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneTextTermsAggregation.java
Log Message:
-----------
HSEARCH-3892 Aggregations on text fields in nested objects for Lucene
Commit: a2b87c5df0c477dc3d2a55f72f6a772c98714458
https://github.com/hibernate/hibernate-search/commit/a2b87c5df0c477dc3d2a...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/LongMultiValuesSource.java
Log Message:
-----------
HSEARCH-3892 Remove an invalid license header from LongMultiValuesSource
It was added by mistake.
Compare: https://github.com/hibernate/hibernate-search/compare/9f216b4f8c6f...a2b8...
4 years
[hibernate/hibernate-search] 1873fa: HSEARCH-1929 Aggregations on multi-valued fields
by Yoann Rodière
Branch: refs/heads/master
Home: https://github.com/hibernate/hibernate-search
Commit: 1873fa6a19d6b25092f6db54aaeb83eab9ebeffc
https://github.com/hibernate/hibernate-search/commit/1873fa6a19d6b25092f6...
Author: Waldemar Kłaczyński <wklaczynski(a)sabaservice.pl>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchAggregation.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValues.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/GeoPointDistanceMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/LongMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/MultiValueMode.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/NumericDoubleValues.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/NumericLongValues.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/SortedNumericDoubleDocValues.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/DoubleMultiValueRangeFacetCounts.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeCounter.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeFacetCounts.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/MultiValueRangeFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/aggregation/impl/AggregationRequestContext.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryBuilder.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneBucketAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericRangeAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneDoubleDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneFloatDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneIntegerDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneLongDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneNumericDomain.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/RangeAggregationOptionsStep.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/TermsAggregationOptionsStep.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/RangeAggregationRangeStepImpl.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/TermsAggregationOptionsStepImpl.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/SearchAggregationBuilder.java
A engine/src/main/java/org/hibernate/search/engine/search/common/MultiValue.java
M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/aggregation/impl/StubRangeAggregationBuilder.java
M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/aggregation/impl/StubTermsAggregationBuilder.java
Log Message:
-----------
HSEARCH-1929 Aggregations on multi-valued fields
Commit: 08f7390ee7d9fb782ff4ccb59b1d13f83c3fbe24
https://github.com/hibernate/hibernate-search/commit/08f7390ee7d9fb782ff4...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/LongMultiValuesToSingleValuesSource.java
Log Message:
-----------
HSEARCH-1929 Remove an unnecessary hack (again)
This relied on scores to pass the replacement for missing values,
but we just don't need that, since missing values are handled correctly
in the FieldComparators.
See also 95777b95fd10b3bd9037e5f2a8114ea46e8142ab
Commit: 91e67697f657779c6b84baeb8422bd5455698a40
https://github.com/hibernate/hibernate-search/commit/91e67697f657779c6b84...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/aggregation/impl/AbstractElasticsearchAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/AbstractLuceneBucketAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericRangeAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneDoubleDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneFloatDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneIntegerDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneLongDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneNumericDomain.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/RangeAggregationOptionsStep.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/TermsAggregationOptionsStep.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/RangeAggregationRangeStepImpl.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/dsl/impl/TermsAggregationOptionsStepImpl.java
M engine/src/main/java/org/hibernate/search/engine/search/aggregation/spi/SearchAggregationBuilder.java
R engine/src/main/java/org/hibernate/search/engine/search/common/MultiValue.java
M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/aggregation/impl/StubRangeAggregationBuilder.java
M util/internal/integrationtest/common/src/main/java/org/hibernate/search/util/impl/integrationtest/common/stub/backend/search/aggregation/impl/StubTermsAggregationBuilder.java
Log Message:
-----------
HSEARCH-1929 Do not expose the ability to set a "multi-value mode" for aggregations
1. This is not the purpose of this ticket, so this should be done as a
second step.
2. We know that we will not be able to implement this for Elasticsearch,
so we cannot expose this in common APIs, but should expose it in
Lucene-specific APIs instead.
Commit: b04fd55a7923c8e2b2a7218f6bee47e0d3be6b84
https://github.com/hibernate/hibernate-search/commit/b04fd55a7923c8e2b2a7...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/DoubleMultiValueRangeFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeCounter.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/MultiValueRangeFacetCounts.java
Log Message:
-----------
HSEARCH-1929 Add missing credits to javadoc
Commit: 31b575ef1523c6af9a039c1aaa81162d1169ffe4
https://github.com/hibernate/hibernate-search/commit/31b575ef1523c6af9a03...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValues.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/DoubleMultiValueRangeFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeFacetCounts.java
Log Message:
-----------
HSEARCH-1929 Remove some dead code from faceting implementations
Commit: 8bed15fd4a617383fc5ca80390d94031607b8c31
https://github.com/hibernate/hibernate-search/commit/8bed15fd4a617383fc5c...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/join/impl/JoinChildrenIdIterator.java
Log Message:
-----------
HSEARCH-1929 Introduce JoinChildrenIdIterator, for easy implementation of doc values retrieval in nested documents
Commit: c9af32cbc35107ddfe1110358388e7683fe298d7
https://github.com/hibernate/hibernate-search/commit/c9af32cbc35107ddfe11...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValues.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/GeoPointDistanceMultiValuesToSingleValuesSource.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/JoiningDoubleMultiValuesSource.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/JoiningLongMultiValuesSource.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/LongMultiValues.java
A backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/LongMultiValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/LongMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/MultiValueMode.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/NumericDoubleValues.java
R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/NumericLongValues.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/DoubleMultiValueRangeFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/aggregation/impl/LuceneNumericTermsAggregation.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneDoubleDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneFloatDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneIntegerDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneLongDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneNumericDomain.java
Log Message:
-----------
HSEARCH-1929 Clearly separate multi-values accessors from single-values accessors in the Lucene backend
1. To avoid hacks where sub-classes of NumericDocValues can actually
provide multiple values, in complete opposition to the purpose of the
NumericDocValues interface.
2. To avoid instantiation of one lists per document followed by a sort
when iterating over the doc values for aggregations.
Aggregations can iterate over millions of documents, so this
instantiation and sort can actually become a big deal
performance-wise.
Commit: 8957786bf788f1aa86c33495f266f124d0b0617f
https://github.com/hibernate/hibernate-search/commit/8957786bf788f1aa86c3...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValues.java
R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValuesSource.java
R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/JoiningDoubleMultiValuesSource.java
R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/DoubleMultiValueRangeFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/FacetCountsUtils.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneDoubleDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneFloatDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneIntegerDomain.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/lowlevel/impl/LuceneLongDomain.java
Log Message:
-----------
HSEARCH-1929 Work on raw, long values for Lucene float/double aggregations
It's less code, and we don't need more at the moment. We can always
revert this commit if one day we need more.
Commit: 4a0d774c7620a5a21108e880854c0e2b268f4cf0
https://github.com/hibernate/hibernate-search/commit/4a0d774c7620a5a21108...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeCounter.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeFacetCounts.java
Log Message:
-----------
HSEARCH-1929 Fix Lucene aggregations: count each document only once per term/range
This solution is probably not great performance-wise, but at least it
will work. It'll have to do until someone has time to find something
better.
Commit: 35dcb5d5bbf5427837034222ed517143caecd401
https://github.com/hibernate/hibernate-search/commit/35dcb5d5bbf542783703...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
Log Message:
-----------
HSEARCH-1927 Mark the test checking aggregations on multi-valued numeric fields
Commit: 9da8ef042b72c9daa2544fafff10ae64315fff4e
https://github.com/hibernate/hibernate-search/commit/9da8ef042b72c9daa254...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
Log Message:
-----------
HSEARCH-1929 Mark the test checking indexing of multi-valued, aggregable numeric fields
Commit: 92db06a52a6755d1299b9581329c9e2c102fa72f
https://github.com/hibernate/hibernate-search/commit/92db06a52a6755d1299b...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M integrationtest/backend/lucene/src/test/java/org/hibernate/search/integrationtest/backend/lucene/testsupport/util/LuceneTckBackendFeatures.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/search/aggregation/SingleFieldAggregationBaseIT.java
M integrationtest/backend/tck/src/main/java/org/hibernate/search/integrationtest/backend/tck/testsupport/util/TckBackendFeatures.java
Log Message:
-----------
HSEARCH-1929 Re-enable tests for aggregations on multi-valued fields for Lucene
Commit: 7a271e11cc35da42c754df4a52a6a639d066ed38
https://github.com/hibernate/hibernate-search/commit/7a271e11cc35da42c754...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/DoubleMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/LongMultiValuesToSingleValuesSource.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/MultiValueMode.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/docvalues/impl/TextMultiValuesToSingleValuesSource.java
R backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/join/impl/JoinFirstChildIdIterator.java
Log Message:
-----------
HSEARCH-1929 Replace JoinFirstChildIdIterator with JoinChildrenIdIterator
It's simpler to use.
Commit: 903309dc00b4e548a6e0f96e63367358448ac7bd
https://github.com/hibernate/hibernate-search/commit/903309dc00b4e548a6e0...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java
Log Message:
-----------
HSEARCH-1929 Sonar: do not assign loop counters within the loop body
Commit: e230ee3f7d873fbbb30b8771e982703220ebc042
https://github.com/hibernate/hibernate-search/commit/e230ee3f7d873fbbb30b...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueFacetCounts.java
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/MultiValueRangeFacetCounts.java
Log Message:
-----------
HSEARCH-1929 Sonar: Boolean literals should not be redundant
Commit: 6a8348b6099f2c505eef8191ec5be65c79a81d97
https://github.com/hibernate/hibernate-search/commit/6a8348b6099f2c505eef...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/LongMultiValueRangeCounter.java
Log Message:
-----------
HSEARCH-1929 Sonar: Sections of code should not be commented out
Commit: 9f216b4f8c6f934e935622fe38a8ab64f78d3f65
https://github.com/hibernate/hibernate-search/commit/9f216b4f8c6f934e9356...
Author: Yoann Rodière <yoann(a)hibernate.org>
Date: 2020-04-15 (Wed, 15 Apr 2020)
Changed paths:
M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/lowlevel/facet/impl/MultiValueRangeFacetCounts.java
Log Message:
-----------
HSEARCH-1929 Sonar: "throws" declarations should not be superfluous
Compare: https://github.com/hibernate/hibernate-search/compare/03f6bd5d4468...9f21...
4 years