February 2010 - jboss-remoting-commits

JBoss Remoting SVN: r5696 - remoting2/branches/2.x.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-16 00:00:55 -0500 (Tue, 16 Feb 2010) New Revision: 5696 Modified: remoting2/branches/2.x/local.properties Log: JBREM-1161: Added findbugs.home. Modified: remoting2/branches/2.x/local.properties =================================================================== --- remoting2/branches/2.x/local.properties 2010-02-16 04:59:51 UTC (rev 5695) +++ remoting2/branches/2.x/local.properties 2010-02-16 05:00:55 UTC (rev 5696) @@ -1,4 +1,5 @@ jboss.home=c://cygwin/home/rsigal/workspace.new/jboss-as-parent-trunk/build/output/jboss-5.0.0.GA as.startup.time=220 as.shutdown.time=10 -shell=c:/cygwin/bin/sh.exe \ No newline at end of file +shell=c:/cygwin/bin/sh.exe +findbugs.home=c:/cygwin/opt/local/findbugs-1.3.9 \ No newline at end of file

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5695 - remoting2/branches/2.x.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 23:59:51 -0500 (Mon, 15 Feb 2010) New Revision: 5695 Modified: remoting2/branches/2.x/build.xml Log: JBREM-1161: Added findbugs target. Modified: remoting2/branches/2.x/build.xml =================================================================== --- remoting2/branches/2.x/build.xml 2010-02-16 04:58:21 UTC (rev 5694) +++ remoting2/branches/2.x/build.xml 2010-02-16 04:59:51 UTC (rev 5695) @@ -4613,6 +4613,15 @@  </target> + <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask"/> + + <target name="findbugs" depends="jars"> + <findbugs home="${findbugs.home}" output="html" outputFile="${output.dir}/findbugs.html" > + <class location="${output.lib.dir}/jboss-remoting.jar" /> + <sourcePath path="${src.dir}" /> + <auxClasspath refid="third_party.classpath"/> + </findbugs> + </target> </project>

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5694 - remoting2/branches/2.2.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 23:58:21 -0500 (Mon, 15 Feb 2010) New Revision: 5694 Modified: remoting2/branches/2.2/local.properties Log: JBREM-1161: Added findbugs.home. Modified: remoting2/branches/2.2/local.properties =================================================================== --- remoting2/branches/2.2/local.properties 2010-02-16 04:43:08 UTC (rev 5693) +++ remoting2/branches/2.2/local.properties 2010-02-16 04:58:21 UTC (rev 5694) @@ -1,4 +1,5 @@ jboss.home=c://cygwin/home/rsigal/JBoss/JBossAS/jboss-4.2.3.GA as.startup.time=40 as.shutdown.time=10 -shell=c:/cygwin/bin/sh.exe \ No newline at end of file +shell=c:/cygwin/bin/sh.exe +findbugs.home=c:/cygwin/opt/local/findbugs-1.3.9 \ No newline at end of file

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5693 - remoting2/branches/2.2.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 23:43:08 -0500 (Mon, 15 Feb 2010) New Revision: 5693 Modified: remoting2/branches/2.2/build.xml Log: JBREM-1161: Added findbugs target. Modified: remoting2/branches/2.2/build.xml =================================================================== --- remoting2/branches/2.2/build.xml 2010-02-16 01:24:03 UTC (rev 5692) +++ remoting2/branches/2.2/build.xml 2010-02-16 04:43:08 UTC (rev 5693) @@ -3795,7 +3795,7 @@  <target name="dist" depends="clean,most,tests,javadoc,docs.generate,dist.only"/> - <target name="dist.quick" depends="clean,most,dist.jars,javadoc,docs.generate,dist.only"/> + <target name="dist.quick" depends="clean,most,dist.jars,javadoc,dist.only"/> <target name="dist.only" depends="configure"> <delete dir="${dist.dir}"/> @@ -3911,6 +3911,15 @@ <delete dir="${dist.dir}"/> </target> - + <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask"/> + + <target name="findbugs" depends="jars"> + <findbugs home="${findbugs.home}" output="html" outputFile="${output.dir}/findbugs.html" > + <class location="${output.lib.dir}/jboss-remoting.jar" /> + <sourcePath path="${src.dir}" /> + <auxClasspath refid="third_party.classpath"/> + </findbugs> + </target> + </project>

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5692 - remoting2/branches/2.2/src/tests/org/jboss/test/remoting/ssl/emptystore.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 20:24:03 -0500 (Mon, 15 Feb 2010) New Revision: 5692 Modified: remoting2/branches/2.2/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java Log: JBREM-1185, JBREM-1172, JBREM-1161: Added testDistinctNONEKeyStore(). Modified: remoting2/branches/2.2/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java =================================================================== --- remoting2/branches/2.2/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java 2010-02-16 01:23:14 UTC (rev 5691) +++ remoting2/branches/2.2/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java 2010-02-16 01:24:03 UTC (rev 5692) @@ -116,4 +116,51 @@ log.info(getName() + " PASSES"); } + + /** + * Creates "NONE" dynamically to test JBREM-1185. + */ + public void testDistinctNONEKeyStore() throws Throwable + { + log.info("entering " + getName()); + + // Create SSLSocketBuilder. + HashMap config = new HashMap(); + String none = new StringBuilder("NONE").toString(); + config.put(SSLSocketBuilder.REMOTING_KEY_STORE_TYPE, "JKS"); + config.put(SSLSocketBuilder.REMOTING_KEY_STORE_FILE_PATH, none); +// config.put(SSLSocketBuilder.REMOTING_KEY_STORE_PASSWORD, "dummy"); + config.put(SSLSocketBuilder.REMOTING_TRUST_STORE_TYPE, "JKS"); + config.put(SSLSocketBuilder.REMOTING_TRUST_STORE_FILE_PATH, none); +// config.put(SSLSocketBuilder.REMOTING_TRUST_STORE_PASSWORD, "dummy"); + SSLSocketBuilder socketBuilder = new SSLSocketBuilder(config); + socketBuilder.setUseSSLServerSocketFactory(false); + socketBuilder.setUseSSLSocketFactory(false); + + // Create ServerSocket. + try + { + ServerSocketFactory ssf = socketBuilder.createSSLServerSocketFactory(); + ServerSocket ss = ssf.createServerSocket(); + ss.close(); + } + catch (IOException e) + { + fail("Unable to create ServerSocket"); + } + + // Create Socket. + try + { + SocketFactory sf = socketBuilder.createSSLSocketFactory(); + Socket s = sf.createSocket(); + s.close(); + } + catch (IOException e) + { + fail("Unable to create Socket"); + } + + log.info(getName() + " PASSES"); + } } \ No newline at end of file

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5691 - remoting2/branches/2.2/src/main/org/jboss/remoting/security.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 20:23:14 -0500 (Mon, 15 Feb 2010) New Revision: 5691 Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java Log: JBREM-1185, JBREM-1172, JBREM-1161: In validateStoreURL() changed string comparison from storePath.equals(NONE_STORE) to NONE_STORE.equals(storePath). Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java =================================================================== --- remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-16 01:17:31 UTC (rev 5690) +++ remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-16 01:23:14 UTC (rev 5691) @@ -1603,7 +1603,7 @@ */ protected URL validateStoreURL(String storePath) throws IOException { - if (storePath.equals(NONE_STORE)) + if (NONE_STORE.equals(storePath)) { return NONE_STORE_URL; }

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5690 - remoting2/branches/2.x/src/tests/org/jboss/test/remoting/ssl/emptystore.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 20:17:31 -0500 (Mon, 15 Feb 2010) New Revision: 5690 Modified: remoting2/branches/2.x/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java Log: JBREM-1185, JBREM-1172, JBREM-1161: Added testDistinctNONEKeyStore(). Modified: remoting2/branches/2.x/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java =================================================================== --- remoting2/branches/2.x/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java 2010-02-16 01:16:10 UTC (rev 5689) +++ remoting2/branches/2.x/src/tests/org/jboss/test/remoting/ssl/emptystore/EmptyStoreTestCase.java 2010-02-16 01:17:31 UTC (rev 5690) @@ -116,4 +116,51 @@ log.info(getName() + " PASSES"); } + + /** + * Creates "NONE" dynamically to test JBREM-1185. + */ + public void testDistinctNONEKeyStore() throws Throwable + { + log.info("entering " + getName()); + + // Create SSLSocketBuilder. + HashMap config = new HashMap(); + String none = new StringBuilder("NONE").toString(); + config.put(SSLSocketBuilder.REMOTING_KEY_STORE_TYPE, "JKS"); + config.put(SSLSocketBuilder.REMOTING_KEY_STORE_FILE_PATH, none); +// config.put(SSLSocketBuilder.REMOTING_KEY_STORE_PASSWORD, "dummy"); + config.put(SSLSocketBuilder.REMOTING_TRUST_STORE_TYPE, "JKS"); + config.put(SSLSocketBuilder.REMOTING_TRUST_STORE_FILE_PATH, none); +// config.put(SSLSocketBuilder.REMOTING_TRUST_STORE_PASSWORD, "dummy"); + SSLSocketBuilder socketBuilder = new SSLSocketBuilder(config); + socketBuilder.setUseSSLServerSocketFactory(false); + socketBuilder.setUseSSLSocketFactory(false); + + // Create ServerSocket. + try + { + ServerSocketFactory ssf = socketBuilder.createSSLServerSocketFactory(); + ServerSocket ss = ssf.createServerSocket(); + ss.close(); + } + catch (IOException e) + { + fail("Unable to create ServerSocket"); + } + + // Create Socket. + try + { + SocketFactory sf = socketBuilder.createSSLSocketFactory(); + Socket s = sf.createSocket(); + s.close(); + } + catch (IOException e) + { + fail("Unable to create Socket"); + } + + log.info(getName() + " PASSES"); + } } \ No newline at end of file

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5689 - remoting2/branches/2.x/src/main/org/jboss/remoting/security.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 20:16:10 -0500 (Mon, 15 Feb 2010) New Revision: 5689 Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java Log: JBREM-1185, JBREM-1172, JBREM-1161: In validateStoreURL() changed string comparison from storePath.equals(NONE_STORE) to NONE_STORE.equals(storePath). Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-15 19:43:27 UTC (rev 5688) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-16 01:16:10 UTC (rev 5689) @@ -1617,7 +1617,7 @@ */ protected URL validateStoreURL(String storePath) throws IOException { - if (storePath.equals(NONE_STORE)) + if (NONE_STORE.equals(storePath)) { return NONE_STORE_URL; }

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5688 - remoting2/branches/2.2/src/main/org/jboss/remoting/security.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 14:43:27 -0500 (Mon, 15 Feb 2010) New Revision: 5688 Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java Log: JBREM-1172, JBREM-1161: In validateStoreURL() changed string comparison from == to String.equals(). Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java =================================================================== --- remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-15 19:38:27 UTC (rev 5687) +++ remoting2/branches/2.2/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-15 19:43:27 UTC (rev 5688) @@ -1603,7 +1603,7 @@ */ protected URL validateStoreURL(String storePath) throws IOException { - if (storePath == NONE_STORE) + if (storePath.equals(NONE_STORE)) { return NONE_STORE_URL; }

14 years, 9 months

1
0
0 / 0

JBoss Remoting SVN: r5687 - remoting2/branches/2.x/src/main/org/jboss/remoting/security.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-02-15 14:38:27 -0500 (Mon, 15 Feb 2010) New Revision: 5687 Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java Log: JBREM-1172, JBREM-1161: In validateStoreURL() changed string comparison from == to String.equals(). Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-15 18:50:41 UTC (rev 5686) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/security/SSLSocketBuilder.java 2010-02-15 19:38:27 UTC (rev 5687) @@ -1617,7 +1617,7 @@ */ protected URL validateStoreURL(String storePath) throws IOException { - if (storePath == NONE_STORE) + if (storePath.equals(NONE_STORE)) { return NONE_STORE_URL; }

14 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

jboss-remoting-commits February 2010