May 2010 - jboss-remoting-commits

JBoss Remoting SVN: r5868 - in remoting2/branches/2.x/src/main/org/jboss/remoting: loading and 1 other directory.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-28 11:52:52 -0400 (Fri, 28 May 2010) New Revision: 5868 Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/MicroRemoteClientInvoker.java remoting2/branches/2.x/src/main/org/jboss/remoting/loading/RemotingClassLoader.java Log: JBREM-1227: Moved synchronization from RemotingClassLoader to MicroRemoteClientInvoker. Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/MicroRemoteClientInvoker.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/MicroRemoteClientInvoker.java 2010-05-12 03:07:58 UTC (rev 5867) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/MicroRemoteClientInvoker.java 2010-05-28 15:52:52 UTC (rev 5868) @@ -169,7 +169,10 @@ finally { // Delete reference to current thread's context classloader. - rcl.unsetUserClassLoader(); + synchronized (MicroRemoteClientInvoker.class) + { + rcl.unsetUserClassLoader(); + } } // Now check if is remoting response and process Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/loading/RemotingClassLoader.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/loading/RemotingClassLoader.java 2010-05-12 03:07:58 UTC (rev 5867) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/loading/RemotingClassLoader.java 2010-05-28 15:52:52 UTC (rev 5868) @@ -51,7 +51,11 @@ referenceCounter = 1; } - public synchronized void setUserClassLoader(ClassLoader userClassLoader) + /* + * Note: This method is called only from MicroRemoteClientInvoker.invoke() while a lock + * on MicroRemoteClientInvoker.class is held. + */ + public void setUserClassLoader(ClassLoader userClassLoader) throws Exception { if (this.userClassLoader == null) @@ -65,7 +69,11 @@ referenceCounter++; } - public synchronized void unsetUserClassLoader() + /* + * Note: This method is called only from MicroRemoteClientInvoker.invoke() while a lock + * on MicroRemoteClientInvoker.class is held. + */ + public void unsetUserClassLoader() { if (--referenceCounter == 0) userClassLoader = null;

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5867 - remoting2/tags.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-11 23:07:58 -0400 (Tue, 11 May 2010) New Revision: 5867 Added: remoting2/tags/2.5.2.SP3/ Log: Copied: remoting2/tags/2.5.2.SP3 (from rev 5866, remoting2/branches/2.x)

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5866 - remoting2/branches/2.2/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-11 22:55:31 -0400 (Tue, 11 May 2010) New Revision: 5866 Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/InvokerLocator.java Log: JBREM-1225: Avoids extraneous '=' when reconstructing InvokerLocator. Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/InvokerLocator.java =================================================================== --- remoting2/branches/2.2/src/main/org/jboss/remoting/InvokerLocator.java 2010-05-11 13:20:24 UTC (rev 5865) +++ remoting2/branches/2.2/src/main/org/jboss/remoting/InvokerLocator.java 2010-05-12 02:55:31 UTC (rev 5866) @@ -300,7 +300,14 @@ { String key = (String) iter.next(); String val = (String) parameters.get(key); - uri += key + "=" + val; + if ("".equals(val)) + { + uri += key; + } + else + { + uri += key + "=" + val; + } if(iter.hasNext()) { uri += "&";

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5865 - remoting2/branches/2.x/docs/guide/en.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-11 09:20:24 -0400 (Tue, 11 May 2010) New Revision: 5865 Modified: remoting2/branches/2.x/docs/guide/en/chap17.xml Log: JBREM-1225: Added JBREM-1225. Modified: remoting2/branches/2.x/docs/guide/en/chap17.xml =================================================================== --- remoting2/branches/2.x/docs/guide/en/chap17.xml 2010-05-11 13:18:51 UTC (rev 5864) +++ remoting2/branches/2.x/docs/guide/en/chap17.xml 2010-05-11 13:20:24 UTC (rev 5865) @@ -81,7 +81,8 @@ <para>* [JBREM-1185] - Change use of == to String.equals() in SSLSocketBuilder.validateStoreURL()</para> <para>* [JBREM-1188] - Socket transport doesn't set "timeout" to default value</para> <para>* [JBREM-1218] - ConnectionValidator.isValid should be volatile</para> - + <para>* [JBREM-1225] - Eliminate extraneous "=" from reconstructed InvokerLocator</para> + <para><emphasis role="bold">Feature request</emphasis></para> <para>* [JBREM-1179] - jboss-remoting.jar should log a version message when it is loaded</para>

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5864 - remoting2/branches/2.x/docs.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-11 09:18:51 -0400 (Tue, 11 May 2010) New Revision: 5864 Modified: remoting2/branches/2.x/docs/README.txt Log: JBREM-1225: Added JBREM-1225. Modified: remoting2/branches/2.x/docs/README.txt =================================================================== --- remoting2/branches/2.x/docs/README.txt 2010-05-11 13:16:33 UTC (rev 5863) +++ remoting2/branches/2.x/docs/README.txt 2010-05-11 13:18:51 UTC (rev 5864) @@ -52,7 +52,8 @@ * [JBREM-1185] - Change use of == to String.equals() in SSLSocketBuilder.validateStoreURL() * [JBREM-1188] - Socket transport doesn't set "timeout" to default value * [JBREM-1218] - ConnectionValidator.isValid should be volatile - + * [JBREM-1225] - Eliminate extraneous "=" from reconstructed InvokerLocator + Feature Request * [JBREM-1179] - jboss-remoting.jar should log a version message when it is loaded

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5863 - remoting2/branches/2.2/src/tests/org/jboss/test/remoting/locator.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-11 09:16:33 -0400 (Tue, 11 May 2010) New Revision: 5863 Added: remoting2/branches/2.2/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java Log: JBREM-1225: New unit test. Added: remoting2/branches/2.2/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java =================================================================== --- remoting2/branches/2.2/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java (rev 0) +++ remoting2/branches/2.2/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java 2010-05-11 13:16:33 UTC (rev 5863) @@ -0,0 +1,81 @@ +/* +* JBoss, Home of Professional Open Source +* Copyright 2009, JBoss Inc., and individual contributors as indicated +* by the @authors tag. See the copyright.txt in the distribution for a +* full listing of individual contributors. +* +* This is free software; you can redistribute it and/or modify it +* under the terms of the GNU Lesser General Public License as +* published by the Free Software Foundation; either version 2.1 of +* the License, or (at your option) any later version. +* +* This software is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this software; if not, write to the Free +* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA +* 02110-1301 USA, or see the FSF site: http://www.fsf.org. +*/ +package org.jboss.test.remoting.locator; + +import junit.framework.TestCase; + +import org.apache.log4j.ConsoleAppender; +import org.apache.log4j.Level; +import org.apache.log4j.Logger; +import org.apache.log4j.PatternLayout; +import org.jboss.remoting.InvokerLocator; + + +public class ExtraneousEqualsTestCase extends TestCase +{ + private static Logger log = Logger.getLogger(ExtraneousEqualsTestCase.class); + + private static boolean firstTime = true; + + public void setUp() throws Exception + { + if (firstTime) + { + firstTime = false; + Logger.getLogger("org.jboss.remoting").setLevel(Level.INFO); + Logger.getLogger("org.jboss.test.remoting").setLevel(Level.INFO); + String pattern = "[%d{ABSOLUTE}] [%t] %5p (%F:%L) - %m%n"; + PatternLayout layout = new PatternLayout(pattern); + ConsoleAppender consoleAppender = new ConsoleAppender(layout); + Logger.getRootLogger().addAppender(consoleAppender); + } + } + + + public void tearDown() + { + } + + + public void testExtraneousEquals() throws Throwable + { + log.info("entering " + getName()); + + // Create client. + String locatorURI = "socket://localhost:8080/abc?xyz"; + InvokerLocator locator = new InvokerLocator(locatorURI); + log.info(locator.getLocatorURI()); + assertEquals(locator.getLocatorURI(), locatorURI); + + locatorURI = "socket://localhost:8080/abc?pqr=123&xyz"; + locator = new InvokerLocator(locatorURI); + log.info(locator.getLocatorURI()); + assertEquals(locator.getLocatorURI(), locatorURI); + + locatorURI = "socket://localhost:8080/abc?pqr&xyz=123"; + locator = new InvokerLocator(locatorURI); + log.info(locator.getLocatorURI()); + assertEquals(locator.getLocatorURI(), locatorURI); + + log.info(getName() + " PASSES"); + } +} \ No newline at end of file Property changes on: remoting2/branches/2.2/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java ___________________________________________________________________ Name: svn:executable + *

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5862 - remoting2/branches/2.x/src/tests/org/jboss/test/remoting/locator.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-11 09:11:16 -0400 (Tue, 11 May 2010) New Revision: 5862 Added: remoting2/branches/2.x/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java Log: JBREM-1225: New unit test. Added: remoting2/branches/2.x/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java =================================================================== --- remoting2/branches/2.x/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java (rev 0) +++ remoting2/branches/2.x/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java 2010-05-11 13:11:16 UTC (rev 5862) @@ -0,0 +1,81 @@ +/* +* JBoss, Home of Professional Open Source +* Copyright 2009, JBoss Inc., and individual contributors as indicated +* by the @authors tag. See the copyright.txt in the distribution for a +* full listing of individual contributors. +* +* This is free software; you can redistribute it and/or modify it +* under the terms of the GNU Lesser General Public License as +* published by the Free Software Foundation; either version 2.1 of +* the License, or (at your option) any later version. +* +* This software is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this software; if not, write to the Free +* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA +* 02110-1301 USA, or see the FSF site: http://www.fsf.org. +*/ +package org.jboss.test.remoting.locator; + +import junit.framework.TestCase; + +import org.apache.log4j.ConsoleAppender; +import org.apache.log4j.Level; +import org.apache.log4j.Logger; +import org.apache.log4j.PatternLayout; +import org.jboss.remoting.InvokerLocator; + + +public class ExtraneousEqualsTestCase extends TestCase +{ + private static Logger log = Logger.getLogger(ExtraneousEqualsTestCase.class); + + private static boolean firstTime = true; + + public void setUp() throws Exception + { + if (firstTime) + { + firstTime = false; + Logger.getLogger("org.jboss.remoting").setLevel(Level.INFO); + Logger.getLogger("org.jboss.test.remoting").setLevel(Level.INFO); + String pattern = "[%d{ABSOLUTE}] [%t] %5p (%F:%L) - %m%n"; + PatternLayout layout = new PatternLayout(pattern); + ConsoleAppender consoleAppender = new ConsoleAppender(layout); + Logger.getRootLogger().addAppender(consoleAppender); + } + } + + + public void tearDown() + { + } + + + public void testExtraneousEquals() throws Throwable + { + log.info("entering " + getName()); + + // Create client. + String locatorURI = "socket://localhost:8080/abc?xyz"; + InvokerLocator locator = new InvokerLocator(locatorURI); + log.info(locator.getLocatorURI()); + assertEquals(locator.getLocatorURI(), locatorURI); + + locatorURI = "socket://localhost:8080/abc?pqr=123&xyz"; + locator = new InvokerLocator(locatorURI); + log.info(locator.getLocatorURI()); + assertEquals(locator.getLocatorURI(), locatorURI); + + locatorURI = "socket://localhost:8080/abc?pqr&xyz=123"; + locator = new InvokerLocator(locatorURI); + log.info(locator.getLocatorURI()); + assertEquals(locator.getLocatorURI(), locatorURI); + + log.info(getName() + " PASSES"); + } +} \ No newline at end of file Property changes on: remoting2/branches/2.x/src/tests/org/jboss/test/remoting/locator/ExtraneousEqualsTestCase.java ___________________________________________________________________ Name: svn:executable + *

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5861 - remoting2/branches/2.x/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-11 09:09:59 -0400 (Tue, 11 May 2010) New Revision: 5861 Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/InvokerLocator.java Log: JBREM-1225: Avoids extraneous '=' when reconstructing InvokerLocator. Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/InvokerLocator.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/InvokerLocator.java 2010-05-11 02:28:29 UTC (rev 5860) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/InvokerLocator.java 2010-05-11 13:09:59 UTC (rev 5861) @@ -921,7 +921,14 @@ { String key = (String) iter.next(); String val = (String) parameters.get(key); - uri += key + "=" + val; + if ("".equals(val)) + { + uri += key; + } + else + { + uri += key + "=" + val; + } if(iter.hasNext()) { uri += "&";

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5860 - in remoting2/branches/2.x/lib: jbossweb and 1 other directories.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-10 22:28:29 -0400 (Mon, 10 May 2010) New Revision: 5860 Modified: remoting2/branches/2.x/lib/jboss/README remoting2/branches/2.x/lib/jboss/jboss-j2se.jar remoting2/branches/2.x/lib/jboss/jboss-jmx.jar remoting2/branches/2.x/lib/jbossweb/README remoting2/branches/2.x/lib/jbossweb/jbossweb.jar remoting2/branches/2.x/lib/servlet/lib/README remoting2/branches/2.x/lib/servlet/lib/servlet-api.jar Log: JBREM-1220: Updated jars to match EAP 5.1.0. Modified: remoting2/branches/2.x/lib/jboss/README =================================================================== --- remoting2/branches/2.x/lib/jboss/README 2010-05-11 02:22:55 UTC (rev 5859) +++ remoting2/branches/2.x/lib/jboss/README 2010-05-11 02:28:29 UTC (rev 5860) @@ -4,8 +4,8 @@ File Version From ------- ------- ---- jboss-common-core.jar 2.2.16.GA http://repository.jboss.com/maven2/org/jboss/jboss-common-core/2.2.16.GA/ -jboss-j2se.jar JBPAPP_5_0: build: SVNTag=JBPAPP_5_0_0_Branch date=200912251700 -jboss-jmx.jar JBPAPP_5_0: build: SVNTag=JBPAPP_5_0_0_Branch date=200912251700 +jboss-j2se.jar JBPAPP_5_1: build: http://svn.jboss.org/repos/jbossas/branches/JBPAPP_5_1: revision 104587 +jboss-jmx.jar JBPAPP_5_0: build: http://svn.jboss.org/repos/jbossas/branches/JBPAPP_5_1: revision 104587 jboss-logging-log4j.jar 2.1.0.GA http://repository.jboss.com/maven2/org/jboss/logging/jboss-logging-log4j/... jboss-logging-spi.jar 2.1.0.GA http://repository.jboss.com/maven2/org/jboss/logging/jboss-logging-spi/2.... jboss-serialization.jar 1.0.3.GA http://repository.jboss.com/maven2/jboss/jboss-serialization/1.0.3.GA/ Modified: remoting2/branches/2.x/lib/jboss/jboss-j2se.jar =================================================================== (Binary files differ) Modified: remoting2/branches/2.x/lib/jboss/jboss-jmx.jar =================================================================== (Binary files differ) Modified: remoting2/branches/2.x/lib/jbossweb/README =================================================================== --- remoting2/branches/2.x/lib/jbossweb/README 2010-05-11 02:22:55 UTC (rev 5859) +++ remoting2/branches/2.x/lib/jbossweb/README 2010-05-11 02:28:29 UTC (rev 5860) @@ -1,3 +1,3 @@ -File Version From -------- ------- ---- -jbossweb.jar 2.1.3.GA http://repository.jboss.com/maven2/jboss/web/jbossweb/2.1.3.GA/ +File Version From +------- ------- ---- +jbossweb.jar 2.1.7.GA https://repository.jboss.org/nexus/content/repositories/public/jboss/web/... Modified: remoting2/branches/2.x/lib/jbossweb/jbossweb.jar =================================================================== (Binary files differ) Modified: remoting2/branches/2.x/lib/servlet/lib/README =================================================================== --- remoting2/branches/2.x/lib/servlet/lib/README 2010-05-11 02:22:55 UTC (rev 5859) +++ remoting2/branches/2.x/lib/servlet/lib/README 2010-05-11 02:28:29 UTC (rev 5860) @@ -1,3 +1,3 @@ -File Version From -------- ------- ---- -servlet-api.jar 2.1.3.GA http://repository.jboss.org/maven2/jboss/web/servlet-api/2.1.3.GA/ +File Version From +------- ------- ---- +servlet-api.jar 2.1.7.GA https://repository.jboss.org/nexus/content/repositories/public/jboss/web/... Modified: remoting2/branches/2.x/lib/servlet/lib/servlet-api.jar =================================================================== (Binary files differ)

14 years, 6 months

1
0
0 / 0

JBoss Remoting SVN: r5859 - remoting2/branches/2.2/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2010-05-10 22:22:55 -0400 (Mon, 10 May 2010) New Revision: 5859 Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java Log: JBREM-1218: Made isValid volatile. Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java =================================================================== --- remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java 2010-05-11 02:13:45 UTC (rev 5858) +++ remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java 2010-05-11 02:22:55 UTC (rev 5859) @@ -239,7 +239,7 @@ private boolean stopLeaseOnFailure = true; private int pingTimeout; private int failureDisconnectTimeout = -1; - private boolean isValid; + private volatile boolean isValid; private Timer timer; private MicroRemoteClientInvoker sharedInvoker; private LeasePinger leasePinger;

14 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

jboss-remoting-commits May 2010