August 2011 - jboss-remoting-commits

JBoss Remoting SVN: r6407 - remoting2/branches/2.2/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-28 02:50:14 -0400 (Sun, 28 Aug 2011) New Revision: 6407 Added: remoting2/branches/2.2/src/main/org/jboss/remoting/Touch.java Log: Added: remoting2/branches/2.2/src/main/org/jboss/remoting/Touch.java =================================================================== --- remoting2/branches/2.2/src/main/org/jboss/remoting/Touch.java (rev 0) +++ remoting2/branches/2.2/src/main/org/jboss/remoting/Touch.java 2011-08-28 06:50:14 UTC (rev 6407) @@ -0,0 +1,15 @@ +package org.jboss.remoting; + +/** + * Adding this class as a convenient way to cause Jenkins to run. + * + * @author <a href="mailto:ron.sigal@jboss.com">Ron Sigal</a> + * @version $Rev$ + * <p> + * Copyright Aug 28, 2011 + * </p> + */ +public class Touch +{ + // 8/28/11 +}

13 years, 2 months

1
0
0 / 0

JBoss Remoting SVN: r6406 - remoting2/branches/2.x/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-28 02:49:40 -0400 (Sun, 28 Aug 2011) New Revision: 6406 Added: remoting2/branches/2.x/src/main/org/jboss/remoting/Touch.java Log: Added: remoting2/branches/2.x/src/main/org/jboss/remoting/Touch.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/Touch.java (rev 0) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/Touch.java 2011-08-28 06:49:40 UTC (rev 6406) @@ -0,0 +1,15 @@ +package org.jboss.remoting; + +/** + * Adding this class as a convenient way to cause Jenkins to run. + * + * @author <a href="mailto:ron.sigal@jboss.com">Ron Sigal</a> + * @version $Rev$ + * <p> + * Copyright Aug 28, 2011 + * </p> + */ +public class Touch +{ + // 8/28/11 +}

13 years, 2 months

1
0
0 / 0

JBoss Remoting SVN: r6405 - remoting2/branches/2.x/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-26 23:29:38 -0400 (Fri, 26 Aug 2011) New Revision: 6405 Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java Log: JBREM-1297: Removed extra blank line. Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java 2011-08-27 03:28:58 UTC (rev 6404) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java 2011-08-27 03:29:38 UTC (rev 6405) @@ -1077,9 +1077,8 @@ { log.debug(ConnectionValidator.this + " shutting down lease pinger: " + leasePinger); int disconnectTimeout = (failureDisconnectTimeout == -1) ? client.getDisconnectTimeout() : failureDisconnectTimeout; - if (trace) log.trace(ConnectionValidator.this + " disconnectTimeout: " + disconnectTimeout); + if (trace) log.trace(ConnectionValidator.this + " disconnectTimeout: " + disconnectTimeout); - // Synchronizing on Client.connectionValidatorLock to prevent a deadlock: // // 1. a. This method calls MicroRemoteClientInvoker.terminateLease()

13 years, 3 months

1
0
0 / 0

JBoss Remoting SVN: r6404 - remoting2/branches/2.2/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-26 23:28:58 -0400 (Fri, 26 Aug 2011) New Revision: 6404 Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/Client.java Log: JBREM-1297: Added getter for connectionValidatorLock and updated comments in setupClientLease(). Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/Client.java =================================================================== --- remoting2/branches/2.2/src/main/org/jboss/remoting/Client.java 2011-08-27 03:28:38 UTC (rev 6403) +++ remoting2/branches/2.2/src/main/org/jboss/remoting/Client.java 2011-08-27 03:28:58 UTC (rev 6404) @@ -1819,6 +1819,11 @@ } } + static Object getConnectionValidatorLock() + { + return connectionValidatorLock; + } + // Protected ------------------------------------------------------------------------------------ // Private -------------------------------------------------------------------------------------- @@ -1955,17 +1960,25 @@ // // 1. a. This method calls MicroRemoteClientInvoker.establishLease() // b. MicroRemoteClientInvoker.establishLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock - // and calls Client.addConnectionListener() - // c. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // c. MicroRemoteClientInvoker.establishLease() calls Client.addConnectionListener() + // d. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock // - // 2. a. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock and calls - // new ConnectionValidator() - // b. new ConnectionValidator() calls MicroRemoteClientInvoker.getLeasePinger(), which - // synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // 2. a. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // b. Client.addConnectionListener() calls new ConnectionValidator() + // c. new ConnectionValidator() calls MicroRemoteClientInvoker.getLeasePinger() + // d. MicroRemoteClientInvoker.getLeasePinger() synchronizes on MicroRemoteClientInvoker.clientLeaseLock // - // By synchronizing on connectionValidatorLock here, we assure that both sequences acquire + // 3. a. ConnectionValidator$WaitOnConnectionCheckTimerTask.run() synchronizes on Client.connectionValidatorLock + // b. ConnectionValidator$WaitOnConnectionCheckTimerTask.run() calls MicroRemoteClientInvoker.terminateLease() + // c. MicroRemoteClientInvoker.terminateLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // d. MicroRemoteClientInvoker.terminateLease() calls LeasePinger.stopPing() + // e. LeasePinger.stopPing() calls Client.notifyListeners() + // f. Client.notifyListeners() synchronizes on Client.connectionValidatorLock + // + // By synchronizing on connectionValidatorLock here, we assure that all sequences acquire // Client.connectionValidatorLock first and then acquire MicroRemoteClientInvoker.clientLeaseLock. // + // See JBREM-1242 and JBREM-1297. synchronized(connectionValidatorLock) { invoker.establishLease(sessionId, temp, leasePeriod);

13 years, 3 months

1
0
0 / 0

JBoss Remoting SVN: r6403 - remoting2/branches/2.2/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-26 23:28:38 -0400 (Fri, 26 Aug 2011) New Revision: 6403 Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java Log: JBREM-1297: Synchronize on Client.connectionValidatorLock while calling MicroRemoteClientInvoker.terminateLease(). Modified: remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java =================================================================== --- remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java 2011-08-27 03:19:11 UTC (rev 6402) +++ remoting2/branches/2.2/src/main/org/jboss/remoting/ConnectionValidator.java 2011-08-27 03:28:38 UTC (rev 6403) @@ -1049,7 +1049,35 @@ log.debug(ConnectionValidator.this + " shutting down lease pinger: " + leasePinger); int disconnectTimeout = (failureDisconnectTimeout == -1) ? client.getDisconnectTimeout() : failureDisconnectTimeout; if (trace) log.trace(ConnectionValidator.this + " disconnectTimeout: " + disconnectTimeout); - sharedInvoker.terminateLease(null, disconnectTimeout, leasePinger); + + // Synchronizing on Client.connectionValidatorLock to prevent a deadlock: + // + // 1. a. This method calls MicroRemoteClientInvoker.terminateLease() + // b. MicroRemoteClientInvoker.terminateLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // c. MicroRemoteClientInvoker.terminateLease() calls LeasePinger.stopPing() + // d. LeasePinger.stopPing() calls Client.notifyListeners() + // e. Client.notifyListeners() synchronizes on Client.connectionValidatorLock + // + // 2. a. Client.connect() calls Client.setupClientLease() + // b. Client.setupClientLease() synchronizes on Client.connectionValidatorLock + // c. Client.setupClientLease() calls MicroRemoteClientInvoker.establishLease() + // d. MicroRemoteClientInvoker.establishLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // e. MicroRemoteClientInvoker.establishLease() calls Client.addConnectionListener() + // f. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // + // 3. a. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // b. Client.addConnectionListener() calls new ConnectionValidator() + // c. new ConnectionValidator() calls MicroRemoteClientInvoker.getLeasePinger() + // d. MicroRemoteClientInvoker.getLeasePinger() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // + // By synchronizing on connectionValidatorLock here, we assure that all sequences acquire + // Client.connectionValidatorLock first and then acquire MicroRemoteClientInvoker.clientLeaseLock. + // + // See JBREM-1242 and JBREM-1297. + synchronized (Client.getConnectionValidatorLock()) + { + sharedInvoker.terminateLease(null, disconnectTimeout, leasePinger); + } } else {

13 years, 3 months

1
0
0 / 0

JBoss Remoting SVN: r6402 - remoting2/branches/2.x/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-26 23:19:11 -0400 (Fri, 26 Aug 2011) New Revision: 6402 Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java Log: JBREM-1297: Synchronize on Client.connectionValidatorLock while calling MicroRemoteClientInvoker.terminateLease(). Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java 2011-08-27 03:18:00 UTC (rev 6401) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/ConnectionValidator.java 2011-08-27 03:19:11 UTC (rev 6402) @@ -1078,7 +1078,36 @@ log.debug(ConnectionValidator.this + " shutting down lease pinger: " + leasePinger); int disconnectTimeout = (failureDisconnectTimeout == -1) ? client.getDisconnectTimeout() : failureDisconnectTimeout; if (trace) log.trace(ConnectionValidator.this + " disconnectTimeout: " + disconnectTimeout); - sharedInvoker.terminateLease(null, disconnectTimeout, leasePinger); + + + // Synchronizing on Client.connectionValidatorLock to prevent a deadlock: + // + // 1. a. This method calls MicroRemoteClientInvoker.terminateLease() + // b. MicroRemoteClientInvoker.terminateLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // c. MicroRemoteClientInvoker.terminateLease() calls LeasePinger.stopPing() + // d. LeasePinger.stopPing() calls Client.notifyListeners() + // e. Client.notifyListeners() synchronizes on Client.connectionValidatorLock + // + // 2. a. Client.connect() calls Client.setupClientLease() + // b. Client.setupClientLease() synchronizes on Client.connectionValidatorLock + // c. Client.setupClientLease() calls MicroRemoteClientInvoker.establishLease() + // d. MicroRemoteClientInvoker.establishLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // e. MicroRemoteClientInvoker.establishLease() calls Client.addConnectionListener() + // f. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // + // 3. a. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // b. Client.addConnectionListener() calls new ConnectionValidator() + // c. new ConnectionValidator() calls MicroRemoteClientInvoker.getLeasePinger() + // d. MicroRemoteClientInvoker.getLeasePinger() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // + // By synchronizing on connectionValidatorLock here, we assure that all sequences acquire + // Client.connectionValidatorLock first and then acquire MicroRemoteClientInvoker.clientLeaseLock. + // + // See JBREM-1242 and JBREM-1297. + synchronized (Client.getConnectionValidatorLock()) + { + sharedInvoker.terminateLease(null, disconnectTimeout, leasePinger); + } } else {

13 years, 3 months

1
0
0 / 0

JBoss Remoting SVN: r6401 - remoting2/branches/2.x/src/main/org/jboss/remoting.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-26 23:18:00 -0400 (Fri, 26 Aug 2011) New Revision: 6401 Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/Client.java Log: JBREM-1297: Added getter for connectionValidatorLock and updated comments in setupClientLease(). Modified: remoting2/branches/2.x/src/main/org/jboss/remoting/Client.java =================================================================== --- remoting2/branches/2.x/src/main/org/jboss/remoting/Client.java 2011-08-15 04:12:10 UTC (rev 6400) +++ remoting2/branches/2.x/src/main/org/jboss/remoting/Client.java 2011-08-27 03:18:00 UTC (rev 6401) @@ -1904,6 +1904,12 @@ } } + + static Object getConnectionValidatorLock() + { + return connectionValidatorLock; + } + // Protected ------------------------------------------------------------------------------------ // Private -------------------------------------------------------------------------------------- @@ -2040,17 +2046,25 @@ // // 1. a. This method calls MicroRemoteClientInvoker.establishLease() // b. MicroRemoteClientInvoker.establishLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock - // and calls Client.addConnectionListener() - // c. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // c. MicroRemoteClientInvoker.establishLease() calls Client.addConnectionListener() + // d. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock // - // 2. a. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock and calls - // new ConnectionValidator() - // b. new ConnectionValidator() calls MicroRemoteClientInvoker.getLeasePinger(), which - // synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // 2. a. Client.addConnectionListener() synchronizes on Client.connectionValidatorLock + // b. Client.addConnectionListener() calls new ConnectionValidator() + // c. new ConnectionValidator() calls MicroRemoteClientInvoker.getLeasePinger() + // d. MicroRemoteClientInvoker.getLeasePinger() synchronizes on MicroRemoteClientInvoker.clientLeaseLock // - // By synchronizing on connectionValidatorLock here, we assure that both sequences acquire + // 3. a. ConnectionValidator$WaitOnConnectionCheckTimerTask.run() synchronizes on Client.connectionValidatorLock + // b. ConnectionValidator$WaitOnConnectionCheckTimerTask.run() calls MicroRemoteClientInvoker.terminateLease() + // c. MicroRemoteClientInvoker.terminateLease() synchronizes on MicroRemoteClientInvoker.clientLeaseLock + // d. MicroRemoteClientInvoker.terminateLease() calls LeasePinger.stopPing() + // e. LeasePinger.stopPing() calls Client.notifyListeners() + // f. Client.notifyListeners() synchronizes on Client.connectionValidatorLock + // + // By synchronizing on connectionValidatorLock here, we assure that all sequences acquire // Client.connectionValidatorLock first and then acquire MicroRemoteClientInvoker.clientLeaseLock. // + // See JBREM-1242 and JBREM-1297. synchronized(connectionValidatorLock) { invoker.establishLease(sessionId, temp, leasePeriod);

13 years, 3 months

1
0
0 / 0

JBoss Remoting SVN: r6400 - remoting2/tags.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-15 00:12:10 -0400 (Mon, 15 Aug 2011) New Revision: 6400 Added: remoting2/tags/2.5.4.SP3/ Log:

13 years, 3 months

1
0
0 / 0

JBoss Remoting SVN: r6399 - remoting2/branches/2.x/docs/userguide/en.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-15 00:03:40 -0400 (Mon, 15 Aug 2011) New Revision: 6399 Modified: remoting2/branches/2.x/docs/userguide/en/chap1.xml remoting2/branches/2.x/docs/userguide/en/master.xml Log: JBREM-1298: Updated version and link to online Remoting Guide. Modified: remoting2/branches/2.x/docs/userguide/en/chap1.xml =================================================================== --- remoting2/branches/2.x/docs/userguide/en/chap1.xml 2011-08-15 03:57:16 UTC (rev 6398) +++ remoting2/branches/2.x/docs/userguide/en/chap1.xml 2011-08-15 04:03:40 UTC (rev 6399) @@ -18,7 +18,7 @@ <para>Remoting is quite flexible, with multiple, pluggable transports, marshallers, serializers, etc., and more than anyone would ever want to know is described in the - <ulink url="http://docs.jboss.org/jbossremoting/2.5.3.SP1/html/">Remoting Guide</ulink>, but the current document, + <ulink url="http://docs.jboss.org/jbossremoting/2.5.4.SP3/html/">Remoting Guide</ulink>, but the current document, instead, focuses on those aspects of Remoting that are useful in the context of EJB2, EJB3, and JBoss Messaging. The Users Guide is not meant to introduce the reader to writing applications based on Remoting, but rather is meant to provide Modified: remoting2/branches/2.x/docs/userguide/en/master.xml =================================================================== --- remoting2/branches/2.x/docs/userguide/en/master.xml 2011-08-15 03:57:16 UTC (rev 6398) +++ remoting2/branches/2.x/docs/userguide/en/master.xml 2011-08-15 04:03:40 UTC (rev 6399) @@ -16,9 +16,9 @@ <bookinfo> <title>JBoss Remoting Users Guide</title> - <subtitle>JBoss Remoting version 2.5.4.SP2</subtitle> + <subtitle>JBoss Remoting version 2.5.4.SP3</subtitle> - <releaseinfo>May 5, 2011</releaseinfo> + <releaseinfo>August 15, 2011</releaseinfo> <mediaobject> <imageobject>

13 years, 3 months

1
0
0 / 0

JBoss Remoting SVN: r6398 - remoting2/branches/2.x/docs/guide/en.

by jboss-remoting-commits＠lists.jboss.org

Author: ron.sigal(a)jboss.com Date: 2011-08-14 23:57:16 -0400 (Sun, 14 Aug 2011) New Revision: 6398 Modified: remoting2/branches/2.x/docs/guide/en/chap1.xml remoting2/branches/2.x/docs/guide/en/chap17.xml Log: JBREM-1298: Added 2.5.4.SP3 release notes. Modified: remoting2/branches/2.x/docs/guide/en/chap1.xml =================================================================== --- remoting2/branches/2.x/docs/guide/en/chap1.xml 2011-08-15 03:47:22 UTC (rev 6397) +++ remoting2/branches/2.x/docs/guide/en/chap1.xml 2011-08-15 03:57:16 UTC (rev 6398) @@ -187,8 +187,17 @@ <para>Other features of Remoting 2.5.0.GA should function with jdk 1.4. However, it is the policy of JBoss, a division of Red Hat, no longer to support jdk 1.4.</para> - + <section> + <title>Release 2.5.4.SP3</title> + <itemizedlist> + <listitem> + <para>Two enhancements</para> + </listitem> + </itemizedlist> + </section> + + <section> <title>Release 2.5.4.SP2</title> <itemizedlist> <listitem> Modified: remoting2/branches/2.x/docs/guide/en/chap17.xml =================================================================== --- remoting2/branches/2.x/docs/guide/en/chap17.xml 2011-08-15 03:47:22 UTC (rev 6397) +++ remoting2/branches/2.x/docs/guide/en/chap17.xml 2011-08-15 03:57:16 UTC (rev 6398) @@ -69,7 +69,22 @@ <section> <title>Version 2.5</title> + + <bridgehead>Release Notes - JBoss Remoting - Version 2.5.4.SP3 (Flounder)</bridgehead> + + <para><emphasis role="bold">Enhancement</emphasis></para> + + <para>* [JBREM-1292] - ServerInvoker should use a ConcurrentHashMap to store callback handlers</para> + <para>* [JBREM-1293] - ServerThread pool should be treated like a stack</para> + + <para><emphasis role="bold">Release</emphasis></para> + + <para>* [JBREM-1298] - Release 2.5.4.SP3</para> + <para><emphasis role="bold">Task</emphasis></para> + + <para>* [JBREM-1299] - Assure version compatibility with earlier versions of Remoting</para> + <bridgehead>Release Notes - JBoss Remoting - Version 2.5.4.SP2 (Flounder)</bridgehead> <para><emphasis role="bold">Bug</emphasis></para>

13 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

jboss-remoting-commits August 2011