[JBoss JIRA] (JBIDE-14399) wise naming/implementation issues
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14399?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen updated JBIDE-14399:
----------------------------------------
Priority: Blocker (was: Major)
putting as blocker for beta1 since if the plugin gets renamed it should be done before the first release of it.
> wise naming/implementation issues
> ---------------------------------
>
> Key: JBIDE-14399
> URL: https://issues.jboss.org/browse/JBIDE-14399
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: Webservices
> Reporter: Max Rydahl Andersen
> Assignee: Brian Fitzpatrick
> Priority: Blocker
> Fix For: 4.1.0.Beta1
>
>
> the new addition of wise have a few quirks in naming and implementation.
> plugin org.jboss.tools.wise -> org.jboss.tools.wise.ui
> Reason: to match the rest of the plugins. Yes, it is mostly about bundling wise, but then it should on its own as org.jboss.tools.wise.core or org.jboss.tools.wise.runtime or similar. Not just org.jboss.tools.wise on its own. Since it also has helper code inside it I suggest to call it org.jboss.tools.ws.wise.ui and if one day it makes sense to isolate the jars in a wise specific plugin/bundle o.j.t.ws.wise or o.j.t.ws.wise.core it can just include it.
> org.jboss.wise.ui overlaps with wise framework package domain, should be org.jboss.tools.ws.wise.ui
> org.jboss.wise.ui.util.Activator - is this class actually needed ? if yes, shouldn't it be in org.jboss.ws.wise.ui.Activator ?
> https://github.com/jbosstools/jbosstools-webservices/blob/master/plugins/... has a method named getSampleSOAPInputMessage2 in what is marked as public API. I suggest rename and javadoc it to something sensible or move it to an internal package.
> https://github.com/jbosstools/jbosstools-webservices/blob/master/plugins/... and onward has a lot of ex.printstacktraces() - shouldn't these be handled/logged/ignored ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-12815) Create a JBoss Tools Orbit
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12815?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-12815 at 5/7/13 3:42 PM:
------------------------------------------------------------
Locus now includes Fest Assert 1.4. So that's 5 plugins included now.
[~maxandersen] Can you push this to the /jbosstools/ group in github, so we can have https://github.com/jbosstools/jbosstools-locus/ as the origin instead of my fork, https://github.com/nickboldt/jbosstools-locus/ ?
Note that 2 of the plugins in Locus (Fest Assert and Mockito) have been requested to be added to the upcoming Kepler M7 target platform, so if this could be done THIS WEEK, that would be ideal.
KTHXBAI!
was (Author: nickboldt):
Locus now includes Fest Assert 1.4. So that's 5 plugins included now.
[~maxandersen] Can you push this to the /jbosstools/ group in github, so we can have https://github.com/jbosstools/jbosstools-locus/ as the origin instead of my fork, https://github.com/nickboldt/jbosstools-locus/ ?
KTHXBAI!
> Create a JBoss Tools Orbit
> --------------------------
>
> Key: JBIDE-12815
> URL: https://issues.jboss.org/browse/JBIDE-12815
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: Build/Releng, locus
> Reporter: Mickael Istria
> Assignee: Max Rydahl Andersen
> Fix For: 4.1.0.Beta1
>
>
> Since all JBoss Eclipse-based project probably share some needs for usual libraries, we should create a JBoss Tools Orbit project in which one we would provide those 3rd-party dependencies packaged as OSGi Bundle in a p2 repository.
> In a first time, we could simply create some OSGi "wrappers" around those jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-12972) Add FestAssert to the TP
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12972?page=com.atlassian.jira.plugi... ]
Nick Boldt edited comment on JBIDE-12972 at 5/7/13 3:32 PM:
------------------------------------------------------------
Fest Assert 1.4 is now part of JBoss Tools Locus: https://github.com/nickboldt/jbosstools-locus/commit/1fa4842d050663333f1e...
It can be rebuilt / installed from here:
https://github.com/nickboldt/jbosstools-locus/ -> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-locus.sit... -> http://download.jboss.org/jbosstools/builds/staging/jbosstools-locus.site...
Published site is here:
http://download.jboss.org/jbosstools/updates/nightly/locus/trunk/
[~xcoulon], please try it out and verify that it works the way you expect.
was (Author: nickboldt):
Added to JBoss Tools Locus: https://github.com/nickboldt/jbosstools-locus/commit/1fa4842d050663333f1e...
Building: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-locus.sit... >=6
Update Site from which to install and verify it works as you'd expect: http://download.jboss.org/jbosstools/builds/staging/jbosstools-locus.site...
> Add FestAssert to the TP
> ------------------------
>
> Key: JBIDE-12972
> URL: https://issues.jboss.org/browse/JBIDE-12972
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: Build/Releng
> Affects Versions: 4.0.0.Beta1
> Reporter: Xavier Coulon
> Assignee: Nick Boldt
> Fix For: 4.1.0.Beta1
>
>
> It would be great if we could use in our tests. We would have to add it to our target platform (TP) for our plugins to use it.
> Reason: FestAssert provides us with a Fluent API to write test assertions.
> License and owner: Apache License 2.0 / http://code.google.com/p/fest/
> Original repository: (not an Eclipse bundle yet). Source and binaries available on Maven (https://repository.jboss.org/nexus/content/groups/public/org/easytesting/... and https://repository.jboss.org/nexus/content/groups/public/org/easytesting/...)
> JBoss Mirrored repository: http://downloads.jboss.org/jbosstools/updates/requirements/fest-assert ?
> Source: https://github.com/alexruiz/fest-assert-1.x
> Affected projects: LiveReload for now, JAX-RS in the future
> Required in devstudio: No for now (if LiveReload is considered incubation)
> Type of dependency: testing
> List of bundles added/removed: fest-assert, fest-util
> Fest-assert provides a fluent API to perform asertions in JUnit tests. It is also nice to use when the objects to tests are collections.
> To convince you of the interest of fest-assert, here are a few syntax examples:
> - In LiveReload-test plugin:
> {code}
> assertThat(new String(modifiedContent)).doesNotContain(addition + "</body>");
> {code}
> - a more complete example of usage in openShift-java-client (not an Eclipse plugin, though, but it gives an idea of the chained assertions that can be performed)
> {code}
> assertThat(new GearGroupsAssert(gearGroups))
> .assertGroup(0).hasUUID().hasGears()
> .assertGear(0).hasId().hasState();
> {code}
> - in case of assertion failure on such a statement:
> {code}
> Assertions.assertThat(commands).hasSize(2);
> {code}
> the exception message will look like this:
> {code}
> java.lang.AssertionError: expected size:<2> but was:<1> for <['{"command":"reload","path":null,"liveCSS":true}']>
> at org.fest.assertions.Fail.failure(Fail.java:228)
> at org.fest.assertions.Assert.failure(Assert.java:149)
> at org.fest.assertions.GroupAssert.hasSize(GroupAssert.java:89)
> at org.jboss.tools.livereload.internal.service.LiveReloadCommandGeneratorTestCase.shouldGenerateCommandForIndexHtmlFileAfterSingleChange(LiveReloadCommandGeneratorTestCase.java:45)
> at ...
> {code}
> See more examples here: http://code.google.com/p/fest/#Fluent_Assertions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months