[JBoss JIRA] (JBIDE-14363) Creation of 'core' component in base
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14363?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-14363:
---------------------------------------------
common feature would need splitting up then - it is currently a big bag of mixed ui/core and has very little to zero documentation and API's aren't exactly stable and changes often (xmodel especially).
Trying to create a true common/core here.
i'm not against the idea of leaving it in common but then we need to find a way to guarantee the old commons stuff does not leak into it.
> Creation of 'core' component in base
> ------------------------------------
>
> Key: JBIDE-14363
> URL: https://issues.jboss.org/browse/JBIDE-14363
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: common/jst/core
> Affects Versions: 4.1.0.Beta1
> Reporter: Rob Stryker
> Assignee: Max Rydahl Andersen
> Fix For: 4.1.0.Beta1
>
>
> The creation of a 'core' with minimal dependencies, preferably ONLY platform, is required. The component will have the following requirements:
> 1) Only code designed for re-use can live there
> 2) Only fully and properly java-doc'd code can live there
> 3) Only code for use by TWO OR MORE components can live there.
> 4) Addition of dependencies for this component will be strictly regulated
> 5) Code must be properly tested and have tests cases demonstrating it.
> 6) Code relating to non-platform requirements (such as egit, maven, wtp) will receive additional bundles and features to keep these dependencies separate. FOr example:
> {code}
> org.jboss.tools.core.platform
> org.jboss.tools.core.platform.ui
> org.jboss.tools.core.wtp
> org.jboss.tools.core.wtp.ui
> {code}
> Bundles such as these would require test bundles, as well as features that keep them separate.
> {code}
> org.jboss.tools.core.platform.feature
> org.jboss.tools.core.wtp.feature
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-14363) Creation of 'core' component in base
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14363?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-14363:
---------------------------------------
{quote}org.jboss.tools.core.platform
org.jboss.tools.core.platform.ui
org.jboss.tools.core.wtp
org.jboss.tools.core.wtp.ui{quote}
if common.core is peeled off and all deps to egit, wtp and other modules would be moved out to
{code}org.jboss.tools.common.egit.*
org.jboss.tools.common.wst.*
org.jboss.tools.common.jst.*
org.jboss.tools.common.jdt.*
{code}
No new component with duplicate name "core" and for now we could keep using common feature to deliver common.* and then introduce new common.(wst|jdt|new-module).feature.
> Creation of 'core' component in base
> ------------------------------------
>
> Key: JBIDE-14363
> URL: https://issues.jboss.org/browse/JBIDE-14363
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: common/jst/core
> Affects Versions: 4.1.0.Beta1
> Reporter: Rob Stryker
> Assignee: Max Rydahl Andersen
> Fix For: 4.1.0.Beta1
>
>
> The creation of a 'core' with minimal dependencies, preferably ONLY platform, is required. The component will have the following requirements:
> 1) Only code designed for re-use can live there
> 2) Only fully and properly java-doc'd code can live there
> 3) Only code for use by TWO OR MORE components can live there.
> 4) Addition of dependencies for this component will be strictly regulated
> 5) Code must be properly tested and have tests cases demonstrating it.
> 6) Code relating to non-platform requirements (such as egit, maven, wtp) will receive additional bundles and features to keep these dependencies separate. FOr example:
> {code}
> org.jboss.tools.core.platform
> org.jboss.tools.core.platform.ui
> org.jboss.tools.core.wtp
> org.jboss.tools.core.wtp.ui
> {code}
> Bundles such as these would require test bundles, as well as features that keep them separate.
> {code}
> org.jboss.tools.core.platform.feature
> org.jboss.tools.core.wtp.feature
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-14363) Creation of 'core' component in base
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14363?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-14363:
---------------------------------------
{quote}org.jboss.tools.core.platform.ui
org.jboss.tools.core.wtp.ui{quote}
This is looking not right, from eclipse perspective core - is non UI related functionality, so core and ui in one name looks wrong to me.
Why not leverage what we have now and just peel off common, common.core, common.ui instead of creating new bundles?
> Creation of 'core' component in base
> ------------------------------------
>
> Key: JBIDE-14363
> URL: https://issues.jboss.org/browse/JBIDE-14363
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: common/jst/core
> Affects Versions: 4.1.0.Beta1
> Reporter: Rob Stryker
> Assignee: Max Rydahl Andersen
> Fix For: 4.1.0.Beta1
>
>
> The creation of a 'core' with minimal dependencies, preferably ONLY platform, is required. The component will have the following requirements:
> 1) Only code designed for re-use can live there
> 2) Only fully and properly java-doc'd code can live there
> 3) Only code for use by TWO OR MORE components can live there.
> 4) Addition of dependencies for this component will be strictly regulated
> 5) Code must be properly tested and have tests cases demonstrating it.
> 6) Code relating to non-platform requirements (such as egit, maven, wtp) will receive additional bundles and features to keep these dependencies separate. FOr example:
> {code}
> org.jboss.tools.core.platform
> org.jboss.tools.core.platform.ui
> org.jboss.tools.core.wtp
> org.jboss.tools.core.wtp.ui
> {code}
> Bundles such as these would require test bundles, as well as features that keep them separate.
> {code}
> org.jboss.tools.core.platform.feature
> org.jboss.tools.core.wtp.feature
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months