[JBoss JIRA] (JBIDE-14370) Add 32bit swt libraries to eclipse64 module as a result of the build
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14370?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-14370:
----------------------------------------
I can see 2 ways of achieving this:
# Create a fake "eclipse-repository" containing those 2 bundles, and use it with "maven-dependency-plugin:unpack" to populate the lib folders with those 2 bundles, or
# Create a Mojo which would poll the target platform configuration of the project to directly get those bundles
Option 1 has the advantage of using standard tools, but requires to set up a fake module.
Option 2 has the advantage of being a bit easier to consume, but introduces yet another Mojo to maintain on our side.
I'm in favor of option 1. Do you have any objection?
> Add 32bit swt libraries to eclipse64 module as a result of the build
> --------------------------------------------------------------------
>
> Key: JBIDE-14370
> URL: https://issues.jboss.org/browse/JBIDE-14370
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: browsersim
> Reporter: Konstantin Marmalyukov
> Assignee: Mickael Istria
> Priority: Critical
> Fix For: 4.1.0.Beta1
>
>
> We need to have latest 32-bit SWT libraries in resources folder of eclipse64 browsersim module to make user able to run browserSim from x64 eclipse.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-12321) handle IApplication#getEmbeddedCartridges correctly with changes to protocol 1.2
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12321?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-12321:
------------------------------------------
There are also unit- and integration tests that assert that the application type is not reported in ApplicationResource#getEmbeddedCartridges:
https://github.com/openshift/openshift-java-client/blob/master/src/test/j...
{code:title=ApplicationResourceTest}
@Test
public void shouldListExistingCartridges() throws Throwable {
// pre-conditions
when(mockClient.get(urlEndsWith("/domains/foobarz/applications")))
.thenReturn(GET_DOMAINS_FOOBARZ_APPLICATIONS.getContentAsString());
when(mockClient.get(urlEndsWith("/domains/foobarz/applications/springeap6")))
.thenReturn(GET_DOMAINS_FOOBARZ_APPLICATIONS_SPRINGEAP6.getContentAsString());
when(mockClient.get(urlEndsWith("/domains/foobarz/applications/springeap6/cartridges")))
.thenReturn(GET_DOMAINS_FOOBARZ_APPLICATIONS_SPRINGEAP6_CARTRIDGES_2EMBEDDED.getContentAsString());
final IApplication app = domain.getApplicationByName("springeap6");
// operation
final List<IEmbeddedCartridge> embeddedCartridges = app.getEmbeddedCartridges();
// verifications
assertThat(embeddedCartridges).hasSize(2);
}
{code}
and
{code:title=ApplicationResourceIntegrationTest}
@Test
public void shouldNotContainTypeInEmbeddedCartridges() throws SocketTimeoutException, OpenShiftException {
// pre-conditions
final IStandaloneCartridge jbossAs = LatestVersionOf.jbossAs().get(user);
assertThat(jbossAs).isNotNull();
IApplication application = ApplicationTestUtils.ensureHasExactly1Application(jbossAs, domain);
// operation
List<IEmbeddedCartridge> embeddedCartridges = application.getEmbeddedCartridges();
// verification
assertThat(embeddedCartridges).doesNotSatisfy(new Condition<List<?>>() {
@Override
public boolean matches(List<?> values) {
for(Object value : values) {
if (!(value instanceof ICartridge)) {
continue;
}
if (jbossAs.getName().equals(((ICartridge)value).getName())) {
return true;
};
}
return false;
}
});
}
{code}
> handle IApplication#getEmbeddedCartridges correctly with changes to protocol 1.2
> --------------------------------------------------------------------------------
>
> Key: JBIDE-12321
> URL: https://issues.jboss.org/browse/JBIDE-12321
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.0.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Beta1
>
> Attachments: app-type-listed-as-embedded.png, type-not-reported-as-embeddedcartridge.png
>
>
> In 1.1 the cartridges that you get reported when listing them on a application changed (IApplication#getEmbeddedCartridges):
> * 1.0:
> would report the embedded cartridges only
> * 1.1:
> would report the embedded cartridges and the application type (cartridge)
> !app-type-listed-as-embedded.png!
> see here: https://github.com/openshift/crankcase/pull/224
> The error that this caused was discussed here:
> https://bugzilla.redhat.com/show_bug.cgi?id=838611
> OpenShift pushed the discussed change (application-type reported as embedded cartridge) to protocol v1.1 and fixed the issue on the server-side. Our client, that currently requests protocol v1.0 has no issue since the fix. We have to make sure we support protocol 1.1 and are able to handle this correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-13675) openshift-java-client: dont swallow domain deletion errors in tests if deletion is pre-condition
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13675?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-13675:
------------------------------------------
[~nickboldt] yes, definitely. thanks for catching!
> openshift-java-client: dont swallow domain deletion errors in tests if deletion is pre-condition
> ------------------------------------------------------------------------------------------------
>
> Key: JBIDE-13675
> URL: https://issues.jboss.org/browse/JBIDE-13675
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
> When running UserResourceIntegrationTests there are currently several tests that fail because of an issue in OpenShift (reported in https://bugzilla.redhat.com/show_bug.cgi?id=916323). The UserResourceIntegrationTests therefore fail in
> #shouldCreateDomain
> #shouldReturnThatHasNoDomain
> #shouldReturnEmptyDomains
> #shouldNoDefaultDomainAfterRefresh
> These tests rely on the fact that the domain(s) could be deleted, no domain is a pre-condition to them.
> Unfortunately these tests swallow the exceptions that may occurr when killing these domains. The tests therefore report resulting errors, not the real cause.
> We have to ensure exception that occurr when killing domains are not swallowed. They have to make the test fail (since domain deletion is a precondition).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-13675) openshift-java-client: dont swallow domain deletion errors in tests if deletion is pre-condition
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13675?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-13675:
------------------------------------
[~adietish] I have changed the fixversion here from 4.0.0.Alpha2-SOA to 4.1.0.Alpha2. If that's incorrect, please revert. This should probably be closed, right?
> openshift-java-client: dont swallow domain deletion errors in tests if deletion is pre-condition
> ------------------------------------------------------------------------------------------------
>
> Key: JBIDE-13675
> URL: https://issues.jboss.org/browse/JBIDE-13675
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
> When running UserResourceIntegrationTests there are currently several tests that fail because of an issue in OpenShift (reported in https://bugzilla.redhat.com/show_bug.cgi?id=916323). The UserResourceIntegrationTests therefore fail in
> #shouldCreateDomain
> #shouldReturnThatHasNoDomain
> #shouldReturnEmptyDomains
> #shouldNoDefaultDomainAfterRefresh
> These tests rely on the fact that the domain(s) could be deleted, no domain is a pre-condition to them.
> Unfortunately these tests swallow the exceptions that may occurr when killing these domains. The tests therefore report resulting errors, not the real cause.
> We have to ensure exception that occurr when killing domains are not swallowed. They have to make the test fail (since domain deletion is a precondition).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-13675) openshift-java-client: dont swallow domain deletion errors in tests if deletion is pre-condition
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13675?page=com.atlassian.jira.plugi... ]
Nick Boldt updated JBIDE-13675:
-------------------------------
Fix Version/s: 4.1.0.Alpha2
(was: 4.0.0.Alpha2-SOA)
> openshift-java-client: dont swallow domain deletion errors in tests if deletion is pre-condition
> ------------------------------------------------------------------------------------------------
>
> Key: JBIDE-13675
> URL: https://issues.jboss.org/browse/JBIDE-13675
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
> When running UserResourceIntegrationTests there are currently several tests that fail because of an issue in OpenShift (reported in https://bugzilla.redhat.com/show_bug.cgi?id=916323). The UserResourceIntegrationTests therefore fail in
> #shouldCreateDomain
> #shouldReturnThatHasNoDomain
> #shouldReturnEmptyDomains
> #shouldNoDefaultDomainAfterRefresh
> These tests rely on the fact that the domain(s) could be deleted, no domain is a pre-condition to them.
> Unfortunately these tests swallow the exceptions that may occurr when killing these domains. The tests therefore report resulting errors, not the real cause.
> We have to ensure exception that occurr when killing domains are not swallowed. They have to make the test fail (since domain deletion is a precondition).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months
[JBoss JIRA] (JBIDE-12321) handle IApplication#getEmbeddedCartridges correctly with changes to protocol 1.2
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12321?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-12321:
-------------------------------------
Attachment: type-not-reported-as-embeddedcartridge.png
> handle IApplication#getEmbeddedCartridges correctly with changes to protocol 1.2
> --------------------------------------------------------------------------------
>
> Key: JBIDE-12321
> URL: https://issues.jboss.org/browse/JBIDE-12321
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.0.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Beta1
>
> Attachments: app-type-listed-as-embedded.png, type-not-reported-as-embeddedcartridge.png
>
>
> In 1.1 the cartridges that you get reported when listing them on a application changed (IApplication#getEmbeddedCartridges):
> * 1.0:
> would report the embedded cartridges only
> * 1.1:
> would report the embedded cartridges and the application type (cartridge)
> !app-type-listed-as-embedded.png!
> see here: https://github.com/openshift/crankcase/pull/224
> The error that this caused was discussed here:
> https://bugzilla.redhat.com/show_bug.cgi?id=838611
> OpenShift pushed the discussed change (application-type reported as embedded cartridge) to protocol v1.1 and fixed the issue on the server-side. Our client, that currently requests protocol v1.0 has no issue since the fix. We have to make sure we support protocol 1.1 and are able to handle this correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 11 months