[JBoss JIRA] (JBIDE-22999) Red Hat Central Rebranding
by Alexey Kazakov (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22999?page=com.atlassian.jira.plugi... ]
Alexey Kazakov commented on JBIDE-22999:
----------------------------------------
I like the new light version.
> Red Hat Central Rebranding
> --------------------------
>
> Key: JBIDE-22999
> URL: https://issues.jboss.org/browse/JBIDE-22999
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: central
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Assignee: James Cobb
> Fix For: 4.4.x
>
> Attachments: central-rhd-icon.png, fullIDE.png, tools_rebrand.png, tools_rebrand_r1v2.png, tools_rebrand_r1v3.png, tools_rebrand_r2v1.png
>
>
> Quoting [~james.cobb], from JBIDE-22382
> {quote}
> I've pulled in the branding fro RHD into this IDE panel.
> 1. I've opted to use colors verses an grey monotones
> 2. I've used Red Hat icons from the icon set
> Thoughts?
> {quote}
> !tools_rebrand.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23177) Server Editor: Combo items have wrong size
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23177?page=com.atlassian.jira.plugi... ]
Snjezana Peco commented on JBIDE-23177:
---------------------------------------
You are right.
There is also a problem with this editor on GTK 3.18 (F23). On GTK2, the OpenShiftServerEditorSection section has a gray background.
The attached patch fixes the issue on GTK 3.20 (F24) and improves the appearance of the editor on GTK 3.18.
> Server Editor: Combo items have wrong size
> ------------------------------------------
>
> Key: JBIDE-23177
> URL: https://issues.jboss.org/browse/JBIDE-23177
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.2.AM1
> Reporter: Marián Labuda
> Labels: openshift_v3, server_editor
> Attachments: combos.png
>
>
> When I open an OpenShift 3 Server Editor the combo boxes have weird size, there are overlapping widgets.
> !combos.png!
> Spotted on Fedora 24 with GTK 3.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-22999) Red Hat Central Rebranding
by James Cobb (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22999?page=com.atlassian.jira.plugi... ]
James Cobb edited comment on JBIDE-22999 at 9/21/16 10:52 AM:
--------------------------------------------------------------
I've worked up another light version. I've incorporated red into the icons and used a larger range between white and the darkest "light" grey.
https://issues.jboss.org/secure/attachment/12409839/tools_rebrand_r2v1.png
[~mlabuda]
was (Author: james.cobb):
I've worked up another light version. I've incorporated red into the icons and used a larger range between white and the darkest "light" grey.
[~mlabuda]
> Red Hat Central Rebranding
> --------------------------
>
> Key: JBIDE-22999
> URL: https://issues.jboss.org/browse/JBIDE-22999
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: central
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Assignee: James Cobb
> Fix For: 4.4.x
>
> Attachments: central-rhd-icon.png, fullIDE.png, tools_rebrand.png, tools_rebrand_r1v2.png, tools_rebrand_r1v3.png, tools_rebrand_r2v1.png
>
>
> Quoting [~james.cobb], from JBIDE-22382
> {quote}
> I've pulled in the branding fro RHD into this IDE panel.
> 1. I've opted to use colors verses an grey monotones
> 2. I've used Red Hat icons from the icon set
> Thoughts?
> {quote}
> !tools_rebrand.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-22999) Red Hat Central Rebranding
by James Cobb (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22999?page=com.atlassian.jira.plugi... ]
James Cobb updated JBIDE-22999:
-------------------------------
Attachment: tools_rebrand_r2v1.png
I've worked up another light version. I've incorporated red into the icons and used a larger range between white and the darkest "light" grey.
[~mlabuda]
> Red Hat Central Rebranding
> --------------------------
>
> Key: JBIDE-22999
> URL: https://issues.jboss.org/browse/JBIDE-22999
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: central
> Affects Versions: 4.4.1.AM2
> Reporter: Marián Labuda
> Assignee: James Cobb
> Fix For: 4.4.x
>
> Attachments: central-rhd-icon.png, fullIDE.png, tools_rebrand.png, tools_rebrand_r1v2.png, tools_rebrand_r1v3.png, tools_rebrand_r2v1.png
>
>
> Quoting [~james.cobb], from JBIDE-22382
> {quote}
> I've pulled in the branding fro RHD into this IDE panel.
> 1. I've opted to use colors verses an grey monotones
> 2. I've used Red Hat icons from the icon set
> Thoughts?
> {quote}
> !tools_rebrand.png!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Fred Bricon commented on JBIDE-23182:
-------------------------------------
HandlerUtil.getCurrentSelection(event); is not used because we are unable to get the selection from the properties view
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months
[JBoss JIRA] (JBIDE-23182) NullPointerException in PodLogsHandler.handleEvent
by Viacheslav Kabanovich (JIRA)
[ https://issues.jboss.org/browse/JBIDE-23182?page=com.atlassian.jira.plugi... ]
Viacheslav Kabanovich commented on JBIDE-23182:
-----------------------------------------------
The line
{code}
ISelection selection = HandlerUtil.getActivePart(event).getSite().getWorkbenchWindow().getSelectionService().getSelection();
{code}
is used in 14 handlers in Openshift 3. It can fail at Eclipse closing.
In Openshift 2, another call is used
{code}
ISelection selection = HandlerUtil.getCurrentSelection(event);
{code}
[~adietish], [~fbricon], was there some reason for not using HandlerUtil.getCurrentSelection(event) in Openshift 3 handlers?
If the current way is preferable, we have to add a safe helper that checks for null active part, site, window and service; and call that helper from all Openshift 3 handlers.
> NullPointerException in PodLogsHandler.handleEvent
> --------------------------------------------------
>
> Key: JBIDE-23182
> URL: https://issues.jboss.org/browse/JBIDE-23182
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Automated Error Reporting Bot
>
> The following problem was reported via the automated error reporting:
> Message: Unhandled event loop exception
> {noformat}
> java.lang.NullPointerException: null
> at org.jboss.tools.openshift.internal.ui.handler.PodLogsHandler.handleEvent(PodLogsHandler.java:46)
> at org.jboss.tools.openshift.internal.ui.handler.AbstractOpenShiftCliHandler.execute(AbstractOpenShiftCliHandler.java:70)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(null:-2)
> at sun.reflect.NativeMethodAccessorImpl.invoke(null:-1)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(null:-1)
> at java.lang.reflect.Method.invoke(null:-1)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:54)
> {noformat}
> Bundles:
> | org.eclipse.e4.core.di | 1.6.0.v20160319-0612 | 1.6.0.v20160319-0612 |
> | org.eclipse.ui | 3.108.0.v20160518-1929 | 3.108.0.v20160518-1929 |
> | org.jboss.tools.openshift.ui | 3.3.0.v20160831-0703 | 3.3.0.v20160831-0703 |
> Operating Systems:
> | Windows | 10.0.0 | 10.0.0 |
> The above information is a snapshot of the collected data. Visit [this page|https://redhat.ctrlflow.com/reviewers/#!/problems/57d6df25e4b0fd7621...] for the latest data.
> Thank you for your assistance.
> Your friendly error-reports-inbox.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 6 months