[JBoss JIRA] Created: (JBDS-983) Console not showing up when staritng a EAP/SOA-P Instance
by Jim Tyrrell (JIRA)
Console not showing up when staritng a EAP/SOA-P Instance
---------------------------------------------------------
Key: JBDS-983
URL: https://jira.jboss.org/jira/browse/JBDS-983
Project: JBoss Developer Studio
Issue Type: Feature Request
Affects Versions: 3.0.0.M4
Reporter: Jim Tyrrell
For some reason starting a SOA-P instance by right clicking in the server view does not start/open the console for the output of the server as it is starting. For EAP and Seam projects this does not seem to be the case as often, but I think I have seen it. The current JBDS 3.0 M4 release does seem to not show the console unless I open the console via the Window -> Show View -> General -> Console and then I have to click an icon to enable the "Java Stack Trace Console". Once I have setup the console once as just noted even if I close it it will open as I expect. If I close JBDS and make sure that the console was not left open, I get the same behaviour when I try to right click on the SOA-P instance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1 week, 1 day
[JBoss JIRA] (JBDS-3044) Align installation default path with installer filename
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-3044?page=com.atlassian.jira.plugin.... ]
Nick Boldt edited comment on JBDS-3044 at 5/28/14 10:36 AM:
------------------------------------------------------------
Martin did a quick test on OSX to see what the longest file paths are inside JBDS 8 Beta2:
{quote}
{code}
find jbdevstudio-* |awk '{ print length($0) ; }'|sort|uniq|egrep "2.+"
{code}
shows 251 as the longest path on Mac so not really safe
longest is ./studio/configuration/org.eclipse.osgi/949/data/c7ff8a0a591e0e90fe36069138e75f68/1012-1401176993555/org.springframework.ide.eclipse.core.java.ProjectClassLoaderCache$SourceAndOutputLocationResourceChangeListener$SourceAndOutputLocationResourceVisitor
but that is spring and it's data
{quote}
So we're already pushing the limit here for long paths on Windows / NTFS...
Related (with some LOLs): http://blog.codinghorror.com/filesystem-paths-how-long-is-too-long/
There are ways to achieve more-than-260-char paths, but do we want to?
was (Author: nickboldt):
Martin did a quick test on OSX to see what the longest file paths are inside JBDS 8 Beta2:
{quote}
{code}
find jbdevstudio-* |awk '{ print length($0) ; }'|sort|uniq|egrep "2.+"
{code}
shows 251 as the longest path on Mac so not really safe
longest is ./studio/configuration/org.eclipse.osgi/949/data/c7ff8a0a591e0e90fe36069138e75f68/1012-1401176993555/org.springframework.ide.eclipse.core.java.ProjectClassLoaderCache$SourceAndOutputLocationResourceChangeListener$SourceAndOutputLocationResourceVisitor
but that is spring and it's data
{quote}
So we're already pushing the limit here for long paths on Windows / NTFS...
> Align installation default path with installer filename
> -------------------------------------------------------
>
> Key: JBDS-3044
> URL: https://issues.jboss.org/browse/JBDS-3044
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: installer
> Affects Versions: 8.0.0.Beta2
> Reporter: Martin Malina
> Assignee: Denis Golovin
> Priority: Blocker
> Labels: discuss
> Fix For: 8.0.0.Beta3
>
>
> Now that Nick changed the installer filenames to jboss-devstudio in JBIDE-16871 (was jbdevstudio), shouldn't the default install path be changed similarly? Because it just went out of sync.
> This question is open for discussion. Nick pointed out some reasons against this suggestion:
> {quote}
> Martin Malina Re: changing the installation folder, I'll hold off on that change for the moment for a few reasons:
> a) Max is AFK, and will want to vet/veto this idea
> b) long paths for Windows users (80% of our user base) = bad news, especially considering how long some file paths can get already within Eclipse workspaces
> c) short paths for Windows (c:\jbdevstudio) & long paths for everyone else ~/jboss-devstudio) would be ill-advised from a documentation and cross-platform user experience
> So, either we stick w/ jbdevstudio, or we shorten to devstudio (losing the "jb" branding fragment). If we move to "jboss-devstudio" we increase the path by only 4 characters.
> Max Rydahl Andersen WDYT?
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
1 month
[JBoss JIRA] (JBDS-2719) Multiple Spring AOP problems when travel example is imported
by Joshua Wilson (JIRA)
[ https://issues.jboss.org/browse/JBDS-2719?page=com.atlassian.jira.plugin.... ]
Joshua Wilson commented on JBDS-2719:
-------------------------------------
[~nickboldt] I will need to test several different configurations to confirm my earlier guess. This is what I know so far.
First I would ask that you test with the [Kitchensink-Spring Quickstarts|https://github.com/jboss-developer/jboss-wfk-quickstarts] as I am working to keep them up to date and error free as much as possible. This specific error can be seen in the [kitchensink-spring-matrixvariable|https://github.com/jboss-developer/jbos...] quickstart. The Travel and PetClinic will be kept as close to the original as possible (and I haven't had a chance to update them yet).
With that in mind if I Build (with Eclipse/JBDS) [kitchensink-spring-matrixvariable|https://github.com/jboss-developer/jbos...] in JBDS 7.0.1 with Spring IDE 3.3 installed from JBoss Central, I get the aspectj error. However if I Build while in a standard Eclipse JEE install with JBDS and the stock Spring IDE/STS 3.4 installed, I do NOT get the aspectj error.
In order to truly confirm that adding both "AspectJ Compiler" and "AspectJ Development Tools" will fix the error, I would need to test that on my JBDS 7.0.1/SpringIDE 3.3 set up.
> Multiple Spring AOP problems when travel example is imported
> ------------------------------------------------------------
>
> Key: JBDS-2719
> URL: https://issues.jboss.org/browse/JBDS-2719
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: 3rd-party-certification, upstream
> Affects Versions: 7.0.0.GA
> Environment: JBDS 7.0.0.GA, L64, Spring IDE 3.3 installed from JBoss Central
> Reporter: Jiri Peterka
> Assignee: Nick Boldt
> Fix For: 7.1.0.Beta1
>
>
> There are Multiple Spring AOP Errors after travel example is imported:
> {code}
> Build path is incomplete. Cannot find class file for org/aspectj/weaver/reflect/ReflectionWorld$ReflectionWorldException
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1 month
[JBoss JIRA] (JBDS-4722) Problem creating splash implementation
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-4722?page=com.atlassian.jira.plugin.... ]
Nick Boldt commented on JBDS-4722:
----------------------------------
That's weird. Maybe we're running the installer build job with JDK 9 now?
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... says Open JDK 8... so that's not it.
Csn you provide more comprehensive steps to reproduce than simply "I got a bunch of error while restarting/starting over devstudio" ?
What OS? What JDK? What version of devstudio? how did you install it? BYOE, installer, update site, marketplace?
> Problem creating splash implementation
> --------------------------------------
>
> Key: JBDS-4722
> URL: https://issues.jboss.org/browse/JBDS-4722
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: product
> Affects Versions: 12.9.0.AM1
> Reporter: Ondrej Dockal
>
> I got a bunch of error while restarting/starting over devstudio.
> {code}
> Problem creating splash implementation
> java.lang.UnsupportedClassVersionError: com/jboss/devstudio/core/splash/SplashHandler has been compiled by a more recent version of the Java Runtime (class file version 53.0), this version of the Java Runtime only recognizes class file versions up to 52.0
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at org.eclipse.osgi.internal.loader.ModuleClassLoader.defineClass(ModuleClassLoader.java:276)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.defineClass(ClasspathManager.java:632)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findClassImpl(ClasspathManager.java:555)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:514)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:501)
> at org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:328)
> at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:392)
> at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:470)
> at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:419)
> at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:411)
> at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:150)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at org.eclipse.osgi.internal.framework.EquinoxBundle.loadClass(EquinoxBundle.java:609)
> at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:177)
> at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:931)
> at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243)
> at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:60)
> at org.eclipse.ui.internal.WorkbenchPlugin.lambda$0(WorkbenchPlugin.java:288)
> at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:71)
> at org.eclipse.ui.internal.WorkbenchPlugin.createExtension(WorkbenchPlugin.java:285)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory$1.run(SplashHandlerFactory.java:134)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory.create(SplashHandlerFactory.java:129)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory.processElement(SplashHandlerFactory.java:112)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory.findSplashHandlerFor(SplashHandlerFactory.java:60)
> at org.eclipse.ui.internal.Workbench.getSplash(Workbench.java:892)
> at org.eclipse.ui.internal.Workbench.access$2(Workbench.java:884)
> at org.eclipse.ui.internal.Workbench$2.run(Workbench.java:782)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.ui.internal.Workbench.createSplashWrapper(Workbench.java:846)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:597)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:560)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:656)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:592)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1498)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1471)
> Session data:
> eclipse.buildId=12.9.0.AM1-v20180726-1026-B3091
> java.version=1.8.0_172
> java.vendor=Oracle Corporation
> BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
> Framework arguments: -product com.jboss.devstudio.core.product
> Command-line arguments: -os linux -ws gtk -arch x86_64 -product com.jboss.devstudio.core.product
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 5 months
[JBoss JIRA] (JBDS-4722) Problem creating splash implementation
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBDS-4722?page=com.atlassian.jira.plugin.... ]
Nick Boldt edited comment on JBDS-4722 at 7/31/18 5:48 PM:
-----------------------------------------------------------
That's weird. Maybe we're running the installer build job with JDK 9 now?
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... says Open JDK 8... so that's not it.
Can you provide more comprehensive steps to reproduce than simply "I got a bunch of error while restarting/starting over devstudio" ?
What OS? What JDK? What version of devstudio? how did you install it? BYOE, installer, update site, marketplace?
was (Author: nickboldt):
That's weird. Maybe we're running the installer build job with JDK 9 now?
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud... says Open JDK 8... so that's not it.
Csn you provide more comprehensive steps to reproduce than simply "I got a bunch of error while restarting/starting over devstudio" ?
What OS? What JDK? What version of devstudio? how did you install it? BYOE, installer, update site, marketplace?
> Problem creating splash implementation
> --------------------------------------
>
> Key: JBDS-4722
> URL: https://issues.jboss.org/browse/JBDS-4722
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Bug
> Components: product
> Affects Versions: 12.9.0.AM1
> Reporter: Ondrej Dockal
>
> I got a bunch of error while restarting/starting over devstudio.
> {code}
> Problem creating splash implementation
> java.lang.UnsupportedClassVersionError: com/jboss/devstudio/core/splash/SplashHandler has been compiled by a more recent version of the Java Runtime (class file version 53.0), this version of the Java Runtime only recognizes class file versions up to 52.0
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at org.eclipse.osgi.internal.loader.ModuleClassLoader.defineClass(ModuleClassLoader.java:276)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.defineClass(ClasspathManager.java:632)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findClassImpl(ClasspathManager.java:555)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:514)
> at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:501)
> at org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:328)
> at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:392)
> at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:470)
> at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:419)
> at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:411)
> at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:150)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at org.eclipse.osgi.internal.framework.EquinoxBundle.loadClass(EquinoxBundle.java:609)
> at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:177)
> at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:931)
> at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243)
> at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:60)
> at org.eclipse.ui.internal.WorkbenchPlugin.lambda$0(WorkbenchPlugin.java:288)
> at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:71)
> at org.eclipse.ui.internal.WorkbenchPlugin.createExtension(WorkbenchPlugin.java:285)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory$1.run(SplashHandlerFactory.java:134)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory.create(SplashHandlerFactory.java:129)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory.processElement(SplashHandlerFactory.java:112)
> at org.eclipse.ui.internal.splash.SplashHandlerFactory.findSplashHandlerFor(SplashHandlerFactory.java:60)
> at org.eclipse.ui.internal.Workbench.getSplash(Workbench.java:892)
> at org.eclipse.ui.internal.Workbench.access$2(Workbench.java:884)
> at org.eclipse.ui.internal.Workbench$2.run(Workbench.java:782)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at org.eclipse.ui.internal.Workbench.createSplashWrapper(Workbench.java:846)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:597)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:560)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:656)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:592)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1498)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1471)
> Session data:
> eclipse.buildId=12.9.0.AM1-v20180726-1026-B3091
> java.version=1.8.0_172
> java.vendor=Oracle Corporation
> BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
> Framework arguments: -product com.jboss.devstudio.core.product
> Command-line arguments: -os linux -ws gtk -arch x86_64 -product com.jboss.devstudio.core.product
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 5 months
[JBoss JIRA] (JBIDE-26169) Create an OpenShift application from a local project
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26169?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-26169:
------------------------------------------
[~rhuss] Sounds great. Is there any ETA for this?
> Create an OpenShift application from a local project
> ----------------------------------------------------
>
> Key: JBIDE-26169
> URL: https://issues.jboss.org/browse/JBIDE-26169
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.6.0.Final
> Reporter: Jeff MAURY
> Assignee: Andre Dietisheim
> Fix For: 4.9.x
>
>
> As part of the better inner loop for OpenShift developpers, we should support the creation of an OpenShift application/deployment from a source project.
> * we should be able to deduce the image from the project context (as the fabric8 maven plugin does)
> * the fabric8 maven plugin is not yet designed to be embedded outside maven so we should look at the following alternatives:
> ** have a field where the user can tune the used image and default it to the one for SpringBoot in the first implementation
> ** see if we cannot reuse part of the fabric8 maven plugin through M2E but this will limit the scope to Java Maven projects
> ** reimplements the generators from fabric8 maven plugin in Eclipse in more limited fashion
> ** see if we cannot participate in the fabric8-build (https://github.com/fabric8io/fabric8-build)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 5 months
[JBoss JIRA] (JBIDE-26164) internal packages are a mess
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26164?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-26164:
-------------------------------------
Labels: cleanup (was: )
> internal packages are a mess
> ----------------------------
>
> Key: JBIDE-26164
> URL: https://issues.jboss.org/browse/JBIDE-26164
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.6.0.AM3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Minor
> Labels: cleanup
> Fix For: 4.9.0.AM2
>
> Attachments: image-2018-07-04-15-42-01-395.png
>
>
> Our package structure is a mess, especially internal ones are wrong.
> Ex. org.jboss.tools.openshift ui:
> There are 2 internal packages:
> * org.jboss.tools.openshift.internal.ui
> * org.jboss.tools.openshift.ui.internal
> !image-2018-07-04-15-42-01-395.png!
> Internal packages have to follow the base component name, which in our case is org.jboss.tools.openshift:
> * org.jboss.tools.openshift.internal.ui: *{color:green}CORRECT{color}*
> * org.jboss.tools.openshift.ui.internal: *{color:red}WRONG{color}*
> For the background:
> * https://wiki.eclipse.org/Naming_Conventions#Internal_Implementation_Packages:
> {quote}
> All implementation packages should be flagged as internal, with the tag occurring just after the major package name
> {quote}
> * http://wiki.eclipse.org/Naming_Conventions#Java_Packages
> {quote}
> org.eclipse.jdt.internal.core.compiler - Correct usage
> org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow project name.
> org.eclipse.core.internal.resources - Correct usage
> org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
> org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 5 months
[JBoss JIRA] (JBIDE-26164) internal packages are a mess
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26164?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-26164:
-------------------------------------
Sprint: devex #153 August 2018
> internal packages are a mess
> ----------------------------
>
> Key: JBIDE-26164
> URL: https://issues.jboss.org/browse/JBIDE-26164
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.6.0.AM3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Minor
> Labels: cleanup
> Fix For: 4.9.0.AM2
>
> Attachments: image-2018-07-04-15-42-01-395.png
>
>
> Our package structure is a mess, especially internal ones are wrong.
> Ex. org.jboss.tools.openshift ui:
> There are 2 internal packages:
> * org.jboss.tools.openshift.internal.ui
> * org.jboss.tools.openshift.ui.internal
> !image-2018-07-04-15-42-01-395.png!
> Internal packages have to follow the base component name, which in our case is org.jboss.tools.openshift:
> * org.jboss.tools.openshift.internal.ui: *{color:green}CORRECT{color}*
> * org.jboss.tools.openshift.ui.internal: *{color:red}WRONG{color}*
> For the background:
> * https://wiki.eclipse.org/Naming_Conventions#Internal_Implementation_Packages:
> {quote}
> All implementation packages should be flagged as internal, with the tag occurring just after the major package name
> {quote}
> * http://wiki.eclipse.org/Naming_Conventions#Java_Packages
> {quote}
> org.eclipse.jdt.internal.core.compiler - Correct usage
> org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow project name.
> org.eclipse.core.internal.resources - Correct usage
> org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
> org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 5 months