[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22138:
------------------------------------------
I think that I found where in m2e-wtp the module name is set: [AbstractProjectConfiguratorDelegate#configureDeployedName|https://github....]
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/23/18 6:07 AM:
-------------------------------------------------------------------
[~rob.stryker] you mean the exact opposite: "the file is being updated but not the model", correct?
{quote}
The only thing I can imagine is happening here is that the model is being updated, and not the file
{quote}
In the screencast one sees the file being updated but the model in wtp for some misterious reason isn't.
[~rob.stryker] +1 on this
{quote}
I would first look to see when / how that file is being changed, and then trace back to see who's doing it. A stacktrace of that event would be very insightful.
{quote}
I bet doing some BJ stepping through things would be helpful, too.
btw. the path shows up at times (and thus the model is updated), but I dont know yet when this happens, when it doesn't.
was (Author: adietish):
[~rob.stryker] you mean the exact opposite: "the file is being updated but not the model", correct?
{quote}
The only thing I can imagine is happening here is that the model is being updated, and not the file
{quote}
In the screencast one sees the file being updated but the model in wtp for some misterious reason isn't.
[~rob.stryker] +1 on this
{quote}
I would first look to see when / how that file is being changed, and then trace back to see who's doing it. A stacktrace of that event would be very insightful.
{quote}
I bet doing some BJ stepping through things would be helpful, too.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26144) Update jboss-stacks minishift.yaml with newer released versions of CDK and minishift
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26144?page=com.atlassian.jira.plugi... ]
Ondrej Dockal updated JBIDE-26144:
----------------------------------
Description:
* Add missing released minishift runtimes (1.18, 1.19, 1.20, 1.21)
* Insert CDK 3.5.0 when it is released
* improve unit tests for stack file validation (add complex http request check)
was:
* Add missing released minishift runtimes (1.18, 1.19, 1.20)
* Insert CDK 3.5.0 when it is released
* improve unit tests for stack file validation (add complex http request check)
> Update jboss-stacks minishift.yaml with newer released versions of CDK and minishift
> ------------------------------------------------------------------------------------
>
> Key: JBIDE-26144
> URL: https://issues.jboss.org/browse/JBIDE-26144
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: cdk, qa
> Affects Versions: 4.6.0.Final
> Reporter: Ondrej Dockal
> Assignee: Ondrej Dockal
> Fix For: 4.9.0.AM1
>
>
> * Add missing released minishift runtimes (1.18, 1.19, 1.20, 1.21)
> * Insert CDK 3.5.0 when it is released
> * improve unit tests for stack file validation (add complex http request check)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26036) Update bundled minishift.yaml and write unit tests for both version of CDK stack yaml files
by Ondrej Dockal (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26036?page=com.atlassian.jira.plugi... ]
Ondrej Dockal updated JBIDE-26036:
----------------------------------
Description:
* Edit minishift.yaml file that resides in jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/resources to have corresponding content as jboss-stack/minishift.yaml file. We want to have the same content available when something fails to read stack's yaml file.
* Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
was:
* Edit minishift.yaml file that resides in jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/resources to have corresponding content as jboss-stack/minishift.yaml file. We want to have the same content available when something fails to read stack's yaml file.
* Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
* Update jboss-stack minishift.yaml (added 1.19 and 1.20)
> Update bundled minishift.yaml and write unit tests for both version of CDK stack yaml files
> -------------------------------------------------------------------------------------------
>
> Key: JBIDE-26036
> URL: https://issues.jboss.org/browse/JBIDE-26036
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: cdk
> Affects Versions: 4.6.0.AM2
> Reporter: Ondrej Dockal
> Assignee: Ondrej Dockal
> Fix For: 4.9.0.AM1
>
>
> * Edit minishift.yaml file that resides in jbosstools-openshift/plugins/org.jboss.tools.openshift.cdk.server/resources to have corresponding content as jboss-stack/minishift.yaml file. We want to have the same content available when something fails to read stack's yaml file.
> * Add new openshift.cdk.server unit tests for stack file (minishift.yaml online and bundled one)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22138:
------------------------------------------
[~rob.stryker] you mean the exact opposite: "the file is being updated but not the model", correct?
{quote}
The only thing I can imagine is happening here is that the model is being updated, and not the file
{quote}
[~rob.stryker] +1 on this
{quote}
I would first look to see when / how that file is being changed, and then trace back to see who's doing it. A stacktrace of that event would be very insightful.
{quote}
I bet doing some BJ stepping through things would be helpful, too.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/22/18 11:02 AM:
--------------------------------------------------------------------
[~rob.stryker] you mean the exact opposite: "the file is being updated but not the model", correct?
{quote}
The only thing I can imagine is happening here is that the model is being updated, and not the file
{quote}
In the screencast one sees the file being updated but the model in wtp for some misterious reason isn't.
[~rob.stryker] +1 on this
{quote}
I would first look to see when / how that file is being changed, and then trace back to see who's doing it. A stacktrace of that event would be very insightful.
{quote}
I bet doing some BJ stepping through things would be helpful, too.
was (Author: adietish):
[~rob.stryker] you mean the exact opposite: "the file is being updated but not the model", correct?
{quote}
The only thing I can imagine is happening here is that the model is being updated, and not the file
{quote}
[~rob.stryker] +1 on this
{quote}
I would first look to see when / how that file is being changed, and then trace back to see who's doing it. A stacktrace of that event would be very insightful.
{quote}
I bet doing some BJ stepping through things would be helpful, too.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-22138:
-------------------------------------
The only thing I can imagine is happening here is that the model is being updated, and not the file, and that somehow, wtp is suppressing firing a resource change event since the file is being updated via the model and not via the user. But I can't seem to find out how or why that'd be happening. I am actually shocked that that's even possible as I assumed a resource-change-event would be fired in all cases.
So this is all very shocking to me.
It does look like m2e is doing its part to update the model, but the wst.component thing is suppressing the resource change event, perhaps somewhere deep in EMF? If that's the case, I'm not at all sure how we could override that behavior. So the 'fix' might have to be done in m2e. I'm assuming m2e is the one initiating the update to the wst.component via the model. m2e might need to be informed that that change is not sufficient to update the model in full.
I would first look to see when / how that file is being changed, and then trace back to see who's doing it. A stacktrace of that event would be very insightful.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/20/18 5:31 PM:
-------------------------------------------------------------------
[~rob.stryker] I recorded how things look in the Eclipse IDE:
I have recorded the following screencast: https://www.youtube.com/watch?v=V_SdtXYkJHA&feature=youtu.be
# ASSERT: I have a maven project "hello" where switching the profile switches the deployment name from *hello.war* (no profile selected) to *ROOT.war* (profile "openshift" selected).
# ASSERT: Initially I have
{code:title=<workspace>hello/.settings/org.eclipse.wst.common.component}
deploy-name="hello"
{code}.
# ASSERT: Looking at the configured modules for my server adapter I see the module being called *hello*.
# EXEC: I go project preferences > Maven and choose the "openshift" profile
# ASSERT: I see component settings being updated on disk.
{code:title=<workspace>hello/.settings/org.eclipse.wst.common.component}
deploy-name="ROOT"
{code}.
# RESULT: the configured module for my OpenShift server adapter is still called *hello*.
# ASSERT: the configured module for my OpenShift server adapter should be called *hello(ROOT)*.
# EXEC: If I now go to some project property which updates the maven config (ex. Web Content Settings) and hit "Apply and Close"
# RESULT: The available modules for my OpenShift Server adapter are updated, the configured module is now updated and called *hello(ROOT)*
was (Author: adietish):
[~rob.stryker] I recorded how things look in the Eclipse IDE please:
I have recorded the following screencast: https://www.youtube.com/watch?v=V_SdtXYkJHA&feature=youtu.be
# ASSERT: I have a maven project "hello" where switching the profile switches the deployment name from *hello.war* (no profile selected) to *ROOT.war* (profile "openshift" selected).
# ASSERT: Initially I have
{code:title=<workspace>hello/.settings/org.eclipse.wst.common.component}
deploy-name="hello"
{code}.
# ASSERT: Looking at the configured modules for my server adapter I see the module being called *hello*.
# EXEC: I go project preferences > Maven and choose the "openshift" profile
# ASSERT: I see component settings being updated on disk.
{code:title=<workspace>hello/.settings/org.eclipse.wst.common.component}
deploy-name="ROOT"
{code}.
# RESULT: the configured module for my OpenShift server adapter is still called *hello*.
# ASSERT: the configured module for my OpenShift server adapter should be called *hello(ROOT)*.
# EXEC: If I now go to some project property which updates the maven config (ex. Web Content Settings) and hit "Apply and Close"
# RESULT: The available modules for my OpenShift Server adapter are updated, the configured module is now updated and called *hello(ROOT)*
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months