[JBoss JIRA] (JBIDE-26164) internal packages are a mess
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26164?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-26164:
-------------------------------------
Fix Version/s: 4.9.0.AM1
(was: 4.9.x)
> internal packages are a mess
> ----------------------------
>
> Key: JBIDE-26164
> URL: https://issues.jboss.org/browse/JBIDE-26164
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.6.0.AM3
> Reporter: Andre Dietisheim
> Priority: Minor
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-07-04-15-42-01-395.png
>
>
> Our package structure is a mess, especially internal ones are wrong.
> Ex. org.jboss.tools.openshift ui:
> There are 2 internal packages:
> * org.jboss.tools.openshift.internal.ui
> * org.jboss.tools.openshift.ui.internal
> !image-2018-07-04-15-42-01-395.png!
> Internal packages have to follow the base component name, which in our case is org.jboss.tools.openshift:
> * org.jboss.tools.openshift.internal.ui: *{color:green}CORRECT{color}*
> * org.jboss.tools.openshift.ui.internal: *{color:red}WRONG{color}*
> For the background:
> * https://wiki.eclipse.org/Naming_Conventions#Internal_Implementation_Packages:
> {quote}
> All implementation packages should be flagged as internal, with the tag occurring just after the major package name
> {quote}
> * http://wiki.eclipse.org/Naming_Conventions#Java_Packages
> {quote}
> org.eclipse.jdt.internal.core.compiler - Correct usage
> org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow project name.
> org.eclipse.core.internal.resources - Correct usage
> org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
> org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBDS-4718) Fuse new project wizard makes a pom that doesn't work for everyone
by Rick Wagner (JIRA)
Rick Wagner created JBDS-4718:
---------------------------------
Summary: Fuse new project wizard makes a pom that doesn't work for everyone
Key: JBDS-4718
URL: https://issues.jboss.org/browse/JBDS-4718
Project: Red Hat JBoss Developer Studio (devstudio)
Issue Type: Bug
Components: fusetools
Affects Versions: 12.0.0.GA
Reporter: Rick Wagner
The user reports:
----------------------------------------------------------------------------------------------
The pom file generated by the Fuse integration wizard creates pom file with a list of repositories, the one listed below is not accessible, it gets the error message Host Not Found
<repository>
<id>eap-7.1-early-access-repository</id>
<url>http://download.eng.bos.redhat.com/brewroot/repos/jb-eap-7.1-rhel-7-maven...</url>
</repository>
----------------------------------------------------------------------------------------------------------
Note: This URL works for me, but I'm on the Red Hat VPN, it might be an access issue.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26223) Server adapter: Error occurred during starting server adapter for nodejs app, oc 3.11 (alpha)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26223?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-26223 at 7/20/18 10:11 AM:
--------------------------------------------------------------------
[~odockal] I have this issue from time to time for quite some time now. Does this really only occur to you with oc >= 3.11?
It only seems to happen for me with a fully clean CDK.
Restarting the adapter then usually solves this for me (which we should - if you confirm it - indicate as workaround in this jira).
My feeling so far was that this was caused by the readyness not being properly handled so that when oc tries to sync the rsync daemon etc. on the pod are not fully ready yet.
was (Author: adietish):
[~odockal] I have this issue from time to time for quite some time now. Does this really only occurr to you with oc >= 3.11?
> Server adapter: Error occurred during starting server adapter for nodejs app, oc 3.11 (alpha)
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-26223
> URL: https://issues.jboss.org/browse/JBIDE-26223
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.9.0.AM1
> Reporter: Ondrej Dockal
> Assignee: Andre Dietisheim
> Priority: Critical
> Labels: oc_binary, rsync, server_adapter
> Fix For: 4.9.x
>
> Attachments: Screenshot_20180719_150025.png
>
>
> I have encounter rsync error during starting up server adapter while trying out https://github.com/jbosstools/jbosstools-openshift/pull/1774 together with oc 3.11 built from source.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugi... ]
Andre Dietisheim resolved JBIDE-26173.
--------------------------------------
Resolution: Done
fixed with the PR for JBIDE-25700
> Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty
> ----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26173
> URL: https://issues.jboss.org/browse/JBIDE-26173
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.6.0.Final
> Reporter: Ondrej Dockal
> Assignee: Andre Dietisheim
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-07-09-18-20-57-878.png, image-2018-07-09-18-21-13-711.png, image-2018-07-09-18-21-33-723.png, image-2018-07-09-18-24-08-509.png
>
>
> When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog.
> I suggest to not validate empty oc location.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26204) Pod Log, Port Forwarding: when using bogus oc, log console shows up empty & port forwarding isn't functioning
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26204?page=com.atlassian.jira.plugi... ]
Andre Dietisheim resolved JBIDE-26204.
--------------------------------------
Resolution: Done
fixed with the PR for JBIDE-25700
> Pod Log, Port Forwarding: when using bogus oc, log console shows up empty & port forwarding isn't functioning
> -------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26204
> URL: https://issues.jboss.org/browse/JBIDE-26204
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.6.0.Final
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.9.0.AM1
>
> Attachments: pod-log-console-empty.png, port-forwarding-stopped.png
>
>
> * Setup:
> *# ASSERT: use the code that in the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1772] for JBIDE-25700
> *# ASSERT: make sure you have an app with a pod running in OpenShift
> *# EXEC: open OpenShift preferences and point it to an oc that is a bogus executable file (that you created ex. by doing "touch oc && chmod +x oc")
> * Port Log:
> *# EXEC: in OpenShift Explorer: select the pod and pick "Pod Log..."
> *# Result:
> The "Console" view shows up but nothing happens, there's no output.
> !pod-log-console-empty.png!
> * Port Forwarding:
> *# EXEC: in OpenShift Explorer: select the pod and pick "Port Forwarding..."
> *# ASSERT: Port Forwarding wizard shows up listing the forwardable ports, the "Status" column shows them "Stopped"
> *# EXEC: hit "Start All" button
> *# Result:
> Port forwarding is not started, the "Status" column for the ports stays "Stopped"
> !port-forwarding-stopped.png!
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months