[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/20/18 2:43 PM:
-------------------------------------------------------------------
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
Looking into delta(s) that are being analyzed I see the following paths being looked at:
{code}
delta2 = ResourceDelta(/hello)
delta2 = ResourceDelta(/hello/target)
delta2 = ResourceDelta(/hello/.settings)
delta2 = ResourceDelta(/hello/.settings/org.eclipse.m2e.core.prefs)
{code}
*.settings/org.eclipse.wst.common.component*, which I clearly see being modified on this never makes it to the visitor. A listener for this file clearly is registered, so if this path would be passed it, #deltaAffectsModules would return *true*.
was (Author: adietish):
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
Looking into delta(s) that are being analyzed I see the following paths being looked at:
{code}
delta2 = ResourceDelta(/hello)
delta2 = ResourceDelta(/hello/target)
delta2 = ResourceDelta(/hello/.settings)
delta2 = ResourceDelta(/hello/.settings/org.eclipse.m2e.core.prefs)
{code}
*.settings/org.eclipse.wst.common.component*, which I clearly see being modified on this never makes it to the visitor.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/20/18 2:41 PM:
-------------------------------------------------------------------
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
Looking into delta(s) that are being analyzed I see the following paths being looked at:
delta2 = ResourceDelta(/hello)
delta2 = ResourceDelta(/hello/target)
delta2 = ResourceDelta(/hello/.settings)
delta2 = ResourceDelta(/hello/.settings/org.eclipse.m2e.core.prefs)
*.settings/org.eclipse.wst.common.component*, which I clearly see being modified on this never makes it to the visitor.
was (Author: adietish):
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
I even occurs twice upon changing the maven profile, with identical results.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/20/18 2:41 PM:
-------------------------------------------------------------------
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
Looking into delta(s) that are being analyzed I see the following paths being looked at:
{code}
delta2 = ResourceDelta(/hello)
delta2 = ResourceDelta(/hello/target)
delta2 = ResourceDelta(/hello/.settings)
delta2 = ResourceDelta(/hello/.settings/org.eclipse.m2e.core.prefs)
{code}
*.settings/org.eclipse.wst.common.component*, which I clearly see being modified on this never makes it to the visitor.
was (Author: adietish):
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
Looking into delta(s) that are being analyzed I see the following paths being looked at:
delta2 = ResourceDelta(/hello)
delta2 = ResourceDelta(/hello/target)
delta2 = ResourceDelta(/hello/.settings)
delta2 = ResourceDelta(/hello/.settings/org.eclipse.m2e.core.prefs)
*.settings/org.eclipse.wst.common.component*, which I clearly see being modified on this never makes it to the visitor.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/20/18 2:12 PM:
-------------------------------------------------------------------
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
I even occurs twice upon changing the maven profile, with identical results.
was (Author: adietish):
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26086) SSP server does not send error codes for bad requests
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26086?page=com.atlassian.jira.plugi... ]
Rob Stryker commented on JBIDE-26086:
-------------------------------------
So the general consensus is that LSP is not a subset of HTTP, so it should never send HTTP status codes back in response. It's a subset of JSON-RPC. However, the LSP specification is vague on whether content-length is required, so nobody upstream is willing to do anything unless the spec is more clear.
> SSP server does not send error codes for bad requests
> -----------------------------------------------------
>
> Key: JBIDE-26086
> URL: https://issues.jboss.org/browse/JBIDE-26086
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: stack-server-protocol
> Affects Versions: 4.6.0.AM3
> Reporter: Jan Richter
> Assignee: Rob Stryker
>
> Sending a request the server does not like produces no response, it is simply logged on the server side and the client is not notified of what happened. Something like a code 400 would be appreciated.
> For example, initiating a connection with no content-length header simply logs the following on the server side, but the client is stuck waiting.
> {noformat}java.lang.IllegalStateException: Missing header Content-Length in input "GET / HTTP/1.1
> Sec-WebSocket-Version: 13
> Sec-WebSocket-Key: 4vrbTo0+BlSk5wK7si6SWQ==
> Connection: Upgrade
> Upgrade: websocket
> Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
> Host: localhost:27511
> "
> at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:89)
> at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:95)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748){noformat}
> This is most likely a 'feature' of lsp4j, thoughts?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-25866) Schema files for WildFly 12 are missing
by Rob Stryker (JIRA)
[ https://issues.jboss.org/browse/JBIDE-25866?page=com.atlassian.jira.plugi... ]
Rob Stryker updated JBIDE-25866:
--------------------------------
Fix Version/s: 4.9.0.Final
(was: 4.9.x)
> Schema files for WildFly 12 are missing
> ---------------------------------------
>
> Key: JBIDE-25866
> URL: https://issues.jboss.org/browse/JBIDE-25866
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: server
> Affects Versions: 4.5.3.AM3
> Reporter: Martin Malina
> Assignee: Rob Stryker
> Fix For: 4.9.0.Final
>
>
> I accidentally found out that schema files that are new in WildFly 12 haven't been added to org.jboss.tools.as.catalog plugin, for instance jboss-web_12_0.xsd (I'm not sure if there are more).
> Why I found out is that I was just trying to verify and close this older JIRA:
> JBIDE-25102 Add "jboss-web-11_0.xsd" to catalog
> And since then we now have WildFly 12 too.
> So this is something to keep in mind when adding a new server adapter.
> Also, please check if this needs to be added to https://github.com/robstryker/jboss.org.schema too.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-22138 at 7/20/18 12:22 PM:
--------------------------------------------------------------------
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false:
{code}
org.eclipse.jst.jee.internal.deployables.JEEDeployableFactory@43d8512b -> false
org.eclipse.wst.web.internal.deployables.StaticWebDeployableFactory@36b4e811 -> false
org.jboss.ide.eclipse.as.core.modules.OSGiModuleFactory@6d096ef1 -> false
org.jboss.ide.eclipse.as.ui.mbeans.project.JBossSARModuleFactory@79bf112d -> false
{code}
was (Author: adietish):
[~rob.stryker] ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false upon changing the maven profile for the project even though the maven profile would change the warName.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-22138:
------------------------------------------
[~rob.stryker] ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it returns false upon changing the maven profile for the project even though the maven profile would change the warName.
> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
> Key: JBIDE-22138
> URL: https://issues.jboss.org/browse/JBIDE-22138
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
> Reporter: Rafael Benevides
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello... (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift"
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months
[JBoss JIRA] (JBIDE-26164) internal packages are a mess
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-26164?page=com.atlassian.jira.plugi... ]
Andre Dietisheim reassigned JBIDE-26164:
----------------------------------------
Assignee: Andre Dietisheim
> internal packages are a mess
> ----------------------------
>
> Key: JBIDE-26164
> URL: https://issues.jboss.org/browse/JBIDE-26164
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.6.0.AM3
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Minor
> Fix For: 4.9.0.AM1
>
> Attachments: image-2018-07-04-15-42-01-395.png
>
>
> Our package structure is a mess, especially internal ones are wrong.
> Ex. org.jboss.tools.openshift ui:
> There are 2 internal packages:
> * org.jboss.tools.openshift.internal.ui
> * org.jboss.tools.openshift.ui.internal
> !image-2018-07-04-15-42-01-395.png!
> Internal packages have to follow the base component name, which in our case is org.jboss.tools.openshift:
> * org.jboss.tools.openshift.internal.ui: *{color:green}CORRECT{color}*
> * org.jboss.tools.openshift.ui.internal: *{color:red}WRONG{color}*
> For the background:
> * https://wiki.eclipse.org/Naming_Conventions#Internal_Implementation_Packages:
> {quote}
> All implementation packages should be flagged as internal, with the tag occurring just after the major package name
> {quote}
> * http://wiki.eclipse.org/Naming_Conventions#Java_Packages
> {quote}
> org.eclipse.jdt.internal.core.compiler - Correct usage
> org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow project name.
> org.eclipse.core.internal.resources - Correct usage
> org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
> org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 8 months