[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Thomas Jonsson commented on JBIDE-3874: --------------------------------------- Does this issue cover the problems of deploying an EAR to the JBoss AS (using m2eclipse import project function)? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3874: -------------------------------------- Maven integration proposal: 1) creating an integration feature and plugin (org.jboss.tools.maven) that would depend on m2eclipse The plugin would have a wtp facet (M2 facet) that would add maven artifacts to a project(s). If Ganymede compatibility wouldn't be required for the Maven integration, we could integrate the M2 facet with a library provider framework (https://bugs.eclipse.org/bugs/show_bug.cgi?id=246448). We could add Maven library providers to the existing WTP facets (JSF, JPA...) in this way. The M2 facet would add the Maven nature, builder, Maven classpath and the pom.xml file to a web project(s) The plugin would contain pom.xml templates for different projects and versions (Seam 1.2, 2.x, Portlet 1.0, 2.0, web services...). 2) if the user has the integration plugin (and m2eclipse) installed, the Seam Project wizard would have the M2 facet enabled. Seam install delegates would check for the existence of the M2 facet. If it exists, Seam libraries wouldn't be copied. Maven parent project would also be created similarly to the mavenized Seam examples. 3) the Portlet facets (and, maybe, Web Services facet) would also check for the existence of the M2 facet and add their dependencies to the pom.xml. I suppose that the ESB wizard could have the "mavenized" option that would serve to add the M2 facet to the ESB project. Re the BIRT facet, currently there is no any Maven repository that contains newer BIRT distributions (2.3, 2.5). 4) if the M2 facet would be added using the New Web Dynamic project wizard, it would add the Maven builder, nature, classpath and a simple pom.xml. Other facets would add their dependencies to the pom.xml. 5) if the M2 facet would be added to an existing Web project, the user would get a list of libraries and classpath containers that could be removed. 6) if the M2 facet would be removed from the project, the Maven nature, builder and classpath would be removed, but the user would have to add required classpaths and libraries. PS m2eclipse plugins don't contain compile errors in Galileo. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Max, you are absolutely correct. More over, if you'll be using custom facets, the m2eclipse won't be able to transparently configure standard WTP facets and natures and project can have issues with classpath for unit tests, runtime and cross project dpeendencies at the compile time. It already handles the standard WTP projects out of the box, so you may not need to add anything special. Though you could perhaps add some custom natures/facets if pom.xml declares dependencies on something like Seam. Please also note that using the m2eclipse project configuration framework will give you an additional advantage in the future, e.g. provide functionality to update pom.xml from the Eclipse project configuration. So, I strongly advise to look at m2eclipse extension points for project configuration and its use cases [1], but if you find any limitations, the project configuration framework can be extended. One area for improvement is perhaps to provide a better support for the faceted project wizard (currently we recommend to use "Maven Project" wizard instead), see for example [2]. [1] http://docs.codehaus.org/display/M2ECLIPSE/Extension+Points+and+API#Exten... [2] http://docs.codehaus.org/display/M2ECLIPSE/WTP+mini+howto -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Snjezana, the m2eclipse currently does not support the custom wizards. However you can create an appropriate pom.xml for the project created by your wizard and then call m2eclipse API to configure it for Maven support, so it will take care of adding builders, natures as well as other facets. Also, if you may not be able to use multiple classpath containers configured by some facets together with Maven integration (because classpath is managed by Maven and those classes need to be in the pom.xml, so one can build project from the command line). Please also note that creating new project is not the only scenario when you need to configure project. We have list of use cases on the wiki page for configuration framework. For example, one could try to import an existing Maven project from local file system or checkout from the version control and in this case you will have to plug into the project configuration framework, so m2eclipse will delegate to your custom project configurator to enable functionality specific to jboss tools. I should also say that currently the faceted framework is only supported in Eclipse configuration that has the WTP, but there is configurations that may not have WTP pieces (and may not even require JDT), so we had to make the project configuration framework in m2eclipse more generic. So, Maven support is somewhat orthogonal to facets. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Max, you can certainly try the maven facet like that and maybe even contribute it back to m2eclipse, though I don't have complete understanding how such facet is going to work. As far as I understand, facets should not be creating resources (including pom.xml), so it is job for your custom wizards. Then after those resources are created you can call m2eclipse API to enable Maven support on the newly created project. It is all in the IProjectConfigurationManager that you can get using MavenPlugin.getProjectConfigurationManager() call. You can use updateProjectConfiguration(..) or createSimpleProject(..) calls to update or create project with Maven support enabled, those call will delegate to the configuration framework where your custom configurator could kick in. I can provide you more pointers how these api calls are used if you like. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3874: -------------------------------------------- as far as I understand it maven-eclipse-plugin is evil - it makes *everything* controlled from maven which is not what we want. m2eclipse's integreation hooks allows much smoother coexistence as far as I can see. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- I won't refer to maven-eclipse-plugin as evil, however it gives much less flexibility when configuring ide tools. Basically you can't use any tool API (jdt, ajdt, wtp) and have to rely to the textual configs and hope that Eclipse will pickup your changes upon refresh. More over, it also requite quite a bit of code duplication and even referse engineering of config files. So, number of things is just not possible when you are outside of Eclipse workbench. Snjezana, it is true that wtp facets can be added or removed, especially if you are using the standard WTP wizard to create a faceted project. Though you still have to generate the Maven's pom.xml and it would be a bad idea to do that upon facet activation. Also, if you have your own custom wizards for jboss, it might be better to just call m2eclipse api after you generated pom.xml, this way you should be also compatible with old and new wtp versions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3874: -------------------------------------------- Snjezana, I don't belive we can support Seam 1.2 with this, and possible not even Seam 2. It was only in Seam 2.1 there is 'true' maven support. For Seam 1.2 and Seam 2.0 the only usage of maven would be to fetch libraries but that is a different usecase I believe - at least it is two different workflows... This is for JBT 3.1 and here Ganymede compability is not an issue. Using the library framework would be ok. About the "New Maven Project" then Ill need to look again, but last time it seem to be hard to adjust with respect to adding additonal UI for specific seam questions..or am I wrong about that ? p.s. Seam is just our primary use case - we should try and get everything *compatible* with Maven, but not be a requirement for users....possible ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Max, when creating new project from the archetype, the "New Maven project" wizard supports properties declared in the archetype. Those are simple string properties that you can declare and then use in templates within the archetype. If you need a more advanced UI, an extension point can be added that would allow to contribute custom wizard pages for selected archetypes. Such page would have to set the archetype properties, since it is the only mechanism supported by archetype core component for passing parameters to the archetype. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Snjezana Peco reassigned JBIDE-3874: ------------------------------------ Assignee: Snjezana Peco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3874: -------------------------------------------- Great - what is the necessary steps to try this out ? install m2eclipse and it will just work or more to it ? Got a movie ? :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Very nice. To complete integration I also recommend to make sure that generated projects can be build from the command line, i.e. using "mvn clean install". Also, a complete of the m2eclipse integration should include the following: * projects should stay intact after invoking Maven / Update project configuration action * after deleting them from the workspace and importing using "File / Import... / Import Maven projects" wizard same projects should still work -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Max, I would leave the implementation details for "update project configuration action" out (you will have to go to the m2eclipse mailing list to get the recent updates). From the user point of view this action should bring Eclipse project configuration up to the level with pom.xml, e.g. when pom.xml been changed the Eclipse project configuration may need to be updated. But you are correct that the same mechanisms are used by the Maven project import wizard (including checkout from version control and project materialization based on the Maven coordinates). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3874: -------------------------------------- The M2 facet page enables a user to add the following maven properties: groupId, artifactId, version, packaging, name and description If the project contains the Seam facet, the user can choose a maven version of Seam - 2.1.1.GA is the default for the Seam facet 2.1 and 2.0.2.SP1 for the Seam facet 2.0. The user can also decide whether to remove WTP classpath containers (where the path starts with org.eclipse.jst) possible names) In case of a Seam project, packaging is related to a web project and needs to be war - we can disable this field. The M2 facet recognizes that the project contains the Seam facet and enables the user to choose a Seam version. As to JSF, I am planning to add an extension point that would use WTP 3.1 Library Framework and provide contributions that would add dependencies to the M2 classpath container. Some facet would be able to use that extension point. The Seam project wizard is specific and is not easy to contribute in the Seam facet. The Seam facet doesn't use the WTP Library framework, but copies libraries from a Seam distribution. I have changed the wizard so that libraries aren't copied, but added to the M2 classpath container within the post install delegate. Post install delegate because we need to know properties of the Seam facet and JBoss Maven facet when adding these libraries to the M2 classpath container. The current Seam wizard is minimally changed this way. Seam requires more than JSF and Seam artifacts: hibernate, drools, richfaces, facelets ... we need versions of all of these artifacts. The project can be run from the command line using maven 2.0.9 (probably 2.0.10), but can't using Run As>Maven clean/Run As>Maven install. The problem is that m2eclipse uses maven 2.1 that is not compatible with maven 2.0 As to Maven > Update project configuration action, it changes the project. For example, if there is the following configuration within the WAR project : <plugin> <artifactId>maven-war-plugin</artifactId> <configuration> <webappDirectory>${basedir}/WebContent</webappDirectory> <warSourceDirectory>${basedir}/WebContent</warSourceDirectory> </configuration> </plugin> Update project configuration will unecessary create a directory that will depend on the workspace (something similar as <workspace>/WebContent). This is a bug in m2eclipse because the Update project configuration action doesn't check if the URL is in the workspace, but treats it relative to the workspace. See https://jira.jboss.org/jira/browse/JBIDE-4413 There is also a problem to ensure the Import Maven Project action to work correctly. Namely, the root directory of the EAR project is EarContent. maven-ear-plugin (>=2.3) doesn't allow changing the resource directory. In order to fix the project to run from the command line, I have configured EarContent as the source directory and src/main/application (the default resource directory of maven-ear-plugin) as the output directory of the Eclipse project . Eclipse deploying, m2eclipse EAR configurator as well as mvn commands from the command line work correctly this way. However, Import Maven projects probably won't import the EarContent directory, WTP settings, Seam settings... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3874: -------------------------------------- If the Seam facet doesn't exist, the Seam Maven Version field doesn't exist. Attached is a screenshot when using the default Dynamic Web Module (containing Java and Web Module facet). This has been done in the way that the o.j.t.maven.core/ui plugins don't depend on Seam. I have planned to create an ext.point that would allow contributing Maven dependencies to the existing WTP facets (JSF,JPT...). However, this isn't possible in the Seam facet because it creates more projects. Because of this, we have to make some changes in the Seam facet (Seam wizard, delegate) which, i think, is best to do after creating this ext. point. The Maven classpath container doesn't contain all the libraries that are contained in Server Runtime containers. That's why I added a possibility to let users to not remove WTP classpath containers. Runtimes can't be removed within a facet delegate. Can be done within the Seam project wizard. Not sure for which projects. maybe rar, sar, some utility project. This is just an additional feature that we can remove. Agree. After creating this ext. point, I will propose changes in the Seam facet/wizard. I suppose you mean build/*.pom.xml files within the Maven distribution. I just checked FP and Seam 2.1.1.GA. They seem to have all necessary info. Will use them. Not sure if maven-ear-plugin is compatible with Maven 2.1/3.0. Will check that. I will create jiras for issues I find. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Now I am confused. The Maven classpath container can contain any libraries, as long as they are declared in the pom.xml. If your project will use libraries that are not declared in the pom.xml you have a good chance that command line Maven build is not going to work for such project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- It is not really in "Maven", but in particular plugins. More over, in some cases, when you changing the defaults, you may have to reconfigure multiple plugins to get their settings intact. For example, the war source location is at: http://maven.apache.org/plugins/maven-war-plugin/war-mojo.html#warSourceD... Currently m2eclipse is missing functionality for converting settings from Eclipse projects back to pom.xml, but I hope such feature will be added in the future. The most straightforward would be to install all those artifacts to the Maven local repository or into the private Maven repository. There is a half-done wizard in m2eclipse for doing that manually, I think its backend could be used by integrators to bring all required dependencies in. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Eugene Kuleshov commented on JBIDE-3874: ---------------------------------------- Ah, that is because maven-war-plugin and maven-ear-plugin can't handle "workspace resolution" when running build from Eclipse. I was planning to patch war/ear plugins to handle it but haven't got time yet. The workaround is either disable workspace resolution for ear/war on Maven properties page in the project properties ("Run as / Maven install" and other predefined shortcuts inherit that setting), or crate explicit launch configuration using "Run as / Maven ..." and disable workpsace dependency resolution in there. Sorry, I don't have jboss ide, nor jboss sample projects, can you please attach it to a jira issue? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3874: -------------------------------------- The Run As>Maven install action works, but deploying the application to the JBoss server doesn't work if the workspace resolution is disabled (application.xml isn't created; the ejb and web module are packaged). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3874: -------------------------------------------- Disabling workspace resolution would make maven projects intolerable to work with ;( So I guess we should push for getting maven war and ear plugins fixed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3874?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-3874: -------------------------------------- The problem happens when building EAR project. Building WAR project works the same with and without the patch. I have solved the issue by disabling workspace resolution for the parent project. In this way, the Run As> Maven install action on the parent project works correctly and the application is deployed correctly. Run As> Maven install on the EAR project still doesn't work unless we disable workspace resolution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira