jbossws-cxf and try-catch blocks
by Rostislav Svoboda
Hi.
I'd like to have your feedback on 2 logging items related to jbossws-cxf and try-catch [1].
1) Usage of Exception.printStackTrace() instead of logging feature
https://github.com/jbossws/jbossws-cxf/blob/master/modules/client/src/mai...
https://github.com/jbossws/jbossws-cxf/blob/master/modules/client/src/mai...
https://github.com/jbossws/jbossws-cxf/blob/master/modules/addons/transpo...
https://github.com/jbossws/jbossws-cxf/blob/master/modules/addons/transpo...
Is there any reason to call printStackTrace() directly ? If not I can create JIRA for cleanup ++ check other jbossws-* projects.
2) // ignore in catch block
https://github.com/jbossws/jbossws-cxf/blob/master/modules/client/src/mai...
https://github.com/jbossws/jbossws-cxf/blob/master/modules/addons/transpo...
https://github.com/jbossws/jbossws-cxf/blob/master/modules/addons/transpo...
https://github.com/jbossws/jbossws-cxf/blob/master/modules/jaspi/src/main...
What about logging on trace level ? In case of UDPConduid it's catching exception on socket.send() while looping across all network interfaces ... logging at trace could potentially help when troubleshooting
What do you think about these items? Should I proceed with JIRA and other jbossws-* projects?
Thank you.
Rostislav
[1] grep -b8 catch . -R | grep -v 'modules/test' | grep -v 'Test\.java' | grep -v "\.xml" | uniq > ~/Downloads/jbossws-cxf-try-catch.txt
8 years, 7 months
- 2
- 2
Fwd: Require assistance with joda-time rebuild for JBEAP-1366
by Rostislav Svoboda
Hi.
CXF WS security part is using joda-time as transitive dependency. Do you think this rebuild thing can affect JBossWS?
In the meantime I'm trying to get ingo if the failures happen when using JDK7 jar but running on JDK8.
Rostislav
----- Forwarded Message -----
From: "Filip Kujikis" <fkujikis(a)redhat.com>
To: eap-qe(a)redhat.com
Cc: "Petr Sakar" <psakar(a)redhat.com>
Sent: Monday, May 23, 2016 10:44:34 AM
Subject: Require assistance with joda-time rebuild for JBEAP-1366
Hi QE team,
I'm currently working on a rebuild for a couple of projects concerning
JBEAP-1366 <https://issues.jboss.org/browse/JBEAP-1366> and have run into a
problem with the rebuild of joda-time (
git.app.eng.bos.redhat.com/srv/git/joda-time.git).
The problem is that there are test failures (about 20 from ~4000) when
running the maven build against JDK 1.8. The build runs successfully
against JDK 1.7. I have confirmed this with a local build against 1.7 and
1.8.
The failing tests concern unexpected formats for short timezone string
representation.
I have attached a patch for one unit test demonstrating the problem /
potential test "fix". In the first example the expected output is "BST",
but the code produces "+01:00" under JDK 1.8.
I would appreciate any advice on how to proceed with the re-build, whether
it is safe to 'correct' the unit tests as in the example I attached, or any
alternatives otherwise.
Regards,
Filip
8 years, 7 months
- 1
- 1
Experiments with LogMessage levels for jbossws/wfly
by Rostislav Svoboda
Hi.
Just sharing small experiment with counting of LogMessage for jbossws/wfly projects
grep -i @LogMessage jbossws-api jbossws-spi jbossws-common jbossws-common-tools jbossws-cxf -R | cut -d@ -f2 | sort | uniq -c | sort -n
7 LogMessage(level = INFO)
19 LogMessage(level = ERROR)
22 LogMessage(level = TRACE)
31 LogMessage(level = DEBUG)
34 LogMessage(level = WARN)
Here is Wildfly:
grep -i @LogMessage wildfly-core wildfly -R | cut -d@ -f2 | sed "s/Logger.Level.//g" | sed "s/Level.//g" | sed "s/l=/l =/g" | sort | uniq -c | sort -n
1 LogMessage(level = FATAL)
14 LogMessage(level = TRACE)
27 LogMessage(level = DEBUG)
195 LogMessage(level = INFO)
253 LogMessage(level = ERROR)
320 LogMessage(level = WARN)
WLFY vs. JBWS usage of logging levels differ a bit. Is it something to worry about ?
FYI: Raw WildFly is a bit inconsistent :)
grep -i @LogMessage wildfly -R | cut -d@ -f2 | sort | uniq -c | sort -n
1 LogMessage(level = FATAL)
1 LogMessage(level= Logger.Level.INFO)
2 LogMessage(level = Logger.Level.DEBUG)
2 LogMessage(level= Logger.Level.ERROR)
3 LogMessage(level = Level.ERROR)
3 LogMessage(level = Level.INFO)
3 LogMessage(level = Logger.Level.INFO)
4 LogMessage(level = Level.WARN)
5 LogMessage(level = Logger.Level.ERROR)
10 LogMessage(level = Logger.Level.WARN)
14 LogMessage(level = TRACE)
23 LogMessage(level = DEBUG)
92 LogMessage(level = INFO)
118 LogMessage(level = ERROR)
164 LogMessage(level = WARN)
grep -i @LogMessage wildfly-core -R | cut -d@ -f2 | sort | uniq -c | sort -n
1 LogMessage(level = Level.DEBUG)
1 LogMessage(level = Logger.Level.DEBUG)
2 LogMessage(level = Logger.Level.INFO)
3 LogMessage(level = Logger.Level.ERROR)
10 LogMessage(level = Logger.Level.WARN)
33 LogMessage(level = Level.WARN)
34 LogMessage(level = Level.ERROR)
36 LogMessage(level = Level.INFO)
58 LogMessage(level = INFO)
88 LogMessage(level = ERROR)
99 LogMessage(level = WARN)
Rostislav
8 years, 7 months
- 1
- 0
- ← Newer
- 1
- Older →