[JBoss JIRA] Created: (RF-8177) rf-demo ftest - patch Wait.until() method to test conditions on the start of the loop
by Lukas Fryc (JIRA)
rf-demo ftest - patch Wait.until() method to test conditions on the start of the loop
-------------------------------------------------------------------------------------
Key: RF-8177
URL: https://jira.jboss.org/jira/browse/RF-8177
Project: RichFaces
Issue Type: Task
Security Level: Public (Everyone can see)
Components: functional-tests, QA-environment
Reporter: Lukas Fryc
Assignee: Lukas Fryc
Use following patch after solving related issues - some tests needs to be modifies (mainly widely used abstractTestSource()):
Index: src/main/java/org/jboss/test/selenium/waiting/Wait.java
===================================================================
--- src/main/java/org/jboss/test/selenium/waiting/Wait.java (revision 16033)
+++ src/main/java/org/jboss/test/selenium/waiting/Wait.java (revision 16037)
@@ -373,8 +373,28 @@
}
/**
- * Stars loop waiting to satisfy condition.
+ * <p>Stars loop waiting to satisfy condition.</p>
*
+ * <p>The condition will be tested</p>
+ *
+ * <ul>
+ * <li>on the start,</li>
+ * <li>every time interval after last try</li>
+ * <li>and also once after timeout when finishes interval since last try before timeout.</li>
+ * </ul>
+ *
+ * <p>Scheme:</p>
+ *
+ * <p><pre>S ..int.. T ..int.. T ..int1..timeout..int2.. L</pre></p>
+ *
+ * <p>
+ * <div>S - starting try</div>
+ * <div>T - try within intervals</div>
+ * <div>L - last try after timeout</div>
+ * <div>int - one interval</div>
+ * <div>int = int1 + int2</div>
+ * </p>
+ *
* @param condition
* what wait for to be satisfied
*/
@@ -382,13 +402,17 @@
long start = System.currentTimeMillis();
long end = start + timeout;
while (System.currentTimeMillis() < end) {
+ if (condition.isTrue())
+ return;
try {
Thread.sleep(interval);
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
- if (condition.isTrue())
- return;
+ if (System.currentTimeMillis() >= end) {
+ if (condition.isTrue())
+ return;
+ }
}
fail();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 10 months
[JBoss JIRA] Created: (RF-6473) fileUpload allowFlash="true" not working when inside modalPanel, in IE6
by Daniel Wiell (JIRA)
fileUpload allowFlash="true" not working when inside modalPanel, in IE6
-----------------------------------------------------------------------
Key: RF-6473
URL: https://jira.jboss.org/jira/browse/RF-6473
Project: RichFaces
Issue Type: Bug
Affects Versions: 3.3.0
Environment: RichFaces 3.3.0.GA, JSF 1.2_12, Seam 2.1.1.GA, Tomcat 5.5.26, Windows XP
Reporter: Daniel Wiell
fileUpload allowFlash="true" not working when inside modalPanel, in IE6
When using IE6, the actual upload "hangs" right away. It works fine with Firefox 3 and Chrome.
Note that this is not the same issue as RF-4480, where the button of the file upload didn't open the file dialog window.
Here is a snippet to recreate it:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:rich="http://richfaces.org/rich"
xmlns:a4j="http://richfaces.org/a4j"
xmlns:f="http://java.sun.com/jsf/core"
xmlns:h="http://java.sun.com/jsf/html">
<head>
<meta http-equiv="Content-Type" content="text/xhtml; charset=UTF-8"/>
<title>File upload</title>
</head>
<body>
<rich:modalPanel id="panel" width="350" autosized="true">
<f:facet name="controls">
<h:panelGroup>
<h:outputText id="hidelink" value="close"/>
<rich:componentControl for="panel" attachTo="hidelink" operation="hide" event="onclick"/>
</h:panelGroup>
</f:facet>
<h:form>
<rich:fileUpload allowFlash="true" fileUploadListener="#{test.onUpload}"/>
</h:form>
</rich:modalPanel>
<h:outputLink value="#" id="link">
Show Modal Panel
<rich:componentControl for="panel" attachTo="link" operation="show" event="onclick"/>
</h:outputLink>
<br/>
</body>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 11 months