[JBoss JIRA] Created: (RF-7922) RenderPhaseDataScrollerVisitor does not work with Tomahawk AliasBean Component
by Mirko Sertic (JIRA)
RenderPhaseDataScrollerVisitor does not work with Tomahawk AliasBean Component
------------------------------------------------------------------------------
Key: RF-7922
URL: https://jira.jboss.org/jira/browse/RF-7922
Project: RichFaces
Issue Type: Bug
Components: component-tables
Affects Versions: 3.3.1
Reporter: Mirko Sertic
The default RenderPhaseDataScrollerVisitor does not work with the Tomahawk AliasBean Component.
Basically, it is invoked by a PhaseListener. It recomputes the model size of the bound UIData and does some other stuff. And here starts the problem. When i use a t:aliasBean to define the datamodel for the UIData, it does not work, as the aliasBean component sets and unsets the alias during its lifecycle processing.
Now, the RenderPhaseDataScrollerVisitor is invoked before the aliasBean can do its job. An empty DataModel is created and put to the modelmap. Later, aliasBean does it work, and the UIData tries to render. Instead of asking again for the datamodel, it uses the empty model from the modelmap, and thus the table is empty.
I know that it is somehow difficult to support every component, but at least it should be supported to disable the RenderPhaseDataScrollerVisitor in some way, or provide my own implementation for it
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (RF-7986) inplaceSelect: allows String value only without specifying converter.
by Ilya Shaikovsky (JIRA)
inplaceSelect: allows String value only without specifying converter.
---------------------------------------------------------------------
Key: RF-7986
URL: https://jira.jboss.org/jira/browse/RF-7986
Project: RichFaces
Issue Type: Bug
Components: component-input
Affects Versions: 3.3.2.GA
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Fix For: Future
should allow the same value bindings as standard selectOne.
<rich:inplaceSelect value="#{inplaceComponentsBean.inputValue}"
defaultLabel="Click here to edit">
<f:selectItem itemValue="0" itemLabel="Option 1" />
<f:selectItem itemValue="1" itemLabel="Option 2" />
<f:selectItem itemValue="2" itemLabel="Option 3" />
<f:selectItem itemValue="3" itemLabel="Option 4" />
<f:selectItem itemValue="4" itemLabel="Option 5" />
</rich:inplaceSelect>
<h:selectOneMenu value="#{inplaceComponentsBean.inputValue}"
>
<f:selectItem itemValue="0" itemLabel="Option 1" />
<f:selectItem itemValue="1" itemLabel="Option 2" />
<f:selectItem itemValue="2" itemLabel="Option 3" />
<f:selectItem itemValue="3" itemLabel="Option 4" />
<f:selectItem itemValue="4" itemLabel="Option 5" />
</h:selectOneMenu>
where value - int works differently but should works int the same way.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (RF-7431) extendedDataTable: menu icon is displayed in wrong place in firefox, if header or caption facet is defined
by Vadim Mikovoz (JIRA)
extendedDataTable: menu icon is displayed in wrong place in firefox, if header or caption facet is defined
----------------------------------------------------------------------------------------------------------
Key: RF-7431
URL: https://jira.jboss.org/jira/browse/RF-7431
Project: RichFaces
Issue Type: Bug
Components: component-tables
Affects Versions: 3.3.2.CR1
Environment: v.3.3.2-SNAPSHOT
firefox 3.0
Reporter: Vadim Mikovoz
Assignee: Nick Belaevski
<rich:extendedDataTable id="myExtendedDataTableID"
value="#{dataScroller.dataTable}" var="dT">
<f:facet name="caption">
<h:outputText value="My caption" />
</f:facet>
<rich:column label="first column">
<f:facet name="header">
<h:outputText value="first" />
</f:facet>
<h:outputText value="#{dT.str0}" />
</rich:column>
<rich:column label="second column">
<f:facet name="header">
<h:outputText value="second" />
</f:facet>
<h:outputText value="#{dT.int0}" />
</rich:column>
</rich:extendedDataTable>
1. Open test page
2. Move mouse over any column header
-------------------------------------------------------
menu icon is appeared on caption (see attachment)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (RF-8262) Unnecessary filtering of fields in a Richfaces DataTable
by Sebastian Rueber (JIRA)
Unnecessary filtering of fields in a Richfaces DataTable
--------------------------------------------------------
Key: RF-8262
URL: https://jira.jboss.org/jira/browse/RF-8262
Project: RichFaces
Issue Type: Patch
Security Level: Public (Everyone can see)
Components: component, component-ScrollableDataTable, component-tables
Reporter: Sebastian Rueber
This patch is a solution for the DataTable problem, when using the internal filter.
e.g.:
<rich:dataTable value="${bean.listDataModel}" var="row">
<rich:column filterBy="row.name" />
reason for this problem is the class org.richfaces.model.ModifiableModel with its method filter(...)
the method filter(...) always calculates the filterBy value for all cells and rows in the table, which has the
filter expression.
example:
500 rows and 7 columns leads to 3500 calculations. it depends on how complex the expressions are, but it
may take a while.
in some cases the expressions are calculated unnecessary.
example 1: empty filter fields
if the user has not entered any filter expressions in fields with a filter attribute, for example if the table is rendered initialy.
calculated expressions 3500
needed expressions 0
example 2: shortcut evaluation
the filter fields are linked by an AND logical operator. that means, if you have 7 fields and the first does not match,
the remaining 6 field should not be evaluated.
calculated expressions 3500
needed expressions 3500 - x
in our application we are using our own table model, but i would like to contribute some code, which may give you
an idea, how to fix this quickly.
solution code for filter method
@Override
protected List<Object> filter(List<FilterField> aFilterFields) {
List<Object> filteredCollection = new ArrayList<Object>();
ExpressionFactory tempFactory = new ExpressionFactory(FacesContext.getCurrentInstance(), var, aFilterFields);
for (Object temp : rowKeys) {
Integer tempKey = (Integer) temp;
Sample tempSample = data.get(tempKey);
if (accept(tempSample, aFilterFields, tempFactory)) {
filteredCollection.add(tempKey);
}
}
rowKeys = filteredCollection;
return rowKeys;
}
public boolean accept(Sample aSample, List<FilterField> aFilterList, ExpressionFactory aFactory) {
for (FilterField filterField : aFilterList) {
if (filterField instanceof ExtendedFilterField) {
String filterValue = ((ExtendedFilterField) filterField).getFilterValue();
if (filterValue != null) {
filterValue = filterValue.trim().toUpperCase(locale);
if (filterValue.length() > 0) {
// delayed until here, were it is really needed
Object property = aFactory.eval(filterField.getExpression(), aSample);
if (property == null || !property.toString().trim().toUpperCase(locale).startsWith(filterValue)) {
return false;
}
}
}
} else {
Object property = aFactory.eval(filterField.getExpression(), aSample);
if (!((Boolean) property).booleanValue()) {
return false;
}
}
}
return true;
}
solution code for the ExpressionFactory
package org.richfaces.model.impl.expressive;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import javax.el.ELContext;
import javax.el.ELResolver;
import javax.el.MethodExpression;
import javax.el.ValueExpression;
import javax.faces.application.Application;
import javax.faces.component.UIViewRoot;
import javax.faces.context.FacesContext;
import org.richfaces.model.Field;
public class ExpressionFactory {
private Map<javax.el.Expression, Expression> expressionMap;
public ExpressionFactory(FacesContext context, final String var, List<? extends Field> sortOrder) {
Application application = context.getApplication();
ELResolver resolver = application.getELResolver();
ELContext elContext = context.getELContext();
expressionMap = new HashMap<javax.el.Expression, Expression>();
for (Field field : sortOrder) {
javax.el.Expression elExpression = field.getExpression();
Expression expression;
if (elExpression instanceof ValueExpression) {
ValueExpression valueExpression = (ValueExpression) elExpression;
if (valueExpression.isLiteralText()) {
String expressionString = valueExpression.getExpressionString();
if (expressionString.startsWith(UIViewRoot.UNIQUE_ID_PREFIX)) {
expression = new NullExpression(expressionString);
} else {
expression = new SimplePropertyExpression(expressionString, elContext, resolver);
}
} else {
expression = new ValueBindingExpression(context, valueExpression, var);
}
} else if (elExpression instanceof MethodExpression) {
expression = new MethodBindingExpression(context, (MethodExpression) elExpression);
} else {
throw new IllegalArgumentException();
}
expressionMap.put(elExpression, expression);
}
}
public Object eval(javax.el.Expression anExpression, Object anObject) {
return expressionMap.get(anExpression).evaluate(anObject);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month
[JBoss JIRA] Created: (RF-7916) Javascript error when having non escaped apostrophe in rich:calendar labels
by Julien Kronegg (JIRA)
Javascript error when having non escaped apostrophe in rich:calendar labels
---------------------------------------------------------------------------
Key: RF-7916
URL: https://jira.jboss.org/jira/browse/RF-7916
Project: RichFaces
Issue Type: Bug
Components: component-output
Affects Versions: 3.3.0
Environment: Seam 2.1.2, Richfaces 3.3.0
Reporter: Julien Kronegg
Priority: Minor
Richfaces Calendar labels can be translated/i18n by adding the following properties in the resource bundle (e.g. messages.properties):
RICH_CALENDAR_TODAY_LABEL
RICH_CALENDAR_CLEAN_LABEL
RICH_CALENDAR_APPLY_LABEL
RICH_CALENDAR_CLOSE_LABEL
RICH_CALENDAR_OK_LABEL
RICH_CALENDAR_CANCEL_LABEL
The problem is that a Javascript error occurs when the property value contain a non escaped apostrophe ('), for example with RICH_CALENDAR_TODAY_LABEL=Aujourd'hui (french label for today):
Error: missing } after property list
Source Code: labels:{apply:'Appliquer', today:'Aujourd'hui', clean:'Effacer', cancel:'Annuler', ok:'Ok', close:'X'},
Richfaces should escape automatically unescaped apostrophes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 1 month