December 2012 - richfaces-issues - Jboss List Archives

[JBoss JIRA] (RF-12303) Custom topiclistener not working on richfaces push component of verion 4.2.2-Final and older

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-12303?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč reassigned RF-12303: ------------------------------- Assignee: Lukáš Fryč > Custom topiclistener not working on richfaces push component of verion 4.2.2-Final and older > -------------------------------------------------------------------------------------------- > > Key: RF-12303 > URL: https://issues.jboss.org/browse/RF-12303 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core, component-push/poll > Affects Versions: 4.2.2.Final > Environment: No deponds on what environment. > Reporter: Daniel Yang > Assignee: Lukáš Fryč > Labels: push, richfaces > Fix For: 4.3.0.M3 > > Original Estimate: 15 minutes > Remaining Estimate: 15 minutes > > See description here: > https://community.jboss.org/message/736651#736651 > Copy it again: > I use it like following lines: > > {code:java} > TopicsContext topicsContext = TopicsContext.lookup(); > Topic topic = topicsContext.getOrCreateTopic(new TopicKey("test")); > topic.setMessageDataSerializer(DefaultMessageDataSerializer.instance()); > topic.addTopicListener(new SessionTopicListener2() { > @Override > public void processPreSubscriptionEvent(SessionPreSubscriptionEvent event) throws SubscriptionFailureException { > //TODO > } > @Override > public void processSubscriptionEvent(SessionSubscriptionEvent event) { > //TODO > } > @Override > public void processUnsubscriptionEvent(SessionUnsubscriptionEvent event) { > //TODO > } > }); > {code} > > I noted that listeners in TopicImpl are all the SessionTopicListener2 type, because add method is: > {code:java} > public void addTopicListener(TopicListener topicListener) { > TopicListener listener = topicListener; > if (listener instanceof SessionTopicListener) { > listener = new SessionTopicListenerWrapper((SessionTopicListener) listener); > } > listeners.add(listener); > } > {code} > > > All SessionTopicListeners are wrapped to type SessionTopicListener2, and when event publish in TopicImpl, it check it if it is appropriate listener like this: > > {code:java} > public void publishEvent(TopicEvent event) { > for (TopicListener listener : listeners) { > if (event.isAppropriateListener(listener)) { > try { > event.invokeListener(listener); > } catch (Exception e) { > logError(e); > } > } > } > } > {code} > > But event type SessionPreSubscriptionEvent, SessionSubscriptionEvent or SessionUnsubscriptionEvent does not override the mothed isAppropriateListener, so when checking, it use the method of its parent SessionTopicEvent, its parent method is like this: > {code:java} > > @Override > public boolean isAppropriateListener(EventListener listener) { > return (listener instanceof SessionTopicListener); > } > {code} > > Then it always returns false for above three SessionTopicEvent , and the custom listeners will never be called. I think it may be changed from " return (listener instanceof SessionTopicListener);" to return (listener instanceof SessionTopicListener2); or override it in seperator implementation of type SessionTopicEvent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12635) jsf-test changes caused unit test failures

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-12635?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-12635: --------------------------------- Thanks Pavol, merged to {{develop}} > jsf-test changes caused unit test failures > ------------------------------------------ > > Key: RF-12635 > URL: https://issues.jboss.org/browse/RF-12635 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: tests - unit > Affects Versions: 4.3.0.M3 > Environment: java-1.7.0-openjdk.x86_64 > apache-maven-3.0.4 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 4.3.0.M3 > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12635) jsf-test changes caused unit test failures

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-12635?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč resolved RF-12635. ----------------------------- Resolution: Done > jsf-test changes caused unit test failures > ------------------------------------------ > > Key: RF-12635 > URL: https://issues.jboss.org/browse/RF-12635 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: tests - unit > Affects Versions: 4.3.0.M3 > Environment: java-1.7.0-openjdk.x86_64 > apache-maven-3.0.4 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 4.3.0.M3 > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12635) jsf-test changes caused unit test failures

by Pavol Pitonak (JIRA)

[ https://issues.jboss.org/browse/RF-12635?page=com.atlassian.jira.plugin.s... ] Pavol Pitonak reassigned RF-12635: ---------------------------------- Assignee: Lukáš Fryč (was: Pavol Pitonak) > jsf-test changes caused unit test failures > ------------------------------------------ > > Key: RF-12635 > URL: https://issues.jboss.org/browse/RF-12635 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: tests - unit > Affects Versions: 4.3.0.M3 > Environment: java-1.7.0-openjdk.x86_64 > apache-maven-3.0.4 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 4.3.0.M3 > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12635) jsf-test changes caused unit test failures

by Pavol Pitonak (JIRA)

[ https://issues.jboss.org/browse/RF-12635?page=com.atlassian.jira.plugin.s... ] Pavol Pitonak commented on RF-12635: ------------------------------------ It works fine on my laptop. > jsf-test changes caused unit test failures > ------------------------------------------ > > Key: RF-12635 > URL: https://issues.jboss.org/browse/RF-12635 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: tests - unit > Affects Versions: 4.3.0.M3 > Environment: java-1.7.0-openjdk.x86_64 > apache-maven-3.0.4 > Reporter: Lukáš Fryč > Assignee: Pavol Pitonak > Fix For: 4.3.0.M3 > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12175) a4j:push - adapt connection error handling code

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-12175?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12175: ------------------------------- Component/s: component-push/poll > a4j:push - adapt connection error handling code > ----------------------------------------------- > > Key: RF-12175 > URL: https://issues.jboss.org/browse/RF-12175 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: component-a4j-core, component-push/poll > Affects Versions: 4.2.1.Final > Reporter: Lukáš Fryč > Fix For: 5-Tracking > > Original Estimate: 1 day > Remaining Estimate: 1 day > > In Atmosphere 0.9.0, there is new client-side error handling code [1], > we need to check it and implement its propagation to {{onerror}} event handler on {{a4j:push}}. > This issue is tied to Atmosphere 0.9 upgrade: RF-12176. > [1] https://github.com/Atmosphere/atmosphere/issues/285 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12175) a4j:push - adapt connection error handling code

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-12175?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12175: ------------------------------- Fix Version/s: 5-Tracking (was: 4.3.0.M3) > a4j:push - adapt connection error handling code > ----------------------------------------------- > > Key: RF-12175 > URL: https://issues.jboss.org/browse/RF-12175 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.2.1.Final > Reporter: Lukáš Fryč > Fix For: 5-Tracking > > Original Estimate: 1 day > Remaining Estimate: 1 day > > In Atmosphere 0.9.0, there is new client-side error handling code [1], > we need to check it and implement its propagation to {{onerror}} event handler on {{a4j:push}}. > This issue is tied to Atmosphere 0.9 upgrade: RF-12176. > [1] https://github.com/Atmosphere/atmosphere/issues/285 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12303) Custom topiclistener not working on richfaces push component of verion 4.2.2-Final and older

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-12303?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12303: ------------------------------- Sprint: 4.3.0.M3 - EDT and AJAX > Custom topiclistener not working on richfaces push component of verion 4.2.2-Final and older > -------------------------------------------------------------------------------------------- > > Key: RF-12303 > URL: https://issues.jboss.org/browse/RF-12303 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core, component-push/poll > Affects Versions: 4.2.2.Final > Environment: No deponds on what environment. > Reporter: Daniel Yang > Labels: push, richfaces > Fix For: 4.3.0.M3 > > Original Estimate: 15 minutes > Remaining Estimate: 15 minutes > > See description here: > https://community.jboss.org/message/736651#736651 > Copy it again: > I use it like following lines: > > {code:java} > TopicsContext topicsContext = TopicsContext.lookup(); > Topic topic = topicsContext.getOrCreateTopic(new TopicKey("test")); > topic.setMessageDataSerializer(DefaultMessageDataSerializer.instance()); > topic.addTopicListener(new SessionTopicListener2() { > @Override > public void processPreSubscriptionEvent(SessionPreSubscriptionEvent event) throws SubscriptionFailureException { > //TODO > } > @Override > public void processSubscriptionEvent(SessionSubscriptionEvent event) { > //TODO > } > @Override > public void processUnsubscriptionEvent(SessionUnsubscriptionEvent event) { > //TODO > } > }); > {code} > > I noted that listeners in TopicImpl are all the SessionTopicListener2 type, because add method is: > {code:java} > public void addTopicListener(TopicListener topicListener) { > TopicListener listener = topicListener; > if (listener instanceof SessionTopicListener) { > listener = new SessionTopicListenerWrapper((SessionTopicListener) listener); > } > listeners.add(listener); > } > {code} > > > All SessionTopicListeners are wrapped to type SessionTopicListener2, and when event publish in TopicImpl, it check it if it is appropriate listener like this: > > {code:java} > public void publishEvent(TopicEvent event) { > for (TopicListener listener : listeners) { > if (event.isAppropriateListener(listener)) { > try { > event.invokeListener(listener); > } catch (Exception e) { > logError(e); > } > } > } > } > {code} > > But event type SessionPreSubscriptionEvent, SessionSubscriptionEvent or SessionUnsubscriptionEvent does not override the mothed isAppropriateListener, so when checking, it use the method of its parent SessionTopicEvent, its parent method is like this: > {code:java} > > @Override > public boolean isAppropriateListener(EventListener listener) { > return (listener instanceof SessionTopicListener); > } > {code} > > Then it always returns false for above three SessionTopicEvent , and the custom listeners will never be called. I think it may be changed from " return (listener instanceof SessionTopicListener);" to return (listener instanceof SessionTopicListener2); or override it in seperator implementation of type SessionTopicEvent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12493) Add option to not filter rich:select onlistshow

by Brian Leathem (JIRA)

[ https://issues.jboss.org/browse/RF-12493?page=com.atlassian.jira.plugin.s... ] Brian Leathem updated RF-12493: ------------------------------- Fix Version/s: 5-Tracking (was: 4.3.0.M3) > Add option to not filter rich:select onlistshow > ----------------------------------------------- > > Key: RF-12493 > URL: https://issues.jboss.org/browse/RF-12493 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: component-input > Affects Versions: 4.2.2.Final > Reporter: Bernard Labno > Priority: Minor > Labels: waiting_on_user > Fix For: 5-Tracking > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > > Currently if we want to show all options in rich:select list despite there is already some value typed in the input we have to add this: > {code} > onlistshow="this.rf.component.input.val('');this.rf.component.__updateItems()" > {code} > But this is usage of private method that may be subject on unexpected changes in future releases of RF. > Suggestion: Add an attribute to _rich:select_ that would not filter list onlistshow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-12649) Placeholder: add fundamental tests for rich Input components

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-12649?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-12649: ---------------------------- Original Estimate: 2 hours Remaining Estimate: 2 hours > Placeholder: add fundamental tests for rich Input components > ------------------------------------------------------------ > > Key: RF-12649 > URL: https://issues.jboss.org/browse/RF-12649 > Project: RichFaces > Issue Type: Enhancement > Security Level: Public(Everyone can see) > Components: tests - unit > Affects Versions: 4.3.0.M3 > Reporter: Lukáš Fryč > Assignee: Jiří Štefek > Priority: Minor > Fix For: 4.3.0.M3 > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > > Could you please extend Placeholder test suite by coverage for integration testing with following components: > * Calendar > * Autocomplete > * Select > * Inplace Input > * Inplace Select -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues December 2012