[JBoss JIRA] (RF-12671) dropTarget does not work inside dynamic tabs when switchType is ajax or server
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12671?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12671:
-------------------------------
Original Estimate: 3 hours (was: 3 minutes)
Remaining Estimate: 3 hours (was: 3 minutes)
> dropTarget does not work inside dynamic tabs when switchType is ajax or server
> ------------------------------------------------------------------------------
>
> Key: RF-12671
> URL: https://issues.jboss.org/browse/RF-12671
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.0.M3
> Reporter: Ken H
> Fix For: 4.3.0.CR1
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> The following works fine:
> {code}
> <rich:tabPanel switchType="client">
> <a4j:repeat value="#{bean.thingsToIterate}" var="thing">
> <rich:tab header="Tab #{thing}">
> <rich:panel style="width: 100px;">
> <rich:dragSource dragValue="drag-#{thing}" type="term" />
> drag #{thing}
> </rich:panel>
> <rich:panel style="width: 100px;">
> <rich:dropTarget dropValue="drop-#{thing}" acceptedTypes="term" dropListener="#{bean.processDrop}" execute="@form" render="@form" />
> drop #{thing}
> </rich:panel>
> </rich:tab>
> </a4j:repeat>
> </rich:tabPanel>
> public void processDrop(DropEvent evt) {
> log.info("processDrop called - dragVal: "+evt.getDragValue()+", dropVal: "+evt.getDropValue());
> }
> {code}
> However, changing the switch type to ajax or server results in processDrop not being called. The POST data appears to be identical.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months
[JBoss JIRA] (RF-12686) javascriptServiceComplete not defined in JavaScript
by Justin Rosenberg (JIRA)
Justin Rosenberg created RF-12686:
-------------------------------------
Summary: javascriptServiceComplete not defined in JavaScript
Key: RF-12686
URL: https://issues.jboss.org/browse/RF-12686
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 4.3.0.M3
Reporter: Justin Rosenberg
After migrating to 4.3.0.M3 I now get the following error. This causes my a4j:status onStop script to fail to execute.
Uncaught TypeError: Object #<Object> has no method 'javascriptServiceComplete'
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months
[JBoss JIRA] (RF-11112) PartialViewContext#getRenderIds() implementation returns empty set
by henk de boer (JIRA)
[ https://issues.jboss.org/browse/RF-11112?page=com.atlassian.jira.plugin.s... ]
henk de boer commented on RF-11112:
-----------------------------------
Any updates here? I think 4.1 has already been released, hasn't it? ;)
> PartialViewContext#getRenderIds() implementation returns empty set
> ------------------------------------------------------------------
>
> Key: RF-11112
> URL: https://issues.jboss.org/browse/RF-11112
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.0.0.Final
> Environment: Win7 x64, Eclipse Helios SR2, JBoss AS 6.0.0 Final, RF 4.0.0 Final.
> Reporter: Bauke Scholtz
> Assignee: Brian Leathem
> Fix For: 5-Tracking
>
>
> During invoke action phase we would like to retrieve a list of partial render IDs for some specific preprocessing (resetting submitted values for the case they're embedded in another form). Those IDs are normally available by {{PartialViewContext#getRenderIds()}}.
> {code}
> PartialViewContext partialViewContext = FacesContext.getCurrentInstance().getPartialViewContext();
> Collection<String> renderIds = partialViewContext.getRenderIds();
> {code}
> This works fine in combination with standard JSF components, such as {{<h:commandLink><f:ajax render="foo"/></h:commandLink>}} However, when a RichFaces/A4J command component is been used, such as {{<a4j:commandLink render="foo" />}}, an empty collection is been returned instead. Debugging learns that the {{ExtendedPartialViewContextImpl}} implementation stores them in {{componentRenderIds}} instead of {{renderIds}} and never returns it on {{getRenderIds()}} method. The {{ExtendedPartialViewContextImpl}} also doesn't seem to use {{renderIds}} in a sensible manner anywhere else.
> I believe that {{componentRenderIds}} really has to be {{renderIds}} instead.
> As far now, we workarounded this by accessing the {{componentRenderIds}} field using reflection.
> {code}
> Collection<String> renderIds = partialViewContext.getRenderIds();
> if (renderIds.isEmpty() && partialViewContext instanceof ExtendedPartialViewContextImpl) {
> try {
> Field componentRenderIds = ExtendedPartialViewContextImpl.class.getDeclaredField("componentRenderIds");
> componentRenderIds.setAccessible(true);
> renderIds = (Collection<String>) componentRenderIds.get(partialViewContext);
> } catch (Exception e) {
> // Handle.
> }
> }
> {code}
> However, this introduced a nasty dependency in our code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months
[JBoss JIRA] (RF-12333) "oncomplete" (seems like along with "onbeforedomupdate", "data") doesn't work when "@all" keyword specified in "render" attribute
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12333?page=com.atlassian.jira.plugin.s... ]
Brian Leathem reassigned RF-12333:
----------------------------------
Assignee: Lukáš Fryč
Is this issue now obsolete?
> "oncomplete" (seems like along with "onbeforedomupdate", "data") doesn't work when "@all" keyword specified in "render" attribute
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: RF-12333
> URL: https://issues.jboss.org/browse/RF-12333
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality , core
> Affects Versions: 4.2.0.Final, 4.2.2.Final
> Environment: no matter
> Reporter: Alexander Kiselyov
> Assignee: Lukáš Fryč
> Labels: @all, a4j, data, onbeforedomupdate, oncomplete, partial-response
> Fix For: 5-Tracking
>
>
> Although this error seems obvious, skimming the tracker didn't give me any similar issues, so I created this one.
> I had tried to use command button component in this fashion:
> <a4j:commandButton render="@all" oncomplete="someFunction()" />
> but "oncomplete" JS code didn't work. After some investigation I figured out that appropriate code hasn't even been sent from the server as an extension element of JSF's <partial-response>. Investigation of Java code showed that ExtendedPartialViewContextImpl prevents handler from being attached to the response when "@all" keyword is specified (along with beforedomupdate and data):
> org.richfaces.renderkit.AjaxConstants:
> ALL = "@all";
> <...>
> org.richfaces.context.ExtendedPartialViewContextImpl.visitActivatorAtRender(Collection<String>):
> if (!Boolean.TRUE.equals(renderAll) && !ids.contains(ALL)) {
> addImplicitRenderIds(ids, limitRender);
> appendOnbeforedomupdate(onbeforedomupdate);
> appendOncomplete(oncomplete);
> setResponseData(responseData);
> }
> These values (org.richfaces.context.ExtendedPartialViewContext.completeHandler, org.richfaces.context.ExtendedPartialViewContext.beforedomupdateHandler, org.richfaces.context.ExtendedPartialViewContext.responseData) are subsequently used by org.richfaces.renderkit.util.CoreAjaxRendererUtils.renderAjaxExtensions(FacesContext, UIComponent) to actually write extension elements of partial-response element to a user-agent.
> I think, even if it is a "feature" (very weird on, I must admit) - it at least deserves to be mentioned in RichFaces Component Reference and VDL docs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months
[JBoss JIRA] (RF-12685) Consider optimizing the extendedDataModel re-generation for DataTable components
by Brian Leathem (JIRA)
Brian Leathem created RF-12685:
----------------------------------
Summary: Consider optimizing the extendedDataModel re-generation for DataTable components
Key: RF-12685
URL: https://issues.jboss.org/browse/RF-12685
Project: RichFaces
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: component-tables, optimization
Affects Versions: 4.3.0.CR1
Reporter: Brian Leathem
Fix For: 5-Tracking
With RF-12673 we are triggering a re-generation of the extendedDataModel whenever the AbstractTableRenderer encodes a table component.
An optimisation would be to introduce triggers such that the extendedDataModel is only regenerated when required. Marking the model as dirty for instance whenever the value of a relevant attribute is changed, and then only re-generating the model prior to render when the model is marked as dirty.
Prior to investing the time in resolving this issue, we need to measure the overall performance of the EDT to determine if this is indeed a rate-determining factor. It may be that our time is better spent optimising other aspects of the DataTable component rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months