[JBoss JIRA] (RF-13301) Favor use of Page Fragments in Framework Tests
by Lukáš Fryč (JIRA)
Lukáš Fryč created RF-13301:
-------------------------------
Summary: Favor use of Page Fragments in Framework Tests
Key: RF-13301
URL: https://issues.jboss.org/browse/RF-13301
Project: RichFaces
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: tests - functional
Affects Versions: 5.0.0.Alpha2
Reporter: Lukáš Fryč
Since we have introduced Page Fragments in Alpha2, we could favor their usage in fragment tests.
We could start to refactor tests for components rewritten in Alpha2 and continue as we rewrite other components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-13300) Page Fragments: refine module dependencies
by Lukáš Fryč (JIRA)
Lukáš Fryč created RF-13300:
-------------------------------
Summary: Page Fragments: refine module dependencies
Key: RF-13300
URL: https://issues.jboss.org/browse/RF-13300
Project: RichFaces
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: page-fragments
Affects Versions: 5.0.0.Alpha2
Reporter: Lukáš Fryč
During the review, I have found out we may need to fine module dependencies:
https://github.com/richfaces/richfaces/pull/55#issuecomment-27339441
----
{code}
joda-time:2.3
- DateTime
commons-lang:2.6
- Validate.isTrue
- StringEscapeUtils.unescapeJava
json-simple:1.1.1
- JSONParser
org.jodah:typetools:0.3.0
- TypeResolver.resolveRawArguments
{code}
I'm fine with {{DateTime}}, since it's going to be standardized - even though we may consider making it optional dependency and provide alternative in form of {{java.util.Date}}.
I didn't found reason to leave {{Validate.isTrue}} - this should be replaced by more verbose but dependency free code.
I did some googling for alternatives to {{StringEscapeUtils.unescapeJava}} and found out few suggestions for dependency free Java-unescaping.
{{JSONParser}} seems to be necessary (even though we don;t use it extensively yet), but I would favor standard APIs in form of JSR-353.
I believe {{TypeResolver}} can be re-written from scratch, but since it's one-class ASL dependency, we might consider shading it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month