[JBoss JIRA] (RF-12748) Generate optimized resources for framework
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12748?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12748:
---------------------------------
Optimized resources are actually generated using maven-richfaces-resources-plugin 4.3.1.Final.
We may need to refactor this plugin out of CDK and place it into framework, but then there will be circular dependency between Framework, this plugin and optimized resources generation step.
> Generate optimized resources for framework
> ------------------------------------------
>
> Key: RF-12748
> URL: https://issues.jboss.org/browse/RF-12748
> Project: RichFaces
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 5.0.0.Alpha1
> Reporter: Lukáš Fryč
> Assignee: Lukáš Fryč
> Labels: rf5-build
> Fix For: 5.0.0.Alpha1
>
> Original Estimate: 1 hour, 30 minutes
> Remaining Estimate: 1 hour, 30 minutes
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (RF-12848) Error "source is not defined" after richfaces-jsf-event.js merge
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12848?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-12848:
----------------------------
Assignee: (was: Lukáš Fryč)
> Error "source is not defined" after richfaces-jsf-event.js merge
> ----------------------------------------------------------------
>
> Key: RF-12848
> URL: https://issues.jboss.org/browse/RF-12848
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.1
> Reporter: Torben Greiser
> Priority: Critical
> Fix For: 4.3.2, 5-Tracking
>
>
> Commit 9255380d626227d909bbcd59ea3bc604966ea5bb breaks the following jsf.ajax.request:
> {code}
> jsf.ajax.request("MyContainer:MySelectionForm", "valueChange", {});
> {code}
> In <a4j:log/> the following error is displayed:
> {code}
> richfaces.queue: ajax submit error: source is not defined
> {code}
> After inspecting richfaces.js I located the cause of the error:
> {code}
> var getFormElement = function(sourceElement) {
> if ($(sourceElement).is('form')) {
> return source;
> } else {
> return $('form').has(sourceElement).get(0);
> }
> };
> {code}
> First if-statement evaluates to true, returning source, which itself is not defined:
> {code}
> ReferenceError: source is not defined
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (RF-12848) Error "source is not defined" after richfaces-jsf-event.js merge
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12848?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12848:
---------------------------------
Hey Torben, thanks for narrowing the issue down.
Could you please also provide a real-world sample of usage - e.g. the Facelet file?
I'm trying to evaluate what are affected use cases - when forms usually triggers AJAX interaction.
> Error "source is not defined" after richfaces-jsf-event.js merge
> ----------------------------------------------------------------
>
> Key: RF-12848
> URL: https://issues.jboss.org/browse/RF-12848
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.1
> Reporter: Torben Greiser
> Assignee: Lukáš Fryč
> Priority: Critical
> Fix For: 4.3.2, 5-Tracking
>
>
> Commit 9255380d626227d909bbcd59ea3bc604966ea5bb breaks the following jsf.ajax.request:
> {code}
> jsf.ajax.request("MyContainer:MySelectionForm", "valueChange", {});
> {code}
> In <a4j:log/> the following error is displayed:
> {code}
> richfaces.queue: ajax submit error: source is not defined
> {code}
> After inspecting richfaces.js I located the cause of the error:
> {code}
> var getFormElement = function(sourceElement) {
> if ($(sourceElement).is('form')) {
> return source;
> } else {
> return $('form').has(sourceElement).get(0);
> }
> };
> {code}
> First if-statement evaluates to true, returning source, which itself is not defined:
> {code}
> ReferenceError: source is not defined
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (RF-12848) Error "source is not defined" after richfaces-jsf-event.js merge
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12848?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-12848:
----------------------------
Fix Version/s: 4.3.2
5-Tracking
> Error "source is not defined" after richfaces-jsf-event.js merge
> ----------------------------------------------------------------
>
> Key: RF-12848
> URL: https://issues.jboss.org/browse/RF-12848
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.1
> Reporter: Torben Greiser
> Assignee: Lukáš Fryč
> Fix For: 4.3.2, 5-Tracking
>
>
> Commit 9255380d626227d909bbcd59ea3bc604966ea5bb breaks the following jsf.ajax.request:
> {code}
> jsf.ajax.request("MyContainer:MySelectionForm", "valueChange", {});
> {code}
> In <a4j:log/> the following error is displayed:
> {code}
> richfaces.queue: ajax submit error: source is not defined
> {code}
> After inspecting richfaces.js I located the cause of the error:
> {code}
> var getFormElement = function(sourceElement) {
> if ($(sourceElement).is('form')) {
> return source;
> } else {
> return $('form').has(sourceElement).get(0);
> }
> };
> {code}
> First if-statement evaluates to true, returning source, which itself is not defined:
> {code}
> ReferenceError: source is not defined
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (RF-12848) Error "source is not defined" after richfaces-jsf-event.js merge
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12848?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-12848:
----------------------------
Priority: Critical (was: Major)
> Error "source is not defined" after richfaces-jsf-event.js merge
> ----------------------------------------------------------------
>
> Key: RF-12848
> URL: https://issues.jboss.org/browse/RF-12848
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.1
> Reporter: Torben Greiser
> Assignee: Lukáš Fryč
> Priority: Critical
> Fix For: 4.3.2, 5-Tracking
>
>
> Commit 9255380d626227d909bbcd59ea3bc604966ea5bb breaks the following jsf.ajax.request:
> {code}
> jsf.ajax.request("MyContainer:MySelectionForm", "valueChange", {});
> {code}
> In <a4j:log/> the following error is displayed:
> {code}
> richfaces.queue: ajax submit error: source is not defined
> {code}
> After inspecting richfaces.js I located the cause of the error:
> {code}
> var getFormElement = function(sourceElement) {
> if ($(sourceElement).is('form')) {
> return source;
> } else {
> return $('form').has(sourceElement).get(0);
> }
> };
> {code}
> First if-statement evaluates to true, returning source, which itself is not defined:
> {code}
> ReferenceError: source is not defined
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (RF-12759) rich:hotkey doesn't handle Ctrl+A key binding
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12759?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-12759:
----------------------------
Fix Version/s: 5-Tracking
> rich:hotkey doesn't handle Ctrl+A key binding
> ---------------------------------------------
>
> Key: RF-12759
> URL: https://issues.jboss.org/browse/RF-12759
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-misc
> Affects Versions: 4.2.3.Final
> Environment: Linux Fedora 16 x64, NetBeans 7.2, GlassFish 3.1.1, CDI/Weld/CODI, JSF2, RichFaces4.2.3, Hibernate3.2.5, Firebird 2.5.1
> Reporter: Edilmar Alves
> Assignee: Lukáš Fryč
> Labels: hotkey
> Fix For: 5-Tracking
>
> Attachments: test.java, test.xhtml
>
>
> When I try to use rich:hotkey with a4j:commandButton, it doesn't work. A detailed explanation about this is in the forum.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (RF-12862) Evaluate how hard it would be to migrate jsf-test for components (using HtmlUnitEnvironment) to fundamental tests
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12862?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč updated RF-12862:
----------------------------
Description:
The advantage of migrating the tests is improved debuggability.
It seems that migration of the component-specific tests is pretty straight-forward, the proof of concept was done for [{{AjaxValidationTest}}|https://github.com/richfaces/richfaces5/commit/bf0f460dada7530cfc43de7837ce98c073bbb5af#diff-8].
We need to evaluate how much of similar tests we have and if it's worth to migrate them.
was:
It seems that migration of the component-specific tests is pretty straight-forward, the proof of concept was done for [{{AjaxValidationTest}}|https://github.com/richfaces/richfaces5/commit/bf0f460dada7530cfc43de7837ce98c073bbb5af#diff-8].
We need to evaluate how much of similar tests we have and if it's worth to migrate them.
> Evaluate how hard it would be to migrate jsf-test for components (using HtmlUnitEnvironment) to fundamental tests
> -----------------------------------------------------------------------------------------------------------------
>
> Key: RF-12862
> URL: https://issues.jboss.org/browse/RF-12862
> Project: RichFaces
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: tests - functional
> Reporter: Lukáš Fryč
> Fix For: 5.0.0.Alpha1
>
>
> The advantage of migrating the tests is improved debuggability.
> It seems that migration of the component-specific tests is pretty straight-forward, the proof of concept was done for [{{AjaxValidationTest}}|https://github.com/richfaces/richfaces5/commit/bf0f460dada7530cfc43de7837ce98c073bbb5af#diff-8].
> We need to evaluate how much of similar tests we have and if it's worth to migrate them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months
[JBoss JIRA] (RF-12862) Evaluate how hard it would be to migrate jsf-test for components (using HtmlUnitEnvironment) to fundamental tests
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-12862?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-12862:
---------------------------------
No, the fun tests themselves are pretty quick, however a deployment takes time.
I'm playing with an idea of leveraging a Surefire plugin's ability to run tests in parallel.
> Evaluate how hard it would be to migrate jsf-test for components (using HtmlUnitEnvironment) to fundamental tests
> -----------------------------------------------------------------------------------------------------------------
>
> Key: RF-12862
> URL: https://issues.jboss.org/browse/RF-12862
> Project: RichFaces
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: tests - functional
> Reporter: Lukáš Fryč
> Fix For: 5.0.0.Alpha1
>
>
> The advantage of migrating the tests is improved debuggability.
> It seems that migration of the component-specific tests is pretty straight-forward, the proof of concept was done for [{{AjaxValidationTest}}|https://github.com/richfaces/richfaces5/commit/bf0f460dada7530cfc43de7837ce98c073bbb5af#diff-8].
> We need to evaluate how much of similar tests we have and if it's worth to migrate them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 8 months