[JBoss JIRA] (RF-12936) Use jQuery in non-conflicting way
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12936?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12936:
-------------------------------
Original Estimate: 1 hour
Remaining Estimate: 1 hour
> Use jQuery in non-conflicting way
> ---------------------------------
>
> Key: RF-12936
> URL: https://issues.jboss.org/browse/RF-12936
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.1
> Reporter: Lukáš Fryč
> Fix For: 5.0.0.Alpha2
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> The {{richfaces.js}} references both, {{jQuery}} from closure and global {{$}} - this issue is addressed in RF-12833.
> However jQuery should not be used directly, rather from closures - prefered way is to use {{$}} but its naming now conflicts with {{RichFaces.$}} for component references.
> I suggest to use following trick:
> {code:title=richfaces.js}
> RichFaces.jQuery = RichFaces.jQuery || jQuery;
> //encapsulation
> (function($, RichFaces) {
> // free to use $ here
> }(RichFaces.jQuery, RichFaces));
> {code}
> It will allow:
> * provide own jQuery for RichFaces
> * use libraries which make use of {{$}} (prototype, other jQuery versions) in no-conflicting way
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-12833) richfaces.js conflicts with prototype.js
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12833?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12833:
-------------------------------
Original Estimate: 1 hour
Remaining Estimate: 1 hour
> richfaces.js conflicts with prototype.js
> ----------------------------------------
>
> Key: RF-12833
> URL: https://issues.jboss.org/browse/RF-12833
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.3.1
> Reporter: Mark Torres
> Fix For: 5.0.0.Alpha2
>
> Attachments: RF-12833.patch
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> Getting some javascript errors on richfaces.js.
> Upon inspection, it is using
> {code}
> (function(jQuery, richfaces) {
> ...
> {code}
> instead of
> {code}
> (function($, richfaces) {
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-11090) rich:collapsibleSubTable cannot be nested
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-11090?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-11090:
-------------------------------
Original Estimate: 45 minutes
Remaining Estimate: 45 minutes
> rich:collapsibleSubTable cannot be nested
> -----------------------------------------
>
> Key: RF-11090
> URL: https://issues.jboss.org/browse/RF-11090
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Final
> Reporter: Val Blant
> Priority: Minor
> Fix For: 5.0.0.Alpha2
>
> Original Estimate: 45 minutes
> Remaining Estimate: 45 minutes
>
> When _<rich:collapsibleSubTable />_ s are nested, the following error occurs:
> {quote}
> This page contains the following errors:
> error on line 202 at column 74: Opening and ending tag mismatch: tbody line 0 and tr
> Below is a rendering of the page up to the first error.
> {quote}
> The page is rendered up to the nested _<rich:collapsibleSubTable />_.
> This error happens b/c nested sub tables render an extra _</tr>_ element after the nested subtable row.
> I was able to work around the problem by making a small tweak to _CollapsibleSubTableRenderer_. The lines I added or changes are marked with *"// fix line"* comment.
> {code:title=FixedCollapsibleSubTableRenderer.java|borderStyle=solid}
> /**
> * Allows nested subTables to be rendered properly
> */
> @ResourceDependencies({
> @ResourceDependency(name = "jquery.js"),
> @ResourceDependency(name = "richfaces.js"),
> @ResourceDependency(library="org.richfaces", name = "collapsible-subtable.ecss"),
> @ResourceDependency(library="org.richfaces", name = "collapsible-subtable.js")
> })
> public class FixedCollapsibleSubTableRenderer extends CollapsibleSubTableRenderer {
>
> @Override
> public void encodeRow(ResponseWriter writer, FacesContext facesContext, RowHolderBase holder) throws IOException {
> RowHolder rowHolder = (RowHolder)holder;
> Row row = rowHolder.getRow();
> putRowStylesIntoContext(facesContext, rowHolder);
> rowHolder.setRowStart(true);
> Iterator<UIComponent> components = row.columns();
> if (rowHolder.isUpdatePartial()) {
> partialStart(facesContext,((AbstractCollapsibleSubTable) row).getRelativeClientId(facesContext) + ":b");
> }
>
> int columnNumber = 0;
> boolean isSubtable = false; // fix line
> while (components.hasNext()) {
> UIComponent component = components.next();
> if(component.isRendered()) {
> if(component instanceof UIColumn ) {
> component.getAttributes().put(COLUMN_CLASS, getColumnClass(rowHolder, columnNumber));
> encodeColumn(facesContext, writer, (UIColumn)component , rowHolder);
> columnNumber++;
> } else if (component instanceof AbstractCollapsibleSubTable) {
> if(component.isRendered()) {
> isSubtable = true; // fix line
> encodeRowEnd(writer);
> }
>
> if ( ((AbstractCollapsibleSubTable) component).isExpanded() ) {
> component.encodeAll(facesContext);
> }
> rowHolder.setRowStart(true);
> }
> }
> }
> if ( !isSubtable) encodeRowEnd(writer); // fix line
> if (rowHolder.isUpdatePartial()) {
> partialEnd(facesContext);
> }
> }
> }
> {code}
> This renderer needs to be registered in _faces-config.xml_:
> {code}
> <render-kit>
> <renderer>
> <component-family>org.richfaces.Data</component-family>
> <renderer-type>org.richfaces.CollapsibleSubTableRenderer</renderer-type>
> <renderer-class>bla.FixedCollapsibleSubTableRenderer</renderer-class>
> </renderer>
> </render-kit>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-11090) rich:collapsibleSubTable cannot be nested
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-11090?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-11090:
-------------------------------
Priority: Minor (was: Major)
> rich:collapsibleSubTable cannot be nested
> -----------------------------------------
>
> Key: RF-11090
> URL: https://issues.jboss.org/browse/RF-11090
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Final
> Reporter: Val Blant
> Priority: Minor
> Fix For: 5.0.0.Alpha2
>
>
> When _<rich:collapsibleSubTable />_ s are nested, the following error occurs:
> {quote}
> This page contains the following errors:
> error on line 202 at column 74: Opening and ending tag mismatch: tbody line 0 and tr
> Below is a rendering of the page up to the first error.
> {quote}
> The page is rendered up to the nested _<rich:collapsibleSubTable />_.
> This error happens b/c nested sub tables render an extra _</tr>_ element after the nested subtable row.
> I was able to work around the problem by making a small tweak to _CollapsibleSubTableRenderer_. The lines I added or changes are marked with *"// fix line"* comment.
> {code:title=FixedCollapsibleSubTableRenderer.java|borderStyle=solid}
> /**
> * Allows nested subTables to be rendered properly
> */
> @ResourceDependencies({
> @ResourceDependency(name = "jquery.js"),
> @ResourceDependency(name = "richfaces.js"),
> @ResourceDependency(library="org.richfaces", name = "collapsible-subtable.ecss"),
> @ResourceDependency(library="org.richfaces", name = "collapsible-subtable.js")
> })
> public class FixedCollapsibleSubTableRenderer extends CollapsibleSubTableRenderer {
>
> @Override
> public void encodeRow(ResponseWriter writer, FacesContext facesContext, RowHolderBase holder) throws IOException {
> RowHolder rowHolder = (RowHolder)holder;
> Row row = rowHolder.getRow();
> putRowStylesIntoContext(facesContext, rowHolder);
> rowHolder.setRowStart(true);
> Iterator<UIComponent> components = row.columns();
> if (rowHolder.isUpdatePartial()) {
> partialStart(facesContext,((AbstractCollapsibleSubTable) row).getRelativeClientId(facesContext) + ":b");
> }
>
> int columnNumber = 0;
> boolean isSubtable = false; // fix line
> while (components.hasNext()) {
> UIComponent component = components.next();
> if(component.isRendered()) {
> if(component instanceof UIColumn ) {
> component.getAttributes().put(COLUMN_CLASS, getColumnClass(rowHolder, columnNumber));
> encodeColumn(facesContext, writer, (UIColumn)component , rowHolder);
> columnNumber++;
> } else if (component instanceof AbstractCollapsibleSubTable) {
> if(component.isRendered()) {
> isSubtable = true; // fix line
> encodeRowEnd(writer);
> }
>
> if ( ((AbstractCollapsibleSubTable) component).isExpanded() ) {
> component.encodeAll(facesContext);
> }
> rowHolder.setRowStart(true);
> }
> }
> }
> if ( !isSubtable) encodeRowEnd(writer); // fix line
> if (rowHolder.isUpdatePartial()) {
> partialEnd(facesContext);
> }
> }
> }
> {code}
> This renderer needs to be registered in _faces-config.xml_:
> {code}
> <render-kit>
> <renderer>
> <component-family>org.richfaces.Data</component-family>
> <renderer-type>org.richfaces.CollapsibleSubTableRenderer</renderer-type>
> <renderer-class>bla.FixedCollapsibleSubTableRenderer</renderer-class>
> </renderer>
> </render-kit>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-12580) Guava versions in Errai and RichFaces are not compatible
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/RF-12580?page=com.atlassian.jira.plugin.s... ]
RH Bugzilla Integration commented on RF-12580:
----------------------------------------------
Petr Penicka <ppenicka(a)redhat.com> made a comment on [bug 870349|https://bugzilla.redhat.com/show_bug.cgi?id=870349]
Edited doc text for 2.3 release notes.
> Guava versions in Errai and RichFaces are not compatible
> --------------------------------------------------------
>
> Key: RF-12580
> URL: https://issues.jboss.org/browse/RF-12580
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.2.3.Final
> Reporter: Tomas Repel
>
> Description of problem:
> RichFaces 4.2.3.Final-redhat-1 depends on com.google.guava:guava:11.0.2. This particular version is not compatible with Errai framework that needs guava of version 12.0.
> Version-Release number of selected component (if applicable):
> RichFaces 4.2.3.Final-redhat-1
> Errai 2.1.0.Final-redhat-1
> How reproducible:
> Always.
> Steps to Reproduce:
> I discovered this when I tried to deploy Ticket Monster example (2.1.0.ER2 version) with administration pages generated by Forge 1.0.5.Final that uses Forge Richfaces plugin.
>
> Actual results:
> {noformat}
> [ERROR] java.lang.NoClassDefFoundError: com/google/common/reflect/TypeToken
> [ERROR] at org.jboss.errai.codegen.meta.impl.java.JavaReflectionMethod.getParameters(JavaReflectionMethod.java:62)
> [ERROR] at org.jboss.errai.codegen.meta.MetaClassFactory.cloneToBuildMetaClass(MetaClassFactory.java:325)
> [ERROR] at org.jboss.errai.codegen.meta.MetaClassFactory.parameterizedAs(MetaClassFactory.java:261)
> [ERROR] at org.jboss.errai.codegen.meta.MetaClassFactory.parameterizedAs(MetaClassFactory.java:257)
> [ERROR] at org.jboss.errai.codegen.meta.impl.java.JavaReflectionClass.getSuperClass(JavaReflectionClass.java:317)
> [ERROR] at org.jboss.errai.codegen.meta.MetaClassFactory.cloneToBuildMetaClass(MetaClassFactory.java:279)
> [ERROR] at org.jboss.errai.codegen.meta.MetaClassFactory.parameterizedAs(MetaClassFactory.java:261)
> [ERROR] at org.jboss.errai.codegen.meta.MetaClassFactory.parameterizedAs(MetaClassFactory.java:257)
> [ERROR] at org.jboss.errai.ioc.rebind.ioc.bootstrapper.QualifierEqualityFactoryGenerator.generateQualifierEqualityFactory(QualifierEqualityFactoryGenerator.java:99)
> [ERROR] at org.jboss.errai.ioc.rebind.ioc.bootstrapper.QualifierEqualityFactoryGenerator.generate(QualifierEqualityFactoryGenerator.java:65)
> [ERROR] at com.google.gwt.core.ext.GeneratorExtWrapper.generate(GeneratorExtWrapper.java:48)
> [ERROR] at com.google.gwt.core.ext.GeneratorExtWrapper.generateIncrementally(GeneratorExtWrapper.java:60)
> [ERROR] at com.google.gwt.dev.javac.StandardGeneratorContext.runGeneratorIncrementally(StandardGeneratorContext.java:647)
> [ERROR] at com.google.gwt.dev.cfg.RuleGenerateWith.realize(RuleGenerateWith.java:41)
> [ERROR] at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.rebind(StandardRebindOracle.java:78)
> [ERROR] at com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.java:268)
> [ERROR] at com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.java:257)
> [ERROR] at com.google.gwt.dev.DistillerRebindPermutationOracle.getAllPossibleRebindAnswers(DistillerRebindPermutationOracle.java:91)
> [ERROR] at com.google.gwt.dev.jdt.WebModeCompilerFrontEnd.doFindAdditionalTypesUsingRebinds(WebModeCompilerFrontEnd.java:96)
> [ERROR] at com.google.gwt.dev.jdt.AbstractCompiler$Sandbox$CompilerImpl.process(AbstractCompiler.java:254)
> [ERROR] at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:444)
> [ERROR] at com.google.gwt.dev.jdt.AbstractCompiler$Sandbox$CompilerImpl.compile(AbstractCompiler.java:173)
> [ERROR] at com.google.gwt.dev.jdt.AbstractCompiler$Sandbox$CompilerImpl.compile(AbstractCompiler.java:288)
> [ERROR] at com.google.gwt.dev.jdt.AbstractCompiler$Sandbox$CompilerImpl.access$400(AbstractCompiler.java:139)
> [ERROR] at com.google.gwt.dev.jdt.AbstractCompiler.compile(AbstractCompiler.java:588)
> [ERROR] at com.google.gwt.dev.jdt.BasicWebModeCompiler.getCompilationUnitDeclarations(BasicWebModeCompiler.java:97)
> [ERROR] at com.google.gwt.dev.jdt.WebModeCompilerFrontEnd.getCompilationUnitDeclarations(WebModeCompilerFrontEnd.java:52)
> [ERROR] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.precompile(JavaToJavaScriptCompiler.java:569)
> [ERROR] at com.google.gwt.dev.jjs.JavaScriptCompiler.precompile(JavaScriptCompiler.java:33)
> [ERROR] at com.google.gwt.dev.Precompile.precompile(Precompile.java:284)
> [ERROR] at com.google.gwt.dev.Precompile.precompile(Precompile.java:233)
> [ERROR] at com.google.gwt.dev.Precompile.precompile(Precompile.java:145)
> [ERROR] at com.google.gwt.dev.Compiler.run(Compiler.java:232)
> [ERROR] at com.google.gwt.dev.Compiler.run(Compiler.java:198)
> [ERROR] at com.google.gwt.dev.Compiler$1.run(Compiler.java:170)
> [ERROR] at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java:88)
> [ERROR] at com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(CompileTaskRunner.java:82)
> [ERROR] at com.google.gwt.dev.Compiler.main(Compiler.java:177)
> [ERROR] Caused by: java.lang.ClassNotFoundException: com.google.common.reflect.TypeToken
> [ERROR] at java.net.URLClassLoader$1.run(URLClassLoader.java:217)
> [ERROR] at java.security.AccessController.doPrivileged(Native Method)
> [ERROR] at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
> [ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:321)
> [ERROR] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
> [ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:266)
> [ERROR] ... 38 more
> {noformat}
> Expected results:
> It deploys.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months