January 2014 - richfaces-issues - Jboss List Archives

[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-13252: --------------------------------- I think that Mojarra should instead use {{UIView#addComponentResource}} to add {{jsf.js}} resource, that will in turn use duplication detection in its rendering logic. Another solution might be specifying {{@ResourceDependency}} directly as I assume that a reason for conditional rendering of {{jsf.js}} is optimalization in case the button is rendered (however most of the JSF apps using AJAX won't mind to refer to {{jsf.js}} anyway). > a4j:ajax includes jsf.js script twice > ------------------------------------- > > Key: RF-13252 > URL: https://issues.jboss.org/browse/RF-13252 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.3.4 > Reporter: Jonáš Trantina > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Attachments: reproducer.zip > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When a4j:script is used in the page like so: > {noformat} > <h:commandLink value="Click me "> > <a4j:ajax event="click" render="@form"/> > </h:commandLink> > {noformat} > Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3]. > Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4]. > [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/... > [4] https://issues.jboss.org/browse/RF-12270 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13252: ---------------------------- Workaround Description: *Specify {{jsf.js}} dependency* (or use a component that depends on the {{jsf.js}}) before {{<h:commandLink/>}} is used. *1)* specify {{<h:outputScript library='javax.faces' name='jsf.js' target='head' />}} in page head *2)* use equivalent {{<r:commandLink />}} instead of {{<h:commandLink />}} was: *Specify {{jsf.js}} dependency* (or use a component that depends on the {{jsf.js}}) before {{<h:commandLink/>}} is used. *1)* specify {{<h:outputScript library='javax.faces' name='jsf.js' target='head' />}} in page head *2)* use equivalent {{<r:commandLink />}} > a4j:ajax includes jsf.js script twice > ------------------------------------- > > Key: RF-13252 > URL: https://issues.jboss.org/browse/RF-13252 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.3.4 > Reporter: Jonáš Trantina > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Attachments: reproducer.zip > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When a4j:script is used in the page like so: > {noformat} > <h:commandLink value="Click me "> > <a4j:ajax event="click" render="@form"/> > </h:commandLink> > {noformat} > Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3]. > Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4]. > [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/... > [4] https://issues.jboss.org/browse/RF-12270 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13252: ---------------------------- Workaround Description: *Specify {{jsf.js}} dependency* (or use a component that depends on the {{jsf.js}}) before {{<h:commandLink/>}} is used. *1)* specify {{<h:outputScript library='javax.faces' name='jsf.js' target='head' />}} in page head *2)* use equivalent {{<r:commandLink />}} was: Specify {{jsf.js}} dependency (or use a component that depends on the {{jsf.js}}) before {{<h:commandLink/>}} is used. 1) specify {{<h:outputScript library='javax.faces' name='jsf.js' target='head' />}} in page head 2) use equivalent {{<r:commandLink />}} > a4j:ajax includes jsf.js script twice > ------------------------------------- > > Key: RF-13252 > URL: https://issues.jboss.org/browse/RF-13252 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.3.4 > Reporter: Jonáš Trantina > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Attachments: reproducer.zip > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When a4j:script is used in the page like so: > {noformat} > <h:commandLink value="Click me "> > <a4j:ajax event="click" render="@form"/> > </h:commandLink> > {noformat} > Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3]. > Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4]. > [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/... > [4] https://issues.jboss.org/browse/RF-12270 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13252: ---------------------------- Workaround Description: Specify {{jsf.js}} dependency (or use a component that depends on the {{jsf.js}}) before {{<h:commandLink/>}} is used. 1) specify {{<h:outputScript library='javax.faces' name='jsf.js' target='head' />}} in page head 2) use equivalent {{<r:commandLink />}} Workaround: Workaround Exists > a4j:ajax includes jsf.js script twice > ------------------------------------- > > Key: RF-13252 > URL: https://issues.jboss.org/browse/RF-13252 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.3.4 > Reporter: Jonáš Trantina > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Attachments: reproducer.zip > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When a4j:script is used in the page like so: > {noformat} > <h:commandLink value="Click me "> > <a4j:ajax event="click" render="@form"/> > </h:commandLink> > {noformat} > Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3]. > Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4]. > [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/... > [4] https://issues.jboss.org/browse/RF-12270 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč edited comment on RF-13252 at 1/3/14 9:29 AM: --------------------------------------------------------- This issue is based in the Mojarra implementation: https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j... The workaround is specify/use {{javax.faces:jsf.js}} resource before any other resource is used, such as a workaround suggested [above|https://issues.jboss.org/browse/RF-13252?focusedCommentId=12925957&...] ^ or by specifying {{<h:outputScript library="javax.faces" name="jsf.js" target="head" />}} into a page head or using {{<rich:commandLink />}} instead. was (Author: lfryc): This is issue based in Mojarra implementation: https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j... The workaround is specify/use {{javax.faces:jsf.js}} resource before any other resource is used, such as a workaround suggested [above|https://issues.jboss.org/browse/RF-13252?focusedCommentId=12925957&...] ^ or by specifying {{<h:outputScript library="javax.faces" name="jsf.js" target="head" />}} into a page head or using {{<rich:commandLink />}} instead. > a4j:ajax includes jsf.js script twice > ------------------------------------- > > Key: RF-13252 > URL: https://issues.jboss.org/browse/RF-13252 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.3.4 > Reporter: Jonáš Trantina > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Attachments: reproducer.zip > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When a4j:script is used in the page like so: > {noformat} > <h:commandLink value="Click me "> > <a4j:ajax event="click" render="@form"/> > </h:commandLink> > {noformat} > Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3]. > Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4]. > [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/... > [4] https://issues.jboss.org/browse/RF-12270 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč edited comment on RF-13252 at 1/3/14 9:29 AM: --------------------------------------------------------- This issue is based in the Mojarra implementation: https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j... The workaround is to specify/use {{javax.faces:jsf.js}} resource before any other resource is used, such as a workaround suggested [above|https://issues.jboss.org/browse/RF-13252?focusedCommentId=12925957&...] ^ or by specifying {{<h:outputScript library="javax.faces" name="jsf.js" target="head" />}} into a page head or using {{<rich:commandLink />}} instead. was (Author: lfryc): This issue is based in the Mojarra implementation: https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j... The workaround is specify/use {{javax.faces:jsf.js}} resource before any other resource is used, such as a workaround suggested [above|https://issues.jboss.org/browse/RF-13252?focusedCommentId=12925957&...] ^ or by specifying {{<h:outputScript library="javax.faces" name="jsf.js" target="head" />}} into a page head or using {{<rich:commandLink />}} instead. > a4j:ajax includes jsf.js script twice > ------------------------------------- > > Key: RF-13252 > URL: https://issues.jboss.org/browse/RF-13252 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.3.4 > Reporter: Jonáš Trantina > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Attachments: reproducer.zip > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When a4j:script is used in the page like so: > {noformat} > <h:commandLink value="Click me "> > <a4j:ajax event="click" render="@form"/> > </h:commandLink> > {noformat} > Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3]. > Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4]. > [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/... > [4] https://issues.jboss.org/browse/RF-12270 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13252) a4j:ajax includes jsf.js script twice

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13252?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč commented on RF-13252: --------------------------------- This is issue based in Mojarra implementation: https://github.com/jboss/mojarra/blob/2.1.19-jbossorg-1/jsf-ri/src/main/j... The workaround is specify/use {{javax.faces:jsf.js}} resource before any other resource is used, such as a workaround suggested [above|https://issues.jboss.org/browse/RF-13252?focusedCommentId=12925957&...] ^ or by specifying {{<h:outputScript library="javax.faces" name="jsf.js" target="head" />}} into a page head or using {{<rich:commandLink />}} instead. > a4j:ajax includes jsf.js script twice > ------------------------------------- > > Key: RF-13252 > URL: https://issues.jboss.org/browse/RF-13252 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: component-a4j-core > Affects Versions: 4.3.4 > Reporter: Jonáš Trantina > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Attachments: reproducer.zip > > Original Estimate: 4 hours > Remaining Estimate: 4 hours > > When a4j:script is used in the page like so: > {noformat} > <h:commandLink value="Click me "> > <a4j:ajax event="click" render="@form"/> > </h:commandLink> > {noformat} > Then two script tags pointing to jsf.js are added to the page, once in the head by the inclusion of @ResourceDependency [1], and once again by Overriding the ClientBehaviorRenderer#getScript method [2,3]. > Note, that according to Brian, resolving this without introducing any functional regressions may require the resolution of RF-12270 [4]. > [1] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [2] https://github.com/richfaces/richfaces/blob/master/framework/src/main/jav... > [3] https://github.com/jboss/mojarra/blob/2.1.21-jbossorg-1/jsf-api/src/main/... > [4] https://issues.jboss.org/browse/RF-12270 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13298) Richfaces BOM manages a non Maven Central dependency

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13298?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč resolved RF-13298. ----------------------------- Resolution: Done I have moved all ui.* artifacts from richfaces-bom to richfaces-root-parent. > Richfaces BOM manages a non Maven Central dependency > ---------------------------------------------------- > > Key: RF-13298 > URL: https://issues.jboss.org/browse/RF-13298 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: build/distribution > Affects Versions: 4.3.2, 4.3.3, 4.3.4 > Reporter: Rafael Benevides > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Original Estimate: 30 minutes > Remaining Estimate: 30 minutes > > Richfaces BOMs http://repo1.maven.org/maven2/org/richfaces/richfaces-bom/4.3.4.Final/ric... manages the following GAV: > org.richfaces.ui.common:richfaces-ui-common-api:${version.richfaces} which is not present on Maven Central ( http://search.maven.org/#search%7Cga%7C1%7Crichfaces-ui-common-api ) > BOM should have this scope changed or declare a https://repository.jboss.org/nexus repository -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13298) Richfaces BOM manages a non Maven Central dependency

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13298?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč updated RF-13298: ---------------------------- Original Estimate: 30 minutes (was: 2 hours) Remaining Estimate: 30 minutes (was: 2 hours) > Richfaces BOM manages a non Maven Central dependency > ---------------------------------------------------- > > Key: RF-13298 > URL: https://issues.jboss.org/browse/RF-13298 > Project: RichFaces > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: build/distribution > Affects Versions: 4.3.2, 4.3.3, 4.3.4 > Reporter: Rafael Benevides > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Original Estimate: 30 minutes > Remaining Estimate: 30 minutes > > Richfaces BOMs http://repo1.maven.org/maven2/org/richfaces/richfaces-bom/4.3.4.Final/ric... manages the following GAV: > org.richfaces.ui.common:richfaces-ui-common-api:${version.richfaces} which is not present on Maven Central ( http://search.maven.org/#search%7Cga%7C1%7Crichfaces-ui-common-api ) > BOM should have this scope changed or declare a https://repository.jboss.org/nexus repository -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

[JBoss JIRA] (RF-13310) Upgrade Graphene and Warp in 4.3 branch

by Lukáš Fryč (JIRA)

[ https://issues.jboss.org/browse/RF-13310?page=com.atlassian.jira.plugin.s... ] Lukáš Fryč resolved RF-13310. ----------------------------- Resolution: Done > Upgrade Graphene and Warp in 4.3 branch > --------------------------------------- > > Key: RF-13310 > URL: https://issues.jboss.org/browse/RF-13310 > Project: RichFaces > Issue Type: Component Upgrade > Security Level: Public(Everyone can see) > Components: tests - functional > Affects Versions: 4.3.5 > Reporter: Lukáš Fryč > Assignee: Lukáš Fryč > Fix For: 4.3.5 > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > > The state of 4.3 branch framework tests is not as stable as 5.0, thus I track this as a separate issue. > Why we want to upgrade: > * Graphene = Final version API changes changes > * Warp = ease of debugging > I don't think this is absolutely necessary, I doesn;'t work with 4.3.x tests regularly and QE doesn't run them afaik. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

10 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues January 2014