[JBoss JIRA] (RF-13160) Refactor the InputNumber* components into abstract classes
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13160?page=com.atlassian.jira.plugin.s... ]
Michal Petrov resolved RF-13160.
--------------------------------
Resolution: Done
> Refactor the InputNumber* components into abstract classes
> ----------------------------------------------------------
>
> Key: RF-13160
> URL: https://issues.jboss.org/browse/RF-13160
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: component-input
> Reporter: Brian Leathem
> Assignee: Michal Petrov
> Fix For: 4.5.0.Alpha3, 5.0.0.Alpha2
>
> Original Estimate: 1 hour, 30 minutes
> Remaining Estimate: 1 hour, 30 minutes
>
> The InputNumberSpinner and InputNumberSlider components are generated via xml in a faces-config.xml file. While this is clever, it means we have two components that are created differently from all the others, making them harder to manage. Additionally the xml is not conducive to refactoring, and the method relies on an xml format for shared attribute definitions, making it difficult to move forward with RF-12952.
> I propose re-implementing those components as Abstract components, like the majority of other RichFaces CDK components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 10 months
[JBoss JIRA] (RF-13514) Support file upload progress tracking in Servlets >= 3.0 environment
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13514?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13514:
-------------------------------
Sprint: 4.5.0.Alpha3 - Sprint 2 (was: 4.5.0.Alpha3 - Sprint 1)
> Support file upload progress tracking in Servlets >= 3.0 environment
> --------------------------------------------------------------------
>
> Key: RF-13514
> URL: https://issues.jboss.org/browse/RF-13514
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: component-input, core
> Affects Versions: 5.0.0.Alpha3
> Reporter: Lukáš Fryč
> Assignee: Michal Petrov
> Fix For: 4.5.0.Alpha3
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> We currently support two approaches for file upload:
> * Servlets 2.5: own request form data parser [{{MultipartRequestParser}}|https://github.com/richfaces/richfaces/blob/master/framework/src/main/java/org/richfaces/request/MultipartRequestParser.java]
> * Servlets 3.0: leveraging {{HttpServletRequest#getParts()}}
> However as we have discussed RF-13444, we had to finally do a trade-off of limiting support of file progress tracking. I.e. in Servlets 3.0 we have no simple way how to track file upload progress since getParts() returns data for completed request.
> There are several possible outcomes:
> 1) drop server-side file upload progress tracking and leverage XHR2/HTML5 that has built-in ability to track progress
> * imho we are already prepared to switch to XHR2 and client-side progress (possibly leveraging some third-party widget) since [all major browsers support it at least one version back|http://caniuse.com/#feat=xhr2]
> * existing implementation: http://www.script-tutorials.com/pure-html5-file-upload/
> 2) use a {{ServletFilter}} to wrap a request as our {{FileUploadFacesContextFactory}} currently do and so have an earlier access to the request object
> * this principle has a drawback - we have to ensure our filter has high-enough priority so the servlet container won't touch the request body yet
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 10 months