[JBoss JIRA] (RF-13749) Upgrade HtmlUnit to 2.15
by Pavol Pitonak (JIRA)
Pavol Pitonak created RF-13749:
----------------------------------
Summary: Upgrade HtmlUnit to 2.15
Key: RF-13749
URL: https://issues.jboss.org/browse/RF-13749
Project: RichFaces
Issue Type: Component Upgrade
Security Level: Public (Everyone can see)
Components: tests - functional , tests - unit
Affects Versions: 4.5.0.Alpha3
Reporter: Pavol Pitonak
I'd like to upgrade our testing dependencies (Arquillian Core, Arquillian Drone, Selenium) but HtmlUnit needs to be upgraded from 2.12 to 2.15 first because it's a transitive dependency of Selenium.
I upgraded it on a feature branch \[1]. However, there were some problems after upgrade:
# HtmlUnit's API changed slightly, thise are easy fixes.
# DummyQueueTest is failing after HtmlUnit upgrade, it seems that it doesn't test anything (there are no asserts, only prints to console) so I removed it \[2].
# One test in DataGridRendererTest was failing, I refactored it.
# Two tests in AutocompleteRendererTest were failing, I removed them because it doesn't test layout=table and these tests are already in Metamer. We might consider migrating this particular test from Metamer to the framework (as an Arquillian test). IMHO it's not worth fixing HtmlUnit test. \[3]
\[1] https://github.com/richfaces/richfaces/tree/htmlunit_upgrade
\[2] https://github.com/richfaces/richfaces/commit/ebb5df8a5dfeaacc47cf4187e3a...
\[3] https://github.com/richfaces/richfaces/commit/2a0a0ec1260ef83df2b83ba64f1...
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months
[JBoss JIRA] (RF-13746) Some of RichFaces 4.5.0.Alpha3 artifacts are missing in Maven Central
by Juraj Húska (JIRA)
[ https://issues.jboss.org/browse/RF-13746?page=com.atlassian.jira.plugin.s... ]
Juraj Húska commented on RF-13746:
----------------------------------
Here is the complete list of GAVs, which are imho missing in the Central.
When building kitchensink archetype I have found following missing:
{code}
org.richfaces:richfaces-components-parent:pom:4.5.0.Alpha3
org.richfaces:richfaces-cache-bom:pom:4.5.0.Alpha3
org.richfaces:richfaces-core:jar:4.5.0.Alpha3
org.richfaces:richfaces-a4j:jar:4.5.0.Alpha3
{code}
Then I went though richfaces repository, and I think that we should also propagate page fragments:
{{org.richfaces:richfaces-page-fragments:jar:4.5.0.Alpha3}}.
> Some of RichFaces 4.5.0.Alpha3 artifacts are missing in Maven Central
> ---------------------------------------------------------------------
>
> Key: RF-13746
> URL: https://issues.jboss.org/browse/RF-13746
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 4.5.0.Alpha3
> Reporter: Juraj Húska
> Assignee: Juraj Húska
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
>
> An 4.5.0.Alpha3 RF application can not be built only with artifacts from Maven Central.
> [Following|http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.richfaces...] artifacts are available there.
> There is not e.g. {{org.richfaces:richfaces-components-parent:pom:4.5.0.Alpha3}}.
> Similar problem raised for {{5.0.0.Alpha2}} and was resolved.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months
[JBoss JIRA] (RF-13748) Rich Tab switching in uiRepeat template
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13748?page=com.atlassian.jira.plugin.s... ]
Michal Petrov updated RF-13748:
-------------------------------
Steps to Reproduce:
* Start Wildfly
* Deploy Metamer and load [this page|http://localhost:8080/metamer/faces/components/richTab/simple.xhtml?templates=uiRepeat] (it already loads with template)
* Switch to second tab
** In phases panel you will see {{item changed: tab1 -> tab2}}
** This works fine
* Switch back to first tab and see the value in phases panel again
** EXPECTED: {{item changed: tab2 -> tab1}}
** ACTUAL: {{item changed: null -> tab1}}
was:
* Start Wildfly
* Deploy Metamer and load [this page|http://localhost:8080/metamer/faces/components/richTab/simple.xhtml??templates=uiRepeat] (it already loads with template)
* Switch to second tab
** In phases panel you will see {{item changed: tab1 -> tab2}}
** This works fine
* Switch back to first tab and see the value in phases panel again
** EXPECTED: {{item changed: tab2 -> tab1}}
** ACTUAL: {{item changed: null -> tab1}}
> Rich Tab switching in uiRepeat template
> ---------------------------------------
>
> Key: RF-13748
> URL: https://issues.jboss.org/browse/RF-13748
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.5.0.Alpha3
> Reporter: Matej Novotny
> Labels: uiRepeat#setIndex
>
> Using Metamer (in order to have the phases info in the page header) go to [richTab sample page with uiRepeat template|http://localhost:8080/metamer/faces/components/richTab/simple.xhtml??templates=uiRepeat]. Switching tabs for the first time works fine, in phase panel info below {{UPDATE_MODEL_VALUES 4}} you can see value {{item changed: tab1 -> tab2}}. But if you now try to switch it back to first tab, the value will be {{item changed: null -> tab1}}.
> Instead the value should be {{item changed: tab2 -> tab1}}.
> This can be reproducer with collapsible table as well.
> Also we have a [test|https://github.com/richfaces/richfaces-qa/blob/master/metamer/ftest/...] covering this issue.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months
[JBoss JIRA] (RF-13748) Rich Tab switching in uiRepeat template
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13748?page=com.atlassian.jira.plugin.s... ]
Michal Petrov updated RF-13748:
-------------------------------
Labels: uiRepeat#setIndex (was: )
> Rich Tab switching in uiRepeat template
> ---------------------------------------
>
> Key: RF-13748
> URL: https://issues.jboss.org/browse/RF-13748
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.5.0.Alpha3
> Reporter: Matej Novotny
> Labels: uiRepeat#setIndex
>
> Using Metamer (in order to have the phases info in the page header) go to [richTab sample page with uiRepeat template|http://localhost:8080/metamer/faces/components/richTab/simple.xhtml??templates=uiRepeat]. Switching tabs for the first time works fine, in phase panel info below {{UPDATE_MODEL_VALUES 4}} you can see value {{item changed: tab1 -> tab2}}. But if you now try to switch it back to first tab, the value will be {{item changed: null -> tab1}}.
> Instead the value should be {{item changed: tab2 -> tab1}}.
> This can be reproducer with collapsible table as well.
> Also we have a [test|https://github.com/richfaces/richfaces-qa/blob/master/metamer/ftest/...] covering this issue.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months
[JBoss JIRA] (RF-13474) Extended data table: selection inside r:region doesn't work
by Matej Novotny (JIRA)
[ https://issues.jboss.org/browse/RF-13474?page=com.atlassian.jira.plugin.s... ]
Matej Novotny commented on RF-13474:
------------------------------------
Updated info, as this issue is still relevant for 4.5.0.Alpha3.
Also I refactored the [test|https://github.com/richfaces/richfaces-qa/blob/master/metamer/ftest/...] to work work exactly as described in steps to reproduce.
> Extended data table: selection inside r:region doesn't work
> -----------------------------------------------------------
>
> Key: RF-13474
> URL: https://issues.jboss.org/browse/RF-13474
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.4, 4.5.0.Alpha1, 4.5.0.Alpha3, 5.0.0.Alpha2
> Environment: RichFaces 4.3.4.Final
> Metamer 4.3.4.Final
> EAP 6.2.0
> all browsers
> Reporter: Pavol Pitonak
> Fix For: 4.5-Tracking
>
>
> # deploy Metamer and open http://localhost:8080/metamer/faces/components/richExtendedDataTable/sele...
> # using data scroller switch to page 2
> # click on fifth row
> # using data scroller switch to page 1
> # hold shift, click on third row, release shift
> # hold ctrl, click on fifth row, release ctrl
> # using data scroller switch to page 2
> result:
> * rows that have never been selected are now selected (e.g. 45-49)
> * it's *not* a regression
> * it is probably related to RF-10256 - previously, selection didn't work when EDT was placed inside a table or region, now it works inside tables but not inside region
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months
[JBoss JIRA] (RF-13474) Extended data table: selection inside r:region doesn't work
by Matej Novotny (JIRA)
[ https://issues.jboss.org/browse/RF-13474?page=com.atlassian.jira.plugin.s... ]
Matej Novotny updated RF-13474:
-------------------------------
Fix Version/s: 4.5-Tracking
(was: 5-Tracking)
> Extended data table: selection inside r:region doesn't work
> -----------------------------------------------------------
>
> Key: RF-13474
> URL: https://issues.jboss.org/browse/RF-13474
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.4, 4.5.0.Alpha1, 4.5.0.Alpha3, 5.0.0.Alpha2
> Environment: RichFaces 4.3.4.Final
> Metamer 4.3.4.Final
> EAP 6.2.0
> all browsers
> Reporter: Pavol Pitonak
> Fix For: 4.5-Tracking
>
>
> # deploy Metamer and open http://localhost:8080/metamer/faces/components/richExtendedDataTable/sele...
> # using data scroller switch to page 2
> # click on fifth row
> # using data scroller switch to page 1
> # hold shift, click on third row, release shift
> # hold ctrl, click on fifth row, release ctrl
> # using data scroller switch to page 2
> result:
> * rows that have never been selected are now selected (e.g. 45-49)
> * it's *not* a regression
> * it is probably related to RF-10256 - previously, selection didn't work when EDT was placed inside a table or region, now it works inside tables but not inside region
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months
[JBoss JIRA] (RF-13474) Extended data table: selection inside r:region doesn't work
by Matej Novotny (JIRA)
[ https://issues.jboss.org/browse/RF-13474?page=com.atlassian.jira.plugin.s... ]
Matej Novotny updated RF-13474:
-------------------------------
Affects Version/s: 4.5.0.Alpha3
> Extended data table: selection inside r:region doesn't work
> -----------------------------------------------------------
>
> Key: RF-13474
> URL: https://issues.jboss.org/browse/RF-13474
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.3.4, 4.5.0.Alpha1, 4.5.0.Alpha3, 5.0.0.Alpha2
> Environment: RichFaces 4.3.4.Final
> Metamer 4.3.4.Final
> EAP 6.2.0
> all browsers
> Reporter: Pavol Pitonak
> Fix For: 4.5-Tracking
>
>
> # deploy Metamer and open http://localhost:8080/metamer/faces/components/richExtendedDataTable/sele...
> # using data scroller switch to page 2
> # click on fifth row
> # using data scroller switch to page 1
> # hold shift, click on third row, release shift
> # hold ctrl, click on fifth row, release ctrl
> # using data scroller switch to page 2
> result:
> * rows that have never been selected are now selected (e.g. 45-49)
> * it's *not* a regression
> * it is probably related to RF-10256 - previously, selection didn't work when EDT was placed inside a table or region, now it works inside tables but not inside region
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months
[JBoss JIRA] (RF-13748) Rich Tab switching in uiRepeat template
by Matej Novotny (JIRA)
[ https://issues.jboss.org/browse/RF-13748?page=com.atlassian.jira.plugin.s... ]
Matej Novotny updated RF-13748:
-------------------------------
Description:
Using Metamer (in order to have the phases info in the page header) go to [richTab sample page with uiRepeat template|http://localhost:8080/metamer/faces/components/richTab/simple.xhtml??templates=uiRepeat]. Switching tabs for the first time works fine, in phase panel info below {{UPDATE_MODEL_VALUES 4}} you can see value {{item changed: tab1 -> tab2}}. But if you now try to switch it back to first tab, the value will be {{item changed: null -> tab1}}.
Instead the value should be {{item changed: tab2 -> tab1}}.
This can be reproducer with collapsible table as well.
Also we have a [test|https://github.com/richfaces/richfaces-qa/blob/master/metamer/ftest/...] covering this issue.
was:
Using Metamer (in order to have the phases info in the page header) go to [richTab sample page with uiRepeat template|http://localhost:8080/metamer/faces/components/richTab/simple.xhtml??templates=uiRepeat]. Switching tabs for the first time works fine, in phase panel info below {{UPDATE_MODEL_VALUES 4}} you can see value {{item changed: tab1 -> tab2}}. But if you now try to switch it back to first tab, the value will be {{item changed: null -> tab1}}.
Instead the value should be {{item changed: tab2 -> tab1}}.
This can be reproducer with collapsible table as well.
> Rich Tab switching in uiRepeat template
> ---------------------------------------
>
> Key: RF-13748
> URL: https://issues.jboss.org/browse/RF-13748
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.5.0.Alpha3
> Reporter: Matej Novotny
>
> Using Metamer (in order to have the phases info in the page header) go to [richTab sample page with uiRepeat template|http://localhost:8080/metamer/faces/components/richTab/simple.xhtml??templates=uiRepeat]. Switching tabs for the first time works fine, in phase panel info below {{UPDATE_MODEL_VALUES 4}} you can see value {{item changed: tab1 -> tab2}}. But if you now try to switch it back to first tab, the value will be {{item changed: null -> tab1}}.
> Instead the value should be {{item changed: tab2 -> tab1}}.
> This can be reproducer with collapsible table as well.
> Also we have a [test|https://github.com/richfaces/richfaces-qa/blob/master/metamer/ftest/...] covering this issue.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 4 months