[JBoss JIRA] (RF-13778) RF-45 cyclic dependency on richfaces-parent
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13778?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13778:
------------------------------------
[~pslegr] as I explained previously: the original plan was to deprecate jsf-test in favor of Arquillian-based Graphene tests. This plan has been put aside when we decided not to pursue RichFaces 5. As such we are stuck with using and maintaining the legacy jsf-test project.
To resolve this conflict I propose we have jsf-test use jboss-parent and independently set any versions required from the RichFaces project. We will have to maintain duplicate versions in some places, but this is manageable. More manageable IMO than again separating richfaces-parent out into a separate repo.
> RF-45 cyclic dependency on richfaces-parent
> -------------------------------------------
>
> Key: RF-13778
> URL: https://issues.jboss.org/browse/RF-13778
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 4.5.0.Alpha3
> Reporter: Pavol Pitonak
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Historically there is a dependency in .../jsf-tests/pom.xml on richfaces-parent which used to be a standalone project/repo in 4.3.x
> {code}
> <parent>
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <version>12</version>
> </parent>
> {code}
> However nowadays in 4.5.x there is playing the role of parent the
> richfaces/pom.xml
> https://github.com/richfaces/richfaces/blob/master/pom.xml
> {code}
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <packaging>pom</packaging>
> <version>4.5.0-SNAPSHOT</version>
> <name>RichFaces Parent</name>
> {code}
> which makes a cyclic dependency
> jsf-test --> richfaces --> jsf-test
> as there are inside https://github.com/richfaces/richfaces/blob/master/build/pom.xml
> referenced dependencies for jsf-tests
> {code}
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>htmlunit-client</artifactId>
> <version>${version.jsf-test}</version>
> <exclusions>
> <exclusion>
> <groupId>javax.servlet</groupId>
> <artifactId>javax.servlet-api</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-stage</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mock</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mockito</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-scriptunit</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13778) RF-45 cyclic dependency on richfaces-parent
by Pavel Slegr (JIRA)
[ https://issues.jboss.org/browse/RF-13778?page=com.atlassian.jira.plugin.s... ]
Pavel Slegr commented on RF-13778:
----------------------------------
> org.richfaces;richfaces-parent:12 shall be used with jsf-test.
> org.richfaces:richfaces-parent:4.5.x shall be used with the framework.
Well you do suggest here to use the 2 different version's of the same artifact (richface-parent) for 2 different projects
IMO this mixing of GAV's is not nice and is not clear solution.
When you planned to unify richfaces-4.3.x separated repositories into one single repository in 4.5.x then another name should be used
Once org.richfaces;richfaces-parent:12 would be used with jsf-test. it means parent repository should be moved over to 4.5.x as well....
It is somehow messed up
> RF-45 cyclic dependency on richfaces-parent
> -------------------------------------------
>
> Key: RF-13778
> URL: https://issues.jboss.org/browse/RF-13778
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 4.5.0.Alpha3
> Reporter: Pavol Pitonak
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Historically there is a dependency in .../jsf-tests/pom.xml on richfaces-parent which used to be a standalone project/repo in 4.3.x
> {code}
> <parent>
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <version>12</version>
> </parent>
> {code}
> However nowadays in 4.5.x there is playing the role of parent the
> richfaces/pom.xml
> https://github.com/richfaces/richfaces/blob/master/pom.xml
> {code}
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <packaging>pom</packaging>
> <version>4.5.0-SNAPSHOT</version>
> <name>RichFaces Parent</name>
> {code}
> which makes a cyclic dependency
> jsf-test --> richfaces --> jsf-test
> as there are inside https://github.com/richfaces/richfaces/blob/master/build/pom.xml
> referenced dependencies for jsf-tests
> {code}
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>htmlunit-client</artifactId>
> <version>${version.jsf-test}</version>
> <exclusions>
> <exclusion>
> <groupId>javax.servlet</groupId>
> <artifactId>javax.servlet-api</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-stage</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mock</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mockito</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-scriptunit</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13778) RF-45 cyclic dependency on richfaces-parent
by Pavel Slegr (JIRA)
[ https://issues.jboss.org/browse/RF-13778?page=com.atlassian.jira.plugin.s... ]
Pavel Slegr commented on RF-13778:
----------------------------------
in current RF-4.5.0.Alpha3 release there are defined dependencies to jsf-tests
So, you can not claim it is deprecated
When it is deprecated, then it should be removed, that is how I understand that. In case it will be removed, no code requires those.
But my impression was the jsf-tests are still present for some reason, am I wrong [~bleathem] ?
> RF-45 cyclic dependency on richfaces-parent
> -------------------------------------------
>
> Key: RF-13778
> URL: https://issues.jboss.org/browse/RF-13778
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 4.5.0.Alpha3
> Reporter: Pavol Pitonak
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Historically there is a dependency in .../jsf-tests/pom.xml on richfaces-parent which used to be a standalone project/repo in 4.3.x
> {code}
> <parent>
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <version>12</version>
> </parent>
> {code}
> However nowadays in 4.5.x there is playing the role of parent the
> richfaces/pom.xml
> https://github.com/richfaces/richfaces/blob/master/pom.xml
> {code}
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <packaging>pom</packaging>
> <version>4.5.0-SNAPSHOT</version>
> <name>RichFaces Parent</name>
> {code}
> which makes a cyclic dependency
> jsf-test --> richfaces --> jsf-test
> as there are inside https://github.com/richfaces/richfaces/blob/master/build/pom.xml
> referenced dependencies for jsf-tests
> {code}
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>htmlunit-client</artifactId>
> <version>${version.jsf-test}</version>
> <exclusions>
> <exclusion>
> <groupId>javax.servlet</groupId>
> <artifactId>javax.servlet-api</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-stage</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mock</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mockito</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-scriptunit</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13778) RF-45 cyclic dependency on richfaces-parent
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13778?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-13778:
---------------------------------
{{richfaces-parent <= 12}} is deprecated and so is {{jsf-test}}.
> RF-45 cyclic dependency on richfaces-parent
> -------------------------------------------
>
> Key: RF-13778
> URL: https://issues.jboss.org/browse/RF-13778
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 4.5.0.Alpha3
> Reporter: Pavol Pitonak
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Historically there is a dependency in .../jsf-tests/pom.xml on richfaces-parent which used to be a standalone project/repo in 4.3.x
> {code}
> <parent>
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <version>12</version>
> </parent>
> {code}
> However nowadays in 4.5.x there is playing the role of parent the
> richfaces/pom.xml
> https://github.com/richfaces/richfaces/blob/master/pom.xml
> {code}
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <packaging>pom</packaging>
> <version>4.5.0-SNAPSHOT</version>
> <name>RichFaces Parent</name>
> {code}
> which makes a cyclic dependency
> jsf-test --> richfaces --> jsf-test
> as there are inside https://github.com/richfaces/richfaces/blob/master/build/pom.xml
> referenced dependencies for jsf-tests
> {code}
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>htmlunit-client</artifactId>
> <version>${version.jsf-test}</version>
> <exclusions>
> <exclusion>
> <groupId>javax.servlet</groupId>
> <artifactId>javax.servlet-api</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-stage</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mock</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mockito</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-scriptunit</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13778) RF-45 cyclic dependency on richfaces-parent
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/RF-13778?page=com.atlassian.jira.plugin.s... ]
Lukáš Fryč commented on RF-13778:
---------------------------------
{{org.richfaces;richfaces-parent:12}} shall be used with {{jsf-test}}.
{{org.richfaces:richfaces-parent:4.5.x}} shall be used with the framework.
> RF-45 cyclic dependency on richfaces-parent
> -------------------------------------------
>
> Key: RF-13778
> URL: https://issues.jboss.org/browse/RF-13778
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: build/distribution
> Affects Versions: 4.5.0.Alpha3
> Reporter: Pavol Pitonak
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Historically there is a dependency in .../jsf-tests/pom.xml on richfaces-parent which used to be a standalone project/repo in 4.3.x
> {code}
> <parent>
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <version>12</version>
> </parent>
> {code}
> However nowadays in 4.5.x there is playing the role of parent the
> richfaces/pom.xml
> https://github.com/richfaces/richfaces/blob/master/pom.xml
> {code}
> <groupId>org.richfaces</groupId>
> <artifactId>richfaces-parent</artifactId>
> <packaging>pom</packaging>
> <version>4.5.0-SNAPSHOT</version>
> <name>RichFaces Parent</name>
> {code}
> which makes a cyclic dependency
> jsf-test --> richfaces --> jsf-test
> as there are inside https://github.com/richfaces/richfaces/blob/master/build/pom.xml
> referenced dependencies for jsf-tests
> {code}
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>htmlunit-client</artifactId>
> <version>${version.jsf-test}</version>
> <exclusions>
> <exclusion>
> <groupId>javax.servlet</groupId>
> <artifactId>javax.servlet-api</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-stage</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mock</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-mockito</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> <dependency>
> <groupId>org.jboss.test-jsf</groupId>
> <artifactId>jsf-test-scriptunit</artifactId>
> <version>${version.jsf-test}</version>
> </dependency>
> {code}
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months