[JBoss JIRA] (RF-13785) Component tree is not visited during RenderResponsePhase
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13785?page=com.atlassian.jira.plugin.s... ]
Michal Petrov updated RF-13785:
-------------------------------
Summary: Component tree is not visited during RenderResponsePhase (was: Validation inside popupPanel is ignored when form is submitted)
> Component tree is not visited during RenderResponsePhase
> --------------------------------------------------------
>
> Key: RF-13785
> URL: https://issues.jboss.org/browse/RF-13785
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Affects Versions: 4.5.0.Alpha3, 4.5.0.Beta1
> Reporter: Juraj Húska
> Assignee: Michal Petrov
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
>
> Consider please a form with multiple inputs inside {{popupPanel}}, which is configured to hide when there are no validation issues.
> *The issue is:* If the form is submitted e.g. with {{a4j:commandButton}}, then it hides even when there are some validation issues.
> {{PopupPanel}} has set {{oncomplete}} attribute to:
> {code:JavaScript}
> oncomplete="if (!#{facesContext.validationFailed}) { #{rich:component('popup')}.hide(); } "
> {code}
> {{facesContext.validationFailed}} is wrongly evaluated always to {{false}}.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13301) Favor use of Page Fragments in Framework Tests
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-13301?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak reassigned RF-13301:
----------------------------------
Assignee: Martin Tomasek (was: Pavol Pitonak)
[~mtomasek], configure framework tests for 4.5 so that page fragments can be used and try to refactor tests for one component, e.g. tab panel.
> Favor use of Page Fragments in Framework Tests
> ----------------------------------------------
>
> Key: RF-13301
> URL: https://issues.jboss.org/browse/RF-13301
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: tests - functional
> Affects Versions: 5.0.0.Alpha2
> Reporter: Lukáš Fryč
> Assignee: Martin Tomasek
> Fix For: 4.5-Tracking
>
>
> Since we have introduced Page Fragments in Alpha2, we could favor their usage in fragment tests.
> We could start to refactor tests for components rewritten in Alpha2 and continue as we rewrite other components.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13301) Favor use of Page Fragments in Framework Tests
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-13301?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak updated RF-13301:
-------------------------------
Fix Version/s: 4.5-Tracking
(was: 5.0.0.Alpha4)
> Favor use of Page Fragments in Framework Tests
> ----------------------------------------------
>
> Key: RF-13301
> URL: https://issues.jboss.org/browse/RF-13301
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: tests - functional
> Affects Versions: 5.0.0.Alpha2
> Reporter: Lukáš Fryč
> Assignee: Pavol Pitonak
> Fix For: 4.5-Tracking
>
>
> Since we have introduced Page Fragments in Alpha2, we could favor their usage in fragment tests.
> We could start to refactor tests for components rewritten in Alpha2 and continue as we rewrite other components.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13785) Validation inside popupPanel is ignored when form is submitted
by Cody Lerum (JIRA)
[ https://issues.jboss.org/browse/RF-13785?page=com.atlassian.jira.plugin.s... ]
Cody Lerum commented on RF-13785:
---------------------------------
My case was with an an a4j:commandLink with an render="form"
> Validation inside popupPanel is ignored when form is submitted
> --------------------------------------------------------------
>
> Key: RF-13785
> URL: https://issues.jboss.org/browse/RF-13785
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Affects Versions: 4.5.0.Alpha3, 4.5.0.Beta1
> Reporter: Juraj Húska
> Assignee: Michal Petrov
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
>
> Consider please a form with multiple inputs inside {{popupPanel}}, which is configured to hide when there are no validation issues.
> *The issue is:* If the form is submitted e.g. with {{a4j:commandButton}}, then it hides even when there are some validation issues.
> {{PopupPanel}} has set {{oncomplete}} attribute to:
> {code:JavaScript}
> oncomplete="if (!#{facesContext.validationFailed}) { #{rich:component('popup')}.hide(); } "
> {code}
> {{facesContext.validationFailed}} is wrongly evaluated always to {{false}}.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13785) Validation inside popupPanel is ignored when form is submitted
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/RF-13785?page=com.atlassian.jira.plugin.s... ]
Michal Petrov commented on RF-13785:
------------------------------------
Reverted the change so we don't get stuck with more issues.
> Validation inside popupPanel is ignored when form is submitted
> --------------------------------------------------------------
>
> Key: RF-13785
> URL: https://issues.jboss.org/browse/RF-13785
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Affects Versions: 4.5.0.Alpha3, 4.5.0.Beta1
> Reporter: Juraj Húska
> Assignee: Michal Petrov
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
>
> Consider please a form with multiple inputs inside {{popupPanel}}, which is configured to hide when there are no validation issues.
> *The issue is:* If the form is submitted e.g. with {{a4j:commandButton}}, then it hides even when there are some validation issues.
> {{PopupPanel}} has set {{oncomplete}} attribute to:
> {code:JavaScript}
> oncomplete="if (!#{facesContext.validationFailed}) { #{rich:component('popup')}.hide(); } "
> {code}
> {{facesContext.validationFailed}} is wrongly evaluated always to {{false}}.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13785) Validation inside popupPanel is ignored when form is submitted
by Jiří Štefek (JIRA)
[ https://issues.jboss.org/browse/RF-13785?page=com.atlassian.jira.plugin.s... ]
Jiří Štefek commented on RF-13785:
----------------------------------
The latest [commit|https://github.com/richfaces/richfaces/commit/e926ef568c08ffe10fc6...] also broke Autocomplete component.
> Validation inside popupPanel is ignored when form is submitted
> --------------------------------------------------------------
>
> Key: RF-13785
> URL: https://issues.jboss.org/browse/RF-13785
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Affects Versions: 4.5.0.Alpha3, 4.5.0.Beta1
> Reporter: Juraj Húska
> Assignee: Michal Petrov
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
>
> Consider please a form with multiple inputs inside {{popupPanel}}, which is configured to hide when there are no validation issues.
> *The issue is:* If the form is submitted e.g. with {{a4j:commandButton}}, then it hides even when there are some validation issues.
> {{PopupPanel}} has set {{oncomplete}} attribute to:
> {code:JavaScript}
> oncomplete="if (!#{facesContext.validationFailed}) { #{rich:component('popup')}.hide(); } "
> {code}
> {{facesContext.validationFailed}} is wrongly evaluated always to {{false}}.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months
[JBoss JIRA] (RF-13785) Validation inside popupPanel is ignored when form is submitted
by Pavol Pitonak (JIRA)
[ https://issues.jboss.org/browse/RF-13785?page=com.atlassian.jira.plugin.s... ]
Pavol Pitonak commented on RF-13785:
------------------------------------
[~michpetrov], the latest commit broke this test: ITRepeatTab.check_tab_switch
> Validation inside popupPanel is ignored when form is submitted
> --------------------------------------------------------------
>
> Key: RF-13785
> URL: https://issues.jboss.org/browse/RF-13785
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Affects Versions: 4.5.0.Alpha3, 4.5.0.Beta1
> Reporter: Juraj Húska
> Assignee: Michal Petrov
> Priority: Blocker
> Fix For: 4.5.0.Beta1
>
>
> Consider please a form with multiple inputs inside {{popupPanel}}, which is configured to hide when there are no validation issues.
> *The issue is:* If the form is submitted e.g. with {{a4j:commandButton}}, then it hides even when there are some validation issues.
> {{PopupPanel}} has set {{oncomplete}} attribute to:
> {code:JavaScript}
> oncomplete="if (!#{facesContext.validationFailed}) { #{rich:component('popup')}.hide(); } "
> {code}
> {{facesContext.validationFailed}} is wrongly evaluated always to {{false}}.
--
This message was sent by Atlassian JIRA
(v6.2.6#6264)
10 years, 3 months