[
https://issues.jboss.org/browse/RF-13514?page=com.atlassian.jira.plugin.s...
]
Juraj Húska edited comment on RF-13514 at 3/27/14 11:17 AM:
------------------------------------------------------------
I have tested {{r:fileUpload}} refactored in
[
this|https://github.com/richfaces/richfaces/tree/RF-13514-fileupload-prog...]
branch.
I have encountered following issues:
*WildFly 8.0.0.Final* && *Chrome*:
** eg. upload a file and then try to add next file, you need to click on add more times
* {{maxFilesQuantity}} attribute does not work, has no effect
* onbegin not fired
* oncomplete not fired
* keydown not fired
*JBoss AS 7.1.1.Final* && *Chrome*
* fileupload is not working,
** e.g. on Showcase: choose a file to upload
** click on upload button
** see that there is progress bar with the initial state displayed, but it does not change
nor the file is uploaded
** I can not see any error
Should I file separate issues for those (I have not done it so as I find it weird
providing that it is not in master) ? Thanks
was (Author: jhuska):
I have tested {{r:fileUpload}} refactored in
[
this|https://github.com/richfaces/richfaces/tree/RF-13514-fileupload-prog...]
branch.
I have encountered following issues:
*WildFly 8.0.0.Final* && *Chrome*:
** eg. upload a file and then try to add next file, you need to click on add more times
* {{maxFilesQuantity}} attribute does not work, has no effect
* onbeforedomupdate not fired
* onbegin not fired
* oncomplete not fired
* keydown not fired
*JBoss AS 7.1.1.Final* && *Chrome*
* fileupload is not working,
** e.g. on Showcase: choose a file to upload
** click on upload button
** see that there is progress bar with the initial state displayed, but it does not change
nor the file is uploaded
** I can not see any error
Should I file separate issues for those (I have not done it so as I find it weird
providing that it is not in master) ? Thanks
Support file upload progress tracking in Servlets >= 3.0
environment
--------------------------------------------------------------------
Key: RF-13514
URL:
https://issues.jboss.org/browse/RF-13514
Project: RichFaces
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: component-input, core
Affects Versions: 5.0.0.Alpha3
Reporter: Lukáš Fryč
Assignee: Michal Petrov
Fix For: 4.5.0.Alpha3
We currently support two approaches for file upload:
* Servlets 2.5: own request form data parser
[{{MultipartRequestParser}}|https://github.com/richfaces/richfaces/blob/master/framework/src/main/java/org/richfaces/request/MultipartRequestParser.java]
* Servlets 3.0: leveraging {{HttpServletRequest#getParts()}}
However as we have discussed RF-13444, we had to finally do a trade-off of limiting
support of file progress tracking. I.e. in Servlets 3.0 we have no simple way how to track
file upload progress since getParts() returns data for completed request.
There are several possible outcomes:
1) drop server-side file upload progress tracking and leverage XHR2/HTML5 that has
built-in ability to track progress
* imho we are already prepared to switch to XHR2 and client-side progress (possibly
leveraging some third-party widget) since [all major browsers support it at least one
version
back|http://caniuse.com/#feat=xhr2]
* existing implementation:
http://www.script-tutorials.com/pure-html5-file-upload/
2) use a {{ServletFilter}} to wrap a request as our {{FileUploadFacesContextFactory}}
currently do and so have an earlier access to the request object
* this principle has a drawback - we have to ensure our filter has high-enough priority
so the servlet container won't touch the request body yet
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira