[
https://issues.jboss.org/browse/RF-13371?page=com.atlassian.jira.plugin.s...
]
Lukáš Fryč updated RF-13371:
----------------------------
Summary: Clarify and fix Push destroy logic (was: Refactored Push destroy logic
is too aggresive and causes ProgressBar to fail)
Description:
I need to commend on the approach I take for destroying Push component which follows
approximately what Widget Factory does.
I have also found that the widget _destro method isn't called at all, because there is
no such event as {{cleanDom}}.
richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right
event to listen for for component cleanup.
was:
From RF-13359:
{quote}
It took a while, but I isolated the single offending line:
https://github.com/richfaces/richfaces/blob/master/framework/src/main/res...
{code}
$(document).on('cleanDom.RICH', function(event, ui) {
if ($.contains(ui.target, widget.element)) {
widget._destroy();
}
});
{code}
[~lfryc] It's not clear to me what you are trying to achieve here, but the end result
seems to be that the destroy call is too aggressive. Can you re-visit this please?
{panel:title=Note:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#FFFFCE}
The isolation was difficult, as the file in question should have nothing to do with the
progressBar component. Hence why the effect was observed only had an effect when included
via resource packaging.
{panel}
{quote}
Clarify and fix Push destroy logic
----------------------------------
Key: RF-13371
URL:
https://issues.jboss.org/browse/RF-13371
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Lukáš Fryč
Assignee: Lukáš Fryč
Priority: Critical
Fix For: 5.0.0.Alpha2
I need to commend on the approach I take for destroying Push component which follows
approximately what Widget Factory does.
I have also found that the widget _destro method isn't called at all, because there
is no such event as {{cleanDom}}.
richfaces.js throws {{beforeDomClean}} and {{afterDomClean}}. The foremost is the right
event to listen for for component cleanup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira