6:47 a.m.
CLONE - rich:messages displays messages multiple times
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-validators
Affects Versions: 3.3.0, 3.3.1, 3.3.2.CR1, 3.3.2.GA, 3.3.2.SR1, 3.3.3.BETA1,
3.3.3.CR1, 3.3.3.Final
Environment: Richfaces 3.3.0 upwards with integrated Spring Webflow (version
2.0.5) and Hibernate Validator 4.0.2.
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Fix For: 3.Future
Using a graphValidator, I set up a bean with Hibernate Validator annotations.
When multiple fields fail validation; the <rich:messages /> tag outputs the error
messages multiple times.
It seems as though the message is displayed based on the number of failed fields. For
example; when 2 fields fail, it will display both error messages twice. If 3 fields fail,
it'll display all 3 messages 3 times, and so on.
I have managed to replicate the same error in versions 3.3.0 to 3.3.3. I have not tried
>4 as we need a stable release. This may mean it could already be fixed in version 4;
but I am submitting this issue regardless.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:47 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) CLONE - rich:messages displays messages multiple times
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky updated RF-10456:
---------------------------------
Fix Version/s: (was: 3.Future)
Affects Version/s: 4.0.0.Milestone6
(was: 3.3.0)
(was: 3.3.1)
(was: 3.3.2.CR1)
(was: 3.3.2.GA)
(was: 3.3.3.CR1)
(was: 3.3.2.SR1)
(was: 3.3.3.BETA1)
(was: 3.3.3.Final)
Environment: (was: Richfaces 3.3.0 upwards with integrated Spring
Webflow (version 2.0.5) and Hibernate Validator 4.0.2.)
Workaround Description: (was: Downgrade to version 3.2.2.)
Workaround: (was: [Workaround Exists])
Description:
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
was:
Using a graphValidator, I set up a bean with Hibernate Validator annotations.
When multiple fields fail validation; the <rich:messages /> tag outputs the error
messages multiple times.
It seems as though the message is displayed based on the number of failed fields. For
example; when 2 fields fail, it will display both error messages twice. If 3 fields fail,
it'll display all 3 messages 3 times, and so on.
I have managed to replicate the same error in versions 3.3.0 to 3.3.3. I have not tried
>4 as we need a stable release. This may mean it could already be fixed in version 4;
but I am submitting this issue regardless.
Steps to Reproduce: (was: Set up environment with Richfaces 3.3.3, Spring
Webflow 2.0.5 and Hibernate Validator 4.0.2.
Create a form for a simple bean and use a <graphValidator /> for that bean.
Set up a single <rich:messages /> tag for that <graphValidator />.
Have more than one field fail validation.
The error messages will be repeated.)
CLONE - rich:messages displays messages multiple times
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:23 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) CLONE - rich:messages displays messages multiple times
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10456:
--------------------------------
Fix Version/s: 4.0.0.CR1
CLONE - rich:messages displays messages multiple times
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Fix For: 4.0.0.CR1
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:32 p.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Jay Balunas updated RF-10456:
-----------------------------
Summary: rich:messages displays messages multiple times [clone] (was: CLONE -
rich:messages displays messages multiple times)
Assuming you have verified that this affects 4.0.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Fix For: 4.0.0.CR1
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:49 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Jay Balunas updated RF-10456:
-----------------------------
Fix Version/s: (was: 4.0.0.CR1)
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:01 p.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky commented on RF-10456:
--------------------------------------
yup. can't re-check right now but when I created it was reproducible stable. Discussed
with Nick prior to posting.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:10 p.m.
New subject: [JBoss JIRA] Assigned: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski reassigned RF-10456:
-----------------------------------
Assignee: Jay Balunas (was: Alexander Smirnov)
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Jay Balunas
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:14 p.m.
New subject: [JBoss JIRA] Assigned: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski reassigned RF-10456:
-----------------------------------
Assignee: Nick Belaevski (was: Jay Balunas)
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 p.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10456:
-------------------------------------
Reliably reproducible when PSS is off.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:23 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski edited comment on RF-10456 at 2/21/11 5:22 PM:
--------------------------------------------------------------
Reproducible for sequential clicks when PSS is off. Note that when PSS is on, graph
validator is just switched off silently because it's not restored by JSF.
was (Author: nbelaevski):
Reliably reproducible when PSS is off.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 p.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10456:
-------------------------------------
Duplicate messages are called by the fact that when rich:graphValidator is used, RF
org.richfaces.validator.FacesBeanValidator is added *after* built-in JSF bean validator
and thus reflect all messages generated by it.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:54 p.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Jay Balunas commented on RF-10456:
----------------------------------
Good find! Is there a way to check for duplicate messages for the same component?
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:05 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski edited comment on RF-10456 at 2/21/11 6:05 PM:
--------------------------------------------------------------
Duplicate messages are called by the fact that when rich:graphValidator is used, RF
org.richfaces.validator.FacesBeanValidator is added *together* with built-in JSF bean
validator. Both generate messages.
was (Author: nbelaevski):
Duplicate messages are called by the fact that when rich:graphValidator is used, RF
org.richfaces.validator.FacesBeanValidator is added *after* built-in JSF bean validator
and thus reflect all messages generated by it.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 p.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10456:
-------------------------------------
Possible workaround could be switching built-in JSF JSR-303 validator off.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:21 p.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Jay Balunas commented on RF-10456:
----------------------------------
Can you do that programmatically on selective components?
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:09 a.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski commented on RF-10456:
-------------------------------------
Jay,
We can remove instances of javax.faces.validator.BeanValidator from components when adding
ours, however this causes several problems:
1) If user registers another class (not ancestor of BeanValidator) as
'javax.faces.Bean' validator, there might be a problems with removal of those
2) Built-in JSR 303 has some functionality we may lack
3) Order of validators will be changed
4) Current implementation has issues with PSS switched on
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:47 a.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky commented on RF-10456:
--------------------------------------
And let's discuss in the same issue why we have rich:beanValidator tag in taglib. Does
it really migrated. Then the question why do we need that? Seems it's just JSF 2
responsibility for now.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:50 p.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10456:
--------------------------------
Fix Version/s: 4.0.0.CR1
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Fix For: 4.0.0.CR1
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:04 p.m.
New subject: [JBoss JIRA] Resolved: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski resolved RF-10456.
---------------------------------
Resolution: Done
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Fix For: 4.0.0.CR1
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:42 a.m.
New subject: [JBoss JIRA] Reopened: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky reopened RF-10456:
----------------------------------
reproducible at Final branch.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Fix For: 4.0.0.CR1
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:44 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky updated RF-10456:
---------------------------------
Component/s: regression
setting critical as regression.
And need to check additionally - messages now changed from just
<rich:messages/>
to
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators, regression
Affects Versions: 4.0.0.Milestone6
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Fix For: 4.0.0.CR1
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:46 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky updated RF-10456:
---------------------------------
Fix Version/s: (was: 4.0.0.CR1)
Affects Version/s: 3.3.1.SP3
(was: 4.0.0.Milestone6)
Component/s: component-tree
qe
(was: regression)
(was: component-validators)
setting critical as regression and because one more problem appeared:
in demo global messages declaration now changed from just
<rich:messages/>
to
<rich:messages for="gv"/>
<rich:messages globalOnly="true"/>
so them should NOT appear if just concrete input validators fails. Only <r:message>
should works in that case.
But now them appears together with "r:message for"
That's either should be fixed or new issues should be created, or should be considered
in docs if some kind of restriction when wrapping inputs to GV.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tree, qe
Affects Versions: 3.3.1.SP3
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:48 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky updated RF-10456:
---------------------------------
Comment: was deleted
(was: setting critical as regression.
And need to check additionally - messages now changed from just
<rich:messages/>
to )
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tree, qe
Affects Versions: 3.3.1.SP3
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:48 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky edited comment on RF-10456 at 3/3/11 9:48 AM:
--------------------------------------------------------------
At first it's shows 4 messages again instead of two ones with rich:messages.
So setting critical as regression and because one more problem appeared:
in demo global messages declaration now changed from just
<rich:messages/>
to
<rich:messages for="gv"/>
<rich:messages globalOnly="true"/>
so them should NOT appear if just concrete input validators fails. Only <r:message>
should works in that case.
But now them appears together with "r:message for"
That's either should be fixed or new issues should be created, or should be considered
in docs if some kind of restriction when wrapping inputs to GV.
was (Author: ilya_shaikovsky):
setting critical as regression and because one more problem appeared:
in demo global messages declaration now changed from just
<rich:messages/>
to
<rich:messages for="gv"/>
<rich:messages globalOnly="true"/>
so them should NOT appear if just concrete input validators fails. Only <r:message>
should works in that case.
But now them appears together with "r:message for"
That's either should be fixed or new issues should be created, or should be considered
in docs if some kind of restriction when wrapping inputs to GV.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tree, qe
Affects Versions: 3.3.1.SP3
Reporter: Ilya Shaikovsky
Assignee: Nick Belaevski
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [JBoss JIRA] Assigned: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski reassigned RF-10456:
-----------------------------------
Assignee: Alexander Smirnov (was: Nick Belaevski)
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tree, qe
Affects Versions: 3.3.1.SP3
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Fix For: 4.0.0.Final
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Nick Belaevski updated RF-10456:
--------------------------------
Fix Version/s: 4.0.0.Final
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-tree, qe
Affects Versions: 3.3.1.SP3
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Fix For: 4.0.0.Final
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:56 a.m.
New subject: [JBoss JIRA] Updated: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky updated RF-10456:
---------------------------------
Affects Version/s: 4.0.0.Milestone5
(was: 3.3.1.SP3)
Priority: Critical (was: Major)
Component/s: component-validators
(was: qe)
(was: component-tree)
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone5
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Priority: Critical
Fix For: 4.0.0.Final
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:59 a.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Ilya Shaikovsky commented on RF-10456:
--------------------------------------
So one more comment in order to summarize after meeting.
Currently seems input bound properties validated twice and adds two messages. Once for the
component and second time for gv component.
Result:
rich:messages shows input bound messages twice
rich:messages for gv shows all the messages and I really need to customize to show only
unbound ones.
let's skip second messages addition for now and it will works just more cleaner (1
message per field, and only "global"(ones which added by GV but not bound to
components) will be fired.)
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone5
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Priority: Critical
Fix For: 4.0.0.Final
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:53 p.m.
New subject: [JBoss JIRA] Commented: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Alexander Smirnov commented on RF-10456:
----------------------------------------
Added check for the FacesContext.isValidationFailed. if it's true, no validation for
object performed.
Also, no validation after model updates if cloned object was used.
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone5
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Priority: Critical
Fix For: 4.0.0.Final
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:53 p.m.
New subject: [JBoss JIRA] Resolved: (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
Alexander Smirnov resolved RF-10456.
------------------------------------
Resolution: Done
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone5
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Priority: Critical
Fix For: 4.0.0.Final
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:32 p.m.
New subject: [JBoss JIRA] (RF-10456) rich:messages displays messages multiple times [clone]
[
https://issues.jboss.org/browse/RF-10456?page=com.atlassian.jira.plugin.s...
]
burak sarac commented on RF-10456:
----------------------------------
Hi All, I had small temporary workaround for this issue. Maybe it can help:
http://stackoverflow.com/a/9184935/706695
rich:messages displays messages multiple times [clone]
------------------------------------------------------
Key: RF-10456
URL: https://issues.jboss.org/browse/RF-10456
Project: RichFaces
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: component-validators
Affects Versions: 4.0.0.Milestone5
Reporter: Ilya Shaikovsky
Assignee: Alexander Smirnov
Priority: Critical
Fix For: 4.0.0.Final
Clonned 3.3.x issue.
code used:
<h:form>
<rich:graphValidator value="#{userBean}">
<rich:panel header="Change password" style="width:500px">
<rich:messages/>
<h:panelGrid columns="3">
<h:outputText value="Enter new password:" />
<h:inputSecret value="#{userBean.password}" id="pass" />
<rich:message for="pass" />
<h:outputText value="Confirm the new password:" />
<h:inputSecret value="#{userBean.confirm}" id="conf" />
<rich:message for="conf" />
</h:panelGrid>
<h:commandButton value="submit"
action="#{userBean.storeNewPassword}" />
<a4j:commandButton value="Store changes"
action="#{userBean.storeNewPassword}" />
</rich:panel>
</rich:graphValidator>
</h:form>
and
@ManagedBean
@RequestScoped
public class UserBean {
@Size(min = 5, max = 15, message="Wrong size for password")
private String password;
@Size(min = 5, max = 15, message="Wrong size for confirmation")
private String confirm;
private String status = "";
@AssertTrue(message = "Different passwords entered!")
public boolean isPasswordsEquals() {
return password.equals(confirm);
}
public void storeNewPassword(){
FacesContext.getCurrentInstance().addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_INFO, "Succesfully changed!",
"Succesfully changed!"));
}
after first click all the messages appears twice. After the second - looks ok.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4676
days inactive
5040
days old
richfaces-issues@lists.jboss.org
30 comments
5 participants
participants (5)
-
Alexander Smirnov (JIRA) -
burak sarac (JIRA)
-
Ilya Shaikovsky (JIRA)
-
Jay Balunas (JIRA)
-
Nick Belaevski (JIRA)