[JBoss JIRA] Created: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[JBoss JIRA] Commented: (RF-696)...

[JBoss JIRA] Created: (RF-6256)...

Sergey Astakhov (JIRA)

Wednesday, 4 February 2009 Wed, 4 Feb '09

4:49 a.m.

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Nick Belaevski (JIRA)

Wednesday, 4 February Wed, 4 Feb

9:10 a.m.

New subject: [JBoss JIRA] Updated: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Nick Belaevski updated RF-6027: ------------------------------- Fix Version/s: 3.3.1 Assignee: Pavel Yaschenko

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Pavel Yaschenko Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pavel Yaschenko (JIRA)

Monday, 9 February Mon, 9 Feb

10:13 a.m.

New subject: [JBoss JIRA] Resolved: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Pavel Yaschenko resolved RF-6027. --------------------------------- Resolution: Done Assignee: Tsikhon Kuprevich (was: Pavel Yaschenko)

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Tsikhon Kuprevich Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Sergey Astakhov (JIRA)

11:58 a.m.

New subject: [JBoss JIRA] Commented: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Sergey Astakhov commented on RF-6027: ------------------------------------- I'm not sure about your fix. After setInterval(), the method correctShadowSize() will be continue calling until clearInterval() is cancel this. So, by setting id (observerSize) to null in correctShadowSize() you are effectively cancel invoking clearInverval() at destroy method, but didn't cancel invoking correctShadowSize(). Did I miss something? correctShadowSize: function(event) { this.correctShadowSizeEx(); + this.observerSize = null; }

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Tsikhon Kuprevich Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Sergey Astakhov (JIRA)

Monday, 16 February Mon, 16 Feb

1:57 a.m.

New subject: [JBoss JIRA] Reopened: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Sergey Astakhov reopened RF-6027: --------------------------------- Please, recheck the fix.

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Tsikhon Kuprevich Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Nick Belaevski (JIRA)

Monday, 2 March Mon, 2 Mar

9:53 a.m.

New subject: [JBoss JIRA] Updated: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Nick Belaevski updated RF-6027: ------------------------------- Assignee: Pavel Yaschenko (was: Tsikhon Kuprevich)

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Pavel Yaschenko Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Nick Belaevski (JIRA)

Monday, 30 March Mon, 30 Mar

9:42 p.m.

New subject: [JBoss JIRA] Assigned: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Nick Belaevski reassigned RF-6027: ---------------------------------- Assignee: Nick Belaevski (was: Pavel Yaschenko)

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Nick Belaevski Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Nick Belaevski (JIRA)

Tuesday, 31 March Tue, 31 Mar

12:01 p.m.

New subject: [JBoss JIRA] Work started: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Work on RF-6027 started by Nick Belaevski.

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Nick Belaevski Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Nick Belaevski (JIRA)

12:29 p.m.

New subject: [JBoss JIRA] Work stopped: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Work on RF-6027 stopped by Nick Belaevski.

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Nick Belaevski Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Nick Belaevski (JIRA)

12:29 p.m.

New subject: [JBoss JIRA] Resolved: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Nick Belaevski resolved RF-6027. -------------------------------- Resolution: Done

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Nick Belaevski Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Nick Belaevski (JIRA)

12:29 p.m.

New subject: [JBoss JIRA] Assigned: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Nick Belaevski reassigned RF-6027: ---------------------------------- Assignee: Tsikhon Kuprevich (was: Nick Belaevski)

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Tsikhon Kuprevich Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

Tsikhon Kuprevich (JIRA)

Wednesday, 29 April Wed, 29 Apr

7:58 a.m.

New subject: [JBoss JIRA] Closed: (RF-6027) ModalPanel: incomplete cleanup at destroy method

[ https://jira.jboss.org/jira/browse/RF-6027?page=com.atlassian.jira.plugin... ] Tsikhon Kuprevich closed RF-6027. --------------------------------- Assignee: Nick Belaevski (was: Tsikhon Kuprevich)

...

ModalPanel: incomplete cleanup at destroy method ------------------------------------------------ Key: RF-6027 URL: https://jira.jboss.org/jira/browse/RF-6027 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: IE7 Reporter: Sergey Astakhov Assignee: Nick Belaevski Fix For: 3.3.1 Extracts from modalPanel.js: show(): ... if (this.options.autosized) { this.observerSize = window.setInterval(this.correctShadowSize.bindAsEventListener(this), 500); } ... hide(): ... if (this.options.autosized) { window.clearInterval(this.observerSize); } ... You are setting up timer listener when ModalPanel is displayed, and clear it when hiding. All works fine when show() is paired with hide(), but there is exist a possibilities when region with panel is replaced by ajax response, then on panel is called only the destroy() method, but not hide(). In this case timer is rest in memory and cause flickering of shadow of panel if you try to display the panel (replaced by ajax) again (and may cause memory leaks). As workaround I tried to include cleanup code in destroy() method: --- ModalPanel.prototype.originalModalDestroy = ModalPanel.prototype.destroy; ModalPanel.prototype.destroy = function(id, options) { if( this.shown && this.options.autosized ) { window.clearInterval(this.observerSize); } return this.originalModalDestroy(id, options); }; --- After this change the problems seems to gone away.

5639

days inactive

5723

days old

richfaces-issues@lists.jboss.org

Manage subscription

11 comments

4 participants

tags (0)

participants (4)

Nick Belaevski (JIRA)
Pavel Yaschenko (JIRA)
Sergey Astakhov (JIRA)
Tsikhon Kuprevich (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

[JBoss JIRA] Created: (RF-6027) ModalPanel: incomplete cleanup at destroy method