November 2008 - richfaces-issues - Jboss List Archives

[JBoss JIRA] Created: (RF-3759) calendar missed oncurrentdayselect call

by Ilya Shaikovsky (JIRA)

calendar missed oncurrentdayselect call --------------------------------------- Key: RF-3759 URL: http://jira.jboss.com/jira/browse/RF-3759 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.1 Reporter: Ilya Shaikovsky Assigned To: Nick Belaevski <rich:calendar value="#{calendarBean.selectedDate}" popup="false" showApplyButton="false" cellWidth="120px" cellHeight="120px" boundaryDatesMode="select" showWeeksBar="false" dataModel="#{calendarDataModel}" oncurrentdateselect="return false"> If I'm trying to change current date from header controls - all works fine,(date NOT changed as return false called) But if I click on boundary date - event even not fired on state change so calendar switched. In my case I could workaround it by changing boundarydatemode but anyway event should be fired on boundary date click in scroll and select modes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

4
9
0 / 0

[JBoss JIRA] Created: (RF-4193) FileUpload component crash if form contain control with name "action".

by Alexander Smirnov (JIRA)

FileUpload component crash if form contain control with name "action". ---------------------------------------------------------------------- Key: RF-4193 URL: https://jira.jboss.org/jira/browse/RF-4193 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.0.SR1 Reporter: Alexander Smirnov JavaScript code for a Fileupload component modify a form "action" property: parentForm.action = this.actionUrl +........ If form contain any control with name "action" , this code will try to replace a control instead of the form attribute. At least, this limitation should be described in the documentation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

4
12
0 / 0

[JBoss JIRA] Created: (RF-4544) Columns: non-thread-safe facelet hadler

by Andrei Markavtsov (JIRA)

Columns: non-thread-safe facelet hadler --------------------------------------- Key: RF-4544 URL: https://jira.jboss.org/jira/browse/RF-4544 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: RF 3.2.2.GA Facelets 1.1.14 Reporter: Andrei Markavtsov Assignee: Andrei Markavtsov Priority: Critical Fix For: 3.3.0 Iteration variables are storing in non-thread -safe area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

2
3
0 / 0

[JBoss JIRA] Created: (RF-4554) ViewHandlerWrapper#fillChain performance degrade

by Nick Belaevski (JIRA)

ViewHandlerWrapper#fillChain performance degrade ------------------------------------------------ Key: RF-4554 URL: https://jira.jboss.org/jira/browse/RF-4554 Project: RichFaces Issue Type: Bug Affects Versions: 3.3.0 Reporter: Nick Belaevski Assignee: Nick Belaevski Fix For: 3.3.0 Method ViewHandlerWrapper#fillChain is synchrononized thus causing performance degrade -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

2
4
0 / 0

[JBoss JIRA] Created: (RF-4040) dataTable: border displays only at the bottom and on the right of dataTable

by Tatyana Romanovich (JIRA)

dataTable: border displays only at the bottom and on the right of dataTable --------------------------------------------------------------------------- Key: RF-4040 URL: https://jira.jboss.org/jira/browse/RF-4040 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: RF-3.2.2.BETA2 jsp, facelets all browsers Tomcat 6 Reporter: Tatyana Romanovich Assignee: Nick Belaevski Priority: Minor 1. Go to the test application 2. Select dataTable component 3. Set border=5px result: border displays only at the bottom and on the right of dataTable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

2
6
0 / 0

[JBoss JIRA] Created: (RF-3569) <rich:tree> possible performance issue

by martin bischoff (JIRA)

<rich:tree> possible performance issue --------------------------------------- Key: RF-3569 URL: http://jira.jboss.com/jira/browse/RF-3569 Project: RichFaces Issue Type: Quality Risk Affects Versions: 3.2.0 Reporter: martin bischoff Fix For: 3.2.0.SR1 i've got an quite simple tree with "just" 50 elements ÃÂ¡ 200 childs -> 10.000 nodes every node gots: - some little text - image for a checkbox via h:graphicImage - a4j:support for listenersupport at the image expanding/collapsing nodes and checking the checkboxes takes a lot of time... jprofiler tells me that most of the time is spend by domparsing. i dont know if i handle the tree as intended. here is some code: JSP [code] <%@ taglib uri="http://richfaces.org/a4j" prefix="a4j"%> <%@ taglib uri="http://richfaces.org/rich" prefix="rich"%> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%> <html> <head> <title>tree</title> </head> <body> <f:view> <h:form> <a4j:loadStyle src="/res/button.css" /> <a4j:loadStyle src="/res/tree/style.css" /> <a4j:commandButton id="show_me" value="show childs" styleClass="normalButton"> <a4j:ajaxListener type="controller.listener.ListenerBean" /> </a4j:commandButton> <h:panelGrid columns="2"> <h:outputLabel> <h:outputText value="infinite Tree extended"></h:outputText> <rich:tree componentState="#{treeBean.treeState}" id="infinite_Tree_expanded" style="width:300px" switchType="ajax" stateAdvisor="#{treeDemoStateAdvisor}"> <rich:recursiveTreeNodesAdaptor roots="#{treeBean.rootNodes}" var="item" nodes="#{item.children}"> <rich:treeNode nodeSelectListener="#{treeBean.processSelection}"> <h:graphicImage value="/res/tree/chkb_#{item.state}.png"> <a4j:support event="onclick" reRender="infinite_Tree_expanded" actionListener="#{item.actionListener}"/> </h:graphicImage> <h:outputText value="#{item.value} - #{item.state}"/> </rich:treeNode> </rich:recursiveTreeNodesAdaptor> </rich:tree> </h:outputLabel> </h:panelGrid> </h:form> </f:view> </body> </html>[/code] TreeBean: [code]package my_tree; import java.io.IOException; import java.io.InputStream; import java.util.Properties; import javax.faces.FacesException; import javax.faces.context.ExternalContext; import javax.faces.context.FacesContext; import javax.faces.event.AbortProcessingException; import org.richfaces.component.state.TreeState; import org.richfaces.event.NodeSelectedEvent; public class TreeBean { private TreeNode rootNode = null; private TreeNode[] rootNodes = null; private TreeState treeState; private static final String DATA_PATH = "/res/tree/simple-tree-data.properties"; public TreeNode getRootNode() { if (rootNode == null) { loadTree(); } return rootNode; } public void setRootNode(TreeNode rootNode) { this.rootNode = rootNode; } public TreeNode[] getRootNodes() { if (rootNodes == null) { rootNodes = this.getRootNode().getChildren(); } return rootNodes; } public void setRootNodes(TreeNode[] rootNodes) { this.rootNodes = rootNodes; } public TreeState getTreeState() { return treeState; } public void setTreeState(TreeState treeState) { this.treeState = treeState; } private void addNodes(String path, TreeNode node, Properties properties) { boolean end = false; int counter = 1; while (!end) { String key = path != null ? path + '.' + counter : String .valueOf(counter); String value = properties.getProperty(key); if (value != null) { TreeNode newNode = new TreeNode(value); newNode.setParent(node); node.addNode(newNode); addNodes(key, newNode, properties); counter++; } else { end = true; } } } private void loadTree() { System.out.println("TreeBean -> loadTree()"); FacesContext facesContext = FacesContext.getCurrentInstance(); ExternalContext externalContext = facesContext.getExternalContext(); InputStream dataStream = externalContext.getResourceAsStream(DATA_PATH); try { Properties properties = new Properties(); properties.load(dataStream); rootNode = new TreeNode("root"); addNodes(null, rootNode, properties); // manual tree extension TreeNode dummy = new TreeNode("Sichtlinie"); int count = 0; for (int i = 1; i <= 50; i++) { count++; TreeNode node = new TreeNode("i" + i); for (int j = 1; j <= 200; j++) { count++; if (count % 1000 == 0) { System.out.println(count); } TreeNode child = new TreeNode("j" + j); child.setParent(node); node.addNode(child); } node.setParent(dummy); dummy.addNode(node); } rootNode.addNode(dummy); } catch (IOException e) { e.printStackTrace(); throw new FacesException(e.getMessage(), e); } finally { if (dataStream != null) { try { dataStream.close(); } catch (IOException e) { e.printStackTrace(); externalContext.log(e.getMessage(), e); } } } } public void processSelection(NodeSelectedEvent arg0) throws AbortProcessingException { System.out.println("SimpleTreeBean -> processSelection fired by " + arg0.getComponent().getId()); }[/code] TreeNode: [code]package my_tree; import javax.faces.event.ActionEvent; import org.richfaces.model.TreeNodeImpl; public class TreeNode{ private String value; private String state; private TreeNode parent; private TreeNode[] children; public TreeNode(String value) { this.value = value; this.state = ""; } public synchronized void addNode(TreeNode newChild) { System.out.println("addNode("+newChild.getValue()+")"); if (this.children == null) { TreeNode[] merged = new TreeNode[1]; merged[0] = newChild; this.children = merged; } else { TreeNode[] merged = new TreeNode[this.children.length + 1]; int i; for (i = 0; i < this.children.length; i++) { merged[i] = this.children[i]; } merged[merged.length - 1] = newChild; this.children = merged; } } public synchronized void addNodes(TreeNode[] newChildren) { System.out.println("addNodeS("+newChildren.length+")"); TreeNode[] merged = new TreeNode[newChildren.length + this.children.length]; int i; for (i = 0; i <= this.children.length; i++) { merged[i] = this.children[i]; } for (int i2 = i; i2 <= newChildren.length + i; i2++) { merged[i2] = newChildren[i2]; } this.children = merged; } public synchronized void removeNodes(TreeNode[] removeChildren) { TreeNode[] splitted = new TreeNode[this.children.length - removeChildren.length]; int pos = 0; for (int i = 0; i <= this.children.length; i++) { boolean contains = false; for (int j = 0; j <= removeChildren.length; j++) { if (this.children[i] == removeChildren[j]) { contains = true; } } if (contains == false) { splitted[pos] = this.children[i]; pos++; } } } public String checkSibling(){ //System.out.println("checkSibling() of "+this.value); if(this.children!=null){ String state = null; int checked = 0; int sub = 0; int i; TreeNode[] siblings = this.children; for (i = 0; i < siblings.length; i++) { TreeNode treeNode = siblings[i]; //System.out.println("\t"+treeNode.getValue()+" - "+treeNode.getState()); if(!treeNode.getState().equals("")){ if(treeNode.getState().equals("checked")){ checked++; } else if(treeNode.getState().equals("sub")){ sub++; } } } if(checked == i){ state = "checked"; } else if(sub > 0 || checked > 0) { state = "sub"; } else { state = ""; } //System.out.println("siblings: "+i+" (checked: "+checked+" sub: "+sub+") -> "+state); return state; } else { return ""; } } public void setChildsChecked(TreeNode node){ //System.out.println("TreeNode -> setChildsChecked of "+node.getValue()); if(node.getChildren()!=null){ TreeNode[] children = node.getChildren(); for (int i = 0; i < children.length; i++) { TreeNode treeNode = children[i]; treeNode.setState("checked"); setChildsChecked(treeNode); } } } public void setChildsUnchecked(TreeNode node){ //System.out.println("TreeNode -> setChildsUnchecked of "+node.getValue()); if(node.getChildren()!=null){ TreeNode[] children = node.getChildren(); for (int i = 0; i < children.length; i++) { TreeNode treeNode = children[i]; treeNode.setState(""); setChildsUnchecked(treeNode); } } } public void setParentsState(TreeNode node){ System.out.println("TreeNode -> setParentsState of "+node.getValue()); node.setState(node.checkSibling()); if(node.getParent()!=null){ setParentsState(node.getParent()); } } public void actionListener(ActionEvent ae){ //System.out.println("TreeNode -> nodeListener fired by "+ae.getComponent().getId()); if(this.state == "checked"){ this.state = ""; setChildsUnchecked(this); } else { this.state = "checked"; setChildsChecked(this); } if(this.parent!=null){ setParentsState(this.parent); } } public String getValue() { return value; } public void setValue(String value) { this.value = value; } public TreeNode[] getChildren() { return children; } public void setChildren(TreeNode[] children) { this.children = children; } public TreeNode getParent() { if(parent==null){ return null; } else { return parent; } } public void setParent(TreeNode parent) { this.parent = parent; } public String getState() { return state; } public void setState(String state) { this.state = state; } } [/code] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

4
9
0 / 0

[JBoss JIRA] Created: (RF-4517) ArrayIndexOutOfBoundsException for scrollableDataTable in 3.2.2 GA and 3.3.3 snapshot

by andreas_back (JIRA)

ArrayIndexOutOfBoundsException for scrollableDataTable in 3.2.2 GA and 3.3.3 snapshot ------------------------------------------------------------------------------------- Key: RF-4517 URL: https://jira.jboss.org/jira/browse/RF-4517 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: Browser independent Reporter: andreas_back Subversion shows that konstantin.mishin introduced the code String[] si = options.split(","); grid.setFirst(Integer.parseInt(si[1])); component.getAttributes().put(ScrollableDataTableUtils.CLIENT_ROW_KEY, Integer.parseInt(si[3])); into the class ScrollableDataTableBaseRenderer at 02 September 2008 for the bugfix of RF-4367. After changing to 3.2.2 GA we see the following exception for scrollableDataTables. The exception occurs if the table contains less rows than the rows parameter in the definition of the rich:scrollableDataTable: java.lang.ArrayIndexOutOfBoundsException: 3 org.richfaces.renderkit.html.ScrollableDataTableBaseRenderer.doDecode(ScrollableDataTableBaseRenderer.java:651) org.ajax4jsf.renderkit.RendererBase.decode(RendererBase.java:76) javax.faces.component.UIComponentBase.decode(UIComponentBase.java:789) org.ajax4jsf.component.UIDataAdaptor.processDecodes(UIDataAdaptor.java:1159) org.ajax4jsf.component.UIDataAdaptor.processDecodes(UIDataAdaptor.java:1168) org.richfaces.component.UIScrollableDataTable.processDecodes(UIScrollableDataTable.java:140) javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1026) javax.faces.component.UIForm.processDecodes(UIForm.java:209) javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1026) org.richfaces.component.UISwitchablePanel.processDecodes(UISwitchablePanel.java:169) org.richfaces.component.UITabPanel.processDecodes(UITabPanel.java:154) org.ajax4jsf.component.AjaxViewRoot$1.invokeContextCallback(AjaxViewRoot.java:392) org.ajax4jsf.component.AjaxViewRoot.processPhase(AjaxViewRoot.java:238) org.ajax4jsf.component.AjaxViewRoot.processDecodes(AjaxViewRoot.java:409) com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:78) com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100) com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118) javax.faces.webapp.FacesServlet.service(FacesServlet.java:265) org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:177) org.ajax4jsf.webapp.BaseFilter.handleRequest(BaseFilter.java:267) org.ajax4jsf.webapp.BaseFilter.processUploadsAndHandleRequest(BaseFilter.java:380) org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:507) Within the class ScrollableDataTableBaseRenderer the string options contains for example a string "0,0,19" if rows="19" is set in the specification of the scrollableDataTable. Therefore the array si has a length of 3, which results into the execption. Changing ScrollableDataTableBaseRenderer.java from component.getAttributes().put(ScrollableDataTableUtils.CLIENT_ROW_KEY, Integer.parseInt(si[3])); into component.getAttributes().put(ScrollableDataTableUtils.CLIENT_ROW_KEY, Integer.parseInt(si[2])); seems to resolve this error in the test that have been done locally. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

4
9
0 / 0

[JBoss JIRA] Created: (RF-4197) Cancel self D'n'D

by Nick Belaevski (JIRA)

Cancel self D'n'D ----------------- Key: RF-4197 URL: https://jira.jboss.org/jira/browse/RF-4197 Project: RichFaces Issue Type: Task Affects Versions: 3.2.2 Reporter: Nick Belaevski Assignee: Nick Belaevski Forbid the behavior when node can be dropped to itself. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

2
3
0 / 0

[JBoss JIRA] Created: (RF-4759) Selenium enhancements

by Konstantin Mishin (JIRA)

Selenium enhancements --------------------- Key: RF-4759 URL: https://jira.jboss.org/jira/browse/RF-4759 Project: RichFaces Issue Type: Task Components: planning, planning_all Reporter: Konstantin Mishin Assignee: Konstantin Mishin Fix For: 3.3.0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

2
2
0 / 0

[JBoss JIRA] Created: (RF-3109) Update Facelet component handlers to comply with JSF 1.2 standards

by Nick Belaevski (JIRA)

Update Facelet component handlers to comply with JSF 1.2 standards ------------------------------------------------------------------ Key: RF-3109 URL: http://jira.jboss.com/jira/browse/RF-3109 Project: RichFaces Issue Type: Task Affects Versions: 3.2.1 Reporter: Nick Belaevski Assigned To: Maksim Kaszynski Fix For: 3.2.1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 3 months

2
5
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues November 2008