August 2008 - richfaces-issues - Jboss List Archives

[JBoss JIRA] Created: (RF-4283) Rich:datascroller does not show the correct number of pages when used with ExtendedDataModel

by Hristo Mitkov (JIRA)

Rich:datascroller does not show the correct number of pages when used with ExtendedDataModel -------------------------------------------------------------------------------------------- Key: RF-4283 URL: https://jira.jboss.org/jira/browse/RF-4283 Project: RichFaces Issue Type: Bug Affects Versions: 3.0.0 Reporter: Hristo Mitkov Priority: Critical Rich:datascroller cannnot be set to show the correct number of pages when using an ExtendedDataModel. The reason for this is that ListSequenceDataModel is used for calculating the number of pages instead of ExtendedDataModel. I have TestDataModel class which extends SerializableDataModel where in wrappedData I return just 10 elements but my getRowCount method returns the number of all records in the database which is 500. The datascroller though shows that there is only one page. I debug the richfaces code to see how the datascroller is rendered. This is done mainly in DatascrollerTemplate and DataScrollerRenderer in package org.richfaces.renderkit.html. As expected the datascroller uses the DataModel of the DataTable to calculate the number of pages: org.richfaces.component.UIDatascroller.getRowCount(UIData data) and after: UIDataAdapter.getRowCount(){ ... return getExtendedDataModel().getRowCount(); } Here getExtendedDataModel() returns an instance of ModifiableModel which field "originalModel" contains my custom TestDataModel. So modifiableModel.getOriginalModel.getRowCount will return 500 as I need. But look at the implementation of modifiableModel.getRowCount: public int getRowCount() { return delegate.getRowCount(); } !!!??? delegate is an instance of ListSequenceDataModel which contains the list wrappedKeys. So getRowCount() returns wrappedKeys.size() which is 10 so the datascroller renders with only one page. The correct implementation of modifiableModel.getRowCount should be: public int getRowCount() { return originalModel.getRowCount(); } At the time of rendering the dataTable when the model is created () both fields: modifiableModel.originalModel and modifiableModel.delegate are set to TestDataModel. But at some point delegate is set to ListSequenceDataModel and returns the size of the list. Another thing is that there is no way to set the number of pages directly to the UIDatascroller component either by an attribute or by the API Here is an example code: This is the datamodel class: @Name("testDataModel") @Scope(ScopeType.SESSION) public class TestDataModel extends SerializableDataModel { private Integer currentPk; private boolean detached = false; private boolean descending; private List<Integer> wrappedKeys = null; private final Map<Integer, Container> wrappedData = new HashMap<Integer, Container>(); private int rowCount=0; @Override public Object getRowKey() { return currentPk; } @Override public void setRowKey(Object key) { this.currentPk = (Integer) key; } @In(create = true) private ContainerService containerManager; @Override public void walk(FacesContext context, DataVisitor visitor, Range range, Object argument) throws IOException { if (detached){ for (Integer key : wrappedKeys) { setRowKey(key); visitor.process(context, key, argument); } } else { int firstRow = ((SequenceRange) range).getFirstRow(); int numberOfRows = 10;// ((SequenceRange) range).getRows(); wrappedKeys = new ArrayList<Integer>(); for (Container container : containerManager.findContainersPaged(firstRow, numberOfRows, null, null)) { wrappedKeys.add(container.getId()); wrappedData.put(container.getId(), container); visitor.process(context, container.getId(), argument); } } } @Override public SerializableDataModel getSerializableModel(Range range) { if (wrappedKeys != null) { detached = true; return this; } return null; } @Override public void update() { detached = false; } @Override public int getRowCount() { if(rowCount==0){ rowCount=containerManager.countContainers(); } // Here for test and debug purposes you can comment the code above and just do: // return 500; return rowCount; } @Override public Object getRowData() { if (currentPk == null) { return null; } else { Container container = wrappedData.get(currentPk); if (container == null) { container = containerManager.getContainerById(currentPk); wrappedData.put(currentPk, container); } return container; } } @Override public boolean isRowAvailable() { if (currentPk == null) { return false; } if (wrappedKeys.contains(currentPk)) { return true; } if (wrappedData.entrySet().contains(currentPk)) { return true; } if (containerManager.getContainerById(currentPk) != null) { return true; } return false; } @Override public void setRowIndex(int index) { } @Override public int getRowIndex() { throw new UnsupportedOperationException(); } @Override public Object getWrappedData() { throw new UnsupportedOperationException(); } @Override public void setWrappedData(java.lang.Object data) { throw new UnsupportedOperationException(); } } Thisis the seam managed bean. It can be any kind of jsf managed bean: @Stateful @Name("containerManager") public class ContainerManager implements ContainerService { public Integer countContainers() { //For test and debug purposes you can comment the following code and just: return 500; Session session = (Session) entityManager.getDelegate(); Criteria criteria = session.createCriteria(Container.class).setProjection(Projections.rowCount()); Integer containerCount = (Integer) criteria.uniqueResult(); return containerCount; } public List<Container> findContainersPaged(int firstRow, int numberOfRows, String sortField, boolean descending) { List<Container> container = entityManager.createQuery("select c from Container c ").setFirstResult(firstRow).setMaxResults(numberOfRows).getResultList(); return container; } public Container getContainerById(Integer id) { return entityManager.find(Container.class, id); } } This is the page <rich:dataTable id="containerList" rows="10" var="c" value="#{testDataModel}"> <rich:column> <f:facet name="header"> <h:outputText value="Name" /> </f:facet> <h:outputText value="#{c.name}" /> </rich:column> </rich:dataTable> <rich:datascroller align="left" for="containerList" maxPages="10" rendered="true" /> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

3
2
0 / 0

[JBoss JIRA] Created: (RF-4272) dataScroller: doesn't work with extendedDataTable

by Tsikhon Kuprevich (JIRA)

dataScroller: doesn't work with extendedDataTable ------------------------------------------------- Key: RF-4272 URL: https://jira.jboss.org/jira/browse/RF-4272 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: jsp jsf 1.2 Reporter: Tsikhon Kuprevich Assignee: Nick Belaevski dataScroller: doesn't work with extendedDataTable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

4
5
0 / 0

[JBoss JIRA] Created: (RF-3711) validation errors at RF tld files.

by Ilya Shaikovsky (JIRA)

validation errors at RF tld files. ---------------------------------- Key: RF-3711 URL: http://jira.jboss.com/jira/browse/RF-3711 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.1 Reporter: Ilya Shaikovsky Assigned To: Nick Belaevski http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4158403#4158403 http://www.nabble.com/Error-with-XMLBeanUtil-and-ValidateDD-when-upgradin... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

3
3
0 / 0

[JBoss JIRA] Created: (RF-4264) SuggestionBox: object selection works incorrectly in IE7

by Nick Belaevski (JIRA)

SuggestionBox: object selection works incorrectly in IE7 -------------------------------------------------------- Key: RF-4264 URL: https://jira.jboss.org/jira/browse/RF-4264 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Reporter: Nick Belaevski Assignee: Pavel Yaschenko Priority: Critical Fix For: 3.2.2 1. Open suggestionBox in richfaces-demo 2. Type 'a', select 'Atlanta' -> Atlanta appears in selected cities list 3. Type 's', select 'Sacramento' -> Sacramento replaces Atlanta in selected cities list -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

3
3
0 / 0

[JBoss JIRA] Created: (RF-3584) PanelBar: rich-* class for item is missing

by Nick Belaevski (JIRA)

PanelBar: rich-* class for item is missing ------------------------------------------ Key: RF-3584 URL: http://jira.jboss.com/jira/browse/RF-3584 Project: RichFaces Issue Type: Bug Reporter: Nick Belaevski Assigned To: Nick Belaevski Fix For: 3.2.2 rich-* class complementary to .dr-pnlbar-ext is missing -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

4
10
0 / 0

[JBoss JIRA] Created: (RF-2830) dataFilterSlider: in IE7 handler hides if handlervalue=maxValue

by Ilya Shaikovsky (JIRA)

dataFilterSlider: in IE7 handler hides if handlervalue=maxValue --------------------------------------------------------------- Key: RF-2830 URL: http://jira.jboss.com/jira/browse/RF-2830 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.0 Reporter: Ilya Shaikovsky Assigned To: Nick Belaevski Fix For: 3.2.1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

5
8
0 / 0

[JBoss JIRA] Created: (RF-4296) Email validator works incorrectly.

by Alexander Dubovsky (JIRA)

Email validator works incorrectly. ---------------------------------- Key: RF-4296 URL: https://jira.jboss.org/jira/browse/RF-4296 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Environment: richfaces-demo Reporter: Alexander Dubovsky Assignee: Ilya Shaikovsky Priority: Minor # Open demo application on any page from Ajax Validators group # Find any field which should be validated as email. Input in it e.g. "email@tut" (incorrect email address) # Validate field Result: validation is passes. - This is incorrect. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

2
2
0 / 0

[JBoss JIRA] Closed: (RF-531) Tree: clean excess markup

by Tatyana Romanovich (JIRA)

[ https://jira.jboss.org/jira/browse/RF-531?page=com.atlassian.jira.plugin.... ] Tatyana Romanovich closed RF-531. --------------------------------- > Tree: clean excess markup > ------------------------- > > Key: RF-531 > URL: https://jira.jboss.org/jira/browse/RF-531 > Project: RichFaces > Issue Type: Task > Affects Versions: 3.1.0 > Reporter: Nick Belaevski > Assignee: py > Priority: Critical > Fix For: 3.1.0 > > Original Estimate: 2 days > Remaining Estimate: 2 days > > Change nesting tables markup to div-based one. Update script and style classes. > Assign to Svetlana when complete to update documentation -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

1
0
0 / 0

[JBoss JIRA] Closed: (RF-602) Tree: lack of rich-* classes

by Tatyana Romanovich (JIRA)

[ https://jira.jboss.org/jira/browse/RF-602?page=com.atlassian.jira.plugin.... ] Tatyana Romanovich closed RF-602. --------------------------------- > Tree: lack of rich-* classes > ---------------------------- > > Key: RF-602 > URL: https://jira.jboss.org/jira/browse/RF-602 > Project: RichFaces > Issue Type: Task > Affects Versions: 3.1.0 > Reporter: Nick Belaevski > Assignee: Pavel Yaschenko > Fix For: 3.1.0 > > > Tree component has almost no rich-* classes. Add them to node & children (see treeNode.jspx & org.richfaces.renderkit.TreeRendererBase.RendererDataModelEventNavigator.openDiv(Context) method) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

1
0
0 / 0

[JBoss JIRA] Closed: (RF-545) Tree: add handling for isRowAvailable() method

by Tatyana Romanovich (JIRA)

[ https://jira.jboss.org/jira/browse/RF-545?page=com.atlassian.jira.plugin.... ] Tatyana Romanovich closed RF-545. --------------------------------- > Tree: add handling for isRowAvailable() method > ---------------------------------------------- > > Key: RF-545 > URL: https://jira.jboss.org/jira/browse/RF-545 > Project: RichFaces > Issue Type: Bug > Affects Versions: 3.1.0 > Reporter: Nick Belaevski > Assignee: Nick Belaevski > Fix For: 3.1.0 > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 7 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues August 2008