[JBoss JIRA] Created: (RF-8386) inputNumberSpinner: autosubmit of a form while pressing the ENTER KEY, validation is discarded and modal panel is closed
by Eleonora Petagna (JIRA)
inputNumberSpinner: autosubmit of a form while pressing the ENTER KEY, validation is discarded and modal panel is closed
------------------------------------------------------------------------------------------------------------------------
Key: RF-8386
URL: https://jira.jboss.org/jira/browse/RF-8386
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-input
Affects Versions: 3.3.2.GA
Environment: Linux kernel 2.6.31-19 Ubuntu rel 9.10; Windows Vista/XP- Web browsers: Firefox 3.5.7; IE8
Reporter: Eleonora Petagna
When using an inputNumberSpinner inside a modalPanel, within an a4j:form,
pressing the Enter key will automatically submit the form and the modal panel is closed.
The validation is not performed.
I've tried to set oninputkeypress="return event.keyCode!=13" but it doesn't work.
I have also tried to catch the return-key with an additional component such as:
<rich:hotKey key="return"
like discussed in http://ahoehma.wordpress.com/tag/hotkey/ but that did not work either.
Remark:
If I replace <rich:inputNumberSpinner with <rich:inputNumberSlider the functionality is OK (the return key can be intercepted and the form is not submitted).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 1 month
[JBoss JIRA] Created: (RF-8216) ThreadLocal/Memory leak in ColumnsHandler
by Thomas W (JIRA)
ThreadLocal/Memory leak in ColumnsHandler
-----------------------------------------
Key: RF-8216
URL: https://jira.jboss.org/jira/browse/RF-8216
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: core
Affects Versions: 3.3.1
Reporter: Thomas W
I have found this issue when hunting down memory leaks on hot deployment with tomcat. It prevents the classloader from unload and leaks memory even outside of hot deployment in HTTP worker threads. This is just one example. Looking at how plain and obvious it is, there are probably more issues hiding in other components. There should be test with ideally full code coverage, followed by inspection of the JVM heap for leaks.
There is a nice post here on how to perform the latter: http://blogs.sun.com/fkieviet/entry/how_to_fix_the_dreaded
The specific culprit I found is the columns tag (ColumnsHandler).
I had to add the following in a subclass to prevent the leak:
@Override
public void apply(FaceletContext ctx, UIComponent parent)
throws IOException, FacesException, ELException {
super.apply(ctx, parent);
// fix memory/classloader leak
super.iterationContextLocal.remove();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 1 month
[JBoss JIRA] Created: (RF-8212) Extended data table - keyboard navigation of rows of a selectable grid breaks after rerendering another datatable with selectionMode=none
by Ryan Yoder (JIRA)
Extended data table - keyboard navigation of rows of a selectable grid breaks after rerendering another datatable with selectionMode=none
-----------------------------------------------------------------------------------------------------------------------------------------
Key: RF-8212
URL: https://jira.jboss.org/jira/browse/RF-8212
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: component-tables
Affects Versions: 3.3.1
Environment: tomcat 6, facelets, RichFaces 3.3.1
Reporter: Ryan Yoder
Priority: Minor
The keyboard navigation of rows of a selectable grid breaks after rerendering another datatable with selectionMode=none.
A selectable grid on the top of the pagehas an a4j:support event="onselectionchange" to reRender another grid below it that is showing details about the currently selected row in the upper grid. The lower grid should have selectionmode="none" to produce this bug.
The up/down arrows no longer work on the upper grid after the selection is changed and the lower grid reRenders.
The problem lies in the following code:
ExtendedDataTableSelection.js
removeListeners: function() {
Event.stopObserving(document, "keydown", this.eventKeyPress);
The problem is that for the bottom grid, the this.eventKeyPress is null which has the effect of removing all keydown event listeners on the page, including the top grid's listener.
Add an if statement before this line to fix the bug. I have tested it and it works for me.
removeListeners: function(){
if(this.eventKeyPress) { // added if to ensure that all keydown event listeners are not removed
Event.stopObserving(document, "keydown", this.eventKeyPress);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 1 month