January 2011 - richfaces-issues - Jboss List Archives

[JBoss JIRA] Created: (RF-7922) RenderPhaseDataScrollerVisitor does not work with Tomahawk AliasBean Component

by Mirko Sertic (JIRA)

RenderPhaseDataScrollerVisitor does not work with Tomahawk AliasBean Component ------------------------------------------------------------------------------ Key: RF-7922 URL: https://jira.jboss.org/jira/browse/RF-7922 Project: RichFaces Issue Type: Bug Components: component-tables Affects Versions: 3.3.1 Reporter: Mirko Sertic The default RenderPhaseDataScrollerVisitor does not work with the Tomahawk AliasBean Component. Basically, it is invoked by a PhaseListener. It recomputes the model size of the bound UIData and does some other stuff. And here starts the problem. When i use a t:aliasBean to define the datamodel for the UIData, it does not work, as the aliasBean component sets and unsets the alias during its lifecycle processing. Now, the RenderPhaseDataScrollerVisitor is invoked before the aliasBean can do its job. An empty DataModel is created and put to the modelmap. Later, aliasBean does it work, and the UIData tries to render. Instead of asking again for the datamodel, it uses the empty model from the modelmap, and thus the table is empty. I know that it is somehow difficult to support every component, but at least it should be supported to disable the RenderPhaseDataScrollerVisitor in some way, or provide my own implementation for it -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

4
3
0 / 0

[JBoss JIRA] Created: (RF-7986) inplaceSelect: allows String value only without specifying converter.

by Ilya Shaikovsky (JIRA)

inplaceSelect: allows String value only without specifying converter. --------------------------------------------------------------------- Key: RF-7986 URL: https://jira.jboss.org/jira/browse/RF-7986 Project: RichFaces Issue Type: Bug Components: component-input Affects Versions: 3.3.2.GA Reporter: Ilya Shaikovsky Assignee: Nick Belaevski Fix For: Future should allow the same value bindings as standard selectOne. <rich:inplaceSelect value="#{inplaceComponentsBean.inputValue}" defaultLabel="Click here to edit"> <f:selectItem itemValue="0" itemLabel="Option 1" /> <f:selectItem itemValue="1" itemLabel="Option 2" /> <f:selectItem itemValue="2" itemLabel="Option 3" /> <f:selectItem itemValue="3" itemLabel="Option 4" /> <f:selectItem itemValue="4" itemLabel="Option 5" /> </rich:inplaceSelect> <h:selectOneMenu value="#{inplaceComponentsBean.inputValue}" > <f:selectItem itemValue="0" itemLabel="Option 1" /> <f:selectItem itemValue="1" itemLabel="Option 2" /> <f:selectItem itemValue="2" itemLabel="Option 3" /> <f:selectItem itemValue="3" itemLabel="Option 4" /> <f:selectItem itemValue="4" itemLabel="Option 5" /> </h:selectOneMenu> where value - int works differently but should works int the same way. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

3
3
0 / 0

[JBoss JIRA] Created: (RF-8566) richfaces-demo - Safari, Chromium - Editor - rerendering of preview textarea fails

by Lukas Fryc (JIRA)

richfaces-demo - Safari, Chromium - Editor - rerendering of preview textarea fails ---------------------------------------------------------------------------------- Key: RF-8566 URL: https://jira.jboss.org/jira/browse/RF-8566 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Affects Versions: 3.3.3.Final Environment: Safari 4.0.4, Chromium 5.0.307.11 (39572) richfaces-demo-3.3.3.Final-tomcat6.war Apache Tomcat 6.0.24 Reporter: Lukas Fryc -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

3
4
0 / 0

[JBoss JIRA] Created: (RF-4791) Calendar with datePattern from resourcebundle doesn't validate

by Edwin van der Elst (JIRA)

Calendar with datePattern from resourcebundle doesn't validate -------------------------------------------------------------- Key: RF-4791 URL: https://jira.jboss.org/jira/browse/RF-4791 Project: RichFaces Issue Type: Bug Affects Versions: 3.2.2 Reporter: Edwin van der Elst See also: http://www.jboss.com/index.html?module=bb&op=viewtopic&t=143930 I use: <rich:calendar value="#{person.birthDate}" datePattern="#{messages['datepattern']}/> The date *is* formatted according to the pattern, but on submitting the form, the validation fails: '04-12-1968' could not be understood as a date. Example: 29-10-2008 Note: the example also uses the correct datePattern If I hardcode the pattern in the template (datePattern='dd-MM-yyyy'), the validation succeeds (but then the pattern is not localized anymore). I tried a4j:loadBundle, and referencing that instance (this was a suggestion from the forum entry). It resulted in the same error message. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

8
12
0 / 0

[JBoss JIRA] Created: (RF-7431) extendedDataTable: menu icon is displayed in wrong place in firefox, if header or caption facet is defined

by Vadim Mikovoz (JIRA)

extendedDataTable: menu icon is displayed in wrong place in firefox, if header or caption facet is defined ---------------------------------------------------------------------------------------------------------- Key: RF-7431 URL: https://jira.jboss.org/jira/browse/RF-7431 Project: RichFaces Issue Type: Bug Components: component-tables Affects Versions: 3.3.2.CR1 Environment: v.3.3.2-SNAPSHOT firefox 3.0 Reporter: Vadim Mikovoz Assignee: Nick Belaevski <rich:extendedDataTable id="myExtendedDataTableID" value="#{dataScroller.dataTable}" var="dT"> <f:facet name="caption"> <h:outputText value="My caption" /> </f:facet> <rich:column label="first column"> <f:facet name="header"> <h:outputText value="first" /> </f:facet> <h:outputText value="#{dT.str0}" /> </rich:column> <rich:column label="second column"> <f:facet name="header"> <h:outputText value="second" /> </f:facet> <h:outputText value="#{dT.int0}" /> </rich:column> </rich:extendedDataTable> 1. Open test page 2. Move mouse over any column header ------------------------------------------------------- menu icon is appeared on caption (see attachment) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

3
5
0 / 0

[JBoss JIRA] Created: (RF-7931) rich:suggestionbox height has a default value, but is still required: that doesn't make sense

by Reshat SABIQ (JIRA)

rich:suggestionbox height has a default value, but is still required: that doesn't make sense --------------------------------------------------------------------------------------------- Key: RF-7931 URL: https://jira.jboss.org/jira/browse/RF-7931 Project: RichFaces Issue Type: Bug Components: component-input Affects Versions: 3.3.1 Reporter: Reshat SABIQ Priority: Minor Vanilla Eclipse reported this as a validation error, and even though i at first was skeptical about it, it's absolutely right: richfaces require a height value, while at the same time saying that the default value is 200. Either, height should not be required because there is a default, or there should be no default. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

3
3
0 / 0

[JBoss JIRA] Created: (RF-8262) Unnecessary filtering of fields in a Richfaces DataTable

by Sebastian Rueber (JIRA)

Unnecessary filtering of fields in a Richfaces DataTable -------------------------------------------------------- Key: RF-8262 URL: https://jira.jboss.org/jira/browse/RF-8262 Project: RichFaces Issue Type: Patch Security Level: Public (Everyone can see) Components: component, component-ScrollableDataTable, component-tables Reporter: Sebastian Rueber This patch is a solution for the DataTable problem, when using the internal filter. e.g.: <rich:dataTable value="${bean.listDataModel}" var="row"> <rich:column filterBy="row.name" /> reason for this problem is the class org.richfaces.model.ModifiableModel with its method filter(...) the method filter(...) always calculates the filterBy value for all cells and rows in the table, which has the filter expression. example: 500 rows and 7 columns leads to 3500 calculations. it depends on how complex the expressions are, but it may take a while. in some cases the expressions are calculated unnecessary. example 1: empty filter fields if the user has not entered any filter expressions in fields with a filter attribute, for example if the table is rendered initialy. calculated expressions 3500 needed expressions 0 example 2: shortcut evaluation the filter fields are linked by an AND logical operator. that means, if you have 7 fields and the first does not match, the remaining 6 field should not be evaluated. calculated expressions 3500 needed expressions 3500 - x in our application we are using our own table model, but i would like to contribute some code, which may give you an idea, how to fix this quickly. solution code for filter method @Override protected List<Object> filter(List<FilterField> aFilterFields) { List<Object> filteredCollection = new ArrayList<Object>(); ExpressionFactory tempFactory = new ExpressionFactory(FacesContext.getCurrentInstance(), var, aFilterFields); for (Object temp : rowKeys) { Integer tempKey = (Integer) temp; Sample tempSample = data.get(tempKey); if (accept(tempSample, aFilterFields, tempFactory)) { filteredCollection.add(tempKey); } } rowKeys = filteredCollection; return rowKeys; } public boolean accept(Sample aSample, List<FilterField> aFilterList, ExpressionFactory aFactory) { for (FilterField filterField : aFilterList) { if (filterField instanceof ExtendedFilterField) { String filterValue = ((ExtendedFilterField) filterField).getFilterValue(); if (filterValue != null) { filterValue = filterValue.trim().toUpperCase(locale); if (filterValue.length() > 0) { // delayed until here, were it is really needed Object property = aFactory.eval(filterField.getExpression(), aSample); if (property == null || !property.toString().trim().toUpperCase(locale).startsWith(filterValue)) { return false; } } } } else { Object property = aFactory.eval(filterField.getExpression(), aSample); if (!((Boolean) property).booleanValue()) { return false; } } } return true; } solution code for the ExpressionFactory package org.richfaces.model.impl.expressive; import java.util.HashMap; import java.util.List; import java.util.Map; import javax.el.ELContext; import javax.el.ELResolver; import javax.el.MethodExpression; import javax.el.ValueExpression; import javax.faces.application.Application; import javax.faces.component.UIViewRoot; import javax.faces.context.FacesContext; import org.richfaces.model.Field; public class ExpressionFactory { private Map<javax.el.Expression, Expression> expressionMap; public ExpressionFactory(FacesContext context, final String var, List<? extends Field> sortOrder) { Application application = context.getApplication(); ELResolver resolver = application.getELResolver(); ELContext elContext = context.getELContext(); expressionMap = new HashMap<javax.el.Expression, Expression>(); for (Field field : sortOrder) { javax.el.Expression elExpression = field.getExpression(); Expression expression; if (elExpression instanceof ValueExpression) { ValueExpression valueExpression = (ValueExpression) elExpression; if (valueExpression.isLiteralText()) { String expressionString = valueExpression.getExpressionString(); if (expressionString.startsWith(UIViewRoot.UNIQUE_ID_PREFIX)) { expression = new NullExpression(expressionString); } else { expression = new SimplePropertyExpression(expressionString, elContext, resolver); } } else { expression = new ValueBindingExpression(context, valueExpression, var); } } else if (elExpression instanceof MethodExpression) { expression = new MethodBindingExpression(context, (MethodExpression) elExpression); } else { throw new IllegalArgumentException(); } expressionMap.put(elExpression, expression); } } public Object eval(javax.el.Expression anExpression, Object anObject) { return expressionMap.get(anExpression).evaluate(anObject); } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

4
6
0 / 0

[JBoss JIRA] Created: (RF-7916) Javascript error when having non escaped apostrophe in rich:calendar labels

by Julien Kronegg (JIRA)

Javascript error when having non escaped apostrophe in rich:calendar labels --------------------------------------------------------------------------- Key: RF-7916 URL: https://jira.jboss.org/jira/browse/RF-7916 Project: RichFaces Issue Type: Bug Components: component-output Affects Versions: 3.3.0 Environment: Seam 2.1.2, Richfaces 3.3.0 Reporter: Julien Kronegg Priority: Minor Richfaces Calendar labels can be translated/i18n by adding the following properties in the resource bundle (e.g. messages.properties): RICH_CALENDAR_TODAY_LABEL RICH_CALENDAR_CLEAN_LABEL RICH_CALENDAR_APPLY_LABEL RICH_CALENDAR_CLOSE_LABEL RICH_CALENDAR_OK_LABEL RICH_CALENDAR_CANCEL_LABEL The problem is that a Javascript error occurs when the property value contain a non escaped apostrophe ('), for example with RICH_CALENDAR_TODAY_LABEL=Aujourd'hui (french label for today): Error: missing } after property list Source Code: labels:{apply:'Appliquer', today:'Aujourd'hui', clean:'Effacer', cancel:'Annuler', ok:'Ok', close:'X'}, Richfaces should escape automatically unescaped apostrophes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

4
4
0 / 0

[JBoss JIRA] Created: (RF-8335) ResourceNotFoundException for csszend theme

by Nick Belaevski (JIRA)

ResourceNotFoundException for csszend theme ------------------------------------------- Key: RF-8335 URL: https://jira.jboss.org/jira/browse/RF-8335 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: skinning Affects Versions: 3.3.3.BETA1 Reporter: Nick Belaevski Assignee: Andrey Markhel Fix For: 3.3.3.CR1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

2
2
0 / 0

[JBoss JIRA] Created: (RF-8196) rf-demo (JSF2): Calendar - Client side disable / styling - Dark-X - too wide at Wed column

by Lukas Fryc (JIRA)

rf-demo (JSF2): Calendar - Client side disable / styling - Dark-X - too wide at Wed column ------------------------------------------------------------------------------------------- Key: RF-8196 URL: https://jira.jboss.org/jira/browse/RF-8196 Project: RichFaces Issue Type: Bug Security Level: Public (Everyone can see) Components: JSF 2.0 Affects Versions: 3.3.3.BETA1 Environment: richfaces-demo-3.3.3.Beta1-jee5.war (with injected richfaces-impl-jsf2-3.3.3.Beta1) JBAS 5.1.0.GA with Mojarra 2.0.1 Internet Explorer 7 Reporter: Lukas Fryc Fix For: 3.3.3.BETA1 The columns are all of same width in Firefox, but in Internet Explorer, the Wed column is wider. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 3 months

4
11
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

richfaces-issues January 2011