[JBoss JIRA] (RF-11759) Remove Cellpadding/Cellspacing from EDT, replace with appropriate CSS
by Brian Leathem (Resolved) (JIRA)
[ https://issues.jboss.org/browse/RF-11759?page=com.atlassian.jira.plugin.s... ]
Brian Leathem resolved RF-11759.
--------------------------------
Resolution: Done
Replaced the cellpadding/cellspacing attributes of the EDT with the following CSS styling:
{code}
.rf-edt-tbl {
border-collapse: collapse;
border-spacing : 0;
}
.rf-edt-tbl tr td, table.rf-edt-tbl tr th {
padding: 0;
}
{code}
> Remove Cellpadding/Cellspacing from EDT, replace with appropriate CSS
> ---------------------------------------------------------------------
>
> Key: RF-11759
> URL: https://issues.jboss.org/browse/RF-11759
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.1.0.CR1
> Reporter: Fisheye JIRA Integration
> Assignee: Brian Leathem
> Priority: Blocker
> Fix For: 4.1.0.CR2
>
>
> Remove the cellpadding/cellspacing attributes introduced with RF-11738, as we want to focus on a CSS based approach to styling the tables.
> The attributes were created to allow overriding the HTML cellpadding and cellspacing attributes set by the EDT, and allow developer override. These HTML attributes should be removed from the EDT, and the appropriate CSS styling changes made to compensate.
> Created by Brian Leathem from Lukáš Fryč's Crucible comment on ExtendedDataTableRenderer.java line 289 https://source.jboss.org/cru/REV-RF-5#c172 :
> {quote}
> -Why does EDT need Cellpadding/spacing defined?
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
- 1
- 0
[JBoss JIRA] (RF-11759) Remove Cellpadding/Cellspacing from EDT, replace with appropriate CSS
by Karsten Wutzke (Commented) (JIRA)
[ https://issues.jboss.org/browse/RF-11759?page=com.atlassian.jira.plugin.s... ]
Karsten Wutzke commented on RF-11759:
-------------------------------------
I agree on removing these from EDT instead of adding the attributes to DT. (Is there a CSS equivalent for cellpadding? Simple padding?)
> Remove Cellpadding/Cellspacing from EDT, replace with appropriate CSS
> ---------------------------------------------------------------------
>
> Key: RF-11759
> URL: https://issues.jboss.org/browse/RF-11759
> Project: RichFaces
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.1.0.CR1
> Reporter: Fisheye JIRA Integration
> Assignee: Brian Leathem
> Priority: Blocker
> Fix For: 4.1.0.CR2
>
>
> Remove the cellpadding/cellspacing attributes introduced with RF-11738, as we want to focus on a CSS based approach to styling the tables.
> The attributes were created to allow overriding the HTML cellpadding and cellspacing attributes set by the EDT, and allow developer override. These HTML attributes should be removed from the EDT, and the appropriate CSS styling changes made to compensate.
> Created by Brian Leathem from Lukáš Fryč's Crucible comment on ExtendedDataTableRenderer.java line 289 https://source.jboss.org/cru/REV-RF-5#c172 :
> {quote}
> -Why does EDT need Cellpadding/spacing defined?
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
- 1
- 0