[JBoss JIRA] (RF-12660) Second call of jsFunction inside dataTable does reach an action
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12660?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12660:
-------------------------------
Fix Version/s: 4.3.0.CR1
> Second call of jsFunction inside dataTable does reach an action
> ---------------------------------------------------------------
>
> Key: RF-12660
> URL: https://issues.jboss.org/browse/RF-12660
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.2.2.Final
> Environment: Windows 7, Tomcat 6
> Reporter: Andrei Tikhomirov
> Priority: Critical
> Labels: regression
> Fix For: 4.3.0.CR1
>
>
> jsFunction works correclty only for the row clicked at first.
> For second and other rows _onbegin_ fires, but _action_ and _oncomplete_ are not executed.
> POST request is executed.
> It worked for me on 4.0.0.Final and does not work after migration on 4.2.2.Final
> Reproduced on 4.2.3.Final
> {code}
> <rich:column>
> <span id="toggler#{row.id}" onclick="click(#{row.id});">
> <rich:collapsibleSubTableToggler for="subtbl" rendered="true" expandedIcon="/images/minus.png" collapsedIcon="/images/plus.png" />
> <a4j:jsFunction name="readFeeadbackMessage#{row.id}" onbegin="unbindFeedbackMessageClick(#{row.id});" action="#{bean.action(row.id)}" oncomplete="complete(#{row.id})"/>
> </span>
> ...........
> </rich:column>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 4 months
[JBoss JIRA] (RF-12661) rich:tooltip causes NPE with null value
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12661?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12661:
-------------------------------
Fix Version/s: 5-Tracking
> rich:tooltip causes NPE with null value
> ---------------------------------------
>
> Key: RF-12661
> URL: https://issues.jboss.org/browse/RF-12661
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.2.2.Final
> Reporter: Raimundas Maknys
> Priority: Minor
> Fix For: 5-Tracking
>
>
> rich:tooltip with null value causes NullPointerException:
> {code}
> Caused by: java.lang.NullPointerException
> at org.richfaces.renderkit.html.TooltipRenderer.encodeContentBegin(TooltipRenderer.java:135)
> at org.richfaces.renderkit.html.TooltipRenderer.doEncodeBegin(TooltipRenderer.java:127)
> at org.richfaces.renderkit.RendererBase.encodeBegin(RendererBase.java:115)
> at javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:585)
> at javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:515)
> at org.richfaces.renderkit.RendererBase.renderChildren(RendererBase.java:276)
> ...........
> {code}
> Proposed solution:
> {code:title=org.richfaces.renderkit.html.TooltipRenderer|borderStyle=solid}
> 130 private void encodeContentBegin(ResponseWriter writer, FacesContext context, AbstractTooltip tooltip) throws IOException {
> 131 writer.startElement(getMarkupElement(tooltip), tooltip);
> 132 writer.writeAttribute(ID_ATTRIBUTE, tooltip.getClientId(context) + ":content", null);
> 133 writer.writeAttribute(CLASS_ATTRIBUTE, "rf-tt-cnt", null);
> 134 if (tooltip.getChildCount() == 0) {
> - 135 writer.write(tooltip.getValue().toString());
> + 135 writer.write(tooltip.getValue() != null ? tooltip.getValue().toString() : "");
> 136 }
> 137 }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 4 months
[JBoss JIRA] (RF-12658) NotifyStack generates invalid JS
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12658?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12658:
-------------------------------
Original Estimate: 30 minutes
Remaining Estimate: 30 minutes
Fix Version/s: 5-Tracking
Component/s: component-validators
> NotifyStack generates invalid JS
> --------------------------------
>
> Key: RF-12658
> URL: https://issues.jboss.org/browse/RF-12658
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-validators
> Affects Versions: 4.3.0.M2
> Reporter: Ken H
> Fix For: 5-Tracking
>
> Original Estimate: 30 minutes
> Remaining Estimate: 30 minutes
>
> Including a notify stack such as:
> {code}
> <rich:notifyStack>
> <rich:notifyMessages stayTime="60000" ajaxRendered="true" />
> </rich:notifyStack>
> {code}
> Generates the following invalid JS block:
> {code}
> <script type="text/javascript">
> new RichFaces.ui.NotifyStack('j_idt13', );
> </script>
> {code}
> This does not appear to affect functionality but does generate a console error in Chrome (unexpected close-paren). Resolving RF-12620 will probably also resolve this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 4 months
[JBoss JIRA] (RF-12660) Second call of jsFunction inside dataTable does reach an action
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12660?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12660:
-------------------------------
Description:
jsFunction works correclty only for the row clicked at first.
For second and other rows
'onbegin' fires, but action and oncomplete is not executed.
POST request executed.
It worked for me on 4.0.0.Final
and does not work after migration on 4.2.2.Final
Reproduced on 4.2.3.Final
{code}
<rich:column>
<span id="toggler#{row.id}" onclick="click(#{row.id});">
<rich:collapsibleSubTableToggler for="subtbl" rendered="true" expandedIcon="/images/minus.png" collapsedIcon="/images/plus.png" />
<a4j:jsFunction name="readFeeadbackMessage#{row.id}" onbegin="unbindFeedbackMessageClick(#{row.id});" action="#{bean.action(row.id)}" oncomplete="complete(#{row.id})"/>
</span>
...........
</rich:column>
{code}
was:
jsFunction works correclty only for the row clicked at first.
For second and other rows
'onbegin' fires, but action and oncomplete is not executed.
POST request executed.
It worked for me on 4.0.0.Final
and does not work after migration on 4.2.2.Final
Reproduced on 4.2.3.Final
..........
<rich:column>
<span id="toggler#{row.id}" onclick="click(#{row.id});">
<rich:collapsibleSubTableToggler for="subtbl" rendered="true" expandedIcon="/images/minus.png" collapsedIcon="/images/plus.png" />
<a4j:jsFunction name="readFeeadbackMessage#{row.id}" onbegin="unbindFeedbackMessageClick(#{row.id});" action="#{bean.action(row.id)}" oncomplete="complete(#{row.id})"/>
</span>
...........
</rich:column>
............
> Second call of jsFunction inside dataTable does reach an action
> ---------------------------------------------------------------
>
> Key: RF-12660
> URL: https://issues.jboss.org/browse/RF-12660
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-a4j-core
> Affects Versions: 4.2.2.Final
> Environment: Windows 7, Tomcat 6
> Reporter: Andrei Tikhomirov
> Priority: Critical
>
> jsFunction works correclty only for the row clicked at first.
> For second and other rows
> 'onbegin' fires, but action and oncomplete is not executed.
> POST request executed.
> It worked for me on 4.0.0.Final
> and does not work after migration on 4.2.2.Final
> Reproduced on 4.2.3.Final
> {code}
> <rich:column>
> <span id="toggler#{row.id}" onclick="click(#{row.id});">
> <rich:collapsibleSubTableToggler for="subtbl" rendered="true" expandedIcon="/images/minus.png" collapsedIcon="/images/plus.png" />
> <a4j:jsFunction name="readFeeadbackMessage#{row.id}" onbegin="unbindFeedbackMessageClick(#{row.id});" action="#{bean.action(row.id)}" oncomplete="complete(#{row.id})"/>
> </span>
> ...........
> </rich:column>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 4 months
[JBoss JIRA] (RF-12654) PartialViewRender skips check for whether column is rendered before checking if children can be rendered
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12654?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-12654:
------------------------------------
I suspect this is a duplicate of RF-11382. CAn you try the 4.3.0.M3 release of RichFaces and see if it fixes your problem? The milestone is currently in the [staging repository|https://repository.jboss.org/nexus/content/groups/staging/], as it's undergoing QA.
> PartialViewRender skips check for whether column is rendered before checking if children can be rendered
> --------------------------------------------------------------------------------------------------------
>
> Key: RF-12654
> URL: https://issues.jboss.org/browse/RF-12654
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.0.M2
> Environment: JBoss 7.1.1.Final
> Reporter: Ken H
>
> When using rendered on a component within a rich:column of a rich:dataTable, the EL on the component is executed even if the column is not rendered.
> The expected behavior (per my loose understanding of the JSF spec) would suggest that the traversal should have short-circuited before checking the unrendered column's children.
> This behavior exists at least as far back as 4.1.0.Final.
> Given this minimal example:
> {code}
> <rich:dataTable value="#{bean.foos}" var="foo">
> <rich:column rendered="false">
> <h:outputText value="#{foo.bar}" rendered="#{foo.propertyDoesNotExist != null}" />
> </rich:column>
> <rich:column>
> <a4j:commandButton value="Test" action="#{bean.noop}"
> execute="@this" render="@form" />
> </rich:column>
> </rich:dataTable>
> {code}
> Clicking the Test button would result in a stack trace similar to the following:
> {code}
> /index.xhtml @33,96 rendered="#{foo.propertyDoesNotExist != null}": The class 'org.richfaces.tests.Foo' does not have the property 'propertyDoesNotExist'.
> at com.sun.faces.facelets.el.TagValueExpression.getValue(TagValueExpression.java:111) [jsf-impl-2.1.7-jbossorg-2.jar:]
> at javax.faces.component.ComponentStateHelper.eval(ComponentStateHelper.java:194) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponentBase.isRendered(UIComponentBase.java:413) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.isVisitable(UIComponent.java:1669) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1602) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at org.richfaces.component.UIDataAdaptor$DataVisitorForVisitTree.process(UIDataAdaptor.java:199) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.ajax4jsf.model.SequenceDataModel.walk(SequenceDataModel.java:65) [richfaces-core-api-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataAdaptor.walk(UIDataAdaptor.java:796) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataAdaptor.visitDataChildren(UIDataAdaptor.java:1269) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataTableBase.visitDataChildren(UIDataTableBase.java:395) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataAdaptor.visitTree(UIDataAdaptor.java:1347) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIForm.visitTree(UIForm.java:371) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at org.richfaces.context.ExtendedPartialViewContextImpl.visitActivatorComponent(ExtendedPartialViewContextImpl.java:440) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.context.ExtendedPartialViewContextImpl.visitActivatorAtExecute(ExtendedPartialViewContextImpl.java:310) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.context.ExtendedPartialViewContextImpl.getExecuteIds(ExtendedPartialViewContextImpl.java:98) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.context.ExtendedPartialViewContextImpl.isExecuteAll(ExtendedPartialViewContextImpl.java:148) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:929) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:78) [jsf-impl-2.1.7-jbossorg-2.jar:]
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 4 months
[JBoss JIRA] (RF-12654) PartialViewRender skips check for whether column is rendered before checking if children can be rendered
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12654?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12654:
-------------------------------
Labels: waiting_on_user (was: )
> PartialViewRender skips check for whether column is rendered before checking if children can be rendered
> --------------------------------------------------------------------------------------------------------
>
> Key: RF-12654
> URL: https://issues.jboss.org/browse/RF-12654
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Affects Versions: 4.3.0.M2
> Environment: JBoss 7.1.1.Final
> Reporter: Ken H
> Labels: waiting_on_user
>
> When using rendered on a component within a rich:column of a rich:dataTable, the EL on the component is executed even if the column is not rendered.
> The expected behavior (per my loose understanding of the JSF spec) would suggest that the traversal should have short-circuited before checking the unrendered column's children.
> This behavior exists at least as far back as 4.1.0.Final.
> Given this minimal example:
> {code}
> <rich:dataTable value="#{bean.foos}" var="foo">
> <rich:column rendered="false">
> <h:outputText value="#{foo.bar}" rendered="#{foo.propertyDoesNotExist != null}" />
> </rich:column>
> <rich:column>
> <a4j:commandButton value="Test" action="#{bean.noop}"
> execute="@this" render="@form" />
> </rich:column>
> </rich:dataTable>
> {code}
> Clicking the Test button would result in a stack trace similar to the following:
> {code}
> /index.xhtml @33,96 rendered="#{foo.propertyDoesNotExist != null}": The class 'org.richfaces.tests.Foo' does not have the property 'propertyDoesNotExist'.
> at com.sun.faces.facelets.el.TagValueExpression.getValue(TagValueExpression.java:111) [jsf-impl-2.1.7-jbossorg-2.jar:]
> at javax.faces.component.ComponentStateHelper.eval(ComponentStateHelper.java:194) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponentBase.isRendered(UIComponentBase.java:413) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.isVisitable(UIComponent.java:1669) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1602) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at org.richfaces.component.UIDataAdaptor$DataVisitorForVisitTree.process(UIDataAdaptor.java:199) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.ajax4jsf.model.SequenceDataModel.walk(SequenceDataModel.java:65) [richfaces-core-api-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataAdaptor.walk(UIDataAdaptor.java:796) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataAdaptor.visitDataChildren(UIDataAdaptor.java:1269) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataTableBase.visitDataChildren(UIDataTableBase.java:395) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.component.UIDataAdaptor.visitTree(UIDataAdaptor.java:1347) [richfaces-components-ui-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIForm.visitTree(UIForm.java:371) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at org.richfaces.context.ExtendedPartialViewContextImpl.visitActivatorComponent(ExtendedPartialViewContextImpl.java:440) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.context.ExtendedPartialViewContextImpl.visitActivatorAtExecute(ExtendedPartialViewContextImpl.java:310) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.context.ExtendedPartialViewContextImpl.getExecuteIds(ExtendedPartialViewContextImpl.java:98) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at org.richfaces.context.ExtendedPartialViewContextImpl.isExecuteAll(ExtendedPartialViewContextImpl.java:148) [richfaces-core-impl-4.3.0.20121024-M2.jar:4.3.0.20121024-M2]
> at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:929) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
> at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:78) [jsf-impl-2.1.7-jbossorg-2.jar:]
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 4 months