[JBoss JIRA] (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-10154:
-------------------------------
Original Estimate: 1 minute
Remaining Estimate: 1 minute
> UIDataAdaptor vs. UIData visitTee small difference
> --------------------------------------------------
>
> Key: RF-10154
> URL: https://issues.jboss.org/browse/RF-10154
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Milestone5
> Environment: RichFaces 4.0.X trunk, svn rev. 20913
> Reporter: Martin Kočí
> Assignee: Brian Leathem
> Priority: Minor
> Labels: jsf21
> Fix For: 4.3.0.M3
>
> Original Estimate: 1 minute
> Remaining Estimate: 1 minute
>
> {code}
> <r:extendedDataTable var="zeile">
> <r:column>
> <h:outputText rendered="#{fasole.method(zeile)}"
> </r:column>
> </r:extendedDataTable>
> {code}
> +
> org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
> Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
> j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-12611) rich:dataTable doesn't call restoreState() on a row-level composite component
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12611?page=com.atlassian.jira.plugin.s... ]
Brian Leathem reassigned RF-12611:
----------------------------------
Assignee: Brian Leathem
> rich:dataTable doesn't call restoreState() on a row-level composite component
> -----------------------------------------------------------------------------
>
> Key: RF-12611
> URL: https://issues.jboss.org/browse/RF-12611
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.2.3.Final
> Environment: Debian Wheezy, Linux, amd64
> Reporter: Mark Cave-Ayland
> Assignee: Brian Leathem
> Fix For: 4.3.0.M3
>
> Attachments: RFStateBug1.tar.gz
>
>
> I currently have a row-level composite component that works well within a h:dataTable which I am looking to migrate to rich:dataTable for more flexibility with layout. However when embedded within a rich:dataTable, the component state is not preserved during the RESTORE_VIEW phase.
> Further investigation with a debugger shows that the problem is within UIDataAdapter::restoreState() in that requiresRowIteration() returns false during the RESTORE_VIEW phase, and so the restoreState() function within the row-level composite component is never called.
> The related transcript from IRC can be found here: http://transcripts.jboss.org/channel/irc.freenode.org/%23richfaces/2012/%....
> Many thanks,
> Mark.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-10154:
-------------------------------
Fix Version/s: 4.3.0.M3
(was: 5-Future)
> UIDataAdaptor vs. UIData visitTee small difference
> --------------------------------------------------
>
> Key: RF-10154
> URL: https://issues.jboss.org/browse/RF-10154
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Milestone5
> Environment: RichFaces 4.0.X trunk, svn rev. 20913
> Reporter: Martin Kočí
> Priority: Minor
> Labels: jsf21
> Fix For: 4.3.0.M3
>
>
> {code}
> <r:extendedDataTable var="zeile">
> <r:column>
> <h:outputText rendered="#{fasole.method(zeile)}"
> </r:column>
> </r:extendedDataTable>
> {code}
> +
> org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
> Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
> j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-12611) rich:dataTable doesn't call restoreState() on a row-level composite component
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12611?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-12611:
-------------------------------
Fix Version/s: 4.3.0.M3
> rich:dataTable doesn't call restoreState() on a row-level composite component
> -----------------------------------------------------------------------------
>
> Key: RF-12611
> URL: https://issues.jboss.org/browse/RF-12611
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.2.3.Final
> Environment: Debian Wheezy, Linux, amd64
> Reporter: Mark Cave-Ayland
> Fix For: 4.3.0.M3
>
> Attachments: RFStateBug1.tar.gz
>
>
> I currently have a row-level composite component that works well within a h:dataTable which I am looking to migrate to rich:dataTable for more flexibility with layout. However when embedded within a rich:dataTable, the component state is not preserved during the RESTORE_VIEW phase.
> Further investigation with a debugger shows that the problem is within UIDataAdapter::restoreState() in that requiresRowIteration() returns false during the RESTORE_VIEW phase, and so the restoreState() function within the row-level composite component is never called.
> The related transcript from IRC can be found here: http://transcripts.jboss.org/channel/irc.freenode.org/%23richfaces/2012/%....
> Many thanks,
> Mark.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s... ]
Brian Leathem reassigned RF-10154:
----------------------------------
Assignee: Brian Leathem
> UIDataAdaptor vs. UIData visitTee small difference
> --------------------------------------------------
>
> Key: RF-10154
> URL: https://issues.jboss.org/browse/RF-10154
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Milestone5
> Environment: RichFaces 4.0.X trunk, svn rev. 20913
> Reporter: Martin Kočí
> Assignee: Brian Leathem
> Priority: Minor
> Labels: jsf21
> Fix For: 4.3.0.M3
>
>
> {code}
> <r:extendedDataTable var="zeile">
> <r:column>
> <h:outputText rendered="#{fasole.method(zeile)}"
> </r:column>
> </r:extendedDataTable>
> {code}
> +
> org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
> Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
> j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s... ]
Brian Leathem edited comment on RF-10154 at 12/6/12 8:09 PM:
-------------------------------------------------------------
{code}
@ManagedBean
@SessionScoped
public class Snippet {
public void action() {
FacesContext facesContext = FacesContext.getCurrentInstance();
visitTree(facesContext, facesContext.getViewRoot());
}
public void visitTree(FacesContext facesContext, UIViewRoot uiViewRoot) {
VisitContext visitContext = VisitContext.createVisitContext(facesContext, null, Sets.newHashSet(VisitHint.SKIP_UNRENDERED));
uiViewRoot.visitTree(visitContext, new VisitCallback() {
@Override
public VisitResult visit(VisitContext context, UIComponent target) {
return VisitResult.ACCEPT;
}
});
}
public boolean isRendered() {
Map<String, Object> map = FacesContext.getCurrentInstance().getExternalContext().getRequestMap();
Object o = map.get("zeile");
if (o == null) {
throw new NullPointerException();
}
System.out.println(o);
return true;
}
}
{code}
{code}
<h:form>
<h:commandButton action="#{snippet.action}" value="Visit" />
<rich:extendedDataTable value="#{dataProvider.data}" var="zeile">
<h:column>
<h:outputText value="#{zeile}" rendered="#{snippet.rendered}" />
</h:column>
</rich:extendedDataTable>
</h:form>
{code}
was (Author: nbelaevski):
@ManagedBean
@SessionScoped
public class Snippet {
public void action() {
FacesContext facesContext = FacesContext.getCurrentInstance();
visitTree(facesContext, facesContext.getViewRoot());
}
public void visitTree(FacesContext facesContext, UIViewRoot uiViewRoot) {
VisitContext visitContext = VisitContext.createVisitContext(facesContext, null, Sets.newHashSet(VisitHint.SKIP_UNRENDERED));
uiViewRoot.visitTree(visitContext, new VisitCallback() {
@Override
public VisitResult visit(VisitContext context, UIComponent target) {
return VisitResult.ACCEPT;
}
});
}
public boolean isRendered() {
Map<String, Object> map = FacesContext.getCurrentInstance().getExternalContext().getRequestMap();
Object o = map.get("zeile");
if (o == null) {
throw new NullPointerException();
}
System.out.println(o);
return true;
}
}
<h:form>
<h:commandButton action="#{snippet.action}" value="Visit" />
<rich:extendedDataTable value="#{dataProvider.data}"
var="zeile">
<h:column>
<h:outputText value="#{zeile}" rendered="#{snippet.rendered}" />
</h:column>
</rich:extendedDataTable>
</h:form>
> UIDataAdaptor vs. UIData visitTee small difference
> --------------------------------------------------
>
> Key: RF-10154
> URL: https://issues.jboss.org/browse/RF-10154
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Milestone5
> Environment: RichFaces 4.0.X trunk, svn rev. 20913
> Reporter: Martin Kočí
> Priority: Minor
> Labels: jsf21
> Fix For: 5-Future
>
>
> {code}
> <r:extendedDataTable var="zeile">
> <r:column>
> <h:outputText rendered="#{fasole.method(zeile)}"
> </r:column>
> </r:extendedDataTable>
> {code}
> +
> org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
> Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
> j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s... ]
Brian Leathem edited comment on RF-10154 at 12/6/12 8:08 PM:
-------------------------------------------------------------
Step to reproduce:
{code}
<h:form>
<h:commandButton action="#{fasole.visitTree(facesContext, view)}" value="Visit" />
<h:dataTable value="#{fasole.someItems}" var="zeile">
<h:column>
<h:outputText value="#{zeile}" rendered="#{fasole.isRendered(zeile)}" />
</h:column>
</h:dataTable>
</h:form>
{code}
Fasole.java snippet:
{code}
public void visitTree(FacesContext facesContext, UIViewRoot uiViewRoot) {
VisitContext visitContext = VisitContext.createVisitContext(facesContext, null, Sets.newHashSet(VisitHint.SKIP_UNRENDERED));
uiViewRoot.visitTree(visitContext, new VisitCallback() {
@Override
public VisitResult visit(VisitContext context, UIComponent target) {
return VisitResult.ACCEPT;
}
});
}
public boolean isRendered(Object object) {
if (null == object) {
throw new NullPointerException();
}
return true;
}
{code}
1) click Visit -> nothing happens
2) change h:dataTable to r:dataTable or r:extendedDataTable and click Visit -> NPE
was (Author: markoc50):
Step to reproduce:
<h:form>
<h:commandButton action="#{fasole.visitTree(facesContext, view)}" value="Visit" />
<h:dataTable value="#{fasole.someItems}" var="zeile">
<h:column>
<h:outputText value="#{zeile}" rendered="#{fasole.isRendered(zeile)}" />
</h:column>
</h:dataTable>
</h:form>
Fasole.java snippet:
public void visitTree(FacesContext facesContext, UIViewRoot uiViewRoot) {
VisitContext visitContext = VisitContext.createVisitContext(facesContext, null, Sets.newHashSet(VisitHint.SKIP_UNRENDERED));
uiViewRoot.visitTree(visitContext, new VisitCallback() {
@Override
public VisitResult visit(VisitContext context, UIComponent target) {
return VisitResult.ACCEPT;
}
});
}
public boolean isRendered(Object object) {
if (null == object) {
throw new NullPointerException();
}
return true;
}
1) click Visit -> nothing happens
2) change h:dataTable to r:dataTable or r:extendedDataTable and click Visit -> NPE
> UIDataAdaptor vs. UIData visitTee small difference
> --------------------------------------------------
>
> Key: RF-10154
> URL: https://issues.jboss.org/browse/RF-10154
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Milestone5
> Environment: RichFaces 4.0.X trunk, svn rev. 20913
> Reporter: Martin Kočí
> Priority: Minor
> Labels: jsf21
> Fix For: 5-Future
>
>
> {code}
> <r:extendedDataTable var="zeile">
> <r:column>
> <h:outputText rendered="#{fasole.method(zeile)}"
> </r:column>
> </r:extendedDataTable>
> {code}
> +
> org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
> Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
> j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-10154) UIDataAdaptor vs. UIData visitTee small difference
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-10154?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-10154:
-------------------------------
Description:
{code}
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
{code}
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
was:
<r:extendedDataTable var="zeile">
<r:column>
<h:outputText rendered="#{fasole.method(zeile)}"
</r:column>
</r:extendedDataTable>
+
org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
> UIDataAdaptor vs. UIData visitTee small difference
> --------------------------------------------------
>
> Key: RF-10154
> URL: https://issues.jboss.org/browse/RF-10154
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.0.0.Milestone5
> Environment: RichFaces 4.0.X trunk, svn rev. 20913
> Reporter: Martin Kočí
> Priority: Minor
> Labels: jsf21
> Fix For: 5-Future
>
>
> {code}
> <r:extendedDataTable var="zeile">
> <r:column>
> <h:outputText rendered="#{fasole.method(zeile)}"
> </r:column>
> </r:extendedDataTable>
> {code}
> +
> org.richfaces.component.UIDataAdaptor.visitTree(VisitContext, VisitCallback) with VisitHint SKIP_UNRENDERED (in render response phase for example)
> Problem: org.richfaces.component.UIDataAdaptor.visitDataChildren(VisitContext, VisitCallback, boolean) calls visitComponents(getFacetsAndChildren(), visitContext, callback);-> it will visit h:outputText component and test if is rendered -> #{fasole.method(zeile)} but no row available -> calls fasole.method with null parameter and causes an unexpected NPE
> j.f.c.UIData does not visit column chidren for -1 rowIndex (null rowKey in RichFaces), UIData.visitTree JavaDoc says: "Take no action on non-UIColumn children".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-8535) Missing classes for sorting icons asc/desc
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-8535?page=com.atlassian.jira.plugin.sy... ]
Brian Leathem updated RF-8535:
------------------------------
Fix Version/s: 5-Tracking
(was: 4.3.0.M3)
> Missing classes for sorting icons asc/desc
> ------------------------------------------
>
> Key: RF-8535
> URL: https://issues.jboss.org/browse/RF-8535
> Project: RichFaces
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: component-tables, skinning
> Affects Versions: 3.3.3.CR1
> Reporter: Daniel Wachter
> Assignee: Brian Leathem
> Labels: dataTable, icons
> Fix For: 5-Tracking
>
> Original Estimate: 30 minutes
> Remaining Estimate: 30 minutes
>
> There are css classes missing to define the sorting icons of the rich:dataTable component.
> Now we must define the icons on each rich:column definition, instead on one single place like the css.
> I propose that there shouldbe created the same classes like used in the sortableDatatable
> e.g. rich-sdt-sort-asc, rich-sdt-sort-desc classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months
[JBoss JIRA] (RF-11728) Support % column widths in extenedDataTable
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-11728?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-11728:
-------------------------------
Original Estimate: (was: 3 hours)
Remaining Estimate: (was: 3 hours)
> Support % column widths in extenedDataTable
> -------------------------------------------
>
> Key: RF-11728
> URL: https://issues.jboss.org/browse/RF-11728
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-tables
> Affects Versions: 4.1.0.Milestone4
> Reporter: hantsy bai
> Assignee: Brian Leathem
> Priority: Minor
> Fix For: 5-Tracking
>
>
> I tried to use extendedDataTable...there is no width attribute...and I set a style="width:100%"...and set column width="30%"...there is no effect...when I dig the code in firebug...I found extenedDataTable use a fixed width...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 5 months