[JBoss JIRA] (RF-13099) Disabled input text is not visible
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13099?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13099:
------------------------------------
The proper way to resolve this issue would be to add a new skinning parameter called _controlDisabledTextColor_. Progress on this issue will be put on hold until the impact of this change is discussed.
> Disabled input text is not visible
> ----------------------------------
>
> Key: RF-13099
> URL: https://issues.jboss.org/browse/RF-13099
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input, skinning
> Reporter: Kush Kumar
> Assignee: Brian Leathem
> Priority: Minor
> Fix For: 4.5.0.Alpha1
>
> Attachments: Disabled_Input_Text_Issue.png
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> Disabled input text is not visible -can you please help me out how can we make it visible or can we change the color of disabled text?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (RF-13099) Disabled input text is not visible
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13099?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13099:
------------------------------------
_tableHeaderTextColor_ is a dark color for all skins except for the _classic_ skin, where it is a white color. This makes it unsuitable for use as the disabled input test color.
> Disabled input text is not visible
> ----------------------------------
>
> Key: RF-13099
> URL: https://issues.jboss.org/browse/RF-13099
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input, skinning
> Reporter: Kush Kumar
> Assignee: Brian Leathem
> Priority: Minor
> Fix For: 4.5.0.Alpha1
>
> Attachments: Disabled_Input_Text_Issue.png
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> Disabled input text is not visible -can you please help me out how can we make it visible or can we change the color of disabled text?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (RF-13268) Typo in LookAheadObjectInputStream.java
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13268?page=com.atlassian.jira.plugin.s... ]
Brian Leathem edited comment on RF-13268 at 10/16/13 1:35 PM:
--------------------------------------------------------------
Thanks for reporting the issue [~fabmars] and the accompanying Pull Request! Would you mind signing the [JBoss CLA|https://cla.jboss.org]? A bit of a PITA, but you only have to sign it once...
was (Author: bleathem):
Thanks for reporting the issue [~fabmars]. Would you mind signing the [JBoss CLA|https://cla.jboss.org]? A bit of a PITA, but you only have to sign it once...
> Typo in LookAheadObjectInputStream.java
> ---------------------------------------
>
> Key: RF-13268
> URL: https://issues.jboss.org/browse/RF-13268
> Project: RichFaces
> Issue Type: Patch
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.4
> Environment: Any
> Reporter: Fab Mars
> Priority: Trivial
> Labels: core
> Fix For: 4.3.5, 5.0.0.Alpha2
>
> Original Estimate: 5 minutes
> Remaining Estimate: 5 minutes
>
> On the loadWhitelist method, stream.close() catch, the message should be "Error closing the resource-serialization.properties file". Git pull request attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (RF-13268) Typo in LookAheadObjectInputStream.java
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13268?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13268:
------------------------------------
Thanks for reporting the issue [~fabmars]. Would you mind signing the [JBoss CLA|https://cla.jboss.org]? A bit of a PITA, but you only have to sign it once...
> Typo in LookAheadObjectInputStream.java
> ---------------------------------------
>
> Key: RF-13268
> URL: https://issues.jboss.org/browse/RF-13268
> Project: RichFaces
> Issue Type: Patch
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.4
> Environment: Any
> Reporter: Fab Mars
> Priority: Trivial
> Labels: core
> Fix For: 4.3.5, 5.0.0.Alpha2
>
> Original Estimate: 5 minutes
> Remaining Estimate: 5 minutes
>
> On the loadWhitelist method, stream.close() catch, the message should be "Error closing the resource-serialization.properties file". Git pull request attached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (RF-10646) Css in composite components not found with MyFaces
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-10646?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-10646:
------------------------------------
[~ppitonak] and [~jstefek] shall we then close this issue and file an upstream MyFaces issue?
> Css in composite components not found with MyFaces
> --------------------------------------------------
>
> Key: RF-10646
> URL: https://issues.jboss.org/browse/RF-10646
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality
> Affects Versions: 4.0.0.CR1, 4.2.2.Final, 4.3.4
> Environment: RichFaces 4.0.0-SNAPSHOT SVN r.21968
> MyFaces 2.0.5-SNAPSHOT (and all older versions)
> Tomcat 6.0.29
> all browsers
> RichFaces 4.2.2.Final
> Metamer 4.2.2.Final
> Apache MyFaces JSF-2.1 Core Impl 2.1.5
> Apache Tomcat 7.0.26
> all browsers
> Reporter: Pavol Pitonak
> Assignee: Brian Leathem
> Attachments: cc.zip, compositecomponent.war, RF-10646.zip
>
>
> MyFaces cannot load the stylesheet for the following page with a composite component (the text is black instead of fuchsia). When RichFaces is removed from project, everything works fine (see attached project for Tomcat).
> Mar 1, 2011 3:49:48 PM org.richfaces.resource.ResourceFactoryImpl logResourceProblem
> WARNING: Resource text.ecss?db=eAHL6rC8BQAEkAIG&ln=my%252fcss was not found
> {code:title=index.xhtml|borderStyle=solid}
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html" xmlns:my="http://java.sun.com/jsf/composite/my" >
> <h:head/>
> <h:body>
> <my:colorText text="Hello World!"/>
> </h:body>
> </html>
> {code}
> {code:title=resources/my/colorText.xhtml|borderStyle=solid}
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://java.sun.com/jsf/html"
> xmlns:composite="http://java.sun.com/jsf/composite" >
> <h:body>
> <composite:interface>
> <composite:attribute name="text" type="java.lang.String" required="true" />
> </composite:interface>
> <composite:implementation>
> <h:outputStylesheet library="my/css" name="text.ecss"/>
> <h:outputText id="text" value="#{cc.attrs.text}" styleClass="color-text" />
> <br/><br/>
> </composite:implementation>
> </h:body>
> </html>
> {code}
> {code:title=resources/my/css/text.ecss|borderStyle=solid}
> .color-text {
> color: fuchsia;
> text-weight: bold;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (RF-13099) Disabled input text is not visible
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13099?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13099:
------------------------------------
I don't want to set the color to black, as then we will lose a visual cue that the input is disabled. OTOH I don't want to introduce an altogether new skinning parameter and break existing skins.
On inspection of the skinning constants, it seems a suitably dark text color may be achieved using the _tableHeaderTextColor_ skinning parameter.
> Disabled input text is not visible
> ----------------------------------
>
> Key: RF-13099
> URL: https://issues.jboss.org/browse/RF-13099
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input, skinning
> Reporter: Kush Kumar
> Assignee: Brian Leathem
> Priority: Minor
> Fix For: 4.5.0.Alpha1
>
> Attachments: Disabled_Input_Text_Issue.png
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> Disabled input text is not visible -can you please help me out how can we make it visible or can we change the color of disabled text?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (RF-13099) Disabled input text is not visible
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13099?page=com.atlassian.jira.plugin.s... ]
Brian Leathem updated RF-13099:
-------------------------------
Attachment: Disabled_Input_Text_Issue.png
> Disabled input text is not visible
> ----------------------------------
>
> Key: RF-13099
> URL: https://issues.jboss.org/browse/RF-13099
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input, skinning
> Reporter: Kush Kumar
> Assignee: Brian Leathem
> Priority: Minor
> Fix For: 4.5.0.Alpha1
>
> Attachments: Disabled_Input_Text_Issue.png
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> Disabled input text is not visible -can you please help me out how can we make it visible or can we change the color of disabled text?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (RF-13099) Disabled input text is not visible
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-13099?page=com.atlassian.jira.plugin.s... ]
Brian Leathem commented on RF-13099:
------------------------------------
The relevant CSS rules from the _standard\_skinning.ecss_ file:
{code}
html .cke_skin_richfaces textarea[disabled],
html .cke_skin_richfaces input[type="text"][disabled],
html .cke_skin_richfaces input[type="password"][disabled],
html .cke_skin_richfaces select[disabled] {
color: '#{richSkin.panelBorderColor}';
cursor: default;
}
{code}
Note the use of _richSkin.panelBorderColor_ for the font color.
> Disabled input text is not visible
> ----------------------------------
>
> Key: RF-13099
> URL: https://issues.jboss.org/browse/RF-13099
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-input, skinning
> Reporter: Kush Kumar
> Assignee: Brian Leathem
> Priority: Minor
> Fix For: 4.5.0.Alpha1
>
> Original Estimate: 15 minutes
> Remaining Estimate: 15 minutes
>
> Disabled input text is not visible -can you please help me out how can we make it visible or can we change the color of disabled text?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months