[JBoss JIRA] (RF-12860) Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
by Brian Leathem (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Brian Leathem edited comment on RF-12860 at 3/27/13 1:58 PM:
-------------------------------------------------------------
[~dlee606] could I entice you into submitting a GitHub Pull request with the appropriate defensive code additions to AccordionItem.js?
See: https://community.jboss.org/wiki/GuideToUsePullRequestsWithGitHubAndJIRA
was (Author: bleathem):
[~dlee606] could I entice you into submitting a GitHub Pull request with the appropriate defensive code additions to AccordionItem.js?
See: https://github.com/richfaces/
> Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
> -------------------------------------------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Brian Leathem
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
> Attachments: richfaces-sanbox.zip
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
> ----
> *from QA:*
> When the following code is insterted to the page:
> {code}
> <script type="text/javascript">
> //<![CDATA[
> Array.prototype.remove = function(s) {
> for (var i = 0; i < this.length; i++) {
> if (s == this[i]) {
> this.splice(i, 1);
> }
> }
> };
> //]]>
> </script>
> {code}
> and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
> {code}
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12874) Cyclic dependencies in RF5 build
by Pavol Pitonak (JIRA)
Pavol Pitonak created RF-12874:
----------------------------------
Summary: Cyclic dependencies in RF5 build
Key: RF-12874
URL: https://issues.jboss.org/browse/RF-12874
Project: RichFaces
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: build/distribution
Affects Versions: 5.0.0.Alpha1
Reporter: Pavol Pitonak
1. git clone git://github.com/richfaces/richfaces5.git
2. mvn clean verify -D integration=jbossas
result:
{quote}
[INFO] Scanning for projects...
[ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex\{label='org.richfaces:richfaces-parent:5.0.0-SNAPSHOT'\}' and 'Vertex\{label='org.richfaces:richfaces-build-resources:5.0.0-SNAPSHOT'\}' introduces to cycle in the graph org.richfaces:richfaces-build-resources:5.0.0-SNAPSHOT --> org.richfaces:richfaces-parent:5.0.0-SNAPSHOT --> org.richfaces:richfaces-build-resources:5.0.0-SNAPSHOT -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectCycleException
{quote}
This is what we agreed on community meeting on 26 Mar 2013:
{quote}
#agreed The simplest resolution to the cyclic dep is to make richfaces-build-resources parent-less
{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12848) Error "source is not defined" after richfaces-jsf-event.js merge
by Torben Greiser (JIRA)
[ https://issues.jboss.org/browse/RF-12848?page=com.atlassian.jira.plugin.s... ]
Torben Greiser updated RF-12848:
--------------------------------
Attachment: rf12848_1.xhtml
Demo XHTML attached. Works fine in 4.2.3, error as described occurs when using 4.3.1.
> Error "source is not defined" after richfaces-jsf-event.js merge
> ----------------------------------------------------------------
>
> Key: RF-12848
> URL: https://issues.jboss.org/browse/RF-12848
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: core
> Affects Versions: 4.3.1
> Reporter: Torben Greiser
> Priority: Critical
> Fix For: 4.3.2, 5-Tracking
>
> Attachments: rf12848_1.xhtml
>
>
> Commit 9255380d626227d909bbcd59ea3bc604966ea5bb breaks the following jsf.ajax.request:
> {code}
> jsf.ajax.request("MyContainer:MySelectionForm", "valueChange", {});
> {code}
> In <a4j:log/> the following error is displayed:
> {code}
> richfaces.queue: ajax submit error: source is not defined
> {code}
> After inspecting richfaces.js I located the cause of the error:
> {code}
> var getFormElement = function(sourceElement) {
> if ($(sourceElement).is('form')) {
> return source;
> } else {
> return $('form').has(sourceElement).get(0);
> }
> };
> {code}
> First if-statement evaluates to true, returning source, which itself is not defined:
> {code}
> ReferenceError: source is not defined
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12860) Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
by Jan Papousek (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Jan Papousek updated RF-12860:
------------------------------
Attachment: richfaces-sanbox.zip
> Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
> -------------------------------------------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Brian Leathem
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
> Attachments: richfaces-sanbox.zip
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
> ----
> *from QA:*
> When the following code is insterted to the page:
> {code}
> <script type="text/javascript">
> //<![CDATA[
> Array.prototype.remove = function(s) {
> for (var i = 0; i < this.length; i++) {
> if (s == this[i]) {
> this.splice(i, 1);
> }
> }
> };
> //]]>
> </script>
> {code}
> and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
> {code}
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12860) Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
by Jan Papousek (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Jan Papousek updated RF-12860:
------------------------------
Attachment: (was: richfaces-sanbox.zip)
> Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
> -------------------------------------------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Brian Leathem
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
> ----
> *from QA:*
> When the following code is insterted to the page:
> {code}
> <script type="text/javascript">
> //<![CDATA[
> Array.prototype.remove = function(s) {
> for (var i = 0; i < this.length; i++) {
> if (s == this[i]) {
> this.splice(i, 1);
> }
> }
> };
> //]]>
> </script>
> {code}
> and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
> {code}
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12860) Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
by Jan Papousek (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Jan Papousek reassigned RF-12860:
---------------------------------
Assignee: Brian Leathem (was: Jan Papousek)
*David Lee*: Finally I've reproduced the issue. Thank you for the assistance.
I think the issue can be reproduced with rich:accordion only.
> Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
> -------------------------------------------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Brian Leathem
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
> Attachments: richfaces-sanbox.zip
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
> ----
> *from QA:*
> When the following code is insterted to the page:
> {code}
> <script type="text/javascript">
> //<![CDATA[
> Array.prototype.remove = function(s) {
> for (var i = 0; i < this.length; i++) {
> if (s == this[i]) {
> this.splice(i, 1);
> }
> }
> };
> //]]>
> </script>
> {code}
> and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
> {code}
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12860) Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
by Jan Papousek (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Jan Papousek updated RF-12860:
------------------------------
Summary: Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used (was: Overridng 'Array.prototype.remove' causes JS error when rich:accordion is used)
> Overriding 'Array.prototype.remove' causes JS error when rich:accordion is used
> -------------------------------------------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Jan Papousek
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
> Attachments: richfaces-sanbox.zip
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
> ----
> *from QA:*
> When the following code is insterted to the page:
> {code}
> <script type="text/javascript">
> //<![CDATA[
> Array.prototype.remove = function(s) {
> for (var i = 0; i < this.length; i++) {
> if (s == this[i]) {
> this.splice(i, 1);
> }
> }
> };
> //]]>
> </script>
> {code}
> and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
> {code}
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12860) Overridng 'Array.prototype.remove' causes JS error when rich:accordion is used
by Jan Papousek (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Jan Papousek updated RF-12860:
------------------------------
Summary: Overridng 'Array.prototype.remove' causes JS error when rich:accordion is used (was: AccordionItem.js with error cause browser crash)
Description:
Put the rich:accordionItem and rich:extendedDataTable on same page,
and just click on any column for sort.
The firebug will show an error:
items[i].__header is not a function
[Break On This Error]
h -= items[i].__header().outerHeight();
Looks like accordionItem.js line48 been triggered when sort:
$(document).one("javascriptServiceComplete", function () {
item.__fitToHeight(item.getTogglePanel());
});
And after this happened, my whole thing crashed.
Now more sortable or click for any action.
----
*from QA:*
When the following code is insterted to the page:
{code}
<script type="text/javascript">
//<![CDATA[
Array.prototype.remove = function(s) {
for (var i = 0; i < this.length; i++) {
if (s == this[i]) {
this.splice(i, 1);
}
}
};
//]]>
</script>
{code}
and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
{code}
items[i].__header is not a function
[Break On This Error]
h -= items[i].__header().outerHeight();
{code}
was:
Put the rich:accordionItem and rich:extendedDataTable on same page,
and just click on any column for sort.
The firebug will show an error:
items[i].__header is not a function
[Break On This Error]
h -= items[i].__header().outerHeight();
Looks like accordionItem.js line48 been triggered when sort:
$(document).one("javascriptServiceComplete", function () {
item.__fitToHeight(item.getTogglePanel());
});
And after this happened, my whole thing crashed.
Now more sortable or click for any action.
Steps to Reproduce:
# clone https://github.com/papousek/richfaces-sanbox/tree/RF-12860 or download the application from attachments, built it and deploy it
# open http://localhost:8080/richfaces-sandbox-jee6/
# open firebug console
# click on the second item in accordion => JS error appears
> Overridng 'Array.prototype.remove' causes JS error when rich:accordion is used
> ------------------------------------------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Jan Papousek
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
> Attachments: richfaces-sanbox.zip
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
> ----
> *from QA:*
> When the following code is insterted to the page:
> {code}
> <script type="text/javascript">
> //<![CDATA[
> Array.prototype.remove = function(s) {
> for (var i = 0; i < this.length; i++) {
> if (s == this[i]) {
> this.splice(i, 1);
> }
> }
> };
> //]]>
> </script>
> {code}
> and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
> {code}
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12860) Overridng 'Array.prototype.remove' causes JS error when rich:accordion is used
by Jan Papousek (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
Jan Papousek updated RF-12860:
------------------------------
Attachment: richfaces-sanbox.zip
> Overridng 'Array.prototype.remove' causes JS error when rich:accordion is used
> ------------------------------------------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Jan Papousek
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
> Attachments: richfaces-sanbox.zip
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
> ----
> *from QA:*
> When the following code is insterted to the page:
> {code}
> <script type="text/javascript">
> //<![CDATA[
> Array.prototype.remove = function(s) {
> for (var i = 0; i < this.length; i++) {
> if (s == this[i]) {
> this.splice(i, 1);
> }
> }
> };
> //]]>
> </script>
> {code}
> and rich:accordion is present, clicking on rich:accordionItem causes the following JS error (from firebug):
> {code}
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (RF-12860) AccordionItem.js with error cause browser crash
by David Lee (JIRA)
[ https://issues.jboss.org/browse/RF-12860?page=com.atlassian.jira.plugin.s... ]
David Lee commented on RF-12860:
--------------------------------
I reproduce the issue from following step:
1.Add my JavaScript code to your code.
2.Click on AccordionItem.
3.Click on column to sort.
==========================================
This bug is cause by I modified the JavaScript prototype,
so for most of time it's fine.
But I think that's possible some user also might do this.
So just suggest to add some defensive code to AccordionItem.js to avoid that.
Thanks
David
> AccordionItem.js with error cause browser crash
> -----------------------------------------------
>
> Key: RF-12860
> URL: https://issues.jboss.org/browse/RF-12860
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: component-output
> Affects Versions: 4.3.0.Final
> Environment: JBOSS7/JSF2/FirefoxESR10 or Chrome25.0.1
> Reporter: David Lee
> Assignee: Jan Papousek
> Labels: javascript, rich:accordionItem
> Fix For: 4.3.2
>
>
> Put the rich:accordionItem and rich:extendedDataTable on same page,
> and just click on any column for sort.
> The firebug will show an error:
> items[i].__header is not a function
> [Break On This Error]
> h -= items[i].__header().outerHeight();
> Looks like accordionItem.js line48 been triggered when sort:
> $(document).one("javascriptServiceComplete", function () {
> item.__fitToHeight(item.getTogglePanel());
> });
> And after this happened, my whole thing crashed.
> Now more sortable or click for any action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month